Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
18516 commits 17 branches 142 tags 291 MiB
Commit graph

136 commits

Author SHA1 Message Date
Nils Wallménius
68f6e83eb0 Alternate fix for the bug fixed by FS#9163, the selection in the playlist viewer was one line too low, which caused it to be off-screen if the last item was selected. The cause was that the selected item was set before the list title, fixed by re-calculating the position of the selected item after setting the title. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18797 a1c6a512-1295-4272-9138-f99709370657
 2008-10-13 12:16:06 +00:00
Jonathan Gordon
8703cca459 Fix FS#9479 - "readonly" lists sometimes wrap when they shouldnt. part of the fix forced it to disable wrapping for these lists.. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18778 a1c6a512-1295-4272-9138-f99709370657
 2008-10-12 10:21:44 +00:00
Jonathan Gordon
2438d7881a redo the previous commit so its actually useful. 
if the callback returns ACTION_STD_CANCEL when the user presses ACTION_STD_OK the simple list will exit and set the selection. Otherwise, when ACTION_STD_CANCEL happens the selection will be set to -1


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18641 a1c6a512-1295-4272-9138-f99709370657
 2008-09-25 08:12:25 +00:00
Jonathan Gordon
67df5f2434 have the info lists set the selection before they are exited, this is sometimes needed by the caller 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18640 a1c6a512-1295-4272-9138-f99709370657
 2008-09-25 07:56:34 +00:00
Maurus Cuelenaere
1392dc2144 Commit FS#9308: differentiate between TOUCHPAD & TOUCHSCREEN 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18338 a1c6a512-1295-4272-9138-f99709370657
 2008-08-23 09:46:38 +00:00
Stéphane Doyon
50512d696d Fix for issues in speaking the time in Rockbox Info screen (B#9167). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18309 a1c6a512-1295-4272-9138-f99709370657
 2008-08-18 00:58:47 +00:00
Jonathan Gordon
311d048f6f fix FS#9144 hopefully for good... only update the screen if the time line is selected, or if talking menus are disabled, only update if the time line is actually on the screen. Also only update every 5s so scrolling lines still scroll. (turns out scroll_all was broken! fixed now) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17944 a1c6a512-1295-4272-9138-f99709370657
 2008-07-05 12:31:04 +00:00
Peter D'Hoye
205f3df781 Remove a viewport ambiguity by changing the screens width/heigth members into lcdwidth/lcdheight. Normal usercode should always use getwidth()/getheigth() as that returns the viewport width/height. Fixes issues that would have appeared in many places when introducing viewports with sizes != lcd sizes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17857 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 20:45:21 +00:00
Daniel Stenberg
2acc0ac542 Updated our source code header to explicitly mention that we are GPL v2 or 
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 18:10:04 +00:00
Jonathan Gordon
e0b957fd51 quick fix for FS#8729 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17780 a1c6a512-1295-4272-9138-f99709370657
 2008-06-24 08:09:35 +00:00
Peter D'Hoye
f76122f0e7 Accept FS #9052 by Alexander Levin with a fix by me. Changes HAS_BUTTONBAR into HAVE_BUTTONBAR to bring it in line with the other defines 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17655 a1c6a512-1295-4272-9138-f99709370657
 2008-05-29 20:32:39 +00:00
Jonathan Gordon
32db049a2a fix FS#9020 and make scrolling down in lists a bit more consistant with scrolling up 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17602 a1c6a512-1295-4272-9138-f99709370657
 2008-05-22 06:23:15 +00:00
Bertrik Sikken
9244259f08 Make list.c use button_queue_count() instead of accessing the button_queue directly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17587 a1c6a512-1295-4272-9138-f99709370657
 2008-05-20 19:41:48 +00:00
Jonathan Gordon
95be4febc8 doh! fix yellow. 
remove the calls to stop_scroll(), clear_viewport() does that

nothing should be using screens[].nb_lines anymore... change the list code to be a good example. (playlist_viewer is the last thing using it which needs fixing)



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17456 a1c6a512-1295-4272-9138-f99709370657
 2008-05-11 14:08:46 +00:00
Jonathan Gordon
10df05438e more textarea to viewport conversion... yes/no screen... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17454 a1c6a512-1295-4272-9138-f99709370657
 2008-05-11 13:39:22 +00:00
Jonathan Gordon
daa8341a13 a bit of code cleanup.. use a single function to get the statusbar height (or lack of if its enabled), and remove some gui_textarea stuff which could be done using the splash. (gui_textarea is on the way out) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17350 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 10:58:05 +00:00
Bertrik Sikken
e15f8a21a9 Made source files #include the header file that they implement to make sure they are in sync. Made some local functions static. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17312 a1c6a512-1295-4272-9138-f99709370657
 2008-05-03 08:35:14 +00:00
Jonathan Gordon
fa64dbb525 So, I was skimming the irc logs from my 3 day absense and I was pinged about a bug in the simplelist code and this function in particular. Neither time was the actual bug explained so I dont know what this commit fixes... I'm fairly certain it does fix it though because the old code was rediculously wrong. MY guess is it has something to do with the radio debug screen seen as its the only call to this with the param != 0. 
Please use the damn tracker for bug reports.. pinging someone when they arnt even online (as opposed to idling in the channel) really is a waste of time.)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17204 a1c6a512-1295-4272-9138-f99709370657
 2008-04-21 13:32:10 +00:00
Nils Wallménius
6848961aa5 Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
 2008-04-09 15:25:17 +00:00
Jonathan Gordon
be185a1eaf fix the buttonbar in the browser and menus. 
fix a problem where the menus wouldnt redraw when they should have when settings change


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16816 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 09:05:42 +00:00
Jonathan Gordon
5ca1539969 the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 03:35:24 +00:00
Jonathan Gordon
885283c424 more fixes for button bar... this will all disappear when viewports are handled by a manager of some sort 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16589 a1c6a512-1295-4272-9138-f99709370657
 2008-03-09 09:37:39 +00:00
Jonathan Gordon
3f686d7034 fix recorder, buttonbar caused list problems 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16584 a1c6a512-1295-4272-9138-f99709370657
 2008-03-09 02:00:31 +00:00
Jonathan Gordon
f444f1ecbe fix the touchpad list code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16528 a1c6a512-1295-4272-9138-f99709370657
 2008-03-05 10:38:10 +00:00
Jonathan Gordon
0e5cec2d18 FS#8457 - convert the list drawing code to use viewports. This does not include any of the customizability which was in the patch, so unless any bugs show up users should not notice any difference. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16527 a1c6a512-1295-4272-9138-f99709370657
 2008-03-05 09:58:30 +00:00
Jens Arnold
bf9ae1f303 Fix the simplelist redraw behaviour. It caused e.g. the 'Open with...' menu items to not scroll as they should, making it partially unusable with small displays and/or large fonts. Thanks to JdGordon for pointing me into the right direction. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16415 a1c6a512-1295-4272-9138-f99709370657
 2008-02-25 07:41:30 +00:00
Peter D'Hoye
c4c678ff1a Accept FS #8490 by Vuong Minh Hiep: fix wrong selection in multi-line lists 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16135 a1c6a512-1295-4272-9138-f99709370657
 2008-01-21 22:28:25 +00:00
Jonathan Gordon
b684b82fd0 Accept and Fix FS#8427 - problem with empty screens in lists with pages scrolling enabled 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16023 a1c6a512-1295-4272-9138-f99709370657
 2008-01-08 08:12:32 +00:00
Jonathan Gordon
213d9a2ca1 fix touchpad list code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15948 a1c6a512-1295-4272-9138-f99709370657
 2007-12-17 04:23:34 +00:00
Jonathan Gordon
f5ec3e49e0 remove the duplicated gui_list struct and only duplicate the members which are actually different on each screen. should translate to a smaller bin and easier code (users shouldnt notice any difference) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15947 a1c6a512-1295-4272-9138-f99709370657
 2007-12-17 02:37:21 +00:00
Nicolas Pennequin
485bbbdb30 Make the "current line" value in the gradient style code zero-based, and an attempt at more understandable names and better comments. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15886 a1c6a512-1295-4272-9138-f99709370657
 2007-12-06 17:09:24 +00:00
Nicolas Pennequin
b766f11701 Oops, wrong define. Fixes the warnings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15699 a1c6a512-1295-4272-9138-f99709370657
 2007-11-19 18:25:13 +00:00
Nicolas Pennequin
1d86dbffe3 Accept FS#7901 by Akio Idehara: Fix gradient for scrolling lines when more than one line is selected 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15698 a1c6a512-1295-4272-9138-f99709370657
 2007-11-19 18:14:51 +00:00
Linus Nielsen Feltzing
e75327b332 FS#7738 - Scroll wheel acceleration for iPod 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15681 a1c6a512-1295-4272-9138-f99709370657
 2007-11-19 11:05:54 +00:00
Jonathan Gordon
04d0e3bc41 fix talking simplelists which I broke yesterday. dont talk if the list is being redrawn because get_action() timed out. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15459 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 12:52:32 +00:00
Jonathan Gordon
eb20149804 minor touchpad tweaking... 
lists - dont do ACTION_STD_OK if pressing an area under the last item
colour chooser - change the seelcted colour straight away without having to swicth sliders first


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15455 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 10:51:11 +00:00
Jonathan Gordon
e247230e0d redraw the siplelist more often 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15446 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 01:04:10 +00:00
Karl Kurbjun
38548c7118 Build some more plugins for M:Robe most work, doom builds and runs if you use a hack - need to fix the user timer so that it works properly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15403 a1c6a512-1295-4272-9138-f99709370657
 2007-11-02 05:21:34 +00:00
Michael Sevakis
d6af287397 Implement as genuine a set_irq_level function for the sim as possible. The yield added earlier is still nescessary since other threads won't run anyway while viewing the database screen on either sim or target. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15321 a1c6a512-1295-4272-9138-f99709370657
 2007-10-26 23:11:18 +00:00
Steve Bavin
ab784649cd Don't lock up simulators when lists are used with TIMEOUT_NOBLOCK. Fixes FS#8030. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15318 a1c6a512-1295-4272-9138-f99709370657
 2007-10-26 18:04:42 +00:00
Steve Bavin
072a3c5017 Complete info screen voicing; now consistent with displayed screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15284 a1c6a512-1295-4272-9138-f99709370657
 2007-10-24 12:32:12 +00:00
Jonathan Gordon
eed41ff985 mrobe changes: 
stop it thinking the battery is always flat and shutting down
add keymap for time/date screen
pressing a list item will highlight it before accepting it (looks better than it just entering the item without the selection changing first)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15280 a1c6a512-1295-4272-9138-f99709370657
 2007-10-23 14:33:16 +00:00
Stéphane Doyon
a82a860c7e Small voice-related tweaks and fixes to simplelists. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15276 a1c6a512-1295-4272-9138-f99709370657
 2007-10-23 05:19:03 +00:00
Jonathan Gordon
fa13cbee80 First go at getting the touchpad working in the ui. lists only for now. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15264 a1c6a512-1295-4272-9138-f99709370657
 2007-10-22 12:26:53 +00:00
Jonathan Gordon
0465101f92 allow simplelists to set the timeout and the start selection. 
set a slightly saner default timeout
talk the selected item when the list is first displayed


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15247 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 13:47:43 +00:00
Miika Pekkarinen
caff835d78 Fixed debug menu crashing. Show last file processed by tagcache engine in debug menu. Enabled autoupdating of deleted files for flash storage devices. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15244 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 11:06:30 +00:00
Jonathan Gordon
616971c71e remove the seelection_size param from the info init call to hopefully decrease the bin size a bit 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15237 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 06:42:52 +00:00
Jonathan Gordon
5eac0108f9 simplify the simpelist api slightly so not every struct member needs to be init manually. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15236 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 01:27:17 +00:00
Stéphane Doyon
8486c0413e Accept FS#7774: Voice callback for gui_synclist. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15231 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 00:20:10 +00:00
Jonathan Gordon
5f893be2a3 add a list API for simple lists which dont need lots of code to run. 
Example uses in debug_menu.c
This API works best if most of the text is static, or not many actions 
need to acted on. (of course, any list could use this)



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15221 a1c6a512-1295-4272-9138-f99709370657
 2007-10-20 12:32:55 +00:00