Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

doh! fix yellow.

Browse source 
remove the calls to stop_scroll(), clear_viewport() does that

nothing should be using screens[].nb_lines anymore... change the list code to be a good example. (playlist_viewer is the last thing using it which needs fixing)



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17456 a1c6a512-1295-4272-9138-f99709370657
This commit is contained in:
Jonathan Gordon 2008-05-11 14:08:46 +00:00
parent aff220c9f5
commit 95be4febc8
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
apps/gui/list.c
View file

@ -483,13 +483,15 @@ void gui_synclist_set_color_callback(struct gui_synclist * lists,
static void gui_synclist_select_next_page(struct gui_synclist * lists,
enum screen_type screen)
{
gui_list_select_at_offset(lists, screens[screen].nb_lines);
int nb_lines = viewport_get_nb_lines(lists->parent[screen]);
gui_list_select_at_offset(lists, nb_lines);
}
static void gui_synclist_select_previous_page(struct gui_synclist * lists,
enum screen_type screen)
{
gui_list_select_at_offset(lists, -screens[screen].nb_lines);
int nb_lines = viewport_get_nb_lines(lists->parent[screen]);
gui_list_select_at_offset(lists, -nb_lines);
}
void gui_synclist_limit_scroll(struct gui_synclist * lists, bool scroll)

2
apps/gui/yesno.c
View file

@ -60,7 +60,6 @@ static void gui_yesno_draw(struct gui_yesno * yn)
int nb_lines, vp_lines, line_shift=0;
display->set_viewport(vp);
display->stop_scroll();
display->clear_viewport();
nb_lines = yn->main_message->nb_lines;
vp_lines = viewport_get_nb_lines(vp);
@ -100,7 +99,6 @@ static bool gui_yesno_draw_result(struct gui_yesno * yn, enum yesno_res result)
if(message==NULL)
return false;
display->set_viewport(vp);
display->stop_scroll();
display->clear_viewport();
put_message(yn->display, message, 0, viewport_get_nb_lines(vp));
display->update_viewport();

2
apps/screens.c
View file

@ -56,6 +56,7 @@
#include "list.h"
#include "yesno.h"
#include "backdrop.h"
#include "viewport.h"
#ifdef HAVE_LCD_BITMAP
#include <bitmaps/usblogo.h>
@ -546,7 +547,6 @@ bool set_time_screen(const char* title, struct tm *tm)
/* draw the screen */
screens[s].set_viewport(&vp[s]);
screens[s].stop_scroll();
screens[s].clear_viewport();
/* display the screen title */
screens[s].puts_scroll(0, 0, title);