Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
19188 commits 17 branches 142 tags 291 MiB
Commit graph

661 commits

Author SHA1 Message Date
Thom Johansen
4a7e0c7949 Rename and rework the "Study Mode" menu into the "Skip Length" setting. Update manual. Bump plugin API thanks to having changed global_settings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18041 a1c6a512-1295-4272-9138-f99709370657
 2008-07-14 20:39:30 +00:00
Nicolas Pennequin
ae05501716 Introduce a new WPS parsing error case: limits exceeded. It includes the cases when there are too many tokens, lines, sublines, viewports, strings, characters or conditional levels. This prevents the parser from failing silently or going on, as it used to do in those cases. Thanks to fml (Alexander Levin) for mentioning this issue. 
I also changed the error types from #defines to an enum, for cleanliness.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18015 a1c6a512-1295-4272-9138-f99709370657
 2008-07-12 15:12:09 +00:00
Magnus Holmgren
aae69dff45 Fix FS #9181, allowing the documented 3 progress bars per WPS. Also simplify the code a little. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18008 a1c6a512-1295-4272-9138-f99709370657
 2008-07-11 07:33:56 +00:00
Marc Guay
2bfcb95fea Clean up the A-B repeat keymaps and add a note to gwps.c describing the ACTION_WPSAB_SINGLE #define. The Archos Player keypresses remain at large - if you have any info on their whereabouts please contact your local law enforcement. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17974 a1c6a512-1295-4272-9138-f99709370657
 2008-07-07 05:17:15 +00:00
Jonathan Gordon
d035f255c9 get checkwps building again (FS#9150) - still doesnt compile on d2 and mr500 though 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17957 a1c6a512-1295-4272-9138-f99709370657
 2008-07-06 13:23:28 +00:00
Jonathan Gordon
311d048f6f fix FS#9144 hopefully for good... only update the screen if the time line is selected, or if talking menus are disabled, only update if the time line is actually on the screen. Also only update every 5s so scrolling lines still scroll. (turns out scroll_all was broken! fixed now) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17944 a1c6a512-1295-4272-9138-f99709370657
 2008-07-05 12:31:04 +00:00
Jonathan Gordon
144f39b4ea revert that scroll engine stuff... good in theory, but broken. 
commit a band-aid fix for FS#9140 which is fine untill someone decides to not use the whole screen for it...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17916 a1c6a512-1295-4272-9138-f99709370657
 2008-07-02 13:02:57 +00:00
Jens Arnold
4dab6235cf The second part of this expression always becomes true before the first part, so the first part is unnecessary. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17907 a1c6a512-1295-4272-9138-f99709370657
 2008-07-01 17:45:16 +00:00
Jonathan Gordon
272f79aa1a Fix the bug where the german language would crash the quickscreen on the nano. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17889 a1c6a512-1295-4272-9138-f99709370657
 2008-06-30 11:26:33 +00:00
Maurus Cuelenaere
475c2e7d05 Simplify touchscreen scrollbar handling code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17861 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 23:48:37 +00:00
Peter D'Hoye
4af5dd84a2 fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17859 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 21:02:43 +00:00
Peter D'Hoye
205f3df781 Remove a viewport ambiguity by changing the screens width/heigth members into lcdwidth/lcdheight. Normal usercode should always use getwidth()/getheigth() as that returns the viewport width/height. Fixes issues that would have appeared in many places when introducing viewports with sizes != lcd sizes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17857 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 20:45:21 +00:00
Maurus Cuelenaere
3d240f1e2a Small fix for touchscreen interface 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17856 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 20:11:51 +00:00
Daniel Stenberg
2acc0ac542 Updated our source code header to explicitly mention that we are GPL v2 or 
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 18:10:04 +00:00
Marcoen Hirschberg
2fb70bcabb implement smooth seeking acceleration for audio playback and mpegplayer 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17843 a1c6a512-1295-4272-9138-f99709370657
 2008-06-28 17:55:53 +00:00
Jonathan Gordon
d8e56e30d7 allow the full lowercase a-z to be used as conditional viewport grouping id's 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17789 a1c6a512-1295-4272-9138-f99709370657
 2008-06-25 08:08:39 +00:00
Jonathan Gordon
e0b957fd51 quick fix for FS#8729 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17780 a1c6a512-1295-4272-9138-f99709370657
 2008-06-24 08:09:35 +00:00
Jonathan Gordon
bdbdb97f19 FS#9051 - remove LCD margins... use viewports if you need them... 
NOTE to WPS people....
%m has been removed, but (i think) because of the other %m tags it wont fail if you try loading a wps with %m|..|, it will just be ignored.
Also note that if the statusbar is enabled the default viewport is 8 pixels shorter than when its not, i.e (0,0) is really (0,8) if the statusbar is shown... I dont think this will be a major issue because almost no WPS show the bar and use bitmaps... text only WPS shouldnt be affected.

Please report problem screens in http://forums.rockbox.org/index.php?topic=17358.0


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17763 a1c6a512-1295-4272-9138-f99709370657
 2008-06-23 13:20:35 +00:00
Jonathan Gordon
082f50b947 fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17760 a1c6a512-1295-4272-9138-f99709370657
 2008-06-23 06:17:22 +00:00
Jonathan Gordon
5a169bb717 commit FS#9027 - conditional viewports 
** BREAKS CURRENT WPS's  **
* %P has been removed, merged with the new %pb
* %pb is now %pb or %pb|bitmap|x|y|width|height| (any of those params can be - to use sane defaults... check wiki/task for more explaination)

* New %Vl and %Vd tags which are used to setup and display conditionaly displayed viewports (%Vl|<id>|<usual %V params>| to set up, then %Vd<id> to enable the viewport
* bumps the max allowed viewport count to 24
* you can setup 3 different progressbars in a WPS... max of one per viewport though

http://www.rockbox.org/tracker/task/9027?getfile=16785 is a simple perl script to convert old %P/%pb to the new %pb syntax

I'll commit changes to the cabbie wps soon which shows how to use %Vl/%Vd properly...

Reminder: %m will be removed soonish also so when fixing your WPS's remember to use conditional viewports to replace %m


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17759 a1c6a512-1295-4272-9138-f99709370657
 2008-06-23 06:04:17 +00:00
Jonathan Gordon
6653072292 bah, fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17758 a1c6a512-1295-4272-9138-f99709370657
 2008-06-23 02:57:24 +00:00
Jonathan Gordon
4982b87b9c fix FS#9098 - fade was updating the WPS sometimes when it shouldnt. also minor code policing.. use true/false instead of 1/0 for calls to fade() 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17757 a1c6a512-1295-4272-9138-f99709370657
 2008-06-23 02:45:55 +00:00
Jonathan Gordon
5c416ae855 "Fix" FS#7887 - the line selector colours would be completly wrong on scrolling lines. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17725 a1c6a512-1295-4272-9138-f99709370657
 2008-06-15 13:12:26 +00:00
Jonathan Gordon
23bca7e400 fix FS#5821 and FS#8449 - WPS isnt updated during fade, play status isnt changed to pause fast enough. 
not sure if this is the best fix, wondering why fade() is handled by the wps code and not playback....


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17723 a1c6a512-1295-4272-9138-f99709370657
 2008-06-15 11:22:44 +00:00
Jonathan Gordon
ae49b387bf Accept FS#9075 and rename valid_vals to set_vals 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17698 a1c6a512-1295-4272-9138-f99709370657
 2008-06-07 09:01:02 +00:00
Maurus Cuelenaere
4bbdc5c3a3 Fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17696 a1c6a512-1295-4272-9138-f99709370657
 2008-06-06 18:44:59 +00:00
Maurus Cuelenaere
e1753de41a 1) Implement generic touchscreen detection library for the plugins 
2) Adapt minesweeper, pegbox & calculator to it
3) Simplify gui/bitmap/list.c


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17695 a1c6a512-1295-4272-9138-f99709370657
 2008-06-06 18:29:46 +00:00
Magnus Holmgren
c2416bf8b9 Fix typo in the new default values for %V, so that the background color is actually set on 16-bit targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17692 a1c6a512-1295-4272-9138-f99709370657
 2008-06-05 15:21:08 +00:00
Jonathan Gordon
f002b7d055 make %V a little simpler. only the x and y values have to be specified now (i.e %V|0|0|||||| ) 
default values are as follows:
width - lcd width - the x value
height - lcd height - y value
font - user font
fg colour - the themes fg colour on 16bit targets, black on greyscale targets
bg colour - the themes bg colour on 16bit targets, white on greyscale targets



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17690 a1c6a512-1295-4272-9138-f99709370657
 2008-06-05 08:20:39 +00:00
Maurus Cuelenaere
75cac2c604 Fix some mistakes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17678 a1c6a512-1295-4272-9138-f99709370657
 2008-06-02 18:59:32 +00:00
Maurus Cuelenaere
cad30d334c 1) Make touchscreen interface more intuitive 
2) Comment the code


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17676 a1c6a512-1295-4272-9138-f99709370657
 2008-06-02 16:08:01 +00:00
Maurus Cuelenaere
5dca53eeb0 Even more touchscreen improvements. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17673 a1c6a512-1295-4272-9138-f99709370657
 2008-06-01 13:56:34 +00:00
Maurus Cuelenaere
995b71a51d Some more touchscreen gui list improvements. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17672 a1c6a512-1295-4272-9138-f99709370657
 2008-06-01 13:37:33 +00:00
Maurus Cuelenaere
944219bb77 (Simulator) Touchscreen improvements. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17662 a1c6a512-1295-4272-9138-f99709370657
 2008-05-30 22:55:24 +00:00
Peter D'Hoye
f76122f0e7 Accept FS #9052 by Alexander Levin with a fix by me. Changes HAS_BUTTONBAR into HAVE_BUTTONBAR to bring it in line with the other defines 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17655 a1c6a512-1295-4272-9138-f99709370657
 2008-05-29 20:32:39 +00:00
Jonathan Gordon
0792596e17 the splash should set the viewport to NULL untill we start passing it a vp. (not any time soon though) 
"fix" FS#9044 by changing the delete dir screen to use the splash instead so it doesnt have to worry about the statusbar 
height


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17654 a1c6a512-1295-4272-9138-f99709370657
 2008-05-29 14:40:12 +00:00
Jonathan Gordon
0501fb016c total removal of gui_textarea. The only thing using the text_message struct is the yesno screen so move its definition to yesno.h 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17653 a1c6a512-1295-4272-9138-f99709370657
 2008-05-29 11:13:46 +00:00
Jonathan Gordon
43f0770943 move the HAS_BUTTONBAR define to the config-<target>.h files 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17652 a1c6a512-1295-4272-9138-f99709370657
 2008-05-29 09:14:32 +00:00
Jonathan Gordon
fd3b46c22c draw the buttonbar in its own viewport. It always uses the sysfont and is drawn on the bottom. 
Callers need to remeber to fiddle with their viewports to not be overwritten by the bar.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17651 a1c6a512-1295-4272-9138-f99709370657
 2008-05-29 08:59:57 +00:00
Jonathan Gordon
ff469ab573 Updated recording trigger screen (seems to be a feature almost noone uses?) 
problems/complaints in http://forums.rockbox.org/index.php?topic=16837.0
there is a known issue that on this screen the stop icon wont update, I dont know why and noone else wants to look at it, so hopefully this will force another set of eyes on it.. this is only a graphical issue... recordings still work fine


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17643 a1c6a512-1295-4272-9138-f99709370657
 2008-05-28 10:55:39 +00:00
Jonathan Gordon
cdf18bf388 callbacks were being called with the old value.. spotted in IRC last week 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17641 a1c6a512-1295-4272-9138-f99709370657
 2008-05-28 10:41:07 +00:00
Peter D'Hoye
f2d7270b70 Fix FS #9022: space reserved for the icons in the quickscreen used the incorrect constant 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17616 a1c6a512-1295-4272-9138-f99709370657
 2008-05-23 21:20:05 +00:00
Jonathan Gordon
32db049a2a fix FS#9020 and make scrolling down in lists a bit more consistant with scrolling up 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17602 a1c6a512-1295-4272-9138-f99709370657
 2008-05-22 06:23:15 +00:00
Bertrik Sikken
9244259f08 Make list.c use button_queue_count() instead of accessing the button_queue directly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17587 a1c6a512-1295-4272-9138-f99709370657
 2008-05-20 19:41:48 +00:00
Nils Wallménius
a21004dee6 Fix FS#9010 warning in checkwps when building on an amd64 machine 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17582 a1c6a512-1295-4272-9138-f99709370657
 2008-05-19 14:37:16 +00:00
Jonathan Gordon
3e5b38945c const raid in option_select 
add table settings and fix int settings with negative step in option_select_next_val
bump plugin API and sort newer functions


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17520 a1c6a512-1295-4272-9138-f99709370657
 2008-05-15 06:58:36 +00:00
Nils Wallménius
111c999756 Delete whitespace to make 'Id' keyword behave as desired 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17501 a1c6a512-1295-4272-9138-f99709370657
 2008-05-14 08:52:19 +00:00
Steve Bavin
71fa58985f Oops, forgot one. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17475 a1c6a512-1295-4272-9138-f99709370657
 2008-05-12 18:05:06 +00:00
Steve Bavin
ad95df2cab Const police raid. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17474 a1c6a512-1295-4272-9138-f99709370657
 2008-05-12 17:52:50 +00:00
Jonathan Gordon
95be4febc8 doh! fix yellow. 
remove the calls to stop_scroll(), clear_viewport() does that

nothing should be using screens[].nb_lines anymore... change the list code to be a good example. (playlist_viewer is the last thing using it which needs fixing)



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17456 a1c6a512-1295-4272-9138-f99709370657
 2008-05-11 14:08:46 +00:00
Jonathan Gordon
aff220c9f5 and the time/date screen... 
also change the order the yes/no screen clears the viewport.. stop_scroll should be called before clear or you might get artifacts


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17455 a1c6a512-1295-4272-9138-f99709370657
 2008-05-11 13:59:27 +00:00
Jonathan Gordon
10df05438e more textarea to viewport conversion... yes/no screen... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17454 a1c6a512-1295-4272-9138-f99709370657
 2008-05-11 13:39:22 +00:00
Nils Wallménius
fc25f3f61b Binsize optimization for targets without lcd remotes, whitespace/long lines police 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17453 a1c6a512-1295-4272-9138-f99709370657
 2008-05-11 10:28:52 +00:00
Bertrik Sikken
7835a20347 Prototype declaration strictness fixes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17424 a1c6a512-1295-4272-9138-f99709370657
 2008-05-08 20:37:26 +00:00
Nicolas Pennequin
357ffb3c46 Convert the whole codebase to UTF-8, except docs/COMMITTERS and tools/creative.c, which need checking. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17369 a1c6a512-1295-4272-9138-f99709370657
 2008-05-05 10:32:46 +00:00
Nicolas Pennequin
ef5fa8eaf5 Restore Zagor's copyright from before the WPS tokenizer. I shouldn't have removed it. Also add mine in playback.c, alongside Slasheri's. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17368 a1c6a512-1295-4272-9138-f99709370657
 2008-05-05 09:40:22 +00:00
Jonathan Gordon
8e57ede59f move the pitchscreen out of screens.c.. no functional changes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17365 a1c6a512-1295-4272-9138-f99709370657
 2008-05-05 07:07:19 +00:00
Stéphane Doyon
7e86e5d866 Polish voicing of quickscreen: make it like in FS#6171: announce 
"quickscreen" on entering, announce when leaving, say option name
when changing values in case the user isn't entirely familiar with
the layout...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17358 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 15:02:46 +00:00
Stéphane Doyon
ab0f7e17ef Accept FS#6188: study mode. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17355 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 13:47:58 +00:00
Jonathan Gordon
1ef5a836f8 doh! those talk functions dont check the setting (which for some reason I thought they did).. shut the quickscreen up if talk is disabled 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17354 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 13:39:54 +00:00
Jonathan Gordon
daa8341a13 a bit of code cleanup.. use a single function to get the statusbar height (or lack of if its enabled), and remove some gui_textarea stuff which could be done using the splash. (gui_textarea is on the way out) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17350 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 10:58:05 +00:00
Jonathan Gordon
39bccd65b9 recommit the talking quickscreen... silly rename bug which I mised this morning 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17348 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 08:11:28 +00:00
Stéphane Doyon
49a73ca90f Revert r17345 on jdgordon's request, until we figure out why it crashes my x5. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17346 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 02:57:30 +00:00
Jonathan Gordon
dd4e3848b8 make the quickscreen talk 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17345 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 02:11:24 +00:00
Jonathan Gordon
b234ef29b6 make the quickscreen not block so the statusbar gets updated 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17343 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 01:42:11 +00:00
Bertrik Sikken
6a0340fc21 More static / header file cleanup. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17341 a1c6a512-1295-4272-9138-f99709370657
 2008-05-03 23:18:56 +00:00
Jonathan Gordon
ef5286c48c remove some dead code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17320 a1c6a512-1295-4272-9138-f99709370657
 2008-05-03 14:26:47 +00:00
Jonathan Gordon
ea664e0647 Viewported quickscreen (take 2 :D) (FS#8553) 
- no customization support
- no top item
- much better use of the screen
- deprecates 20 odd lang strings (the QS can now use the regular lang strings and user font)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17315 a1c6a512-1295-4272-9138-f99709370657
 2008-05-03 12:30:40 +00:00
Bertrik Sikken
e15f8a21a9 Made source files #include the header file that they implement to make sure they are in sync. Made some local functions static. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17312 a1c6a512-1295-4272-9138-f99709370657
 2008-05-03 08:35:14 +00:00
Bertrik Sikken
2843469876 Moved atoi declaration to stdlib.h. Deleted atoi.h 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17280 a1c6a512-1295-4272-9138-f99709370657
 2008-04-28 16:18:04 +00:00
Nils Wallménius
f79bc56430 Use smaller data types in structs which are in big arrays to save memory 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17256 a1c6a512-1295-4272-9138-f99709370657
 2008-04-27 12:54:36 +00:00
Nils Wallménius
33c44461e1 Const police raid, making a lot of pointers to lang strings const and removing some ugly casting 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
 2008-04-26 09:30:24 +00:00
Jonathan Gordon
fe9dca3d5b option_screen() now accepts a viewport 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17223 a1c6a512-1295-4272-9138-f99709370657
 2008-04-23 11:07:40 +00:00
Jonathan Gordon
f8181966e6 And fix the bug which I was actually being pinged about... 
dont show the selection marker if its not supposed to be shown (i.e the debug lists)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17205 a1c6a512-1295-4272-9138-f99709370657
 2008-04-21 13:44:52 +00:00
Jonathan Gordon
fa64dbb525 So, I was skimming the irc logs from my 3 day absense and I was pinged about a bug in the simplelist code and this function in particular. Neither time was the actual bug explained so I dont know what this commit fixes... I'm fairly certain it does fix it though because the old code was rediculously wrong. MY guess is it has something to do with the radio debug screen seen as its the only call to this with the param != 0. 
Please use the damn tracker for bug reports.. pinging someone when they arnt even online (as opposed to idling in the channel) really is a waste of time.)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17204 a1c6a512-1295-4272-9138-f99709370657
 2008-04-21 13:32:10 +00:00
Nicolas Pennequin
380e915428 Fix FS#8914 (WPS %mp tag inconsistency). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17198 a1c6a512-1295-4272-9138-f99709370657
 2008-04-20 20:07:05 +00:00
Stéphane Doyon
4b5f0909d1 Fix bug in r17188. 
The warning from the build page was valid and helpful, wish my compiler had
given it to me...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17189 a1c6a512-1295-4272-9138-f99709370657
 2008-04-20 14:44:36 +00:00
Stéphane Doyon
b2aa86a785 FS#7980: Select default option in an option list 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17188 a1c6a512-1295-4272-9138-f99709370657
 2008-04-20 14:12:28 +00:00
Bertrik Sikken
db2d61f4ea Killed unnecessary global variables by making them static. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17184 a1c6a512-1295-4272-9138-f99709370657
 2008-04-20 10:24:15 +00:00
Nicolas Pennequin
a5ad74ffca Revert what was left of r17018 until I find a better way. It had quirks in some cases, and doesn't play well with what I'm about to commit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17108 a1c6a512-1295-4272-9138-f99709370657
 2008-04-14 15:51:40 +00:00
Nils Wallménius
84dc8d2c7e Move a function to gwps-common.c because it belongs there 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17084 a1c6a512-1295-4272-9138-f99709370657
 2008-04-12 13:25:16 +00:00
Nils Wallménius
6848961aa5 Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
 2008-04-09 15:25:17 +00:00
Nicolas Pennequin
e92c176d95 r17018 caused the WPS playlist index display to be wrong with shuffled enabled, so we revert to using playlist_get_display_index() on HWCODEC. Using id3->index would require something like what was added in r3726. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17025 a1c6a512-1295-4272-9138-f99709370657
 2008-04-07 19:09:30 +00:00
Nicolas Pennequin
977069a41d Bring the WPS playlist index display into sync with the track being played by using the index field of the ID3 info struct instead of directly asking the playlist code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17018 a1c6a512-1295-4272-9138-f99709370657
 2008-04-07 13:43:09 +00:00
Dave Chapman
aa9dbfef19 Add a comment to clarify how the WPS image buffer size is calculated 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16961 a1c6a512-1295-4272-9138-f99709370657
 2008-04-04 12:32:37 +00:00
Jonathan Gordon
34196edb60 fix FS#8841 - scrolling doesnt work when using cursor seelction icon 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16941 a1c6a512-1295-4272-9138-f99709370657
 2008-04-03 04:41:42 +00:00
Nicolas Pennequin
19868938d4 WPS parser: also revert to the default WPS when there were bitmap loading errors. The reverting is moved from wps_parse() to wps_data_load(). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16914 a1c6a512-1295-4272-9138-f99709370657
 2008-04-01 17:35:48 +00:00
Dave Chapman
d746b79317 Remove unnecessary (and incorrect) #ifdefs surrounding #include "backdrop.h", and correct remaining references to HAVE_LCD_REMOTE to HAVE_REMOTE_LCD 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16873 a1c6a512-1295-4272-9138-f99709370657
 2008-03-29 01:14:10 +00:00
Steve Bavin
c9df8fd87b The const police raid playback.c, should be no change to behaviour. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16860 a1c6a512-1295-4272-9138-f99709370657
 2008-03-28 11:24:24 +00:00
Dave Chapman
78d29f535f Major cleanup of checkwps - fix all warnings and add a script to build versions for all supported targets (plus some unsupported ones). You now need to run the version of checkwps that matches the device your WPS is for. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16831 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 23:35:34 +00:00
Dave Chapman
3d88eddb83 Move checkwps to its own subdir in preparation for compiling target-specific versions. Also remove a DEBUGF that should not have been left in. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16827 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 20:19:39 +00:00
Dave Chapman
fa1da20d3a Fix yellow, and at the same time simplify some #ifdefs 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16823 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 19:07:39 +00:00
Dave Chapman
b9bb723f12 1) Make Rockbox reject any WPSs if there are errors loading any of the required bmps; 2) Make checkwps actually load the images using the Rockbox bmp loader, and reject the WPS in the same was as Rockbox on bmp errors. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16822 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 18:18:22 +00:00
Jonathan Gordon
be185a1eaf fix the buttonbar in the browser and menus. 
fix a problem where the menus wouldnt redraw when they should have when settings change


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16816 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 09:05:42 +00:00
Jonathan Gordon
5ca1539969 the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 03:35:24 +00:00
Dave Chapman
7418c357c3 Make checkwps compile again. Still more work is needed though, as checkwps is compiled to emulate an iPod Color - this needs changing to allow the LCD (and remote LCD) dimensions/depth to be specified on the commandline - the new %V tags are validated against the LCD characteristics 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16807 a1c6a512-1295-4272-9138-f99709370657
 2008-03-25 21:09:58 +00:00
Steve Bavin
ae39135e2e Oops. Mop up red. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16799 a1c6a512-1295-4272-9138-f99709370657
 2008-03-25 15:35:14 +00:00
Steve Bavin
cd88e2ad93 Code police raid on the settings code, consting and putting headers alongside their implementation. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16798 a1c6a512-1295-4272-9138-f99709370657
 2008-03-25 15:24:03 +00:00
Dave Chapman
60413d898e D'oh - fix a silly #ifdef mistake that caused problems with remote WPSs using viewports. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16787 a1c6a512-1295-4272-9138-f99709370657
 2008-03-25 00:20:59 +00:00
Dave Chapman
0bb2e05aef Stricter syntax checking of the %V tag - pay attention to the return-code from parse_list, and check for the tailing | symbol. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16784 a1c6a512-1295-4272-9138-f99709370657
 2008-03-24 18:40:13 +00:00