Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
rockbox/apps/plugins
History
Aidan MacDonald 9ce5b2a2ed gui: Remove show/hide selection option in lists 
The implementation of the "show_selection_marker" option in
lists isn't great. It's a cosmetic option used to hide the
selection, but it causes the list to do funny things to the
selected_item and doesn't play nice with voiced menus, since
these rely on the selection to determine what item is spoken.

There are only two user-facing lists that use the option, the
"Rockbox Info" screen and a menu in the superdom plugin. The
rest are debug screens, and cosmetics don't matter much there.

Given how little used the option is, and its issues, removing
it seems reasonable.

Change-Id: I2c70b3e4c74ff3cc6dbac46366a371d271dd2d58
2022-10-02 09:21:25 -04:00
..
beatbox [1/4] Remove SH support and all archos targets 2020-07-24 21:20:13 +00:00
bitmaps Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
chessbox apps: Add ability to do a clean reboot 2022-04-16 14:36:39 +01:00
clock Make fixepoint.c as a shared library (libfixedpoint.a). 2013-04-26 00:11:04 +02:00
doom Updated keymaps for Sansa Connect 2022-08-19 00:31:00 -04:00
fft Convert FFT plugin to using PLA keymapings 2020-10-23 09:41:21 -04:00
fractals New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
frotz keyboard add ability to specify temporary custom layouts 2020-07-22 06:48:28 -04:00
goban Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
imageviewer Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
lib gui: Constify list title text 2022-10-02 08:20:10 -04:00
lua Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
lua_scripts random_playlist.lua make index more sparse 2021-12-08 22:09:16 -05:00
midi New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
mikmod mikmod: Uninitialized variable used in a control flow decision 2021-08-05 13:44:33 +00:00
mpegplayer apps: Add ability to do a clean reboot 2022-04-16 14:36:39 +01:00
pacbox New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
pdbox Silence warnings that happen on newer GCCs 2020-10-13 20:09:14 -04:00
pictureflow Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
puzzles Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
reversi New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
rockboy New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
sdl sdl: increase default worker thread size. 2021-06-28 02:51:48 +00:00
searchengine [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
shortcuts Add open_plugin to core 2020-08-17 10:15:14 -04:00
sudoku New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
text_viewer New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
xworld Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
zxbox New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
2048.c plugins: Fix issues in 2048 2021-08-04 19:04:37 +00:00
alarmclock.c Implement time-based resume and playback start. 2014-03-10 04:12:30 +01:00
announce_status.c announce_status Fix USB fall through and usb on plugin start 2021-11-13 03:38:28 -05:00
battery_bench.c apps: Add ability to do a clean reboot 2022-04-16 14:36:39 +01:00
bench_mem_jpeg.c
bench_scaler.c
blackjack.c Remove the (very) incomplete port for the Tatung TPJ-1102 2021-08-14 16:29:39 -04:00
boomshine.lua lua boomshine update to use rockevents library 2020-06-25 13:50:57 +00:00
bounce.c Replace SAMSUNG_YH920_PAD with YH92X 2016-01-25 09:23:09 +01:00
brickmania.c Updated keymaps for Sansa Connect 2022-08-19 00:31:00 -04:00
bubbles.c Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
BUILD_OVERLAY
calculator.c Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
calendar.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
CATEGORIES plugins: add USB TSR test plugin 2022-05-21 14:58:55 +01:00
chessbox.c
chessclock.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
chip8.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
chopper.c plugins: fix out of bounds read in chopper 2022-05-02 15:38:48 +01:00
clix.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
codebuster.c do_menu pass internal synclist reference to callback 2020-07-19 22:10:26 +00:00
credits.c Credits plugin: use black background 2021-12-09 21:01:11 -05:00
credits.pl
crypt_firmware.c rockbox: move firmware checksum algorithms into a common header 2020-11-22 05:12:04 +00:00
cube.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
db_folder_select.c folder_select.c move to plugin as db_folder_select 2021-11-11 00:28:59 -05:00
demystify.c plugins: More HAVE_BACKLIGHT cleanup 2020-07-24 19:20:15 -04:00
dice.c FS#7704 - Talk support for plugins 2019-07-20 08:48:35 +02:00
dict.c keyboard add ability to specify temporary custom layouts 2020-07-22 06:48:28 -04:00
disktidy.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
disktidy.config Revert r31239 and r31250. Selecting ALL in disktidy used to be generally safe for most people, and these changes change that, making it easy to delete most or all of a user's music. This is a *very* bad idea. 2011-12-26 00:03:28 +00:00
duke3d.c Port of Duke Nukem 3D 2017-12-23 21:01:26 -05:00
elfdep.pl
fire.c LCD core move buf ptr and address look up function viewport struct 2020-10-26 12:28:48 -04:00
fireworks.c plugins: More HAVE_BACKLIGHT cleanup 2020-07-24 19:20:15 -04:00
flipit.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
goban.c
greyscale.c Nuke the never-functional iriver ifp-7xx port 2021-04-26 07:42:58 -04:00
helloworld.c
helloworld.lua
invadrox.c Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
iriver_flash.c rockbox: move firmware checksum algorithms into a common header 2020-11-22 05:12:04 +00:00
iriverify.c Changed the FOR_NB_SCREENS macro to always be a for loop that declares its own loop variable. This removes the need to declare this variable in the outer scope. 2011-10-15 19:35:02 +00:00
jackpot.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
jewels.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
keybox.c Use LIST_WRAP_UNLESS_HELD consistently 2021-12-05 14:17:52 -05:00
keyremap.c keyremap add plain text import and export 2022-03-06 17:00:27 -05:00
lamp.c Lamp plugin: Allow toggling the button light using "select". 2015-02-22 12:22:40 +01:00
lastfm_scrobbler.c lastfm_scrobbler Add settings WIP 2022-05-28 06:23:37 -04:00
logo.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
lrcplayer.c gui: Remove show/hide selection option in lists 2022-10-02 09:21:25 -04:00
lua_scripts.lua lua print table put_line a do_menu alternative 2021-04-20 03:30:41 +00:00
main_menu_config.c whitespace fixes 2021-10-21 22:42:01 +02:00
matrix.c The Matrix plugin -- Bugfix 2021-04-16 10:10:15 -04:00
maze.c plugins: More HAVE_BACKLIGHT cleanup 2020-07-24 19:20:15 -04:00
mazezam.c plugins: More HAVE_BACKLIGHT cleanup 2020-07-24 19:20:15 -04:00
md5sum.c md5sum: clean up whitespace 2020-07-26 15:41:54 -04:00
metronome.c Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
minesweeper.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
mosaique.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
mp3_encoder.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
multiboot_select.c plugins: Add multiboot select plugin 2022-04-16 14:36:39 +01:00
open_plugins.c Open_Plugin add checksum on struct offsets 2021-10-18 23:30:27 -04:00
oscilloscope.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
otp.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
pegbox.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
periodic_table.c Add tentative new element names, IUPAC approval expected around November 2016-12-04 18:05:51 +01:00
pictureflow.c
pitch_detector.c Revise the PCM callback system after adding multichannel audio. 2012-03-03 07:23:38 +01:00
pitch_screen.c pitchscreen make it a plugin 2021-11-10 22:38:37 -05:00
pixel-painter.lua Lua fix pixel-painter score save 2018-11-05 07:18:08 +01:00
plasma.c LCD core move buf ptr and address look up function viewport struct 2020-10-26 12:28:48 -04:00
plugin.lds DM320: Regorganize LCD and TTB memory layout 2021-07-09 09:24:38 +00:00
plugin_crt0.c apps: Add ability to do a clean reboot 2022-04-16 14:36:39 +01:00
plugins.make rb_info plugin and button,action+context name helper 2021-11-22 21:39:45 -05:00
pong.c plugins pong, properties remove dead code 2021-07-22 23:24:12 +00:00
properties.c Properties plugin: Fix crash when parameter is zero-length string 2022-08-04 14:40:59 -04:00
quake.c sdl: Fix path substitution in log messages, fix game names in comments 2019-08-22 22:00:43 +03:00
random_folder_advance_config.c whitespace fixes 2021-10-21 22:42:01 +02:00
rb_info.c gui lists add callback for owner drawn items 2022-01-01 23:56:51 -05:00
remote_control.c
resistor.c plugins/resistor: Fix incorrect check for a valid 4th band value 2021-08-04 14:56:20 +00:00
robotfindskitten.c robotfindskitten: clear message line before cinema scene 2019-07-28 01:30:29 +02:00
rockblox.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
rockblox1d.c rockblox1d's plugin PLA integration (main code + manual) 2012-02-18 23:57:22 +01:00
rockbox-fonts.config
rockboy.c
rocklife.c Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
rockpaint.c Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
search.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
settings_dumper.c EQ settings: Rework the settings to clean up the config file. 2013-02-09 13:05:32 +01:00
shopper.c Shopper: slightly improve plugin and manual 2015-09-24 23:15:24 +02:00
sliding_puzzle.c plugin sliding puzzle fix unneeded check 2022-06-21 22:22:50 -04:00
snake.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
snake2.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
snake2.levels
snow.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
sokoban.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
sokoban.levels
solitaire.c apps: Add ability to do a clean reboot 2022-04-16 14:36:39 +01:00
sort.c plugins: make local functions static for a subset of plugins 2011-09-17 17:20:27 +00:00
SOURCES Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
SOURCES.app_build keyboard.c Use viewports, move text box pos 2022-04-07 19:46:56 -04:00
spacerocks.c Updated keymaps for Sansa Connect 2022-08-19 00:31:00 -04:00
speedread.c plugins: More HAVE_BACKLIGHT cleanup 2020-07-24 19:20:15 -04:00
star.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
starfield.c plugins: More HAVE_BACKLIGHT cleanup 2020-07-24 19:20:15 -04:00
stats.c plugins: More HAVE_BACKLIGHT cleanup 2020-07-24 19:20:15 -04:00
stopwatch.c Nuke the never-functional iriver ifp-7xx port 2021-04-26 07:42:58 -04:00
stopwatch.lua New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
SUBDIRS Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
SUBDIRS.app_build [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
superdom.c gui: Remove show/hide selection option in lists 2022-10-02 09:21:25 -04:00
test_boost.c Fix two variable-set-but-not-used warnings 2020-07-24 23:26:15 -04:00
test_codec.c plugins: HAVE_BACKLIGHT in the test plugins 2020-07-24 19:42:32 -04:00
test_core_jpeg.c Second try: Introduce plugin_crt0.c that every plugin links. 2010-08-24 14:30:46 +00:00
test_disk.c test_disk: Minor fix in an error path 2021-08-05 14:22:53 +00:00
test_fps.c plugins: HAVE_BACKLIGHT in the test plugins 2020-07-24 19:42:32 -04:00
test_gfx.c plugins: HAVE_BACKLIGHT in the test plugins 2020-07-24 19:42:32 -04:00
test_grey.c plugins: HAVE_BACKLIGHT in the test plugins 2020-07-24 19:42:32 -04:00
test_greylib_bitmap_scale.c test_X plugins PLA integration 2012-03-03 19:55:51 +01:00
test_kbd.c keyboard.c Use viewports, move text box pos 2022-04-07 19:46:56 -04:00
test_mem.c test_mem: fix asm variant of read/write test 2020-11-04 13:00:01 +00:00
test_mem_jpeg.c
test_resize.c LCD core move buf ptr and address look up function viewport struct 2020-10-26 12:28:48 -04:00
test_sampr.c Add 192 and 176KHz to mikmod and test_sampr plugins 2020-09-30 22:52:56 -04:00
test_scanrate.c [1/4] Remove SH support and all archos targets 2020-07-24 21:20:13 +00:00
test_touchscreen.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
test_usb.c plugins: add USB TSR test plugin 2022-05-21 14:58:55 +01:00
test_viewports.c Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
test_viewports.lua
text_editor.c keyboard add ability to specify temporary custom layouts 2020-07-22 06:48:28 -04:00
theme_remove.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
vbrfix.c plugins trade talk_value for talk_value_decimal 2021-08-19 01:17:29 +00:00
viewers.config plugins: Add multiboot select plugin 2022-04-16 14:36:39 +01:00
vu_meter.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
wav2wv.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
wavview.c plugins: make local functions static for metronome, rockblox1d, wavview 2011-10-04 19:33:52 +00:00
windows_lnk.c plugin windows_lnk: fix missing return-on-error 2020-07-07 02:36:33 +00:00
wolf3d.c sdl: Fix path substitution in log messages, fix game names in comments 2019-08-22 22:00:43 +03:00
wormlet.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
xobox.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
zxbox.c Second try: Introduce plugin_crt0.c that every plugin links. 2010-08-24 14:30:46 +00:00