Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
rockbox/apps
History
Aidan MacDonald 9ce5b2a2ed gui: Remove show/hide selection option in lists 
The implementation of the "show_selection_marker" option in
lists isn't great. It's a cosmetic option used to hide the
selection, but it causes the list to do funny things to the
selected_item and doesn't play nice with voiced menus, since
these rely on the selection to determine what item is spoken.

There are only two user-facing lists that use the option, the
"Rockbox Info" screen and a menu in the superdom plugin. The
rest are debug screens, and cosmetics don't matter much there.

Given how little used the option is, and its issues, removing
it seems reasonable.

Change-Id: I2c70b3e4c74ff3cc6dbac46366a371d271dd2d58
2022-10-02 09:21:25 -04:00
..
bitmaps Rename symbols of FiiO M3K Linux-based port 2021-02-27 23:53:28 +00:00
gui gui: Remove show/hide selection option in lists 2022-10-02 09:21:25 -04:00
hosted/android keyboard add ability to specify temporary custom layouts 2020-07-22 06:48:28 -04:00
iap apps: Add ability to do a clean reboot 2022-04-16 14:36:39 +01:00
keymaps fiiom3k Yes/No screen: Only accept Play button for YES 2022-04-18 22:28:13 -04:00
lang FS13356: Update Polish Translation (Adam Rak) 2022-09-25 18:28:04 -04:00
menus gui: Remove show/hide selection option in lists 2022-10-02 09:21:25 -04:00
plugins gui: Remove show/hide selection option in lists 2022-10-02 09:21:25 -04:00
radio Fix red in bc416ff590 2021-04-10 21:06:41 -04:00
recorder Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
abrepeat.c [3/4] Completely remove HWCODEC support 2020-07-24 21:20:13 +00:00
abrepeat.h [3/4] Completely remove HWCODEC support 2020-07-24 21:20:13 +00:00
action.c key remap: simplify and use movable allocations 2022-09-25 11:05:59 +01:00
action.h key remap: simplify and use movable allocations 2022-09-25 11:05:59 +01:00
alarm_menu.c alarm_menu share setter with settime 2022-03-30 09:05:28 -04:00
alarm_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
appevents.h Get voice event out of playback.c 2017-12-12 20:28:56 -05:00
applimits.h
apps.make
audio_path.c nwza860: fix simulator build 2020-10-19 03:39:33 +00:00
audio_thread.c Get voice event out of playback.c 2017-12-12 20:28:56 -05:00
audio_thread.h
beep.c
bookmark.c whitespace fixes 2021-10-21 22:42:01 +02:00
bookmark.h
buffering.c buffering: remove bufgettail/bufcuttail 2022-04-20 16:51:49 -04:00
buffering.h buffering: remove bufgettail/bufcuttail 2022-04-20 16:51:49 -04:00
codec_thread.c codec_thread.c don't overrun audio_formats[] array 2021-08-11 10:56:14 -04:00
codec_thread.h
codecs.c [3/4] Completely remove HWCODEC support 2020-07-24 21:20:13 +00:00
core_asmdefs.c
core_keymap.c key remap: simplify and use movable allocations 2022-09-25 11:05:59 +01:00
core_keymap.h key remap: simplify and use movable allocations 2022-09-25 11:05:59 +01:00
cuesheet.c Allow cuesheet index offsets longer than 99 minutes. 2022-04-07 20:10:19 -04:00
cuesheet.h [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
debug_menu.c gui: Remove show/hide selection option in lists 2022-10-02 09:21:25 -04:00
debug_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
enc_config.c enc_config.c don't overrun mp3_enc_bitr[] array 2021-08-11 11:00:03 -04:00
enc_config.h Fix menu warnings 2018-10-18 00:06:31 +02:00
features.txt Reset settings on button hold 2022-06-21 22:43:39 -04:00
filetree.c filetree.c cleanup 2022-03-21 08:14:30 -04:00
filetree.h FS#13287 - Load a newly saved playlist and resume where it was 2021-05-03 20:10:27 +00:00
filetypes.c misc: Add 'mpga' as a valid file extension 2022-02-01 13:23:39 -05:00
filetypes.h filetree.c move static and stack allocated buffers around 2021-10-20 16:05:21 -04:00
fracmul.h
keyboard.h [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
language.c language.c fix possible buffer overrun 2021-08-03 00:57:35 +00:00
language.h
logfdisp.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
logfdisp.h
main.c Reset settings on button hold 2022-06-21 22:43:39 -04:00
menu.c Fix glitches with custom list title viewports 2022-02-06 11:20:34 -05:00
menu.h do_menu pass internal synclist reference to callback 2020-07-19 22:10:26 +00:00
misc.c add const to const * strings 2022-05-03 23:00:58 -04:00
misc.h add function string_option to misc.c use in skin_parser.c 2022-03-13 03:45:00 -04:00
onplay.c add hotkeys for properties and pictureflow 2022-08-05 11:39:35 -04:00
onplay.h add hotkeys for properties and pictureflow 2022-08-05 11:39:35 -04:00
open_plugin.c apps: fix use of negative fd in open_plugin.c 2022-05-02 16:42:32 +01:00
open_plugin.h Open Plugins Ignore hash for lang Ids 2021-10-23 02:45:54 -04:00
pcmbuf.c Additional Single Mode options 2021-12-11 11:43:39 -05:00
pcmbuf.h Fix a problem with audio not starting on a list of short files 2017-04-06 19:32:35 -04:00
playback.c buffering: remove bufgettail/bufcuttail 2022-04-20 16:51:49 -04:00
playback.h Option to switch off album art or to prefer file over embedded 2022-01-22 08:29:40 -05:00
playlist.c Playlists: Fix losing cached control data when resuming 2022-08-19 00:28:35 -04:00
playlist.h [3/4] Completely remove HWCODEC support 2020-07-24 21:20:13 +00:00
playlist_catalog.c Partial fix for FS#12702: playlist catalogue silently fails to save files 2022-08-21 09:36:04 -04:00
playlist_catalog.h
playlist_menu.h
playlist_viewer.c Playlist Viewer: Fix unintentional fallthrough 2022-08-19 00:29:17 -04:00
playlist_viewer.h
plugin.c gui: Remove show/hide selection option in lists 2022-10-02 09:21:25 -04:00
plugin.h gui: Remove show/hide selection option in lists 2022-10-02 09:21:25 -04:00
rbcodec_helpers.c tdspeed.c remove buffer name strings 2022-05-05 00:31:07 -04:00
rbcodecconfig.h
rbcodecplatform.h
README
root_menu.c BUGFIX root_menu.c 2022-03-18 19:45:01 -04:00
root_menu.h Add open_plugin to core 2020-08-17 10:15:14 -04:00
screen_access.c Whitespace cleanup on fb_viewport Rewrite 2020-10-26 12:38:22 -04:00
screen_access.h Whitespace cleanup on fb_viewport Rewrite 2020-10-26 12:38:22 -04:00
screens.c Properties plugin: Eliminate redundant Track Info code 2022-05-09 09:44:23 -04:00
screens.h Remove dead code 2022-04-16 10:18:28 -04:00
settings.c Option to switch off album art or to prefer file over embedded 2022-01-22 08:29:40 -05:00
settings.h Reset settings on button hold 2022-06-21 22:43:39 -04:00
settings_list.c Cabbie v2: 240x320: Increase font size to 18. Remove linespace and increase the size of the album art slightly to better utilize the screen area. 2022-09-18 11:09:38 -06:00
settings_list.h Add open_plugin to core 2020-08-17 10:15:14 -04:00
shortcuts.c add const to const * strings 2022-05-03 23:00:58 -04:00
shortcuts.h
sound_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
SOURCES LastFm remove scrobbler from core make a TSR plugin WIP 2022-03-26 02:50:11 -04:00
status.c [2/4] get rid of HAVE_LCD_CHARCELLS 2020-07-24 21:20:13 +00:00
status.h [2/4] get rid of HAVE_LCD_CHARCELLS 2020-07-24 21:20:13 +00:00
tagcache.c tagtree: Delay showing search progress when ramcache is enabled 2022-08-19 00:27:34 -04:00
tagcache.h tagtree/tagcache add new clause operators begins/ends _oneof 2022-03-19 02:24:14 -04:00
tagnavi.config tagtree: Support user override config file 2021-12-24 10:41:27 -05:00
tagtree.c tagtree: Delay showing search progress when ramcache is enabled 2022-08-19 00:27:34 -04:00
tagtree.h Fix menu warnings 2018-10-18 00:06:31 +02:00
talk.c apps: fix close of negative fd in talk.c 2022-05-02 16:34:18 +01:00
talk.h talk: Explicitly cast -1 as unsigned before a left shift. 2021-07-20 00:09:33 +00:00
tree.c tree.c update settings when new theme selected 2022-04-28 18:56:13 -04:00
tree.h Fix tree.c->tree_get_entry_at() buffer overflow 2018-12-14 01:28:17 -06:00
usb_keymaps.c Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
usb_keymaps.h
voice_thread.c voice_thread.c ensure cpu gets re-boosted after Q_VOICE_STOP event 2021-09-29 01:18:00 -04:00
voice_thread.h voice: Allow voice prompt volume to be configurable 2021-03-07 12:51:36 +00:00

README 

For general information see: docs/README
For API information see: docs/API