Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
rockbox/apps/plugins
History
Franklin Wei 4554b90859 sdl: fix two bugs in ROCKBOXAUD_PlayAudio() 
First was an off-by-one bug in the loop over buffers. The condition was
`i < this->hidden->n_buffers', but should have been <=, not <. This wasn't
a critical issue, because the last iteration would check the currently
playing buffer - an unlikely situation.

The second logic bug would make the code always think it had found an empty
buffer, even when it had not, since `idx' was being unconditionally set
every loop, rendering it unusable for a sentinel value. Fix that.

Change-Id: I137330965d699acf827e59b6aa5c5f9ddf2ca617
2023-05-17 13:23:14 -04:00
..
beatbox [1/4] Remove SH support and all archos targets 2020-07-24 21:20:13 +00:00
bitmaps Fix red in 9bd5249 2023-01-06 06:38:57 +01:00
chessbox plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
clock plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
doom plugins HAVE_BACKLIGHT helper remove ifdefs in favor of dummy functions 2022-11-23 23:00:29 -05:00
fft plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
fractals plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
frotz
goban Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
imageviewer plugins: Simplify plugin/codec API versioning 2023-03-21 16:23:54 -04:00
lib [Feature, Plugin] lastfm_scrobbler_viewer 2023-04-16 23:50:24 -04:00
lua lua: rocklib_events fix 2023-01-02 13:38:08 -05:00
lua_scripts random_playlist.lua make index more sparse 2021-12-08 22:09:16 -05:00
midi New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
mikmod Add perceptual volume adjustment 2023-01-22 21:19:57 +00:00
mpegplayer Fix unified syntax in ARM inline assembly 2023-03-23 18:16:33 +00:00
pacbox plugins HAVE_BACKLIGHT helper remove ifdefs in favor of dummy functions 2022-11-23 23:00:29 -05:00
pdbox pdbox: Move core thread off COP 2023-01-29 07:15:40 -05:00
pictureflow Track Info: Show number of tracks being inspected 2023-04-13 03:55:21 +02:00
puzzles plugins HAVE_BACKLIGHT helper remove ifdefs in favor of dummy functions 2022-11-23 23:00:29 -05:00
reversi New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
rockboy settings: Remove setting ID return from find_setting() 2022-12-17 13:36:38 +00:00
sdl sdl: fix two bugs in ROCKBOXAUD_PlayAudio() 2023-05-17 13:23:14 -04:00
searchengine
shortcuts gui: Remove "enum list_wrap" from list action functions 2022-10-05 11:22:55 -04:00
sudoku New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
text_viewer Remove browse_context_init() 2022-12-17 13:36:38 +00:00
xworld settings: Remove setting ID return from find_setting() 2022-12-17 13:36:38 +00:00
zxbox New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
2048.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
alarmclock.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
announce_status.c [Feature] resume TSR plugins after interruption WIP 2023-03-25 10:02:43 -04:00
battery_bench.c [Feature] resume TSR plugins after interruption WIP 2023-03-25 10:02:43 -04:00
bench_mem_jpeg.c
bench_scaler.c
blackjack.c Remove the (very) incomplete port for the Tatung TPJ-1102 2021-08-14 16:29:39 -04:00
boomshine.lua
bounce.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
brickmania.c plugins HAVE_BACKLIGHT helper remove ifdefs in favor of dummy functions 2022-11-23 23:00:29 -05:00
bubbles.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
BUILD_OVERLAY Rockbox as an application: Replace many occurences of #ifdef SIMULATOR with #if (CONFIG_PLATFORM & PLATFORM_HOSTED) (or equivalently). 2010-06-21 16:53:00 +00:00
calculator.c Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
calendar.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
CATEGORIES [Feature, Plugin] lastfm_scrobbler_viewer 2023-04-16 23:50:24 -04:00
chessbox.c
chessclock.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
chip8.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
chopper.c plugins HAVE_BACKLIGHT helper remove ifdefs in favor of dummy functions 2022-11-23 23:00:29 -05:00
clix.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
codebuster.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
credits.c plugins: Credits: Fix logo sizes 2023-01-05 23:45:41 -05:00
credits.pl
crypt_firmware.c
cube.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
db_folder_select.c folder_select.c move to plugin as db_folder_select 2021-11-11 00:28:59 -05:00
demystify.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
dice.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
dict.c
disktidy.c
disktidy.config
duke3d.c
elfdep.pl first shot at a perl script that generates the dependencies for the .elf files 2005-03-06 00:05:33 +00:00
fire.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
fireworks.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
flipit.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
goban.c
greyscale.c Nuke the never-functional iriver ifp-7xx port 2021-04-26 07:42:58 -04:00
helloworld.c
helloworld.lua
invadrox.c Define LCD_STRIDEFORMAT unconditionally 2022-09-30 10:42:49 +01:00
iriver_flash.c
iriverify.c
jackpot.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
jewels.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
keybox.c gui: Remove "enum list_wrap" from list action functions 2022-10-05 11:22:55 -04:00
keyremap.c [Feature, Plugin] lastfm_scrobbler_viewer 2023-04-16 23:50:24 -04:00
lamp.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
lastfm_scrobbler.c [Feature, Plugin] lastfm_scrobbler_viewer 2023-04-16 23:50:24 -04:00
lastfm_scrobbler_viewer.c Fix Red lastfm_scrobbler_viewer.c 2023-04-17 00:36:04 -04:00
logo.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
lrcplayer.c Add perceptual volume adjustment 2023-01-22 21:19:57 +00:00
lua_scripts.lua lua print table put_line a do_menu alternative 2021-04-20 03:30:41 +00:00
main_menu_config.c gui: Remove "enum list_wrap" from list action functions 2022-10-05 11:22:55 -04:00
matrix.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
maze.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
mazezam.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
md5sum.c
metronome.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
minesweeper.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
mosaique.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
mp3_encoder.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
multiboot_select.c plugins: Add multiboot select plugin 2022-04-16 14:36:39 +01:00
open_plugins.c [BugFix] open_plugin didn't recognize opx shortcuts 2023-03-30 01:04:51 -04:00
oscilloscope.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
otp.c Remove browse_context_init() 2022-12-17 13:36:38 +00:00
pegbox.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
periodic_table.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
pictureflow.c
pitch_detector.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
pitch_screen.c wps.c cleanup gui_show_wps 2022-12-14 22:35:33 -05:00
pixel-painter.lua
plasma.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
plugin.lds DM320: Regorganize LCD and TTB memory layout 2021-07-09 09:24:38 +00:00
plugin_crt0.c apps: Add ability to do a clean reboot 2022-04-16 14:36:39 +01:00
plugins.make rb_info plugin and button,action+context name helper 2021-11-22 21:39:45 -05:00
pong.c plugins HAVE_BACKLIGHT helper remove ifdefs in favor of dummy functions 2022-11-23 23:00:29 -05:00
properties.c Track Info: Show number of tracks being inspected 2023-04-13 03:55:21 +02:00
quake.c
random_folder_advance_config.c gui: Remove "enum list_wrap" from list action functions 2022-10-05 11:22:55 -04:00
rb_info.c [Feature, Plugin] lastfm_scrobbler_viewer 2023-04-16 23:50:24 -04:00
remote_control.c
resistor.c plugins HAVE_BACKLIGHT helper remove ifdefs in favor of dummy functions 2022-11-23 23:00:29 -05:00
robotfindskitten.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
rockblox.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
rockblox1d.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
rockbox-fonts.config
rockboy.c
rocklife.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
rockpaint.c Remove browse_context_init() 2022-12-17 13:36:38 +00:00
search.c
settings_dumper.c
shopper.c gui: Remove "enum list_wrap" from list action functions 2022-10-05 11:22:55 -04:00
sliding_puzzle.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
snake.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
snake2.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
snake2.levels
snow.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
sokoban.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
sokoban.levels
solitaire.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
sort.c
SOURCES [Feature, Plugin] lastfm_scrobbler_viewer 2023-04-16 23:50:24 -04:00
SOURCES.app_build keyboard.c Use viewports, move text box pos 2022-04-07 19:46:56 -04:00
spacerocks.c plugins: SpaceRocks: iPod keymap, use Menu button for Menu 2022-12-29 08:10:01 +01:00
speedread.c Remove browse_context_init() 2022-12-17 13:36:38 +00:00
star.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
starfield.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
stats.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
stopwatch.c Nuke the never-functional iriver ifp-7xx port 2021-04-26 07:42:58 -04:00
stopwatch.lua New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
SUBDIRS Revert "RFC: Get rid of mpegplayer plugin" 2022-10-13 11:08:11 -04:00
SUBDIRS.app_build
superdom.c gui: Remove show/hide selection option in lists 2022-10-02 09:21:25 -04:00
test_boost.c
test_codec.c
test_core_jpeg.c Second try: Introduce plugin_crt0.c that every plugin links. 2010-08-24 14:30:46 +00:00
test_disk.c plugins HAVE_BACKLIGHT helper remove ifdefs in favor of dummy functions 2022-11-23 23:00:29 -05:00
test_fps.c plugins HAVE_BACKLIGHT helper remove ifdefs in favor of dummy functions 2022-11-23 23:00:29 -05:00
test_gfx.c plugins HAVE_BACKLIGHT helper remove ifdefs in favor of dummy functions 2022-11-23 23:00:29 -05:00
test_grey.c plugins HAVE_BACKLIGHT helper remove ifdefs in favor of dummy functions 2022-11-23 23:00:29 -05:00
test_greylib_bitmap_scale.c
test_kbd.c keyboard.c Use viewports, move text box pos 2022-04-07 19:46:56 -04:00
test_mem.c
test_mem_jpeg.c
test_resize.c
test_sampr.c Add 192 and 176KHz to mikmod and test_sampr plugins 2020-09-30 22:52:56 -04:00
test_scanrate.c
test_touchscreen.c New port: Shanling Q1 native 2021-07-13 22:01:33 +01:00
test_usb.c [Feature] resume TSR plugins after interruption WIP 2023-03-25 10:02:43 -04:00
test_viewports.c Bug Fix test_viewports.c call scroll_stop before changing viewports 2022-11-16 01:49:41 -05:00
test_viewports.lua
text_editor.c gui: Remove "enum list_wrap" from list action functions 2022-10-05 11:22:55 -04:00
theme_remove.c
vbrfix.c plugins: vbrfix: Fix fd leak & error handling 2023-04-01 08:19:22 -04:00
viewers.config [Feature, Plugin] lastfm_scrobbler_viewer 2023-04-16 23:50:24 -04:00
vu_meter.c plugins: VU Meter: Ignore backlight timeout 2022-12-27 09:43:34 -05:00
wav2wv.c
wavview.c
windows_lnk.c
wolf3d.c
wormlet.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
xobox.c plugins: Improve usability of iPod keymaps 2022-12-29 04:39:22 +01:00
zxbox.c