Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
rockbox/apps
History
Franklin Wei 4554b90859 sdl: fix two bugs in ROCKBOXAUD_PlayAudio() 
First was an off-by-one bug in the loop over buffers. The condition was
`i < this->hidden->n_buffers', but should have been <=, not <. This wasn't
a critical issue, because the last iteration would check the currently
playing buffer - an unlikely situation.

The second logic bug would make the code always think it had found an empty
buffer, even when it had not, since `idx' was being unconditionally set
every loop, rendering it unusable for a sentinel value. Fix that.

Change-Id: I137330965d699acf827e59b6aa5c5f9ddf2ca617
2023-05-17 13:23:14 -04:00
..
bitmaps Rename symbols of FiiO M3K Linux-based port 2021-02-27 23:53:28 +00:00
gui Track Info: Show number of tracks being inspected 2023-04-13 03:55:21 +02:00
hosted/android replace strlcpy with strmemccpy 2022-11-14 23:56:16 -05:00
iap Remove buflib allocation names, part two 2023-01-13 10:32:54 +00:00
keymaps Fix locked context fallthrough 2023-03-18 17:47:19 +00:00
lang FS#13992: Update Serbian translation (Ivan Pesic) 2023-05-09 16:37:07 -04:00
menus Add perceptual volume adjustment 2023-01-22 21:19:57 +00:00
plugins sdl: fix two bugs in ROCKBOXAUD_PlayAudio() 2023-05-17 13:23:14 -04:00
radio Remove buflib allocation names, part two 2023-01-13 10:32:54 +00:00
recorder Using ARM Unified Assembler Language 2023-03-23 13:28:22 -04:00
abrepeat.c [3/4] Completely remove HWCODEC support 2020-07-24 21:20:13 +00:00
abrepeat.h abrepeat add dummy functions and remove some of the ifdefs 2022-12-14 23:37:14 -05:00
action.c Remove buflib allocation names, part two 2023-01-13 10:32:54 +00:00
action.h [Feature/Bugfix] keyremap add Context flags 2022-12-31 16:12:18 -05:00
alarm_menu.c alarm_menu share setter with settime 2022-03-30 09:05:28 -04:00
alarm_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
appevents.h
applimits.h Remove two unused defines. 2010-08-21 15:49:42 +00:00
apps.make makefiles: Suppress stray backslash warnings with grep 3.8 2023-03-21 04:48:31 -04:00
audio_path.c nwza860: fix simulator build 2020-10-19 03:39:33 +00:00
audio_thread.c
audio_thread.h
beep.c
bookmark.c wps.c cleanup gui_show_wps 2022-12-14 22:35:33 -05:00
bookmark.h Fix return to root after selecting items from playlist viewer 2022-11-19 10:01:23 +01:00
buffering.c [BugFix] Buffering.c NULL src for memcpy is UB -- ASAN 2023-01-04 20:20:08 -05:00
buffering.h buffering: remove bufgettail/bufcuttail 2022-04-20 16:51:49 -04:00
codec_thread.c codec_thread.c don't overrun audio_formats[] array 2021-08-11 10:56:14 -04:00
codec_thread.h
codecs.c plugins: Simplify plugin/codec API versioning 2023-03-21 16:23:54 -04:00
core_asmdefs.c
core_keymap.c Add core_get_data_pinned(), use it where possible 2023-01-15 08:57:45 -05:00
core_keymap.h key remap: simplify and use movable allocations 2022-09-25 11:05:59 +01:00
cuesheet.c cuesheet.c guard against invalid digits causing underflow on field ASAN 2022-11-21 23:24:30 -05:00
cuesheet.h [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
debug_menu.c debug_menu database delay redraw 2023-01-27 00:10:47 -05:00
debug_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
enc_config.c menus remove reserved 'param' parameter 2022-12-17 04:24:37 -05:00
enc_config.h Fix menu warnings 2018-10-18 00:06:31 +02:00
features.txt Add perceptual volume adjustment 2023-01-22 21:19:57 +00:00
filetree.c filetree: Remove dead code in ft_build_playlist() 2023-03-24 19:02:56 +00:00
filetree.h Don't autoload bookmarks after saving dynamic playlist 2022-10-18 07:23:25 -04:00
filetypes.c [Feature, Plugin] lastfm_scrobbler_viewer 2023-04-16 23:50:24 -04:00
filetypes.h [Feature, Plugin] lastfm_scrobbler_viewer 2023-04-16 23:50:24 -04:00
fracmul.h
keyboard.h [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
language.c language.c fix possible buffer overrun 2021-08-03 00:57:35 +00:00
language.h Change the .lng files to contain strings from multiple users. Still hard-coded to only output the core strings for now. Should be the majority of the core changes needed for translatable plugins. 2009-10-18 00:56:42 +00:00
logfdisp.c misc.c open_pathfmt caller supplied buffer 2022-11-23 22:09:46 -05:00
logfdisp.h
main.c remove rockboxlogo after boot INIT_ATTR 2022-12-19 18:59:59 -05:00
menu.c settings: Remove setting ID return from find_setting() 2022-12-17 13:36:38 +00:00
menu.h menus remove reserved 'param' parameter 2022-12-17 04:24:37 -05:00
misc.c [Feature] Supress voice during sleep timer shutdown 2023-04-08 17:13:07 -04:00
misc.h Add perceptual volume adjustment 2023-01-22 21:19:57 +00:00
onplay.c Track Info: Show number of tracks being inspected 2023-04-13 03:55:21 +02:00
onplay.h Hotkey: Add List Bookmarks action 2023-04-05 09:06:28 -04:00
open_plugin.c [BugFix] open_plugin didn't recognize opx shortcuts 2023-03-30 01:04:51 -04:00
open_plugin.h open_plugin.c access open_plugin_entry through a function 2022-12-16 09:05:06 -05:00
pcmbuf.c Additional Single Mode options 2021-12-11 11:43:39 -05:00
pcmbuf.h Fix a problem with audio not starting on a list of short files 2017-04-06 19:32:35 -04:00
playback.c Remove buflib allocation names, part two 2023-01-13 10:32:54 +00:00
playback.h Option to switch off album art or to prefer file over embedded 2022-01-22 08:29:40 -05:00
playlist.c Temp quick fix for broken bookmarks 2023-04-22 12:58:18 -04:00
playlist.h playlist: Remove control file cache 2023-03-24 19:02:56 +00:00
playlist_catalog.c Database: Add ability to insert multiple files into playlists 2023-01-14 12:14:28 -05:00
playlist_catalog.h Database: Add ability to insert multiple files into playlists 2023-01-14 12:14:28 -05:00
playlist_menu.h
playlist_viewer.c Track Info: Show number of tracks being inspected 2023-04-13 03:55:21 +02:00
playlist_viewer.h Playlist Catalogue: Restore selection in playlist 2022-11-26 17:20:06 +01:00
plugin.c [Feature] resume TSR plugins after interruption WIP 2023-03-25 10:02:43 -04:00
plugin.h Track Info: Show number of tracks being inspected 2023-04-13 03:55:21 +02:00
rbcodec_helpers.c Remove buflib allocation names, part two 2023-01-13 10:32:54 +00:00
rbcodecconfig.h kernel: Break out kernel primitives into separate files and move to separate dir. 2014-03-03 18:11:57 +01:00
rbcodecplatform.h rbcodec: abstract tdspeed buffer allocation 2012-05-07 10:29:07 +02:00
README lets point to the docs dir 2002-08-21 10:25:16 +00:00
root_menu.c Remove browse_context_init() 2022-12-17 13:36:38 +00:00
root_menu.h Add open_plugin to core 2020-08-17 10:15:14 -04:00
screen_access.c make splash split on control characters 2022-11-12 06:22:16 -05:00
screen_access.h make splash split on control characters 2022-11-12 06:22:16 -05:00
screens.c Track Info: Show number of tracks being inspected 2023-04-13 03:55:21 +02:00
screens.h Track Info: Show number of tracks being inspected 2023-04-13 03:55:21 +02:00
settings.c [BugFix] font.c filename was movable 2023-02-15 01:15:59 -05:00
settings.h Add perceptual volume adjustment 2023-01-22 21:19:57 +00:00
settings_list.c Hotkey: Add List Bookmarks action 2023-04-05 09:06:28 -04:00
settings_list.h settings: Update doc comment for struct settings_list::cfg_vals 2022-12-01 14:24:51 -05:00
shortcuts.c Remove buflib allocation names, part two 2023-01-13 10:32:54 +00:00
shortcuts.h
sound_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
SOURCES LastFm remove scrobbler from core make a TSR plugin WIP 2022-03-26 02:50:11 -04:00
status.c [2/4] get rid of HAVE_LCD_CHARCELLS 2020-07-24 21:20:13 +00:00
status.h Add a comment about the ordering of 'enum playmode' 2022-11-23 10:08:49 -05:00
tagcache.c tagnavi make track submenu 2023-02-07 08:44:57 -05:00
tagcache.h Tagcache - Ramcache Move ref checks, speed up disk searches 2023-01-27 00:03:51 -05:00
tagnavi.config tagnavi make track submenu 2023-02-07 08:44:57 -05:00
tagtree.c playlist: Simplify playlist modified detection 2023-03-23 13:01:23 -04:00
tagtree.h database: make parent tables work with plugin 2023-01-19 15:56:35 -05:00
talk.c Remove buflib allocation names, part two 2023-01-13 10:32:54 +00:00
talk.h talk.c clean up 2022-11-19 02:12:09 -05:00
tree.c [Bugfix] open_plugin_browse() not showing plugins 2023-03-18 04:23:43 -04:00
tree.h [Bugfix] open_plugin_browse() not showing plugins 2023-03-18 04:23:43 -04:00
usb_keymaps.c Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
usb_keymaps.h
voice_thread.c Remove buflib allocation names, part two 2023-01-13 10:32:54 +00:00
voice_thread.h voice: Allow voice prompt volume to be configurable 2021-03-07 12:51:36 +00:00

README 

For general information see: docs/README
For API information see: docs/API