Andree Buschmann
f7808c1fe5
Fix several 'variable set but not used' warnings reported by GCC 6.4.1.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29871 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 18:47:42 +00:00
Thomas Martitz
6034978c84
Skin engine: Swap meaning of & and * for touch regions.
...
r29653 broke compatibility in a unnecessary way, including shipped themes (cabbieve2). Swapping restores compatibility.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29866 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 11:38:04 +00:00
Andree Buschmann
fffc6c4a80
Trapped into ifdef-hell. Configure libfaad's IRAM/DRAM usage like it is meant to be.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29864 a1c6a512-1295-4272-9138-f99709370657
2011-05-12 22:24:09 +00:00
Andree Buschmann
281666a066
The last submit had one define too much. Nevertheless fix the IRAM configuration for static allocation method.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29863 a1c6a512-1295-4272-9138-f99709370657
2011-05-12 18:06:03 +00:00
Andree Buschmann
2263cf35ab
libfaad: AAC including HE-profile needs ~470 KB for playback (measured on ARM). Therefor it does not make sense to enable HE on devices with CODEC_SIZE < 512 KB. This will allow to load and play larger AAC-LC files on such devices.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29862 a1c6a512-1295-4272-9138-f99709370657
2011-05-12 17:41:45 +00:00
Andree Buschmann
72fba7a9d7
Make libfaad compilable again without PS_DEC.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29861 a1c6a512-1295-4272-9138-f99709370657
2011-05-12 17:35:06 +00:00
Michael Hohmuth
bc315ad731
FS#12076 - DB stats resurrection: If the filename was changed, require
...
all three of album, artist, and title tags to match for resurrection
to take place.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29858 a1c6a512-1295-4272-9138-f99709370657
2011-05-11 22:37:46 +00:00
Andree Buschmann
0e7c04e57d
libfaad: Move PS related variables to sbr_info struct. This allows dynamic allocation including error handling.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29857 a1c6a512-1295-4272-9138-f99709370657
2011-05-11 18:52:05 +00:00
Andree Buschmann
03e23d1113
Implement error handling for libfaad's memory allocation. Do not allocate PS related types dynamically anymore to minimize code changes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29854 a1c6a512-1295-4272-9138-f99709370657
2011-05-10 19:04:24 +00:00
Andree Buschmann
78b0f94c76
Proper initialization of static variables in codeclib.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29853 a1c6a512-1295-4272-9138-f99709370657
2011-05-10 18:20:56 +00:00
Michael Hohmuth
6a24a7a903
tagnavi.config: Add a logical-OR operator ("|") for tagnavi conditionals.
...
Logical-AND ("&") always takes precedence over logical-OR.
(Parentheses are not supported.)
Fight binsize increase by storing some common expressions in local
variables. This avoids repeated reevaluations involving memory
accesses.
check_clauses: Fail clause (return false) in case of errors (tag too
long, DB entry deleted).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29851 a1c6a512-1295-4272-9138-f99709370657
2011-05-10 10:25:41 +00:00
Jeffrey Goode
8cb4b36ee3
Fix whitespace and some comment typos
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29850 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 21:52:06 +00:00
Michael Sevakis
5a8f5b8330
Provide a reasonable fix for FS#12093 - Playback hanging after codec/playback rework. Also, get rid of an impossible buffering case (BUF_USED is always less than buffer_len) and remove a buffering API that is not used anywhere and shouldn't be needed (plugin API has to be incompatible).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29849 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 21:19:11 +00:00
Andree Buschmann
12e8e43236
Use signed variable to check available buffer size.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29848 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 20:43:35 +00:00
Andree Buschmann
1ee4e89627
Renaming for the sake of consistency.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29846 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 19:34:45 +00:00
Michael Hohmuth
0b59079dd2
Fix a warning
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29845 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 13:07:04 +00:00
Michael Hohmuth
84301c1e2d
FS#11931 part 1: Make fade in/out behavior more consistent across the
...
various causes of pause and unpause.
Patch by John Morris.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29844 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 12:59:46 +00:00
Michael Hohmuth
9b7027232f
unplug_change: Precede call to audio_ff_rewind with
...
audio_pre_ff_rewind (for SWCODEC).
This became necessary with the recent playback-code renovation.
Thanks to jethead for the hint!
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29843 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 12:51:19 +00:00
Andree Buschmann
9befc2e747
Remove tabs.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29842 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 21:21:02 +00:00
Andree Buschmann
67f215032d
Fix a bunch of 'variable set but not used' warnings reported from GCC 4.6.0.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29841 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 21:06:38 +00:00
Bertrik Sikken
ab99e941db
More tab fixes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29840 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 20:35:29 +00:00
Andree Buschmann
d68d02ec11
Move implementation of codec_get_buffer() to codec.c, make related variables static.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29839 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 20:18:35 +00:00
Andree Buschmann
b452fa061d
Use CACHEALIGN_SIZE in codec_malloc for optimal alignment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29838 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 19:50:39 +00:00
Andree Buschmann
f79769c541
Minor loop optimization in libfaad's is/ms decoding.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29837 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 19:36:08 +00:00
Andree Buschmann
e720724b95
Use MEM_ALIGN_ATTR and CACHEALIGN_SIZE in oggmalloc to ensure optimal alignment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29833 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 16:41:23 +00:00
Andree Buschmann
897fd92827
codeclib: Declare several variables static and remove unused variables.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29831 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 10:34:05 +00:00
Nils Wallménius
04b4722a5c
Fix FS#12098 by ignoring battery update events in the yesno screen.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29828 a1c6a512-1295-4272-9138-f99709370657
2011-05-07 08:08:49 +00:00
Magnus Holmgren
c2ff646b78
Avoid false warnings of full dirs when the number of visible entries in a dir equals the limit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29823 a1c6a512-1295-4272-9138-f99709370657
2011-05-04 18:33:12 +00:00
Michael Giacomelli
37a9a200b2
Commit FS#12096 by Stephan Grossklass. Increases the maximum ID3v2 field length to 240 bytes on large memory targets, and 90 bytes on low memory targets. Total bytes for all tags combined remains unchanged.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29821 a1c6a512-1295-4272-9138-f99709370657
2011-05-04 17:29:53 +00:00
Andree Buschmann
d6accacc60
Fix last known 'variable set but not used' warning reported from GCC 4.6.0.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29820 a1c6a512-1295-4272-9138-f99709370657
2011-05-04 06:11:59 +00:00
Andree Buschmann
f19d6a5e1d
Fix even more 'variable set but not used' warnings reported from GCC 4.6.0.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29819 a1c6a512-1295-4272-9138-f99709370657
2011-05-03 20:28:56 +00:00
Bertrik Sikken
069567c0bc
iap: pass length and data pointer to iap_handlepkt functions, this prepares for iap large packet support.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29815 a1c6a512-1295-4272-9138-f99709370657
2011-05-02 21:55:13 +00:00
Andree Buschmann
8aa1577a0b
Display the correct sign of replaygain for levels from -0.99 to -0.01 dB.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29814 a1c6a512-1295-4272-9138-f99709370657
2011-05-01 21:12:40 +00:00
Andree Buschmann
9af2ca7340
Remove tabs.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29813 a1c6a512-1295-4272-9138-f99709370657
2011-05-01 20:33:31 +00:00
Nils Wallménius
4a62bc40c2
Work around another 'set but not used' warning.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29811 a1c6a512-1295-4272-9138-f99709370657
2011-05-01 16:53:20 +00:00
Andree Buschmann
27d153db93
Fix nearly all residual 'variable set but not used' warnings reported from GCC 4.6.0.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29810 a1c6a512-1295-4272-9138-f99709370657
2011-05-01 14:44:20 +00:00
Andree Buschmann
f7c4594134
Fix further 'variable set but not used' warnings reported from GCC 4.6.0.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29809 a1c6a512-1295-4272-9138-f99709370657
2011-05-01 13:48:28 +00:00
Andree Buschmann
e75018ad66
Fix several 'variable set but not used' warnings reported from GCC 4.6.0.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29805 a1c6a512-1295-4272-9138-f99709370657
2011-05-01 11:42:41 +00:00
Michael Sevakis
5e57edf263
Clean up speex a bit after the playback changes in r29785. Haven't found any idiosyncracies not present before then. Fix it always returning CODEC_ERROR even when exiting codec_run normally.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29804 a1c6a512-1295-4272-9138-f99709370657
2011-05-01 04:23:30 +00:00
Bertrik Sikken
155584fb78
iap: introduce functions (put_u32 and get_u32) to convert a uint32_t to a byte array and vice versa
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29799 a1c6a512-1295-4272-9138-f99709370657
2011-04-30 18:21:18 +00:00
Magnus Holmgren
ed2cfb8c1d
Don't (partially) apply changes to max entries in the file browser immediately. The setting affects a buffer that is allocated during boot, so code using that buffer should use the value that was in effect during boot. Add a note to the manual that a reboot is needed for the changes to be applied.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29798 a1c6a512-1295-4272-9138-f99709370657
2011-04-30 11:00:26 +00:00
Bertrik Sikken
16e793f5d1
iap: update handling of IdentifyDeviceLingoes command and fix RF tuner detection code
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29797 a1c6a512-1295-4272-9138-f99709370657
2011-04-30 10:40:05 +00:00
Bertrik Sikken
eac9577f76
FS#12085 - Correction of iap.c to avoid sending useless data to an accessory, and allow larger playlists names, by Ophir Lojkine
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29796 a1c6a512-1295-4272-9138-f99709370657
2011-04-30 09:15:57 +00:00
Andree Buschmann
d0d1a3f2f7
Remove unneeded update of ci->id3->frequency in aac and raac codec.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29794 a1c6a512-1295-4272-9138-f99709370657
2011-04-28 21:07:28 +00:00
Michael Sevakis
ac724cca19
Get the NSF internal playlists working again. Fix a few wrongdoings in the metadata parser. Use the larger of track or playlist count to determine 'duration' so that the repeat-one switching to access the raw tracks works.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29793 a1c6a512-1295-4272-9138-f99709370657
2011-04-28 02:56:28 +00:00
Andree Buschmann
fa65362a42
Fix compiler warnings ('variable set ut not used') with GCC 4.6.0.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29792 a1c6a512-1295-4272-9138-f99709370657
2011-04-27 17:59:49 +00:00
Michael Sevakis
4170ac8ac6
Fix r29790 yellow. Need 'string-extra.h' for strlcpy().
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29791 a1c6a512-1295-4272-9138-f99709370657
2011-04-27 17:06:52 +00:00
Michael Sevakis
3d9c062822
Get NSF fixed up a bit and parse metadata in the core.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29790 a1c6a512-1295-4272-9138-f99709370657
2011-04-27 16:46:27 +00:00
Michael Sevakis
08bedf8305
Having a default weak codec_main symbol doesn't seem to be working out for compiling the sim under cygwin in at least some cases. Just implement it explicitly in all cases.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29789 a1c6a512-1295-4272-9138-f99709370657
2011-04-27 12:52:11 +00:00
Bertrik Sikken
1a68986bc5
FS#12079 - Support for new commands in iap.c, by Ophir Lojkine
...
This allows access to the playlists from an ipod dock.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29788 a1c6a512-1295-4272-9138-f99709370657
2011-04-27 06:24:28 +00:00