Commit graph

9345 commits

Author SHA1 Message Date
Magnus Holmgren
ee378abe63 Add support for the album artist field used by Foobar2000 in ID3v2 tags.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18935 a1c6a512-1295-4272-9138-f99709370657
2008-10-30 19:00:24 +00:00
Björn Stenberg
0ca8c44f9d Data does not belong in .h files. Not even if it makes the .c file prettier.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18934 a1c6a512-1295-4272-9138-f99709370657
2008-10-30 14:39:20 +00:00
Jonathan Gordon
fdd4050bc7 fix some problems with the menu code:
- MENU_FUNC_CHECK_RETVAL has been loosened to return if the function returns non-zero (and passes that return value on as the return value for do_menu(). This is fine for now because only 2 places uses this flag and both return 1.
- when the option screen or a function is called from a menu which doesn't use the full screen viewport the wrong viewport was used (option screen crashed, and returning from the funciton ignored the origional viewport.) This is now changed so (for now) the option screen always gets the full screen viewport and returning from functions shows the menu correctly.

Some time in the future menu items which are functions should be changed to accept a viewport (if they end up drawing). 
When that happens both option screen and the called function should use the menu's parent viewport


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18933 a1c6a512-1295-4272-9138-f99709370657
2008-10-30 07:07:45 +00:00
Dave Chapman
25d4f4bb7a Add .oga as a valid file extension for Ogg vorbis files. Even though Xiph recommend against using .oga for vorbis (for compatibility reasons), they say that it may be used, and some applications (e.g. Gnome Media) are doing so.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18932 a1c6a512-1295-4272-9138-f99709370657
2008-10-30 01:17:26 +00:00
Björn Stenberg
3e4c9f760b Added an explicit bitmap dependency to icons.h to resolve issues with parallell builds (-j).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18922 a1c6a512-1295-4272-9138-f99709370657
2008-10-29 15:59:20 +00:00
Björn Stenberg
20754cf370 'make voice' no longer builds bitmaps.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18920 a1c6a512-1295-4272-9138-f99709370657
2008-10-29 14:24:59 +00:00
Jens Arnold
68f3ad3454 state->savedboard doesn't exist, so revert that part of r18906 for now. It might be necessary to redo this fix properly. Also, state->currentboard is an array of shorts, so the memcpy() only covered half of it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18917 a1c6a512-1295-4272-9138-f99709370657
2008-10-29 07:51:45 +00:00
Dominik Riebeling
24cf2ae804 Fix sudoku crash when using reload without previously saved state (FS#9509 by Henri Valta). Fix a similar issue when using reload after generating a new sudoku by me.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18906 a1c6a512-1295-4272-9138-f99709370657
2008-10-28 22:39:54 +00:00
Dave Chapman
74b935c893 Make the e200v2 simulator compile - an easy job as the apps/ code is identical to the e200v1.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18902 a1c6a512-1295-4272-9138-f99709370657
2008-10-28 17:49:35 +00:00
Magnus Holmgren
1b9991c229 Try to fix FS#9502: end playback properly if no valid files were found in a playlist.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18891 a1c6a512-1295-4272-9138-f99709370657
2008-10-26 20:15:10 +00:00
Magnus Holmgren
e511017293 Bump plugin API version as needed.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18890 a1c6a512-1295-4272-9138-f99709370657
2008-10-26 20:11:26 +00:00
Jonas Häggqvist
a28e33f861 Language updates:
- Synched Danish by me
 - Synched Finnish by Jani Kinnunen (FS#9488)
 - Fix spelling errors in Polish translation by Marcin Łukasik (FS#9416)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18887 a1c6a512-1295-4272-9138-f99709370657
2008-10-26 14:17:49 +00:00
Bertrik Sikken
92683778f6 Add missing #include to mp3 metadata parser.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18885 a1c6a512-1295-4272-9138-f99709370657
2008-10-26 13:07:29 +00:00
Nils Wallménius
7bb81ce689 Change button map for iaudio x5 and m5 to avoid using impossible button combos, delete ondio button map as it has no rtc
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18884 a1c6a512-1295-4272-9138-f99709370657
2008-10-26 12:47:43 +00:00
Jonathan Gordon
535764c76b bah! messed up the filename settings... and do some line length fixing
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18883 a1c6a512-1295-4272-9138-f99709370657
2008-10-26 11:59:21 +00:00
Jonathan Gordon
9e2807fc66 Add a simple plugin (apps/settings_dumper.rock) which dumps the valid values of all the config settings to /settings_dumper.txt. If you notice any settings its not dumping please let me know.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18882 a1c6a512-1295-4272-9138-f99709370657
2008-10-26 11:44:21 +00:00
Dominik Riebeling
2fb63ae6a8 Add in-grid graphical markers for scratchpad values to sudoku (FS#8364 by Henri Valta with adjustments by me).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18880 a1c6a512-1295-4272-9138-f99709370657
2008-10-25 21:22:00 +00:00
Nils Wallménius
e477052497 Add MEM_FUNCTION_WRAPPERS to fix linker errors and tweak the ipod buttonmap slightly
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18877 a1c6a512-1295-4272-9138-f99709370657
2008-10-25 17:03:38 +00:00
Nils Wallménius
50a8017139 Accept FS#9224 by Teruaki Kawashima, adding support for all RTC equipped targets and some other enhancements to the calendar plugin.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18875 a1c6a512-1295-4272-9138-f99709370657
2008-10-25 16:34:15 +00:00
Nils Wallménius
be00a109b3 FS#9487 fixes and improvements of the calendar plugin by Teruaki Kawashima
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18870 a1c6a512-1295-4272-9138-f99709370657
2008-10-24 08:40:48 +00:00
Mustapha Senhaji
3ff2f14f9e Just correct a typo in a comment.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18869 a1c6a512-1295-4272-9138-f99709370657
2008-10-23 16:23:42 +00:00
Michael Sevakis
effceea229 Remove the event object in the kernel since it's rather extraneous at the moment. This makes the codecs and the plugins incompatible, so update fully.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18867 a1c6a512-1295-4272-9138-f99709370657
2008-10-23 13:13:00 +00:00
Dave Chapman
188e898e3c Refactor the panning code into separate functions, and correct a comment
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18865 a1c6a512-1295-4272-9138-f99709370657
2008-10-23 08:05:25 +00:00
Jonathan Gordon
106b68e3a7 Accept FS#9504 - make the FILENAME_SETTING() macro more user-proof, also rename it to TEXT_SETTING
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18864 a1c6a512-1295-4272-9138-f99709370657
2008-10-23 00:29:17 +00:00
Dave Chapman
a42602b350 Don't accept 0 for the width or height of a progress bar in the %pb tag. A zero width causes a divide by zero, and a zero height simply doesn't make any sense, so we assume it was a mistake.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18863 a1c6a512-1295-4272-9138-f99709370657
2008-10-22 21:35:38 +00:00
Nils Wallménius
4e14f2d6dd Fix test_codec plugin that was broken by r18834
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18862 a1c6a512-1295-4272-9138-f99709370657
2008-10-22 18:42:55 +00:00
Jonathan Gordon
7b77910de4 fix FS#8124 - pressing STOP after seeking while paused causes playback to start again for a second or 2
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18860 a1c6a512-1295-4272-9138-f99709370657
2008-10-22 09:59:42 +00:00
Dave Chapman
019f9c034b Make some local global variables static.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18859 a1c6a512-1295-4272-9138-f99709370657
2008-10-22 08:50:13 +00:00
Jens Arnold
4e2557cfce Fix .talk clips on hwcodec targets. mp3info() must not call get_metadata(), because this one tries to guess which get_xx_metadata() to call from the extension, and mp3info() is used in talk_file() (extension .talk) on hwcodec.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18855 a1c6a512-1295-4272-9138-f99709370657
2008-10-21 19:28:40 +00:00
Dave Chapman
76596deaf1 Move the monolithic jpeg viewer into its own subdirectory and split it into three (for now - maybe it should be split further) files - jpeg.c (the main plugin/viewer parts), jpeg_decoder.c (the actual decoder) and. for colour targets only, yuv2rgb.c. The intention of this commit is as a first step towards abstracting this viewer into a reusable jpeg decoder and a multi-format image viewer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18853 a1c6a512-1295-4272-9138-f99709370657
2008-10-21 16:05:46 +00:00
Nils Wallménius
2f50cd58b9 Codec memory reorganization
Based on a patch by Tomasz Malesinski
* Merge Codec buffer and Malloc buffer into one large buffer.
* The new merged buffer is now 1MB on targets with lots of memory.
* Renamed codec_get_memory to codec_get_buffer and made it behave more. 
like plugin_get_buffer.
* Bumped Codec api and min api versions.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18834 a1c6a512-1295-4272-9138-f99709370657
2008-10-19 12:35:53 +00:00
Jonathan Gordon
5320a6a019 Dont show lines which have no info in the id3 viewer screen.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18832 a1c6a512-1295-4272-9138-f99709370657
2008-10-19 03:58:33 +00:00
Frank Gevaerts
8c08511013 revert plugin_api part of r18830, as this was the wrong solution for those
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18831 a1c6a512-1295-4272-9138-f99709370657
2008-10-18 23:50:05 +00:00
Frank Gevaerts
ae7391b187 code police : fix some multiply defined variables
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18830 a1c6a512-1295-4272-9138-f99709370657
2008-10-18 23:31:29 +00:00
Jens Arnold
42e0c3b45e Increase UCL blocksize in order to fix 'blocksize too small' errors when trying to flash rockbox on fm/v2 recorders. Default blocksize is 256KB and our thinned-out decompressor only supports single-block UCL files. 1MB blocksize should be on the safe side.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18823 a1c6a512-1295-4272-9138-f99709370657
2008-10-18 11:20:22 +00:00
Jens Arnold
546083c784 Merge the necessary changes for the new archos firmware flash images back to the trunk, including the related optimisations.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18821 a1c6a512-1295-4272-9138-f99709370657
2008-10-16 16:42:37 +00:00
Jonathan Gordon
00a228fefb Accept FS#7482 by Klaas Bosteels - return the full path of a file which doesnt have valid tags yet (and use the end of the filename for the title) instead of before which was only using the filename
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18820 a1c6a512-1295-4272-9138-f99709370657
2008-10-16 11:11:45 +00:00
Jonathan Gordon
71898e5c54 Accept FS#9480 - centralise and organise the events in the apps/ layer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18819 a1c6a512-1295-4272-9138-f99709370657
2008-10-16 10:38:03 +00:00
Björn Stenberg
51b45d5602 Split id3.c/h into metadata.c/h and metadata/mp3.c. Updated all references. Moved mp3data.c/h from firmware to apps.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18814 a1c6a512-1295-4272-9138-f99709370657
2008-10-15 06:38:51 +00:00
Magnus Holmgren
d2dd34ba29 Update Swedish translation.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18811 a1c6a512-1295-4272-9138-f99709370657
2008-10-14 18:46:39 +00:00
Magnus Holmgren
9c52c39528 Make some dependencies on id3.h explicit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18810 a1c6a512-1295-4272-9138-f99709370657
2008-10-14 18:40:52 +00:00
Björn Stenberg
f30430f9a3 Added #include pcm_record.h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18809 a1c6a512-1295-4272-9138-f99709370657
2008-10-14 12:15:14 +00:00
Björn Stenberg
9cf024c5a8 Red build fix: Moved PCM #defines from pcm_record.h to pcm.h. Added necessary #includes to statusbar.c and s1a0903x01.c.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18808 a1c6a512-1295-4272-9138-f99709370657
2008-10-14 11:43:32 +00:00
Björn Stenberg
9558c4956d Moved pcm_record from firmware to apps. Cleaned up some. Now all code using struct mp3entry is in apps.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18807 a1c6a512-1295-4272-9138-f99709370657
2008-10-14 11:12:20 +00:00
Michael Giacomelli
1620d1fd03 Correct poor assumption on my part that WMA frames are 2048 samples long. Fixed problems with sample rates < 44.1khz. Fixes FS#9242 and FS#9439.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18805 a1c6a512-1295-4272-9138-f99709370657
2008-10-14 01:41:26 +00:00
Marianne Arnold
b774adafe4 Pegbox - new graphics for Archos, c200, small H10, Mini, M3 - also cleaning and small tweaks to the rest of the greyscale and monochrome bitmaps. Aspect ratio correct the pieces for the Archos screen (now uses 9x7 tiles) which made it possible to also add the header with statistics). Necessary changes to pegbox.c: don't assume piece height = piece width, prepare a new 'wide' layout for the c200 with the statics at the side. Additional cleanup - make the code more readable by replacing repeatedly used bmpheight_XYZ with defines, splitting some too long lines. Let the 'Start on level' line in the menu actually appear on the Mini's screen. Also rename the greyscale graphics according convention to '...x2.bmp' and set the mime-type more accurately for all pegbox bitmaps. Finally, add Joel Puik, the creator of the original colour graphics to CREDITS.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18803 a1c6a512-1295-4272-9138-f99709370657
2008-10-13 23:13:12 +00:00
Peter D'Hoye
c5383c1c27 Stop scrolling lines when entering or leaving a menu list item. Fixes FS #9478 (Scrolling lines from (menu) lists are drawn over other screens)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18802 a1c6a512-1295-4272-9138-f99709370657
2008-10-13 22:08:01 +00:00
Nils Wallménius
5aa0665b5b Move 'Playback Settings' up from 'General Settings' to 'Settings' (FS#9472 by William Poetra Yoga Hadisoeseno but without the menu rearrangement) also closes FS#9154. Update manual to reflect the menu change, Playback Settings is now its own chapter. As a bonus that makes it a bit easier to find stuff in the toc.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18799 a1c6a512-1295-4272-9138-f99709370657
2008-10-13 15:11:11 +00:00
Nils Wallménius
4b7ebdc6f2 FS#9463 Fixes and updates to the simplified Chinese translation by William Poetra Yoga Hadisoeseno
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18798 a1c6a512-1295-4272-9138-f99709370657
2008-10-13 14:22:05 +00:00
Nils Wallménius
68f6e83eb0 Alternate fix for the bug fixed by FS#9163, the selection in the playlist viewer was one line too low, which caused it to be off-screen if the last item was selected. The cause was that the selected item was set before the list title, fixed by re-calculating the position of the selected item after setting the title.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18797 a1c6a512-1295-4272-9138-f99709370657
2008-10-13 12:16:06 +00:00