Commit graph

6907 commits

Author SHA1 Message Date
Nicolas Pennequin
5cc98efddc Add %fk and %Fk WPS tags : (next) file audio frequency in KHz (rewrite of FS#6393 to adapt it to the tokenizer).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13455 a1c6a512-1295-4272-9138-f99709370657
2007-05-21 13:41:43 +00:00
Nicolas Pennequin
9d5e376fc3 Allow the day of month (%cm) and day of week (%cu and %cw) RTC tags to be used in enums.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13454 a1c6a512-1295-4272-9138-f99709370657
2007-05-21 12:54:07 +00:00
Michael Sevakis
14b639d179 wavrecord needs its own source count. Source defines also collided with some new constants and that was part of the problem too.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13451 a1c6a512-1295-4272-9138-f99709370657
2007-05-20 21:17:04 +00:00
Michael Sevakis
6dbf4081df Fix the wavrecord errors
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13450 a1c6a512-1295-4272-9138-f99709370657
2007-05-20 20:59:33 +00:00
Michael Sevakis
8f659ae8d3 Use bitmasks to define which inputs are available. Makes it easier to remove old assumptions of which are available. Inspired by e200 being unique in having FM Radio and Mic but no Line. Doesn't remove the assumption that Mic is available or that one of Mic and/or Line is available just to avoid excessive #ifdef'ing until needed.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13448 a1c6a512-1295-4272-9138-f99709370657
2007-05-20 20:26:36 +00:00
Mustapha Senhaji
c4da23ab0e Update the francais language, plus some minor changes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13446 a1c6a512-1295-4272-9138-f99709370657
2007-05-20 16:28:38 +00:00
Jonathan Gordon
fd9d140119 Fix FS#7176 - wps context menu doesnt set the correct selection.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13445 a1c6a512-1295-4272-9138-f99709370657
2007-05-20 14:24:02 +00:00
Marcoen Hirschberg
0037a1b648 add separate button defines for the Gigabeat remote control
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13442 a1c6a512-1295-4272-9138-f99709370657
2007-05-20 11:42:04 +00:00
Dan Everton
4c486ce948 Add splash messages while copying, moving, and deleting files. Also boost the CPU during move/copy since it seems to make things faster.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13441 a1c6a512-1295-4272-9138-f99709370657
2007-05-20 10:04:39 +00:00
Jonathan Gordon
b85817a5ba Update some comments in menu.h to be hopefully more helpful.
Fix all the wrong usage of rb->do_menu() (my fault, sorry)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13439 a1c6a512-1295-4272-9138-f99709370657
2007-05-20 08:26:27 +00:00
Marcoen Hirschberg
5b0ced85c3 directly calculate some defines from the screen size
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13437 a1c6a512-1295-4272-9138-f99709370657
2007-05-20 00:19:53 +00:00
Marcoen Hirschberg
a7168feeac attempt to make the Gigabeat button mappings in the plugins more logical and in line with the mapping in rockbox itself
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13436 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 23:38:09 +00:00
Jens Arnold
e09b87a31f WAV recording plugin: Fix distortion when feeding a full-range digital signal (most noticeable from S/PDIF), and make it obvious that S/PDIF recording ignores the defined sample rate.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13435 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 23:31:42 +00:00
Marcoen Hirschberg
0671cee53a remove useless button defines
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13434 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 22:00:49 +00:00
Nils Wallménius
f7a81a9d6a More header and dead code cleanup.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13430 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 20:55:49 +00:00
Linus Nielsen Feltzing
a416cc981a Prevent idle poweroff in the MIDI player
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13427 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 20:37:02 +00:00
Nils Wallménius
f31e123133 Remove unused function and unused header
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13424 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 19:54:11 +00:00
Jens Arnold
2dddc1c0d4 Fix name collision on misc.h between zxbox and core.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13421 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 19:15:14 +00:00
Jens Arnold
52986fb79e Fix name collision on misc.h between zxbox and core.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13420 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 19:13:56 +00:00
Jens Arnold
b4702463e2 Archos Recorders, Ondio FM: WAV recording plugin. This is considered a technical preview, and has the following limitations: * No peakmeters and no gain control. The plugin reuses the gain values from the core, so use the core's recording screen to set gain, then call the plugin. * Recording directory is fixed, and on Ondio it always records to external MMC (there is not much point to record WAV to the 128MB internal flash). * All supported targets just generate numbered filenames, i.e. no R[DATE][TIME].wav files on recorders. * Only records to a single file, and will stop when approaching the safe file size limit of 2GB.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13416 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 18:29:27 +00:00
Linus Nielsen Feltzing
fcbc699dca Prevent idle poweroff in the MPEG video player plugin. Fixes FS#6091.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13413 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 17:02:55 +00:00
Marcoen Hirschberg
6ea228d39d fix warnings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13407 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 00:51:21 +00:00
Peter D'Hoye
fabe988eb2 Always save settings when leaving recording, not just when leaving recording settings. Should fix FS #7185
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13406 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 00:27:24 +00:00
Marcoen Hirschberg
0d02c13bac add a menu to the chessbox plugin, FS #7186 by Mauricio Peccorini
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13405 a1c6a512-1295-4272-9138-f99709370657
2007-05-18 22:12:34 +00:00
Jens Arnold
900ced2c05 Player: Fix database commit step display on boot.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13400 a1c6a512-1295-4272-9138-f99709370657
2007-05-17 06:37:25 +00:00
Hardeep Sidhu
8c2bcf1bff Use INSERT_LAST when inserting tracks before playback has started. Fixes FS#7153. Also code policed for 80 col limit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13396 a1c6a512-1295-4272-9138-f99709370657
2007-05-15 23:30:30 +00:00
Nicolas Pennequin
95b52a0d00 Make bubbles smoother (and a bit faster) on the gigabeat.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13394 a1c6a512-1295-4272-9138-f99709370657
2007-05-15 16:45:45 +00:00
Jonathan Gordon
4bf27eccdd another LAME for colombo... fix the sansa wheel; in solitaire
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13391 a1c6a512-1295-4272-9138-f99709370657
2007-05-15 14:08:17 +00:00
Jonathan Gordon
6ddc38c021 Accept FS#7170 - fix a bug with random folder advance
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13390 a1c6a512-1295-4272-9138-f99709370657
2007-05-15 06:42:02 +00:00
Nicolas Pennequin
6190a0d68d Add an item to the WPS context menu to browse a currently playing cuesheet. The menu that appears allows changing tracks within the cuesheet. It was already reachable by selecting the right cuesheet file in the file browser, but this makes it easier to use (and should help users noticing that possibility because many seemed to ignore this viewer existed).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13388 a1c6a512-1295-4272-9138-f99709370657
2007-05-14 17:34:52 +00:00
Nicolas Pennequin
4a6ab0d031 Commit FS#7164 (request is FS#6780) : Improve WPS volume enumeration. It is now the following : %?pv<Mute|...|...|0 dB|Above 0 dB>. It almost doesn't changes anything for most WPSs but adds some new possibilities. Keep in mind that some targets don't go above 0 dB so the last case might be unused.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13387 a1c6a512-1295-4272-9138-f99709370657
2007-05-14 14:33:43 +00:00
Nils Wallménius
9e94b380f0 Accept FS#6934 by Akio Idehara to fix an unresolved dependency on apps/codecs/codec_crt0.o that could trigger when using 'make' with the '-j' switch
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13386 a1c6a512-1295-4272-9138-f99709370657
2007-05-14 10:07:41 +00:00
Steve Bavin
21d538b98e Fix for unlikely, but possible, division-by-zero
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13385 a1c6a512-1295-4272-9138-f99709370657
2007-05-14 09:56:55 +00:00
Karl Kurbjun
2ac037d7c5 Set the brightness before setting the timeout values for the backlight and buttonlights
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13382 a1c6a512-1295-4272-9138-f99709370657
2007-05-14 04:44:55 +00:00
Thom Johansen
30d01b66db FS #7163. Updated norsk.lang by Tobias Langhoff.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13380 a1c6a512-1295-4272-9138-f99709370657
2007-05-13 17:11:22 +00:00
Dave Chapman
98b7229d7e Oops, the previous commit broke the speed-test feature. This fixes it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13377 a1c6a512-1295-4272-9138-f99709370657
2007-05-13 00:32:56 +00:00
Dave Chapman
3463e87220 Add WAV-writing option - currently limited to 16-bit output only; Make it work in the sim again (after the change to grab the codec thread stack); Some cosmetic cleanups.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13376 a1c6a512-1295-4272-9138-f99709370657
2007-05-13 00:11:25 +00:00
Jonathan Gordon
c9ed673c81 only show the cursor for the first line of the selected item (if selection is more than one line). doesnt effect inverted cursor mode
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13375 a1c6a512-1295-4272-9138-f99709370657
2007-05-12 14:13:23 +00:00
Michael Sevakis
d92e09556f GPIO IRQ ready button driver for e200 series. Can't actually use them yet but their status is polled. Easy to switch over once that works. Cheapo acceleration added or else it would be too fast for selecting items. Too much scrolling might cause the PCM buffer to empty out - beware. )
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13371 a1c6a512-1295-4272-9138-f99709370657
2007-05-11 08:09:49 +00:00
Dave Chapman
198845fe91 Set svn:keywords
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13370 a1c6a512-1295-4272-9138-f99709370657
2007-05-10 21:56:34 +00:00
Dave Chapman
f02cba8096 Code cleaning - remove some unnecessary defined(SIMULATOR) checks
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13369 a1c6a512-1295-4272-9138-f99709370657
2007-05-10 13:16:08 +00:00
Jonathan Gordon
cbf6a66aca Accpet FS#7141, Italian Language update by Alessio Lenzi
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13367 a1c6a512-1295-4272-9138-f99709370657
2007-05-10 01:20:46 +00:00
Michael Sevakis
77771b0a43 How'd I miss that I'd left LOGFQUEUES enabled in my pre-commit diff? :/
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13365 a1c6a512-1295-4272-9138-f99709370657
2007-05-09 03:48:52 +00:00
Michael Sevakis
e486ed0453 SWCODEC Playback: Put a stop to the resume deadlock however crudely. Clean some unused lines out that no longer compatible.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13364 a1c6a512-1295-4272-9138-f99709370657
2007-05-09 03:44:44 +00:00
Michael Sevakis
a21871ceaa Fix errors. LOGFQUEUE should take formatting parameters now.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13363 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 23:13:46 +00:00
Michael Sevakis
d9839bc8a6 Silly fix for a silly comment mistake.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13362 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 22:59:25 +00:00
Michael Sevakis
1c59b101df SWCODEC Playback: Seriously mess with it and get rid of (at least some ;) race conditions.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13361 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 22:56:12 +00:00
Michael Sevakis
e88078f9f5 Playback: Ensure some state coherency. paused implies playing and pause actions are bypassed if not playing. stopped implies not playing and not paused. Starting playback transistions to playing and not paused.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13360 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 16:19:13 +00:00
Jens Arnold
34e6b6b2ae Fix red overlay plugins on archos. Linker scripts weren't prepared for those plugins using plugin library components.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13359 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 12:28:34 +00:00
Jonathan Gordon
77a458a464 Move the old api out of the core and into the plugin lib.
ew plugins shuold use the new api and not this one.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13358 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 11:55:43 +00:00
Karl Kurbjun
6f95ab7de7 Add in buttonlight brightness setting for the Gigabeat, and setup the framework for future players that have adjustable button light brightness settings. Also fixed a bug in the backlight code when the brightness was set to 0.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13356 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 06:45:38 +00:00
Jonathan Gordon
cf478758dd fix the menus again, this time it stopped redrawing after coming out of setting screens
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13353 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 01:32:29 +00:00
Karl Kurbjun
2576d34ac6 Fix Gigabeat english.lang target specific strings (should be gigabeatf rather then gigabeat)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13352 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 01:20:09 +00:00
Jonas Häggqvist
09097978be Synced
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13350 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 00:31:11 +00:00
Dave Chapman
4ae85e6886 Revert the addition of the steal_codec_stack function. Replace by accessing the threads structure to grab the codec stack. Maybe a better solution exists.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13349 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 23:54:10 +00:00
Karl Kurbjun
3d53e10341 Reduce code size for players that do not have the 'Human Interface Luminescence Control' feature
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13348 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 23:42:12 +00:00
Dave Chapman
f4a9dab4d1 Use a separate thread in test_codec, with the same (IRAM) stack as the main codec thread. Add a function to the plugin API to steal the codec thread, which test_codec copies and then restores. Now libmad can be benchmarked.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13347 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 22:30:23 +00:00
Karl Kurbjun
173b611921 Basic gigabeat buttonlight support outside of debug menu FS#7112. Also disables USB PLL and the USB device clock (uneeded to connect to computer) - May offer some power savings. Changed how some pins are initialized.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13346 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 19:34:34 +00:00
Dave Chapman
7cdd0fe6ea Initial version of a test_codec plugin (viewer). This loads the audio file into the audio buffer and decodes it as fast as it can via a locally implemented version of the codec API. Intended for use when optimising codecs - so isn't built by default. Remember to add it to both plugins/SOURCES and viewers.config to enable it. Currently the codec is run in the main thread which means mpa.codec doesn't work - it requires more stack than is available on the main thread. The solution will be to create a new thread in the plugin which steals the main codec thread's IRAM stack, but that's not done yet.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13345 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 17:23:31 +00:00
Dave Chapman
1feb8bd4a1 Minor header file cleanup - try and include the minimal number of files, and only where they are needed.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13344 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 13:32:56 +00:00
Dave Chapman
9a011f3a80 Clean up the codec API - remove all unused (and in many cases inappropriate) functions, move functions used only by encoders into the HAVE_RECORDING part of the API and document the reasons for the more unexpected functions being present.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13343 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 11:09:45 +00:00
Dave Chapman
a8b7967055 Code police - codecs shouldn't call GUI functions
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13341 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 10:34:10 +00:00
Jonathan Gordon
e22f22b599 Accept FS#7123 - add h10_5gb strings
Do the same for e200 by me


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13340 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 08:53:37 +00:00
Jonathan Gordon
baf9cf6990 Fix my previous commit... menus will redraw correctly again
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13338 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 08:50:47 +00:00
Jonathan Gordon
1228820ca9 Fix the menus so lines scroll again
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13337 a1c6a512-1295-4272-9138-f99709370657
2007-05-07 07:51:35 +00:00
Jonathan Gordon
0e8a9e4eb7 e200 viewer button changes:
- rec button toggles auto-scroll
- scroll wheel scrolles text up/down by lines (FS#7087)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13336 a1c6a512-1295-4272-9138-f99709370657
2007-05-06 15:41:10 +00:00
Nils Wallménius
f41497f98e Fix metadata reading for 64 bit sims. Closes FS#6690
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13335 a1c6a512-1295-4272-9138-f99709370657
2007-05-06 15:09:41 +00:00
Thom Johansen
35390cd625 FS #7115. Updated nynorsk translation by Karl Ove Hufthammer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13333 a1c6a512-1295-4272-9138-f99709370657
2007-05-06 11:10:00 +00:00
Magnus Holmgren
a967523b2b Fix buffer overflow when adding a radio preset.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13327 a1c6a512-1295-4272-9138-f99709370657
2007-05-05 12:06:35 +00:00
Michael Sevakis
a8140eb259 Enable KBD_CURSOR_KEYS and KBD_MODES on Gigabeat. Enter things any way you like.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13324 a1c6a512-1295-4272-9138-f99709370657
2007-05-04 17:15:55 +00:00
Michael Sevakis
2aaf45e643 Get samplerate switching working in the sim to be similar to on target. Make all pcm functions available there as well.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13320 a1c6a512-1295-4272-9138-f99709370657
2007-05-04 15:14:56 +00:00
Michael Sevakis
d7e8e38253 Audio seemed never to want to stop stopping. A bad condition for plugins that want to stop audio and begin pcm playback immediately. Only do the stop if the state is playing. Properly wait for it to be done as well.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13317 a1c6a512-1295-4272-9138-f99709370657
2007-05-03 21:49:59 +00:00
Hardeep Sidhu
7a2bc5272b Enable playlist functions for m3u files
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13308 a1c6a512-1295-4272-9138-f99709370657
2007-05-03 01:10:52 +00:00
Nicolas Pennequin
aa220d5acd Trim a bunch of long lines and fix an infinite loop and buffer overrun in the impossible case that a WPS line ends with a litteral string but without a newline char (wps_parser.c:774).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13306 a1c6a512-1295-4272-9138-f99709370657
2007-05-02 17:51:01 +00:00
Magnus Holmgren
2a20bfe153 Make the ID3 info screen treat empty tag strings as 'no value', like the WPS does.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13305 a1c6a512-1295-4272-9138-f99709370657
2007-05-02 17:01:02 +00:00
Magnus Holmgren
05a158ecf3 Treat empty strings as 'no value' in conditionals, as it used to.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13304 a1c6a512-1295-4272-9138-f99709370657
2007-05-02 16:28:24 +00:00
Nicolas Pennequin
378a140ae2 Add a check for unclosed conditionals at the end of the WPS parsing in case we didn't reach the end of the file. Also a few minor other changes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13303 a1c6a512-1295-4272-9138-f99709370657
2007-05-02 11:39:46 +00:00
Peter D'Hoye
3494b2118b FS #7093 by Dave Hooper: prevent crash when loading too many/long static strings in the wps
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13302 a1c6a512-1295-4272-9138-f99709370657
2007-05-01 23:36:15 +00:00
Jonathan Gordon
26ff697480 clean up and fix comments. no actual code change
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13297 a1c6a512-1295-4272-9138-f99709370657
2007-05-01 11:01:53 +00:00
Jonathan Gordon
1fa516822f The menu code needs to know that the function wants a param...
Fixes all the playlist insert/queue items


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13296 a1c6a512-1295-4272-9138-f99709370657
2007-05-01 10:43:30 +00:00
Nicolas Pennequin
7e6af1532b Better handling of strings in the WPS parser by detecting duplicates to avoid having two copies of the same string in the string buffer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13295 a1c6a512-1295-4272-9138-f99709370657
2007-04-30 14:08:58 +00:00
Jonathan Gordon
3a7760c3e2 Convert onplay.c to the new manu API. only plugins are still using the old API now
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13294 a1c6a512-1295-4272-9138-f99709370657
2007-04-30 13:41:33 +00:00
Jonathan Gordon
507345000d these should be static
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13288 a1c6a512-1295-4272-9138-f99709370657
2007-04-29 23:26:26 +00:00
Jens Arnold
fa67e5fd4d Fix typo.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13287 a1c6a512-1295-4272-9138-f99709370657
2007-04-29 19:54:45 +00:00
Jonathan Gordon
39a6b5d643 Stop using the old menu API in the debug menu (using the new api causes massive bin increase, so fake the old api with existing code instead) (onplay.c and plugins are the only parts using th eold api now)
Fix a bug where the menu title was sometimes shown in the system font


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13286 a1c6a512-1295-4272-9138-f99709370657
2007-04-29 15:31:43 +00:00
Jonathan Gordon
4eaddc3f85 Use the new menu API
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13285 a1c6a512-1295-4272-9138-f99709370657
2007-04-29 15:02:09 +00:00
Miika Pekkarinen
b1ff1ea303 Improved speed when deleting tags and prevent remaining ghost entries with database loaded in ram.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13284 a1c6a512-1295-4272-9138-f99709370657
2007-04-29 14:40:59 +00:00
Jonathan Gordon
9270ada23a keep some #if 0'ed code in sync
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13283 a1c6a512-1295-4272-9138-f99709370657
2007-04-29 13:33:15 +00:00
Jonathan Gordon
caea20e75f show a splash instead of a menu when the chosen encoder format has no options
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13282 a1c6a512-1295-4272-9138-f99709370657
2007-04-29 13:26:56 +00:00
Marcoen Hirschberg
810f7178ae make A the new 'clear settings' button for the Gigabeat as it was easy to accidentally trigger it with HOLD
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13279 a1c6a512-1295-4272-9138-f99709370657
2007-04-27 19:24:31 +00:00
Marcoen Hirschberg
7eb8512bf0 changed POWER to be the cancel/stop button and A to be the modifier button to prevent acidental shutdowns
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13278 a1c6a512-1295-4272-9138-f99709370657
2007-04-27 18:48:20 +00:00
Nicolas Pennequin
b8a79b8bba Clear the RWPS backdrop when a RWPS is loaded, not when a WPS is loaded.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13275 a1c6a512-1295-4272-9138-f99709370657
2007-04-26 20:32:05 +00:00
Magnus Holmgren
832bbf72a8 AAC: More adjustments to how the frequency is read. Still not perfect, but this is probably as good as it can get.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13274 a1c6a512-1295-4272-9138-f99709370657
2007-04-26 17:59:24 +00:00
Jonathan Gordon
386d838b87 fix player warning
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13273 a1c6a512-1295-4272-9138-f99709370657
2007-04-26 14:02:10 +00:00
Jonathan Gordon
ed8b3bb74b Accept FS#7080 by Mauricio Peccorini with some minor changes by me:
- show more info in the stopwatch screen, and use the whole display for lap times


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13271 a1c6a512-1295-4272-9138-f99709370657
2007-04-26 13:52:53 +00:00
Jonathan Gordon
52ba1c614d Fix some naughty variable name reuse (hopefully correctly)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13269 a1c6a512-1295-4272-9138-f99709370657
2007-04-26 10:28:32 +00:00
Jonathan Gordon
3d44a20db7 Accept FS7078, try to show the last playlist if no audio is being played
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13268 a1c6a512-1295-4272-9138-f99709370657
2007-04-26 08:21:29 +00:00
Jonathan Gordon
5b5d1018d0 Fix a .icons loading bug which caused the tango iconset to not load.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13267 a1c6a512-1295-4272-9138-f99709370657
2007-04-26 05:30:46 +00:00
Nicolas Pennequin
1cf2ec38b1 Change some ifdefs for the recent backdrop changes (fixes the yellow builds) and move the backdrop files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13265 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 22:08:00 +00:00
Nicolas Pennequin
7fdfa56454 Add backdrop support for LCD remotes with depth > 1-bit. Only WPS backdrops, but the groundwork is laid for main backdrops too (all that's really needed are menus to set/clear them).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13263 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 21:44:56 +00:00
Michael Sevakis
205ec3279d Make recording complain about every little file I/O problem (error on close() failure and fsync() failure). Why? I guess we will find out the disk is full about 1/2 sector sooner on average when the file APIs actually detect this correctly. :/
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13262 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 19:53:34 +00:00
Nicolas Pennequin
2a2b8d8a82 Make bitmaps use the right format in a RWPS and prevent a backdrop tag in a RWPS from clearing the main display's backdrop. This also allows future backdrop support for LCD remotes by making the parsing code aware of whether the display for a WPS is a remote or not.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13261 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 13:09:56 +00:00
Jonathan Gordon
70e2846241 oops, wrong return value
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13260 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 12:17:16 +00:00
Jonathan Gordon
a2740d9edc convert the playlist viewer menus to the newer API
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13259 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 11:20:19 +00:00
Jonathan Gordon
680acbf71b fix a stupid bug which didnt check the flag correctly (caused the player to crash trying to access the shutdown options context menu)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13258 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 10:41:17 +00:00
Nicolas Pennequin
6ac306a515 Add a new commandline switch to the simulator: "--debugwps". It enables printing of advanced (and very verbose) WPS debugging information. Also make the debugging code a bit cleaner.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13257 a1c6a512-1295-4272-9138-f99709370657
2007-04-24 23:58:57 +00:00
Nicolas Pennequin
4ddc764a7c Small fix to prevent crashing when attempting to use non-mono bitmaps in a RWPS.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13256 a1c6a512-1295-4272-9138-f99709370657
2007-04-24 21:00:45 +00:00
Magnus Holmgren
ab707b8362 AAC: Improve SBR detection, to fix incorrect frequency on some files (and hopefully not break others :).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13255 a1c6a512-1295-4272-9138-f99709370657
2007-04-24 19:22:21 +00:00
Michael Sevakis
72e6dd5e0c Do the clamping a little better.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13254 a1c6a512-1295-4272-9138-f99709370657
2007-04-24 03:38:19 +00:00
Michael Sevakis
0d032d1fa1 mpeglayer: Give the simulator YCbCr blit similar behavior to the target.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13253 a1c6a512-1295-4272-9138-f99709370657
2007-04-24 02:46:32 +00:00
Nicolas Pennequin
d7fd989319 WPS Parser: On parse failure, print a (hopefully) useful error message with line number (sim only).
Also the debug code is still  disabled but now in a nicer way.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13251 a1c6a512-1295-4272-9138-f99709370657
2007-04-24 00:57:04 +00:00
Jens Arnold
27b4a64f9b AIFF COMM chunks might be larger than 18 bytes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13249 a1c6a512-1295-4272-9138-f99709370657
2007-04-23 23:11:33 +00:00
Jonathan Gordon
77a868360f make the moving smarter so you dont have to select the top card of a column to move the whole column
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13248 a1c6a512-1295-4272-9138-f99709370657
2007-04-23 14:15:07 +00:00
Jonathan Gordon
cd8870ccfb fix a bug which made menus using the old API and a callback function to not work correctly
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13246 a1c6a512-1295-4272-9138-f99709370657
2007-04-22 14:24:32 +00:00
Jonathan Gordon
4b1d1b4033 e200: Make the wheel light timeout configurable (under settings > system) (FS#7067)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13244 a1c6a512-1295-4272-9138-f99709370657
2007-04-22 13:02:24 +00:00
Jens Arnold
6bf86b799e Ooooops, fix warning.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13243 a1c6a512-1295-4272-9138-f99709370657
2007-04-22 12:48:05 +00:00
Jens Arnold
5070f41bfc Consolidated several potential places of return from WPS into one. Fixes the 'Return from WPS at end of playlist always brings up the root menu.' bug on hwcodec.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13241 a1c6a512-1295-4272-9138-f99709370657
2007-04-22 12:38:11 +00:00
Jonathan Gordon
9d3694ced6 Fix FS#7056 - dont display garbage if the viewer icon set and the main iconset have different icon heights
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13237 a1c6a512-1295-4272-9138-f99709370657
2007-04-22 08:50:24 +00:00
Nicolas Pennequin
814d402d4c More strict WPS parsing and displaying code. If there are errors, WPS loading will fail and the default WPS will be displayed.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13236 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 19:31:46 +00:00
Michael Sevakis
eb85f14f95 No more type punning where it's not funny.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13235 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 19:20:20 +00:00
Michael Sevakis
8676dc25f5 Missed a couple. Hopefully fix all warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13234 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 19:07:15 +00:00
Michael Sevakis
26d242ae65 General housekeeping: Make plugin buffer functions take size_t * instead of int * to match the parameter type of the buffer functions called in the core. Get rid of unsafe int * <==> size_t * casting. Use ssize_t where int was used and size_t where unsigned int was used in the buffer calls to not alter signedness in the plugins. No API version change since it should only be an issue for 64-bit sim builds.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13233 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 18:38:25 +00:00
Magnus Holmgren
cf6f4cf6f1 Bookmark screen fixes: 1) Make the 'Load bookmark?' prompt follow the status bar setting, and also actually display the statusbar. 2) Call the LCD update function on charcell devices.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13232 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 13:56:18 +00:00
Jonathan Gordon
7f3c66f1cb Fix the playlist viewer so only 1 line flashes when you move a track
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13231 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 11:14:57 +00:00
Jens Arnold
b1f0049307 Fix the undefined char symbols appearing in many output lines. This printf does neither support nor need \n.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13229 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 05:35:17 +00:00
Michael Sevakis
045d3cc9b5 mpegplayer: Fix jumping past the frame waiting if Limit FPS is on but Skip Frames is not. Fixes FS#7055 though this was just a general mistake and not limited to the sim.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13227 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 05:27:45 +00:00
Karl Kurbjun
335de0b043 Clean up that warning and pull out an unneeded #ifdef
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13226 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 05:07:18 +00:00
Karl Kurbjun
8a1fd8c686 Commit FS#6929 - Gigabeat bootloader improvements by Barry Wardell and myself. This build fixes the problems seen with the latest builds on the Gigabeat X. Added View IO Ports under the Debug menu for the Gigabeat. Make sure you grab the latest bootloader from the Wiki as the old bootloader will not work properly with new builds.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13225 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 04:48:20 +00:00
Jens Arnold
5a79536697 Changing colours didn't save settings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13212 a1c6a512-1295-4272-9138-f99709370657
2007-04-20 05:53:07 +00:00
Jens Arnold
2fd7c3c828 Make the simulator work with unicode filenames on windows. This includes both file operations and console (debug) output. Note that the console window _must_ be configured to use a truetype font for proper unicode display.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13211 a1c6a512-1295-4272-9138-f99709370657
2007-04-19 20:17:24 +00:00
Jonathan Gordon
5d173ead6e brickmania for the e200. (screen cant rotate, so using half the screen is better than nothing)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13210 a1c6a512-1295-4272-9138-f99709370657
2007-04-19 12:14:54 +00:00
Michael Sevakis
01c0fb492f mpegplayer: Better frame dropping code adapted to the using correct timestamps change. Even smoother frames. Higher FPS and smoother when having to drop than before (Around 15fps regulated for Elephants Dream on x5 which is a dismal situation, up from around 12 or so).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13205 a1c6a512-1295-4272-9138-f99709370657
2007-04-18 23:23:18 +00:00
Peter D'Hoye
0b11d983e7 Rockpaint plugin: protect against loading bitmaps that are too big. Fixes FS #7040
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13204 a1c6a512-1295-4272-9138-f99709370657
2007-04-18 21:13:08 +00:00
Brandon Low
b44b660ac4 Fix build for those who don't want to build tagcache
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13203 a1c6a512-1295-4272-9138-f99709370657
2007-04-18 19:46:34 +00:00
Magnus Holmgren
392a4ef49b Fix logf builds on devices that support remotes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13202 a1c6a512-1295-4272-9138-f99709370657
2007-04-18 17:49:32 +00:00
Jonathan Gordon
36a2e30872 Move the inbuilt filetype info into filetypes.c and rename the defines.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13201 a1c6a512-1295-4272-9138-f99709370657
2007-04-18 13:03:01 +00:00
Karl Kurbjun
c3dcc87aa4 Allow rockboy to run while music is playing with smaller roms. Works on players that do not use the IRAM macros. Only tested on the Gigabeat as I think that is the only player that will run rockboy well with music. Also simplified the sound and reduced the code size a bit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13199 a1c6a512-1295-4272-9138-f99709370657
2007-04-18 07:41:31 +00:00
Marianne Arnold
8f8510ed5a Since the greyscale remote deserved an own iconset the greyscale main screens should have one too. (They also had their own viewer icons already.)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13197 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 20:12:21 +00:00
Jonathan Gordon
27643c6538 Initialise the custom icons array correctly instead of just using the ? for all filetypes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13194 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 09:17:23 +00:00
Jonathan Gordon
e9610dca80 Remove unneeded #include, comment the filename define
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13193 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 08:37:01 +00:00
Linus Nielsen Feltzing
69e1f7528a Gigabeat: Use the volume up/down buttons for zooming in the JPEG viewer
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13192 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 07:50:46 +00:00
Jonathan Gordon
754d9195f7 explicitly set *loaded_ok = false; when given "" for a filename.
remove icon_init from the startup sequence, its not dependant on filetypes_init anymore,settings_apply calls the icons_init (causes the bmp's to only be read once on boot instead of twice)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13191 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 06:37:22 +00:00
Jens Arnold
79a8b41513 Fix loadable remote icons. fb_data != fb_remote_data ...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13190 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 01:03:25 +00:00
Jens Arnold
f87eaf3c4e Fix non-working default viewer icons. Remote viewer icons work now, but still not properly.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13189 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 00:29:04 +00:00
Jens Arnold
ded87cfcf5 Fix yellow...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13188 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 00:08:58 +00:00
Jens Arnold
539c513fe6 Temporary fix for remote bitmap functions in the multi-screen API. Fixed icon.c to use this. Also fixed crash due to missing assignment of lcd_bitmap[_part] for monochrome main LCDs.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13187 a1c6a512-1295-4272-9138-f99709370657
2007-04-16 23:55:19 +00:00
Jonathan Gordon
e346a4cb29 forgot to add this viewers iconset for greyscale targets
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13186 a1c6a512-1295-4272-9138-f99709370657
2007-04-16 23:45:57 +00:00
Magnus Holmgren
62994d42a7 Reduce code size a bit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13185 a1c6a512-1295-4272-9138-f99709370657
2007-04-16 19:17:37 +00:00
Jonathan Gordon
fd951ab8d0 make the folder icons play nice when you load a viewers theme (sorry, this is it from me tonight... )
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13184 a1c6a512-1295-4272-9138-f99709370657
2007-04-16 14:52:47 +00:00
Jonathan Gordon
a9c1df4001 * its name[rows][columns] you drongo!
* make custom viewer icons work slightly better
* minor nit-picks to keep crop happy
* create a /.rockbox/themes/default_rockbox_icons.cfg to restore the default icons easily


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13183 a1c6a512-1295-4272-9138-f99709370657
2007-04-16 14:33:29 +00:00