Commit graph

26995 commits

Author SHA1 Message Date
Dave Hooper
a5b17b4511 Rearrange and remove some manual register assignments, make use of pointer address increments for free on arm, and remove macros in favour of explicit inline fns. also add memory clobbers to all uses of stm in inline asm. appears to resolve issues with codeclib failing to work as expected when using ARM_ASM optimisations on targets with native position independent code (e.g. android rockbox targets, but also tremor on non-rockbox targets that has been patched with the fastermdct patches)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28262 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 23:29:17 +00:00
Michael Sparmann
986910175c iPod Nano 2G USB: Make sure the USB core is properly powered off on boot.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28261 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 23:14:27 +00:00
Alex Parker
f70ec76fcc Manual: fix some English in the bar tag options.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28260 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 19:34:47 +00:00
Alex Parker
27a6d29771 Manual: get rid of some extra spaces in the sansa ams install instructions.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28259 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 19:34:42 +00:00
Alex Parker
40ec7b9d06 Manual: Add button mappings for the equalizer for the clip/clip+. Fixes part of FS#11672
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28258 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 19:34:38 +00:00
Marianne Arnold
498f66f8db Manual: add the missing % for %# in the 'Other tags' theme tag section.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28257 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 19:13:24 +00:00
Alex Parker
60e2af282b Manual: Correct clip/clip+ pitchscreen button table. Closes FS#11671.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28256 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 17:43:37 +00:00
Bertrik Sikken
7d494ec4c5 Remove duplicate entry from docs/CREDITS (as announced in svn r28254)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28255 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 17:03:44 +00:00
Bertrik Sikken
1799406839 Slovak language update - FS#11668 by Peter Lecký.
Also remove duplicate entry from docs/CREDITS


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28254 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 17:00:22 +00:00
Teruaki Kawashima
796ba3ed76 fix FS#11659. wait for user input before exiting the plugin.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28253 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 13:56:54 +00:00
Nils Wallménius
b2f5142601 Fix the last part of FS#11670 by using the 'disk' macro that expands to the appropriate storage type for each player, also change a reference to 'MP3 buffer' to 'music buffer'.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28252 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 13:43:38 +00:00
Nils Wallménius
1a14537e26 Database auto update doesn't need dircache to remove deleted files from the database anymore.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28251 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 13:29:28 +00:00
Nils Wallménius
cf9af0165b Don't include manual section for the 'Load to ram' option if the option isn't there and use 'disk' macro that expands to the proper storage type.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28250 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 13:14:17 +00:00
Jonathan Gordon
9acd242839 skin bar tag: Load an image from a label or filename. i.e %xl(bar_image, pb.bmp,0,0) %pb(0,0,10,10,bar_image) or %pb(0,0,10,10, pb.bmp) both are acceptable.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28249 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 12:46:57 +00:00
Teruaki Kawashima
3eb5826c8a improvement for bar tag with slider.
-fix bug the slider is drawn outside of the bounds (FS#11658).
-offset the slider position so that the center of the slider indicates current position.
-add nobar option. if this option is set, the bar isn't drawn at all.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28248 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 12:17:39 +00:00
Jonathan Gordon
69e379a47b Skin bar tags fix+cleanup:
Don't crash when not enough params were given (i.e forgetting the filename)
Make the parser enforce the first 4 params as compulsary
Be more leniant and don't require the image filename if one isnt going to be loaded (no more need for the - as the 5th param)
Add an option "image" to specify the filename (otherwise the first option will be used if it isnt a recognised option).

e.g: %pv(0,0,100,10) or %pv(0,0,100,10, bar.bmp) or %pv(0,0,100,10, ..., image, bar.bmp)

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28247 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 12:03:07 +00:00
Jonathan Gordon
e1c9eb31f7 FS#11669 - extra > in the skin
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28246 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 09:45:11 +00:00
Jonathan Gordon
39cf6dd2f3 Viewports dont necessarily have children lines, so make sure there is one or it will crash
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28245 a1c6a512-1295-4272-9138-f99709370657
2010-10-12 09:36:59 +00:00
Teruaki Kawashima
59f487205c check viewport dimension when parsing viewport so that player doesn't clash with bad wps.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28244 a1c6a512-1295-4272-9138-f99709370657
2010-10-11 13:08:49 +00:00
Thomas Martitz
8e8839c8c2 Forgot to update lcd-remote.h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28243 a1c6a512-1295-4272-9138-f99709370657
2010-10-11 01:23:40 +00:00
Thomas Martitz
3022a60cc2 Rename {draw,fill}_viewport once more (to draw_border_viewport and fill_viewport) and remove the viewport parameter as suggested by Dave Chapman.
The parameter wasn't used yet and it's not clear whether it should be a absolute or relative viewport.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28242 a1c6a512-1295-4272-9138-f99709370657
2010-10-11 01:19:55 +00:00
Frank Gevaerts
1f0ab7c9e6 Fix charcell %pb and %pf tags, FS#11592
This also moves draw_player_fullbar() and draw_player_progress() from skin_display.c to skin_tokens.c. Charcell is a bit different from bitmap here because drawing a progress bar is a combination of setting up the LCD controller (custom characters) and providing a format string. The custom character definition might fit in skin_display.c, but the format strings are needed in skin_tokens.c. Putting these functions in skin_tokens.c seemed to fit better.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28241 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 23:46:15 +00:00
Thomas Martitz
5462ef728f Add _rect to {draw,fill}_viewport as suggested by Jonathan Gordon to reduce the chance to confuse it with update_viewport().
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28240 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 23:35:03 +00:00
Thomas Martitz
8a0152bd4a Two new lcd/multi screen api convinience functions: draw_viewport(), fill_viewport().
They work as the drawrect/fillrect pendants but work on a viewport basis; pass NULL to draw the current viewport (the one set with set_viewport()).
In conjunction with action_get_touchscreen_press_in_vp() it should be less of a pain to draw buttons and get presses on them.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28239 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 23:15:05 +00:00
Frank Gevaerts
752c91b50d Guard the cpucache_invalidate() with proper #ifdefs
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28238 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 20:53:46 +00:00
Michael Sparmann
c599da333e Commit FS#11663 by me - Patch: iPod Nano 2G Bootloader: Boot OF if MENU button is held
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28237 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 20:52:46 +00:00
Frank Gevaerts
e94eea9538 Invalidate the CPU cache after clearing bss, to make sure that bss variables that are used via non-cached aliases don't read garbage.
This fixes FS#11653 for me


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28236 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 20:49:21 +00:00
Thomas Martitz
bf301fdbb6 Fix a few div0 cases forgotten in r27684 to enable enabling asm optimizations for android builds.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28235 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 14:43:40 +00:00
Teruaki Kawashima
462771066b correct comment in configfile.h, FS#11292 by Chris Savery.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28234 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 14:34:07 +00:00
Teruaki Kawashima
38e88f35f4 use different function to resize bitmap for greylib.
it is confusing that same function expects different data type (fb_data or unsigned char) depending on the target.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28233 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 14:24:11 +00:00
Bertrik Sikken
8ad85ba291 Fix for FS #10097 - Sometimes keys do work after exiting plugins.
This removes the call to button_clear_queue which interfered with the mechanism in action.c to wait for a key
release event when the button context is changed.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28232 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 14:07:56 +00:00
Frank Gevaerts
561999ebff Make skin_render_playlistviewer() noinline. This function uses lots of stack (around 1 kilobyte), and is called from a recursive function. gcc's stack allocation strategy makes the calling function then use all this stack space when inlining.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28231 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 13:26:51 +00:00
Frank Gevaerts
d0bf13b486 Revert accidental commit of skin_render.c
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28230 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 13:21:49 +00:00
Frank Gevaerts
c8c40c5291 Add a "early_usb" argument to gui_usb_screen_run(), and don't do skin unloading/reloading in gui_usb_screen_run() in the early usb case. Fixes the crash part of FS#11589
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28229 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 13:17:39 +00:00
Bertrik Sikken
0d100b4dd8 Fix FS# 11414 : .mod files - metadata in incorrect fields
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28228 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 10:24:50 +00:00
Nils Wallménius
5cf249155e Fix FS#11513, pictureflow keymap in the manual was wrong.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28227 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 08:09:22 +00:00
Jonathan Gordon
0b824da4de fix FS#11662 and FS#11629 - skin %t() issues. %t should now work properly inside and outside of conditionals.
Remember that skins update at a rather slow speed so even if you have %t(0.2) in your skin it depends on which screen you are in for it to work (the main menu only updates at 2FPS, the WPS is 25FPS with peakmeters enabled... this is on the fixme list)

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28226 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 06:47:52 +00:00
Jonathan Gordon
a5ba1bf4fb cabbie 320x480 WIP sbs:
Add a playlist viewer, AA and a resumeplayback touch region. (resumeplayback is the bottom right corner, even when AA isnt present or no music is playing)

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28225 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 05:30:41 +00:00
Jonathan Gordon
0b0ce2e59b Touchscreen %T() tag.. don't allow - for width/height params (shouldn't affect anyway because the current code would crash if you tried it)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28224 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 05:23:38 +00:00
Jonathan Gordon
a7b1f7577b Add "resumeplayback" touchscreen button action which returns you to the previous music screen (WPS or FM) from most of the lists (browsers and menus)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28223 a1c6a512-1295-4272-9138-f99709370657
2010-10-10 04:17:34 +00:00
Jonathan Gordon
3f7b780b54 fix a stupid typo in the vertical bar tag parser, spotted by teru
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28222 a1c6a512-1295-4272-9138-f99709370657
2010-10-09 12:18:10 +00:00
Thomas Martitz
b39a4933cb Fix several inaccuracies in list handling on touchscreen.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28221 a1c6a512-1295-4272-9138-f99709370657
2010-10-09 11:22:52 +00:00
Teruaki Kawashima
cc8918e909 fix displaying of the slider when default is used for pb->y and pb->height.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28220 a1c6a512-1295-4272-9138-f99709370657
2010-10-08 14:26:36 +00:00
Teruaki Kawashima
09d8975084 don't reload the skins if color isn't actually changed.
reload skins when colors are reset.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28219 a1c6a512-1295-4272-9138-f99709370657
2010-10-08 13:07:20 +00:00
Magnus Holmgren
6bd9a31b0b Update Swedish translation.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28218 a1c6a512-1295-4272-9138-f99709370657
2010-10-07 19:25:56 +00:00
Teruaki Kawashima
d9a328872e alarm clock: don't have user pause the playback manually. make the plugin pause it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28217 a1c6a512-1295-4272-9138-f99709370657
2010-10-07 13:19:21 +00:00
Teruaki Kawashima
2d86417c46 use CONTEXT_LIST in simplelist_show_list() so that button combinations for page down/page up work.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28216 a1c6a512-1295-4272-9138-f99709370657
2010-10-07 12:27:26 +00:00
Thomas Martitz
c2b5739419 Fix targets with remote display, forgot to add the new functions to their header.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28215 a1c6a512-1295-4272-9138-f99709370657
2010-10-06 12:52:00 +00:00
Thomas Martitz
d9d0b4dd20 Pixel-accurate (vertical) list scrolling for touchscreen targets.
Looks much smoother now as you don't scroll by whole lines anymore.
Add some functions lcd driver to enable the line based scrolling engine to draw the lines with a pixel-based y-offset.
This should also allow for a sensible kinetic scrolling mechanism (still a todo).

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28214 a1c6a512-1295-4272-9138-f99709370657
2010-10-06 12:46:42 +00:00
Teruaki Kawashima
53a936ab83 text viewer:
-remove 1px gap at the top and bottom of the screen to maximize the draw erea, especially for small screens.
-fix trashes on the vertical scrollbar when scrolled the column left/right.
-fix bug that vertical scrllbar sometimes goes up while scrolling down.
-don't chage displayed line after closing menu.
-use simplelist to select bookmark to make it work better.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28213 a1c6a512-1295-4272-9138-f99709370657
2010-10-06 12:35:37 +00:00