Rafaël Carré
7240478457
file_exists(): fix DEBUGF()
...
- %s was missing the argument (function name)
- add %p to print the function argument
- also don't call strlen() to test string nullity (and strlen() can't return a negative result)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28123 a1c6a512-1295-4272-9138-f99709370657
2010-09-20 16:39:22 +00:00
Amaury Pouly
11ce23a989
rbutil: update french translation
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28122 a1c6a512-1295-4272-9138-f99709370657
2010-09-20 15:07:36 +00:00
Amaury Pouly
7baa522364
usb: remove unused variable and correctly stall on unhandled control requests
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28121 a1c6a512-1295-4272-9138-f99709370657
2010-09-20 14:18:14 +00:00
Marcin Bukat
93c50d4770
Remove the call to settings_save() from settings_load_config() as it seems unneeded any more and causes unecessary writes on every startup.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28120 a1c6a512-1295-4272-9138-f99709370657
2010-09-20 13:34:21 +00:00
Rafaël Carré
5a98ad2d7f
format() (and its alias vuprintf) return values are uncheck -> void
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28119 a1c6a512-1295-4272-9138-f99709370657
2010-09-20 08:55:45 +00:00
Michael Giacomelli
cc6ef19dd9
Remove some unused variables.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28118 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 22:09:11 +00:00
Dominik Riebeling
a742ba4656
Make tooltip for Offline Mode setting wrap properly.
...
Qt wraps tooltip texts automatically when it detects the text to be Rich
text. Embed the tooltip text into <p> tags to get it recognized as such.
Manually update translations to avoid the need to retranslation that
line.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28117 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 20:32:32 +00:00
Jonathan Gordon
2c8204cd91
Hopefully fix FS#11630 where the wps backdrop would be shown instead of the menu one
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28116 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 11:49:33 +00:00
Rafaël Carré
272e425a2f
get_mp3file_info(): Use the correct printf format in DEBUGF()
...
Also remove useless parens and casts in bytes2int()
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28115 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:27:49 +00:00
Rafaël Carré
961b5dd4c1
tagcache open_files(): open the correct file (missed in r27656)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28114 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:17:15 +00:00
Rafaël Carré
d2000a9178
radio_screen() return value is unused -> void
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28113 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:17:08 +00:00
Rafaël Carré
c78d55a311
kbd_input(): move sc assignement under #ifdef HAVE_TOUCHSCREEN
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28112 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:17:02 +00:00
Rafaël Carré
37c1192753
ASAP parse_sap_header() : remove write only variables
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28111 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:16:56 +00:00
Rafaël Carré
f03141477a
setid3v2title(): unused variable
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28110 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:16:52 +00:00
Rafaël Carré
9afa8002ae
get_mp3file_info(): remove unused variable
...
frames_per_entry is only used for debugging
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28109 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:16:47 +00:00
Rafaël Carré
1dfebdddbe
playlist_shuffle(): remove unused variable
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28108 a1c6a512-1295-4272-9138-f99709370657
2010-09-19 08:16:40 +00:00
Dominik Riebeling
f75d912d7c
Display number of processors in System Info dialog.
...
Oops: on Windows, ask the system about the values before displaying it instead
of expecting the structure to fill itself.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28107 a1c6a512-1295-4272-9138-f99709370657
2010-09-18 20:50:11 +00:00
Dominik Riebeling
752ce1e6e7
Display number of processors in System Info dialog.
...
Since Rockbox Utility got support for utilizing more than one CPU / Core
this value might be helpful in case of issues like FS#11496 (QThreadPool
defaults to the number of CPUs found as maximum number of threads).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28106 a1c6a512-1295-4272-9138-f99709370657
2010-09-18 20:41:03 +00:00
Rafaël Carré
f18e630ef2
Update Polish translation
...
Author: Wojciech Lesniak
Flyspray: FS#11625
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28105 a1c6a512-1295-4272-9138-f99709370657
2010-09-18 03:51:54 +00:00
Frank Gevaerts
d343bbe846
Allow e200 to compile without HAVE_RECORDING
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28104 a1c6a512-1295-4272-9138-f99709370657
2010-09-17 20:42:45 +00:00
Frank Gevaerts
95aae36c6c
Fix red, stupid typo
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28103 a1c6a512-1295-4272-9138-f99709370657
2010-09-17 20:34:47 +00:00
Frank Gevaerts
f366090562
Make disabling HAVE_PITCHSCREEN actually work without breaking the build
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28102 a1c6a512-1295-4272-9138-f99709370657
2010-09-17 20:28:47 +00:00
Frank Gevaerts
bd43690170
Simplify unnecessary baroque preprocessor condition a bit
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28101 a1c6a512-1295-4272-9138-f99709370657
2010-09-17 20:13:13 +00:00
Frank Gevaerts
b0351c7588
Only define USB_ENABLE_STORAGE if USB_HAS_BULK and USE_ROCKBOX_USB are both set
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28100 a1c6a512-1295-4272-9138-f99709370657
2010-09-17 20:00:04 +00:00
Alex Parker
34c4c44c5d
Manual: Clarify that the player must be running to charge/power over USB. Closes bug FS#11504.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28099 a1c6a512-1295-4272-9138-f99709370657
2010-09-17 19:13:26 +00:00
Alex Parker
15258e0a5b
Manual: add the bar tag themeing possibilites to the manual. Closes bug FS#11543.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28098 a1c6a512-1295-4272-9138-f99709370657
2010-09-17 19:13:20 +00:00
Alex Parker
779f1dbc7a
Manual: Add the %if tag to the manual. Closes bug FS#11555.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28097 a1c6a512-1295-4272-9138-f99709370657
2010-09-17 19:13:14 +00:00
Frank Gevaerts
f6912d3bbb
Make the call to buttonlight_on() properly depend on HAVE_BUTTON_LIGHT
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28096 a1c6a512-1295-4272-9138-f99709370657
2010-09-17 19:05:27 +00:00
Alex Parker
011bece6ca
Manual: The gigabeat S has hardware tone controls instead of bass/treble settings, so update the manual to reflect this. Also update the sound settings screen shot.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28095 a1c6a512-1295-4272-9138-f99709370657
2010-09-16 18:54:24 +00:00
Jonathan Gordon
10b6861bfd
fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28094 a1c6a512-1295-4272-9138-f99709370657
2010-09-16 14:01:43 +00:00
Jonathan Gordon
fbb008331d
skin engine: completly rework the sbs title handing code
...
This hopefully fixes the remaining data aborts and freezes when loading skins caused by the somewhat nasty list/sbs title handling code.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28093 a1c6a512-1295-4272-9138-f99709370657
2010-09-16 12:56:51 +00:00
Rafaël Carré
520baf0b6a
usb_drv_reset() is only used in usb-drv-arc.c
...
remove from usb_drv.h and mark static
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28092 a1c6a512-1295-4272-9138-f99709370657
2010-09-16 05:46:24 +00:00
Marcin Bukat
2e9242e321
fix target name for MPIO HD200 in tools/configure
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28090 a1c6a512-1295-4272-9138-f99709370657
2010-09-15 09:05:47 +00:00
Marcin Bukat
e0803381a4
Fix malformed name in builds.pm for MPIO HD200 (thx to Zagor)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28088 a1c6a512-1295-4272-9138-f99709370657
2010-09-15 08:34:48 +00:00
Rafaël Carré
f8d1509a95
flac: more detailed debug message
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28087 a1c6a512-1295-4272-9138-f99709370657
2010-09-15 07:44:03 +00:00
Rafaël Carré
128593538b
button driver: make repeat timings be centiseconds and not ticks
...
This doesn't change the value with the current HZ=100,
but makes it easy to change HZ in custome builds and still have buttons be usable
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28086 a1c6a512-1295-4272-9138-f99709370657
2010-09-15 07:43:55 +00:00
Andree Buschmann
24d8e8ef1a
Minor macro redefinition in libfaad to avoid FIXED_POINT ifdef'ing.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28085 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 20:40:56 +00:00
Andree Buschmann
9fb54ae32b
More unification of FIXED_POINT and FLOAT. Small refactoring.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28084 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 20:26:01 +00:00
Andree Buschmann
82c143c4e1
Also correct autocorrelation for yet undefined SBR_LOW_POWER. Unify FIXED_POINT and FLOAT implementation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28083 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 19:53:13 +00:00
Andree Buschmann
c8da311de4
Fix scaling error that was introduced with r28069. With this fix the level of the hf-spectrum will be correct when decoding aac-he files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28081 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 19:31:00 +00:00
Andree Buschmann
e98ee2d696
Correct comment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28080 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 19:17:21 +00:00
Andree Buschmann
b543a2a5d2
Correct autocorrelation function in libfaad. It used the wrong fract part for the multiplication macros. Introduce appropriate solution to avoid overflow.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28079 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 19:05:09 +00:00
Jonathan Gordon
f4e886158c
fix build (typo)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28078 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 12:40:42 +00:00
Jonathan Gordon
308ece9e9c
why did plugin.h need statusbar-skinned.h?
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28077 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 12:36:39 +00:00
Jonathan Gordon
75f04f56eb
woops
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28076 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 12:30:45 +00:00
Jonathan Gordon
71379cafb1
fix errors, warnings, tabs
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28075 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 12:21:56 +00:00
Jonathan Gordon
46142b91cd
new file got lost
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28074 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 11:59:52 +00:00
Jonathan Gordon
9928e3418f
Another major skin backend update/hopefully bugfix:
...
Skins are now more self contained in the skin manager which in the future might allow on demand skin loading (i.e smaller skin buffers)
Skin backdrops are also managed more intelegently (fixes a bug where you can get a crazy backdrop loaded if a .sbs fails to load)
the rockbox_default rescue theme is now called rockbox_failsafe to better express what it actually is.
This commit hopefully/maybe fixes the heavily reported data aborts, so please check if you are getting them
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28073 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 11:56:50 +00:00
Rafaël Carré
0928cdf074
pitch_detector: don't use a struct with only one member
...
use fixed point type (fixed == int32_t) directly
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28072 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 06:34:01 +00:00
Andree Buschmann
cba9d259b0
Further libfaad cleanup. Make libfaad compilable for floating point. Floating point cannot be used as reference though, as errorous noise is the result.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28071 a1c6a512-1295-4272-9138-f99709370657
2010-09-14 06:03:39 +00:00