Commit graph

33916 commits

Author SHA1 Message Date
Solomon Peachy
6c2a7ddc74 build: Put all codec optiomization definitions in one place
It was already mostly there.

Change-Id: I24ff278d9bf18a54be4b67c3075d5ebbe7947f65
2018-12-25 14:17:29 -05:00
Solomon Peachy
4c933a1d01 build: Properly generate build dependency for autogenerated bitmap .h files
* bmp2rb generated a .h file that rockbox .c files used.
 * .h files in .c files were used to generate dependency graphs for make
 * When Make saw the .h file for the bitmap, it didn't know how what
   to do with them
 * Only arose in parallel builds

Fixed this by adding explicit dependencies for the .h files as part of
the existing 'bmpdepfile' function.

Solves the Xduoo X3 bootloader build failure that I could trigger 100%
of the time by using 'make -j8'

Change-Id: I6b3e78dde26c820a3b6c7c286e7d6c981b8e01fc
2018-12-25 11:54:11 -05:00
Solomon Peachy
9b3f22ac3a FS#7814 - Enable RTC Alarms on H300, X5, and M5
Original patch by Alexander Spyridakis
Modified by Steve Bavin and Igor Poretsky
Keymap fixes by Marianne Arnold

Change-Id: I5a252d97d2b05c533e048931f7354f4261f76499
2018-12-25 08:51:33 -05:00
Solomon Peachy
df1d386019 Hopefully silence the warning in the warble codec build.
Change-Id: I63eef2c33bf3ea31a135cd6336882b600723f946
2018-12-24 22:18:23 +01:00
William Wilgus
a71af1778d Fix lua helpers -- supress line markers in preproc source generation scripts
In newer builds line markers prevent lua helper scripts
from grabbing some inputs especially _bool

This patch adds the -P switch
  Inhibit generation of linemarkers in the output from the preprocessor.
  This might be useful when running the preprocessor on something that
  is not C code, and will be sent to a program which might be confused
  by the linemarkers.

Change-Id: I66c3b099729f6651300f9fcf4670533a20cc90c1
2018-12-24 21:37:06 +01:00
Solomon Peachy
c45016dd88 Clean up a wanring with the updated turkish translation on ZEN targets.
Change-Id: I7dcbd00a084e05e15ba09c3b65cabd33ac71e7f4
2018-12-24 14:49:09 -05:00
Solomon Peachy
40b6d025c0 FS#13043: Updated Hungarian translation
(Thanks to Gergely Békési)

Change-Id: Ib56417794cbcd693324419710c370779b2fcf954
2018-12-24 12:01:32 -05:00
Solomon Peachy
ccf96833b0 FS#13144: Updated Dutch translation
(Thanks to Nathan Follens)

Change-Id: I9b000cf7e7294c3dc750a72577ca7c1d2f04e659
2018-12-24 11:53:37 -05:00
Solomon Peachy
2c94ad9c71 Credits: Add Roman Levkin-Taymenev
(Updated Russian Translation)

Change-Id: I88150c897d9facf566beff38e5a0c863d5256c0c
2018-12-24 11:53:33 -05:00
Solomon Peachy
75fe78c802 Handle SYS_POWEROFF event in recorder and chessbox plugins
Credit to Igor Poretsky

Change-Id: I151d3511b9cee269190d87df7fa7dd355aaafc9b
2018-12-23 18:01:54 -05:00
Solomon Peachy
7a718fc27d Do not touch FM tuner when it is turned off
Credit to Igor Poretsky

Change-Id: Ie9e61740f87f3b56d0b602cd431757262a6ed808
2018-12-24 00:01:02 +01:00
Solomon Peachy
d636c5e823 FS#13148: Considerably updated Turkish translation
(Thanks to Malik Safak)

Change-Id: I21339b331ad8c6ca975f23cd98041426acf8961f
2018-12-23 16:37:58 -05:00
Solomon Peachy
9c6329245a Add missing CREDITS for updated French translation
Change-Id: Iab08a2eed0254a01683fe9ce68867dc88a0ea5ef
2018-12-23 14:35:12 -05:00
Solomon Peachy
93f447a8ef FS13137: Update Polish translation
(Thanks, Adam Rak!)

Change-Id: I39aa0d9eb265827a5dcd05943a2c0abbb9f81fa8
2018-12-23 14:27:59 -05:00
Solomon Peachy
1ecc94e4c3 FS#13162: Update French translation
(Thanks Guinness)

Change-Id: Ia978b26744ba7d97393d1b87b6704690e39e8ccd
2018-12-23 14:22:08 -05:00
Solomon Peachy
206a644bf7 FS#13165: Updated Russian translation
(Thanks, Roman!)

Change-Id: I270ed16fa899d1ec69dddb1d783e5c37b08af838
2018-12-23 14:20:38 -05:00
Solomon Peachy
e598ba13f5 Support using 'rbspeak' to generate voice files.
(Full credit to Igor Poretsky)

Change-Id: Ib9c5d2748cd7e0543b7fd110e83b4656089254b8
2018-12-22 20:27:39 -05:00
Solomon Peachy
928557bb17 AAC bitstream format files support
Files with extension "aac" in ADTS or ADIF format are now playable.

Full credit goes to Igor Poretsky.

Change-Id: I413b34e15e5242fea60d3461966ae0984080f530
2018-12-22 20:12:10 -05:00
Solomon Peachy
9b9b30bd54 Realmedia related codecs fixes and enhancements
* More tolerance to the file format variations.
 * AC3 coded files in realaudio format are now playable

Full credit to Igor Poretsky

Change-Id: Id24e94bc00623e89fb8c80403efa92f69ab1e5d7
2018-12-22 20:12:10 -05:00
Solomon Peachy
eee3f0ce79 FS#12610 - Clip+ Ticking Noise Fixed in Radio
Patch taken from Igor Poretsky's tree.

Original clip-radio-tick.patch modified to acts only when screen is
deemed, or when recording, in order to preserve indicators
functionality.

Change-Id: I62afb24a0dad7ad2ecc9272c24810b37f032408d
2018-12-22 20:12:10 -05:00
Solomon Peachy
6416c22b45 Czech translation update from Marek Salaba
Change-Id: I45304719e3c5f9c6e9aa92347d1ba9b483431a54
2018-12-22 20:08:16 -05:00
Solomon Peachy
b51995942e Improved seeking in a52 codec
(Patch by Igor Poretsky)

Change-Id: I0cdc2021b44f6cd6e76def190d9f04733b922454
2018-12-22 19:54:40 -05:00
William Wilgus
d258edbb4f Fix Auto Ranged Time Fix Red for Database
Change-Id: I8f4edc4ca84792f977ea673d2435e15f7e2da14e
2018-12-22 14:31:40 -06:00
William Wilgus
4a8f263a7d Fix Auto Ranged Time Fix Red for Checkwps
Change-Id: I36e37c7557d6eee07978046e549509ee628aba2e
2018-12-22 13:53:00 -06:00
William Wilgus
a06d9c85f7 Auto-Ranging Time Formatting For Menus (hh:mm:ss:mss)
Unifies time formatting in settings_list.c allows time format to
display as HH:MM:SS.MSS or any consecutive combination thereof
(hh:mm:ss, mm:ss, mm:ss.mss, ss.mss, hh, mm, ss ,mss)
works in INT and TABLE settings with the addition of flag 'F_TIME_SETTING'

Time is auto-ranged dependent on value

Adds talk_time_intervals to allow time values to be spoken similar to
display format:  x Hours, x Minutes, x Seconds, x Milliseconds

Table lookups merged or removed from recording, clip meter and lcd timeout
-String_Choice replaced with TABLE_SETTING or INT_SETTING for these
functions as well, cleaned-up cfg_vals that get saved to cfgfile

RTL Languages ARE supported

Negative values ARE supported

Backlight on/off are now Always and Never to share formatter with LCD
Timeout

Added flag to allow ranged units to be locked to a minimum index

Added flag to allow leading zero to be supressed from the largest unit

merged talk_time_unit() and talk_time_intervals()

optimized time_split()

optimized format_time_auto()

Backlight time-out list same as original

Change-Id: I59027c62d3f2956bd16fdcc1a48b2ac32c084abd
2018-12-22 12:27:21 -06:00
Franklin Wei
b3356e3aff puzzles: resync with upstream
This brings the code to upstream commit 3ece3d6 (I've made my own Rockbox-
specific changes on top of that).

Changes include using C99 `bool' throughout, and minor logic fixes for some
puzzles.

Change-Id: Ie823e73ae49a8ee1de411d6d406df2ba835af541
2018-12-21 22:13:33 -05:00
William Wilgus
f08d218e67 Fix tree.c->dirbrowse panic from database browser
I set up panics on invalid entries throughout tree.c
dirbrowser was checking for file attributes even when the result
was unused, the database browser called this code with an
invalid (to the tagcache) index

This patch fixes that oversight and also adds __func__ to the
panics for easier sleuthing in the future

Change-Id: Ie1d6511423bba48125e4916b1c3049c048abaee0
2018-12-20 20:41:21 -06:00
William Wilgus
28f91ff3dc Lua Fix settings_helper for the gigaBeastS
the gigabeatS has an embedded struct that needs to be parsed

Change-Id: I88c9101afaaa95182f37ade1410cccb4fb768e33
2018-12-17 09:41:15 -06:00
Solomon Peachy
622f3f2497 Synchronize Slovak language
(Thank you, Peter!)

Change-Id: I90495070e8f2f5118497f7fbce5e5112ba690777
2018-12-16 16:56:35 -05:00
William Wilgus
9d66b5459e Lua add read/write access to global_status, global_settings, audio_current_track
moved items to rb.system
added read access to audio_current_track and audio_next_track

Change-Id: Ia055b8cb3848e540067818f596ffd1058da057fb
2018-12-16 13:33:18 -06:00
Solomon Peachy
c2308bdf40 Fix HWCODEC builds.
Change-Id: I7abed5dab9b4d0d053c274404dc4dc06864aa060
2018-12-15 13:09:51 -05:00
Solomon Peachy
d8ce84c382 Fix compile failure due to a merge error in 4adad0bc1f
Change-Id: I7aa013e99c1f20c4f62299a5fa65dc7db65bf386
2018-12-15 12:10:36 -05:00
Solomon Peachy
75f74814c0 Voice: Don't omit "shutting down" speech warning when battery dies.
(Taken from Igor Poretsky's tree)

Change-Id: I0fee8346e857eeaea5059360c0f35bd6a2e98b97
2018-12-15 12:02:21 -05:00
Solomon Peachy
4adad0bc1f FS#6323: Speech for ID3 viewer, playlist catalog and playlist viewer
Modified from original ticket, Taken from Igor Poretsky's tree, and
further modified by myself to incorporate feedback.

Change-Id: Ibc2180e52af76890b1448d23f79386fd0f88f709
2018-12-15 18:00:23 +01:00
William Wilgus
f061330c3d Fix Manual(s) -- Advanced Keylock
Manuals were showing Advanced Keylock even for devices that don't support it

Change-Id: I8e40a76bcbba9c67a4680d505c507a0b09f7f203
2018-12-15 13:53:24 +01:00
Solomon Peachy
bea9cf7b1e FS11473: Add bookmarking option: one per track.
Modified version from ticket, taken from Igor Poretsky's tree, and
further modified to incorporate feedback.

Change-Id: I9284497d53a0247a51739d29fdc1db5fbbebfadc
2018-12-14 14:03:12 +01:00
William Wilgus
6f020ef155 filetree.c add checks for invalid file entries
Admittedly I can not really think of a reason this would occur
in normal use but if it does it'll result in a crash so
better safe than sorry

Change-Id: I593652bb658475bbd9a18026243c02524f5e7ccb
2018-12-14 06:09:38 -06:00
William Wilgus
3f110daf30 Fix tree.c->tree_get_entry_at() buffer overflow
I observed a crash on buflib>move_block
after dumping ram I noticed that the buffer for filetypes was being corrupted

tree_get_entry_at returns a entry from the buflib 'tree entry' buffer
filetree.c->ft_load writes data to this buffer before checking if it has
reached the last entry resulting in buffer overflow that overwrites the
next entry in the buffer ['filetypes']

Patch checks that the index passed to tree_get_entry_at() is in range
otherwise it returns NULL

Added checks + panic in other functions using tree_get_entry_at()
Fixed tree_lock_cache() calls in playlist and filetree

Change-Id: Ibf9e65652b4e00445e8e509629aebbcddffcfd4d
2018-12-14 01:28:17 -06:00
William Wilgus
ce0b31d87d Shortcuts, Fix FS#13151 Deleting shortcut removes name, icon, talkclip
FS#13151 - Deleting item from shortcut menu corrupts the menu's display

The function that writes shortcut.txt didn't write existing
name, icon or talkclip items

Change-Id: I4418700c82f91522b2dd8a975548d7bd91f150d3
Now: writes all three supplying default values if the items don't exist
2018-12-10 12:04:55 -06:00
William Wilgus
4055f90f08 Fix host build for newer linux distros
I realized there was a better way to do this..

Instead of specifying a path just have gcc run the preprocessor (-E) on
an input file consisting of only '#include <byteswap.h>' if it succeeds
then we can use it if not then don't define OS_USE_BYTESWAP_H

Change-Id: I0de8e469445221bc1b5ad8cc032de5b89a85ab66
2018-12-10 01:36:33 -06:00
William Wilgus
62a5ed49cc Fix possible truncation misc.c->output_dyn_value + use Kibytes
output_dyn_value now requires the count for number of units

Binary scale now shows Kibibytes instead of kilobytes (g#1742)

Fixes output for negative values as well

Change-Id: I8aa896860e97d2453fa35069e2dfe1caac60109f
2018-12-09 22:54:55 -06:00
William Wilgus
74701a16a5 Decrease static code size recording.c
Forgot static for recording_step_levels()

There is no need to re-calculate split_time or split_bytes each loop
you can't change them within recording screen --  these become constants

We don't need longs to store the conversion of minutes to seconds
or MB to bytes these are now shorts and the conversion takes place within
rec_timesplit_seconds() and rec_sizesplit_bytes() respectively

Change-Id: Ie1514085e92e00e67eb1942c0f4f8820714587e9
2018-12-08 18:05:13 -06:00
William Wilgus
7907eb8946 Fix truncation warning recording.c->recording_screen
Limit buf2 to enough characters(16) to display signed int & label

consolidate gain/volume settings

Change-Id: I9ef6aa1e16ea2a17acc311a9b7e1c0556f58eff7
2018-12-08 16:03:47 -06:00
William Wilgus
ed63ef077a Fix overlapping string region ape.c->read_ape_tags
Switch to strrchr to find the extension

Change-Id: Id7ea01ecc2e0553f560308f8b0fc53bd33b023e5
2018-12-08 20:30:12 +01:00
William Wilgus
78b2d13567 Pdbox hide cast-function-type fix overlapping memcpy
dsoundfile.c used memcpy for overlapping memory regions switched to memmove
Suppress the 160+ warnings for cast-function-type
This plugin would require major work to fix these warnings

Change-Id: I309d914839c1e70126a05b387863fd21613497a9
2018-12-08 06:23:19 -06:00
William Wilgus
6bfd7da97c Fix Truncation warning in cuesheet.c->browse_cuesheet
give user concrete indication that track title has been truncated
by adding '~' at end of string

Change-Id: I53034f4a09c103eb98ae1e0ef0a8a843fd2a2c6e
2018-12-08 04:47:27 -06:00
William Wilgus
0f5f5c3390 Fix Sim & checkwps for newer distros
__builtin found fix for rbendian.h
tools/configure defines SIM_USE_BYTESWAP_H if byteswap.h is found in
/usr/include/ maybe there is a better mechanism for this

Change-Id: I4d004e68313e8b32aa5587582be36bc459fdaf6b
2018-12-08 03:19:14 -06:00
William Wilgus
69c6c77680 Fix speex warning lsp.c->lsp_to_lpc
I'm pretty sure this was a false positive

Change-Id: I0ab375d1d844b3d468c24888c371f588052e1ce9
2018-12-08 02:25:17 -06:00
William Wilgus
9450689483 Fix Sim for newer distros
__builtin found fix for rbendian.h
tools/configure defines SIM_USE_BYTESWAP_H if byteswap.h is found in
/usr/include/ maybe there is a better mechanism for this

genshortcut.sh is a simple script to make .desktop shortcut files
several newer distros don't allow you to run the simulator from the
file manager, this or perhaps a different method can probably be
included while building a sim at a later date.

for now it can be run manually like so:
similar to ../tools/configure
run from your simulator folder
../tools/genshortcut.sh exepath shortname icon
ex. ../tools/genshortcut.sh ./rockboxui clip+sim music-app

Change-Id: Ia05d3a9349b27c5968a4a7a68b2eb480e60faec3
2018-12-07 21:04:30 +01:00
Marcin Bukat
4e8ef17a8b More keymap refinements
Change-Id: If3ae6ece7848b143088d5f9ec8c00ed593d59ed2
2018-12-06 15:15:26 +01:00