Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
28731 commits 17 branches 142 tags 291 MiB
Commit graph

14054 commits

Author SHA1 Message Date
Michael Giacomelli
0497adffcf Commit FS#12130 - Fix ADX decoding on 64-bit systems by Sean Bartell. Fixes an incorrect assumption in the ADX decoder that sizeof(int) == 32 when performing fixed point math. Update comments in the fixed point library to correct this. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29927 a1c6a512-1295-4272-9138-f99709370657
 2011-05-26 21:22:29 +00:00
Michael Sevakis
caf907eef1 Workaround an occasional problem where album art or cuesheets might not be ready by the time the track change event is send which can result in the WPS not immediately being aware that the handles are ready. A better solution will be sought that hopefully doesn't require the additional event. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29923 a1c6a512-1295-4272-9138-f99709370657
 2011-05-25 08:35:31 +00:00
Nils Wallménius
2e3162f039 Fix 2 'set but not used' warnings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29922 a1c6a512-1295-4272-9138-f99709370657
 2011-05-24 10:56:01 +00:00
Nils Wallménius
5fd9471c15 FS#12120. Convert FRACMUL macros into inline functions and fix typecasting for 64 bit platforms so that sims produce the same results as targets. Tweak the cf inline asm to not require an immediate value but add a FORCE_INLINE attribute to one of the cf functions to make sure it gets inlined as that saves both codesize and cycles. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29921 a1c6a512-1295-4272-9138-f99709370657
 2011-05-24 10:44:12 +00:00
Andree Buschmann
ecb4d2d9a7 Remove next reported 'set but unused' warnings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29920 a1c6a512-1295-4272-9138-f99709370657
 2011-05-23 19:09:04 +00:00
Andree Buschmann
8767ba9a85 Remove residual float operations from sid codec. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29919 a1c6a512-1295-4272-9138-f99709370657
 2011-05-23 18:28:08 +00:00
Jonathan Gordon
645ffa9beb Make volume and progresssbar touch regions work with touch timeouts 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29918 a1c6a512-1295-4272-9138-f99709370657
 2011-05-23 06:23:04 +00:00
Andree Buschmann
3071b2bde1 Fix yellow. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29917 a1c6a512-1295-4272-9138-f99709370657
 2011-05-23 06:19:30 +00:00
Jonathan Gordon
94257e5e19 Fix %Tl 'last touch' tag not accepting the timeout 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29916 a1c6a512-1295-4272-9138-f99709370657
 2011-05-23 06:02:44 +00:00
Andree Buschmann
de1529c4eb Save a large static buffer in sid codec. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29915 a1c6a512-1295-4272-9138-f99709370657
 2011-05-22 21:00:32 +00:00
Andree Buschmann
d038f89f3f S5L870x is fast enough to play spc with gaussian interpolation and echo processing. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29914 a1c6a512-1295-4272-9138-f99709370657
 2011-05-22 20:01:07 +00:00
Andree Buschmann
6117ffdde5 Submit FS#12115: Use more IRAM in cook codec for several targets. Speeds up PP5022 and MCF5250 by ~3% and S5L87.0x by ~4%. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29913 a1c6a512-1295-4272-9138-f99709370657
 2011-05-22 19:03:58 +00:00
Andree Buschmann
8531380de4 Fix unintentional removal of an if-statement. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29912 a1c6a512-1295-4272-9138-f99709370657
 2011-05-22 14:10:05 +00:00
Andree Buschmann
96b21753bc Fix some residual 'defined but not used' warnings by GCC 4.6.0 for touchscreen targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29910 a1c6a512-1295-4272-9138-f99709370657
 2011-05-22 13:53:31 +00:00
Bertrik Sikken
313254e4ec Update Latvian language, FS#12123 by Mārtiņš Šimis 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29907 a1c6a512-1295-4272-9138-f99709370657
 2011-05-22 09:22:04 +00:00
Andree Buschmann
609c526d56 Use more IRAM on S5L870x to speed up wmapro by ~2%. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29906 a1c6a512-1295-4272-9138-f99709370657
 2011-05-20 23:28:09 +00:00
Andree Buschmann
99494140da Use more IRAM on S5L870x to speed up wma by ~3%. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29905 a1c6a512-1295-4272-9138-f99709370657
 2011-05-20 22:53:22 +00:00
Michael Sevakis
89e791cc4b Fix FS#12118 - Voice UI has issues talking various issues in menus and in the file browswer. audio_pcmbuf_may_play should check play_status for !=PLAY_PAUSED, not ==PLAY_PLAYING so that PCM may auto-start when voicing out playback state. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29904 a1c6a512-1295-4272-9138-f99709370657
 2011-05-20 22:52:34 +00:00
Bertrik Sikken
90aa993e00 FS#12122 - Translated the missing string in Romanian. by Sergiu Rotaru 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29903 a1c6a512-1295-4272-9138-f99709370657
 2011-05-20 18:39:55 +00:00
Andree Buschmann
a45af1c4fe Reduce FRACMUL calls in equalizer. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29898 a1c6a512-1295-4272-9138-f99709370657
 2011-05-18 20:06:37 +00:00
Rafaël Carré
a2c2589247 don't install boomshine.lua if lua.rock isn't built 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29895 a1c6a512-1295-4272-9138-f99709370657
 2011-05-17 22:29:36 +00:00
Andree Buschmann
7b054efa0b FS#12117: Use more IRAM for atrac3. Speeds up decoding from 1-2% (PP5022, PP5024, S5L870x) to 11% (MCF5250). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29892 a1c6a512-1295-4272-9138-f99709370657
 2011-05-16 21:47:13 +00:00
Andree Buschmann
22c9b6ef8e Use more IRAM for mpc on S5L870x. Speed up decoding by ~2%. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29891 a1c6a512-1295-4272-9138-f99709370657
 2011-05-16 21:31:59 +00:00
Bertrik Sikken
14cac39d19 FS#12119 - June update of Czech language by Marek Salaba 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29888 a1c6a512-1295-4272-9138-f99709370657
 2011-05-16 19:57:43 +00:00
Andree Buschmann
46507d29b4 FS#12113: Optimize IRAM configuration for SPC. Performance increases by 5-6% on PP5022, PP5024 and S5L870x. No change of performance on Coldfire, PP5002 and PP5020. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29887 a1c6a512-1295-4272-9138-f99709370657
 2011-05-15 16:08:50 +00:00
Andree Buschmann
41723bc14b FS#12113: Optimize IRAM configuration for NES Sound Format. Performance is stable on Coldfire and shows performance gains from about 50-100% (PP5020, S5L870x, PP5022) up to 168% (PP5002). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29886 a1c6a512-1295-4272-9138-f99709370657
 2011-05-15 15:00:41 +00:00
Bertrik Sikken
5a726f83b7 Update french translation for LANG_PAUSE_REWIND by Ophir Lojkine 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29885 a1c6a512-1295-4272-9138-f99709370657
 2011-05-15 14:51:57 +00:00
Bertrik Sikken
d835b7b51f FS#12116 - Update of Portuguese (Portugal) language - Rewind on Pause by Gabriel Maia 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29884 a1c6a512-1295-4272-9138-f99709370657
 2011-05-15 13:56:52 +00:00
Andree Buschmann
bf46e634b4 FS#12113: Optimize IRAM configuration for Atari SAP format. Performance gains range from 5% (PP5020), over 13-16% (PP5002, PP5022, PP5024, S5L870x) to 115% (MCF5249, MCF5250). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29883 a1c6a512-1295-4272-9138-f99709370657
 2011-05-15 13:40:02 +00:00
Frank Gevaerts
322bbf7c00 Prefill the playlist name when creating a new playlist from the file browser. FS#12104 by Ophir Lojkine 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29882 a1c6a512-1295-4272-9138-f99709370657
 2011-05-15 10:37:45 +00:00
Michael Sevakis
c949d69f4b test_codec: Allow user to abort tests using target-defined TESTCODEC_EXITBUTTON. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29881 a1c6a512-1295-4272-9138-f99709370657
 2011-05-15 01:41:25 +00:00
Jonas Häggqvist
7b3e05b346 Remove a tab character from the bulgarian translation 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29880 a1c6a512-1295-4272-9138-f99709370657
 2011-05-14 20:09:49 +00:00
Robert Menes
7169e49798 Disktidy: New default files and folders for disktidy.config; 
.fseventsd/ folders from OS X 10.6, and several system
files created by Mac OS 9 and under.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29879 a1c6a512-1295-4272-9138-f99709370657
 2011-05-14 00:24:54 +00:00
Michael Hohmuth
593d520a00 mpegplayer: Adapt to new pause_rewind setting and apply it for all 
kinds of pause, not just pause on headphone unplug.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29878 a1c6a512-1295-4272-9138-f99709370657
 2011-05-13 22:51:10 +00:00
Michael Hohmuth
5aec3c2400 FS#11931 part 2: Allow a short rewind when playback is paused. Patch 
by John Morris.

This patch adds an option to rewind the current track by a few seconds
when it is paused, irrespective of what has caused the pause.  This is
useful for audiobooks and podcasts to allow the listener to recall
where the track was left off.

The patch subsumes the existing rewind-on-headphone-unplug feature and
extends it to all invocations of pause: play/pause button (or touch
area), headphone removal, and power-supply unplug in car-adapter
mode. It also subsumes FS#9448 (rewind on fade).

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29876 a1c6a512-1295-4272-9138-f99709370657
 2011-05-13 22:28:47 +00:00
Andree Buschmann
0a070c5420 Fix last known 'set but not used' warning by GCC 4.6.1. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29875 a1c6a512-1295-4272-9138-f99709370657
 2011-05-13 19:40:17 +00:00
Andree Buschmann
d9098707f8 Fix another 'set but not used' warning. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29874 a1c6a512-1295-4272-9138-f99709370657
 2011-05-13 19:34:11 +00:00
Andree Buschmann
2aa0759077 Fix even more 'set but not used' warnings and a regression. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29873 a1c6a512-1295-4272-9138-f99709370657
 2011-05-13 19:23:27 +00:00
Andree Buschmann
4f4edd89e4 Fix further 'set but not used' warnings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29872 a1c6a512-1295-4272-9138-f99709370657
 2011-05-13 19:06:04 +00:00
Andree Buschmann
f7808c1fe5 Fix several 'variable set but not used' warnings reported by GCC 6.4.1. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29871 a1c6a512-1295-4272-9138-f99709370657
 2011-05-13 18:47:42 +00:00
Thomas Martitz
6034978c84 Skin engine: Swap meaning of & and * for touch regions. 
r29653 broke compatibility in a unnecessary way, including shipped themes (cabbieve2). Swapping restores compatibility.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29866 a1c6a512-1295-4272-9138-f99709370657
 2011-05-13 11:38:04 +00:00
Andree Buschmann
fffc6c4a80 Trapped into ifdef-hell. Configure libfaad's IRAM/DRAM usage like it is meant to be. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29864 a1c6a512-1295-4272-9138-f99709370657
 2011-05-12 22:24:09 +00:00
Andree Buschmann
281666a066 The last submit had one define too much. Nevertheless fix the IRAM configuration for static allocation method. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29863 a1c6a512-1295-4272-9138-f99709370657
 2011-05-12 18:06:03 +00:00
Andree Buschmann
2263cf35ab libfaad: AAC including HE-profile needs ~470 KB for playback (measured on ARM). Therefor it does not make sense to enable HE on devices with CODEC_SIZE < 512 KB. This will allow to load and play larger AAC-LC files on such devices. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29862 a1c6a512-1295-4272-9138-f99709370657
 2011-05-12 17:41:45 +00:00
Andree Buschmann
72fba7a9d7 Make libfaad compilable again without PS_DEC. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29861 a1c6a512-1295-4272-9138-f99709370657
 2011-05-12 17:35:06 +00:00
Michael Hohmuth
bc315ad731 FS#12076 - DB stats resurrection: If the filename was changed, require 
all three of album, artist, and title tags to match for resurrection
to take place.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29858 a1c6a512-1295-4272-9138-f99709370657
 2011-05-11 22:37:46 +00:00
Andree Buschmann
0e7c04e57d libfaad: Move PS related variables to sbr_info struct. This allows dynamic allocation including error handling. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29857 a1c6a512-1295-4272-9138-f99709370657
 2011-05-11 18:52:05 +00:00
Andree Buschmann
03e23d1113 Implement error handling for libfaad's memory allocation. Do not allocate PS related types dynamically anymore to minimize code changes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29854 a1c6a512-1295-4272-9138-f99709370657
 2011-05-10 19:04:24 +00:00
Andree Buschmann
78b0f94c76 Proper initialization of static variables in codeclib. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29853 a1c6a512-1295-4272-9138-f99709370657
 2011-05-10 18:20:56 +00:00
Michael Hohmuth
6a24a7a903 tagnavi.config: Add a logical-OR operator ("|") for tagnavi conditionals. 
Logical-AND ("&") always takes precedence over logical-OR.
(Parentheses are not supported.)

Fight binsize increase by storing some common expressions in local
variables. This avoids repeated reevaluations involving memory
accesses.

check_clauses: Fail clause (return false) in case of errors (tag too
long, DB entry deleted).

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29851 a1c6a512-1295-4272-9138-f99709370657
 2011-05-10 10:25:41 +00:00
Jeffrey Goode
8cb4b36ee3 Fix whitespace and some comment typos 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29850 a1c6a512-1295-4272-9138-f99709370657
 2011-05-09 21:52:06 +00:00
Michael Sevakis
5a8f5b8330 Provide a reasonable fix for FS#12093 - Playback hanging after codec/playback rework. Also, get rid of an impossible buffering case (BUF_USED is always less than buffer_len) and remove a buffering API that is not used anywhere and shouldn't be needed (plugin API has to be incompatible). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29849 a1c6a512-1295-4272-9138-f99709370657
 2011-05-09 21:19:11 +00:00
Andree Buschmann
12e8e43236 Use signed variable to check available buffer size. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29848 a1c6a512-1295-4272-9138-f99709370657
 2011-05-09 20:43:35 +00:00
Andree Buschmann
1ee4e89627 Renaming for the sake of consistency. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29846 a1c6a512-1295-4272-9138-f99709370657
 2011-05-09 19:34:45 +00:00
Michael Hohmuth
0b59079dd2 Fix a warning 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29845 a1c6a512-1295-4272-9138-f99709370657
 2011-05-09 13:07:04 +00:00
Michael Hohmuth
84301c1e2d FS#11931 part 1: Make fade in/out behavior more consistent across the 
various causes of pause and unpause.

Patch by John Morris.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29844 a1c6a512-1295-4272-9138-f99709370657
 2011-05-09 12:59:46 +00:00
Michael Hohmuth
9b7027232f unplug_change: Precede call to audio_ff_rewind with 
audio_pre_ff_rewind (for SWCODEC).

This became necessary with the recent playback-code renovation.
Thanks to jethead for the hint!

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29843 a1c6a512-1295-4272-9138-f99709370657
 2011-05-09 12:51:19 +00:00
Andree Buschmann
9befc2e747 Remove tabs. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29842 a1c6a512-1295-4272-9138-f99709370657
 2011-05-08 21:21:02 +00:00
Andree Buschmann
67f215032d Fix a bunch of 'variable set but not used' warnings reported from GCC 4.6.0. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29841 a1c6a512-1295-4272-9138-f99709370657
 2011-05-08 21:06:38 +00:00
Bertrik Sikken
ab99e941db More tab fixes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29840 a1c6a512-1295-4272-9138-f99709370657
 2011-05-08 20:35:29 +00:00
Andree Buschmann
d68d02ec11 Move implementation of codec_get_buffer() to codec.c, make related variables static. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29839 a1c6a512-1295-4272-9138-f99709370657
 2011-05-08 20:18:35 +00:00
Andree Buschmann
b452fa061d Use CACHEALIGN_SIZE in codec_malloc for optimal alignment. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29838 a1c6a512-1295-4272-9138-f99709370657
 2011-05-08 19:50:39 +00:00
Andree Buschmann
f79769c541 Minor loop optimization in libfaad's is/ms decoding. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29837 a1c6a512-1295-4272-9138-f99709370657
 2011-05-08 19:36:08 +00:00
Andree Buschmann
e720724b95 Use MEM_ALIGN_ATTR and CACHEALIGN_SIZE in oggmalloc to ensure optimal alignment. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29833 a1c6a512-1295-4272-9138-f99709370657
 2011-05-08 16:41:23 +00:00
Andree Buschmann
897fd92827 codeclib: Declare several variables static and remove unused variables. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29831 a1c6a512-1295-4272-9138-f99709370657
 2011-05-08 10:34:05 +00:00
Nils Wallménius
04b4722a5c Fix FS#12098 by ignoring battery update events in the yesno screen. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29828 a1c6a512-1295-4272-9138-f99709370657
 2011-05-07 08:08:49 +00:00
Magnus Holmgren
c2ff646b78 Avoid false warnings of full dirs when the number of visible entries in a dir equals the limit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29823 a1c6a512-1295-4272-9138-f99709370657
 2011-05-04 18:33:12 +00:00
Michael Giacomelli
37a9a200b2 Commit FS#12096 by Stephan Grossklass. Increases the maximum ID3v2 field length to 240 bytes on large memory targets, and 90 bytes on low memory targets. Total bytes for all tags combined remains unchanged. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29821 a1c6a512-1295-4272-9138-f99709370657
 2011-05-04 17:29:53 +00:00
Andree Buschmann
d6accacc60 Fix last known 'variable set but not used' warning reported from GCC 4.6.0. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29820 a1c6a512-1295-4272-9138-f99709370657
 2011-05-04 06:11:59 +00:00
Andree Buschmann
f19d6a5e1d Fix even more 'variable set but not used' warnings reported from GCC 4.6.0. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29819 a1c6a512-1295-4272-9138-f99709370657
 2011-05-03 20:28:56 +00:00
Bertrik Sikken
069567c0bc iap: pass length and data pointer to iap_handlepkt functions, this prepares for iap large packet support. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29815 a1c6a512-1295-4272-9138-f99709370657
 2011-05-02 21:55:13 +00:00
Andree Buschmann
8aa1577a0b Display the correct sign of replaygain for levels from -0.99 to -0.01 dB. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29814 a1c6a512-1295-4272-9138-f99709370657
 2011-05-01 21:12:40 +00:00
Andree Buschmann
9af2ca7340 Remove tabs. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29813 a1c6a512-1295-4272-9138-f99709370657
 2011-05-01 20:33:31 +00:00
Nils Wallménius
4a62bc40c2 Work around another 'set but not used' warning. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29811 a1c6a512-1295-4272-9138-f99709370657
 2011-05-01 16:53:20 +00:00
Andree Buschmann
27d153db93 Fix nearly all residual 'variable set but not used' warnings reported from GCC 4.6.0. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29810 a1c6a512-1295-4272-9138-f99709370657
 2011-05-01 14:44:20 +00:00
Andree Buschmann
f7c4594134 Fix further 'variable set but not used' warnings reported from GCC 4.6.0. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29809 a1c6a512-1295-4272-9138-f99709370657
 2011-05-01 13:48:28 +00:00
Andree Buschmann
e75018ad66 Fix several 'variable set but not used' warnings reported from GCC 4.6.0. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29805 a1c6a512-1295-4272-9138-f99709370657
 2011-05-01 11:42:41 +00:00
Michael Sevakis
5e57edf263 Clean up speex a bit after the playback changes in r29785. Haven't found any idiosyncracies not present before then. Fix it always returning CODEC_ERROR even when exiting codec_run normally. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29804 a1c6a512-1295-4272-9138-f99709370657
 2011-05-01 04:23:30 +00:00
Bertrik Sikken
155584fb78 iap: introduce functions (put_u32 and get_u32) to convert a uint32_t to a byte array and vice versa 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29799 a1c6a512-1295-4272-9138-f99709370657
 2011-04-30 18:21:18 +00:00
Magnus Holmgren
ed2cfb8c1d Don't (partially) apply changes to max entries in the file browser immediately. The setting affects a buffer that is allocated during boot, so code using that buffer should use the value that was in effect during boot. Add a note to the manual that a reboot is needed for the changes to be applied. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29798 a1c6a512-1295-4272-9138-f99709370657
 2011-04-30 11:00:26 +00:00
Bertrik Sikken
16e793f5d1 iap: update handling of IdentifyDeviceLingoes command and fix RF tuner detection code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29797 a1c6a512-1295-4272-9138-f99709370657
 2011-04-30 10:40:05 +00:00
Bertrik Sikken
eac9577f76 FS#12085 - Correction of iap.c to avoid sending useless data to an accessory, and allow larger playlists names, by Ophir Lojkine 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29796 a1c6a512-1295-4272-9138-f99709370657
 2011-04-30 09:15:57 +00:00
Andree Buschmann
d0d1a3f2f7 Remove unneeded update of ci->id3->frequency in aac and raac codec. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29794 a1c6a512-1295-4272-9138-f99709370657
 2011-04-28 21:07:28 +00:00
Michael Sevakis
ac724cca19 Get the NSF internal playlists working again. Fix a few wrongdoings in the metadata parser. Use the larger of track or playlist count to determine 'duration' so that the repeat-one switching to access the raw tracks works. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29793 a1c6a512-1295-4272-9138-f99709370657
 2011-04-28 02:56:28 +00:00
Andree Buschmann
fa65362a42 Fix compiler warnings ('variable set ut not used') with GCC 4.6.0. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29792 a1c6a512-1295-4272-9138-f99709370657
 2011-04-27 17:59:49 +00:00
Michael Sevakis
4170ac8ac6 Fix r29790 yellow. Need 'string-extra.h' for strlcpy(). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29791 a1c6a512-1295-4272-9138-f99709370657
 2011-04-27 17:06:52 +00:00
Michael Sevakis
3d9c062822 Get NSF fixed up a bit and parse metadata in the core. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29790 a1c6a512-1295-4272-9138-f99709370657
 2011-04-27 16:46:27 +00:00
Michael Sevakis
08bedf8305 Having a default weak codec_main symbol doesn't seem to be working out for compiling the sim under cygwin in at least some cases. Just implement it explicitly in all cases. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29789 a1c6a512-1295-4272-9138-f99709370657
 2011-04-27 12:52:11 +00:00
Bertrik Sikken
1a68986bc5 FS#12079 - Support for new commands in iap.c, by Ophir Lojkine 
This allows access to the playlists from an ipod dock.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29788 a1c6a512-1295-4272-9138-f99709370657
 2011-04-27 06:24:28 +00:00
Michael Sevakis
82e97363f1 Get rid of a committed #define from kernel.h that didn't make the final cut. Put voice_wait in voice_thread.h where it ought. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29787 a1c6a512-1295-4272-9138-f99709370657
 2011-04-27 04:00:48 +00:00
Michael Sevakis
a089b00ea0 Hopefully fix red from r29785 - an #ifdef AB_REPEAT_ENABLE was left out. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29786 a1c6a512-1295-4272-9138-f99709370657
 2011-04-27 03:23:48 +00:00
Michael Sevakis
c537d5958e Commit FS#12069 - Playback rework - first stages. Gives as thorough as possible a treatment of codec management, track change and metadata logic as possible while maintaining fairly narrow focus and not rewriting everything all at once. Please see the rockbox-dev mail archive on 2011-04-25 (Playback engine rework) for a more thorough manifest of what was addressed. Plugins and codecs become incompatible. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29785 a1c6a512-1295-4272-9138-f99709370657
 2011-04-27 03:08:23 +00:00
Andree Buschmann
dcf0f8de4a Submit FS#12081. Check validity of channel configuration, comment unneeded code that is too inflexible to work with MAX_CHANNELS = 2. Fixes compiler warnings with GCC 4.6.0. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29784 a1c6a512-1295-4272-9138-f99709370657
 2011-04-26 21:30:51 +00:00
Bertrik Sikken
05c3290608 iap: fix shutdown of logitech Pure-Fi Elite dock, by Ophir Lojkine 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29783 a1c6a512-1295-4272-9138-f99709370657
 2011-04-25 11:06:59 +00:00
Michael Giacomelli
8166ce75c8 Commit FS#12056 by Noe Lojkinse. Fixes a bug in Xobox where old key presses were left on the buffer too long. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29781 a1c6a512-1295-4272-9138-f99709370657
 2011-04-24 23:44:58 +00:00
Bertrik Sikken
4c1de9c015 iap: add more comments to iap command and responses 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29779 a1c6a512-1295-4272-9138-f99709370657
 2011-04-24 20:22:38 +00:00
Andree Buschmann
a602f46d69 Rework of libfaad in several areas. Allow removal of malloc with a new define FAAD_STATIC_ALLOC (in common.h). For now malloc is not fully removed but used by a few arrays needed for AAC-HE SBR+PS only. Reason to keep malloc is to have this amount of memory available for AAC-LC files which might require large m4a tables. The changes make the allocation routines much smaller, better centralized and allow to move duplicated code from aac.c/raa.c to libfaad. The rework includes removal of (now and former) unused code as well. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29778 a1c6a512-1295-4272-9138-f99709370657
 2011-04-24 20:19:05 +00:00
Andree Buschmann
69580a96eb Fix yellow. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29777 a1c6a512-1295-4272-9138-f99709370657
 2011-04-24 19:13:08 +00:00
Bertrik Sikken
abf503496b iap: order lingo 0x00 commands by id and add comments 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29776 a1c6a512-1295-4272-9138-f99709370657
 2011-04-24 19:05:23 +00:00
Andree Buschmann
2f215da9c3 Use dedicated function to internally reset aac decoder synthesis after seek. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29775 a1c6a512-1295-4272-9138-f99709370657
 2011-04-24 18:56:23 +00:00
Andree Buschmann
2f04e6cca2 Ensure proper termination of m4a lookup table. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29774 a1c6a512-1295-4272-9138-f99709370657
 2011-04-24 18:33:39 +00:00
Andree Buschmann
15e9053afb Clean up array sizes in the SBR + PS part of libfaad. Add MAX_NTSRPS (=38), use MAX_NTSR and MAX_NTSRHFG at the right places. RAM (IRAM) usage is reduced by 2 KB. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29773 a1c6a512-1295-4272-9138-f99709370657
 2011-04-24 13:54:02 +00:00
Jonathan Gordon
2271995517 invert the quickscreen setting direction on wheel targets for settings which are number lists so pressing up makes it bigger (i.e contrast). fixes http://forums.rockbox.org/index.php/topic,27778.0.html 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29772 a1c6a512-1295-4272-9138-f99709370657
 2011-04-24 07:04:52 +00:00
Andree Buschmann
6bab4e8dc0 get_sample_info() has been removed. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29771 a1c6a512-1295-4272-9138-f99709370657
 2011-04-23 22:28:47 +00:00
Andree Buschmann
7d1de584fe Minor speed optimization to m4a lookup table build up. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29770 a1c6a512-1295-4272-9138-f99709370657
 2011-04-23 20:43:47 +00:00
Bertrik Sikken
d038db9420 iap: introduce cmd_ok_mode0 and cmd_ok_mode4 functions to reduce code duplication 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29757 a1c6a512-1295-4272-9138-f99709370657
 2011-04-21 22:36:10 +00:00
Bertrik Sikken
9ea20660ca iap: split iap_handlepkt into a function per mode 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29755 a1c6a512-1295-4272-9138-f99709370657
 2011-04-21 21:50:39 +00:00
Nils Wallménius
12a60efca9 FS#12072 Improved and updated translation of Romaneste by Sergiu Rotaru. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29751 a1c6a512-1295-4272-9138-f99709370657
 2011-04-20 12:34:41 +00:00
Andree Buschmann
2358fabb70 Optimization to latest aac decoder changes. Significantly reduce loop count in m4a_check_sample_offset() during standard playback. Before this change the loop count increased with each decoded chunk and for each frame. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29750 a1c6a512-1295-4272-9138-f99709370657
 2011-04-19 05:55:54 +00:00
Andree Buschmann
68199cc195 Major rework of the m4a parser for aac/alac playback, seek and resume support. As a result the memory consumption was drastically reduced. This allows to play several files with long duration -- especially on low memory targets. The change builds a lookup table from m4a's sample_to_chunk[] and chunk_offset[] and completely removes the allocation of the large tables chunk_offset[] and sample_byte_size[]. To be able to remove reading and allocating sample_byte_offset[] the aac and alac decoder now buffer a fixed amount of bytes for each frame. The generated lookup table is used for seek/resume and skipping bytes in empty chunks (aac decoder only). The precision for seek/resume is somewhat lower but still equals 0.5 sec for the worst case. Fixes FS#8923. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29745 a1c6a512-1295-4272-9138-f99709370657
 2011-04-18 19:12:51 +00:00
Bertrik Sikken
204a2e920a Move declaration of global function cfg_string_to_int to header file settings.h 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29737 a1c6a512-1295-4272-9138-f99709370657
 2011-04-17 11:23:48 +00:00
Andree Buschmann
5775159462 Refactor aac decoder as preparation for upcoming m4a changes. The aac decoder does not need to use get_sample_info() to gather frame size or the number of consumed bytes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29727 a1c6a512-1295-4272-9138-f99709370657
 2011-04-16 19:39:01 +00:00
Frank Gevaerts
a96a72b7b0 Since r29700 changed the way the backdrop setting works, the default needs to be updated too 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29726 a1c6a512-1295-4272-9138-f99709370657
 2011-04-16 19:26:21 +00:00
Andree Buschmann
8055b48b46 Fix yellow. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29725 a1c6a512-1295-4272-9138-f99709370657
 2011-04-16 19:26:07 +00:00
Andree Buschmann
19f9fd0f5f Refactor alac decoder as preparation for upcoming m4a changes. The alac decoder does not need to use get_sample_info() to gather frame size or the number of consumed bytes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29724 a1c6a512-1295-4272-9138-f99709370657
 2011-04-16 19:08:50 +00:00
Michael Hohmuth
cf223b98ad Do not attempt to remove the temporary database twice during a database update. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29716 a1c6a512-1295-4272-9138-f99709370657
 2011-04-15 21:45:45 +00:00
Nils Wallménius
bbeba640bf Fix missing printfstyle formatting in simplified Chinese. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29711 a1c6a512-1295-4272-9138-f99709370657
 2011-04-14 15:07:04 +00:00
Andree Buschmann
4359058c79 Fix the Xing header parser to have reliable gapless playback. Closes FS#12062. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29708 a1c6a512-1295-4272-9138-f99709370657
 2011-04-13 05:51:03 +00:00
Bertrik Sikken
fa068bbaf7 Do not show IRMax/IWMax in the disk info debug screen for sd cards with CSD version > 1.0 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29703 a1c6a512-1295-4272-9138-f99709370657
 2011-04-11 19:11:39 +00:00
Bertrik Sikken
98d6924d50 FS#12061 - April update of Czech language by Marek Salaba 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29702 a1c6a512-1295-4272-9138-f99709370657
 2011-04-11 17:40:28 +00:00
Frank Gevaerts
966becfa9f Deprecate strings that are unused since r29700 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29701 a1c6a512-1295-4272-9138-f99709370657
 2011-04-10 13:54:06 +00:00
Frank Gevaerts
d09f97880a Support loading backdrops from anywhere in the filesystem. Fixes FS#12041 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29700 a1c6a512-1295-4272-9138-f99709370657
 2011-04-10 13:25:47 +00:00
Michael Sevakis
d5849e0d30 Playlists forget to set playlist.started when creating new playlist on SWCODEC and which leads to flush-and-rebuffer messages never being sent again until playback is restarted. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29697 a1c6a512-1295-4272-9138-f99709370657
 2011-04-09 13:07:08 +00:00
Nils Wallménius
e7c6ba66aa Whitespace and cosmetics consistency cleanup in playlist_viewer.c, no functional changes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29694 a1c6a512-1295-4272-9138-f99709370657
 2011-04-08 13:39:56 +00:00
Nils Wallménius
a0791178ae Voice filenames in the playlist viewer, closes FS#11951 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29693 a1c6a512-1295-4272-9138-f99709370657
 2011-04-08 13:10:32 +00:00
Andree Buschmann
29a855245c Fix residual red. Keep index in mp3entry for HWCODEC. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29692 a1c6a512-1295-4272-9138-f99709370657
 2011-04-07 22:11:12 +00:00
Andree Buschmann
39d9d8bab1 Fix red and yellow. Move resume_index from mp3entry to playlist_info struct. Bump codec api. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29691 a1c6a512-1295-4272-9138-f99709370657
 2011-04-07 21:38:51 +00:00
Andree Buschmann
4df825be43 Fix regressions of r29682. Update playlist index resume position when playlist changes (e.g. shuffling, inserting, removing, ...). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29690 a1c6a512-1295-4272-9138-f99709370657
 2011-04-07 20:33:00 +00:00
Björn Stenberg
2d00f0c8b2 Removed some dead code identified by clang-analyzer. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29685 a1c6a512-1295-4272-9138-f99709370657
 2011-04-06 21:08:31 +00:00
Andree Buschmann
3184cbe10a Fix FS#12043. Next track was resumed when pausing and shutting down the player in the last seconds of a track. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29682 a1c6a512-1295-4272-9138-f99709370657
 2011-04-06 19:11:40 +00:00
Andree Buschmann
d1766a1510 Rework parts of the replaygain code to be able to differentiate between 0.00 dB set intentionally and having no replaygain information at all. Bump codec api. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29679 a1c6a512-1295-4272-9138-f99709370657
 2011-04-04 15:21:44 +00:00
Andree Buschmann
a7354e7925 Cosmetic change of a comment. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29666 a1c6a512-1295-4272-9138-f99709370657
 2011-03-31 22:06:52 +00:00
Andree Buschmann
29164ccbcc Changing convert_gain() also implicitly changed get_replaygain_int() which could lead to div by zero. This patch finds another way to fix the replaygain fallback. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29665 a1c6a512-1295-4272-9138-f99709370657
 2011-03-31 21:46:09 +00:00
Andree Buschmann
4f7930b883 Fix for replaygain: Ensure fallback to track gain in case of missing album gain. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29664 a1c6a512-1295-4272-9138-f99709370657
 2011-03-31 12:44:29 +00:00
Björn Stenberg
ce755dd9c5 Only set volume on SYS_VOLUME_CHANGED the first time. Workaround for FS#12034. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29663 a1c6a512-1295-4272-9138-f99709370657
 2011-03-31 07:04:44 +00:00
Bertrik Sikken
81d67d0dda Revert accidental commit of apps/plugins/SOURCES 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29661 a1c6a512-1295-4272-9138-f99709370657
 2011-03-29 20:44:09 +00:00
Bertrik Sikken
8351a1aa9d AMSv2 sd: do not try to switch sd cards into high-speed mode. 
High-speed mode is only half implemented (sd controller still uses normal speed) and causes card detection problems.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29660 a1c6a512-1295-4272-9138-f99709370657
 2011-03-29 20:37:40 +00:00
Rafaël Carré
8c3fc23ae6 remove set but unused variable 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29659 a1c6a512-1295-4272-9138-f99709370657
 2011-03-28 21:44:36 +00:00
Rafaël Carré
cde3c9a08e maze: fix warning spotted by gcc 4.6.0 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29658 a1c6a512-1295-4272-9138-f99709370657
 2011-03-28 21:44:23 +00:00
Jonathan Gordon
87aa86cedd Skin variables for touchscreen targets (origional implementation by Jens Theeß) 
%vs(name, [set|inc|dec], value [,max]) - name is the id, set sets the value, inc increments by value, dec decrements by value
%vg(name) - get the current value
%vl(name [,timeout]) - 'has it changed in [timeout]'?

values start at 1 and are all reset to 1 on skin load

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29655 a1c6a512-1295-4272-9138-f99709370657
 2011-03-27 08:01:58 +00:00
Jonathan Gordon
969381322d Fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29654 a1c6a512-1295-4272-9138-f99709370657
 2011-03-27 07:30:23 +00:00
Jonathan Gordon
443b134983 Fix touchregions muting volume, and change &<action> to mean 'needs long press but only fire once'. Use *<action> for 'long press and allow repeats' 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29653 a1c6a512-1295-4272-9138-f99709370657
 2011-03-27 07:23:38 +00:00
Andree Buschmann
0258895faa Fix error in Ohm's law formula as provided in FS#12023. Thanks to Leif Andersen. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29644 a1c6a512-1295-4272-9138-f99709370657
 2011-03-25 07:22:38 +00:00
Andree Buschmann
afe6ee4300 Fix FS#12024. Scroll acceleration did not work -- at least reported for iRiver H10 -- caused by too short duration for button repeat recognition. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29642 a1c6a512-1295-4272-9138-f99709370657
 2011-03-24 18:42:27 +00:00
Andree Buschmann
04bd51fbcb Scroll speed is increased every N seconds, not every N half seconds. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29635 a1c6a512-1295-4272-9138-f99709370657
 2011-03-22 21:29:05 +00:00
Andree Buschmann
0897753d3b Submit parts of FS#12024. Describe the settings 'List Acceleration Start Delay' and 'List Acceleration Speed' in the manual. Correct the unit (seconds) for the first setting and change the text for the second setting. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29634 a1c6a512-1295-4272-9138-f99709370657
 2011-03-22 21:15:22 +00:00
Jonathan Gordon
f4e152bdef Make repeat mode/shuffle work in the sbs also 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29632 a1c6a512-1295-4272-9138-f99709370657
 2011-03-22 09:41:11 +00:00
Jonathan Gordon
98881fd822 Add some playback controls to the SBS. 2 new touch regions wps_next/wps_prev needed to make it work. 'next' in the sbs changes list selection, 'wps_next' in sbs changes audio tracks. no difference in the wps 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29631 a1c6a512-1295-4272-9138-f99709370657
 2011-03-22 09:31:45 +00:00
Michael Sevakis
4823b2b1c0 Buffering should truncate if read() returns 0 since it's not a valid return there as there should be data left to read. The loop wouldn't break until there was a message in the queue. I just experienced the case with crosslinked files and read stopped making progress, returning 0 each time it was called. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29626 a1c6a512-1295-4272-9138-f99709370657
 2011-03-21 15:57:07 +00:00
Andree Buschmann
e9c5190de7 Headroom in AAC SBR HF-generator's fixed point implementation of autocorrelation was too small. Fixes FS#12019. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29622 a1c6a512-1295-4272-9138-f99709370657
 2011-03-20 15:57:38 +00:00