Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
rockbox/apps
History
Osborne Jacobs fb30d01372 Fix minor bookmark problems/Enhance bookmark functions 
This fix:

-fixes when the bookmark menu and submenus are displayed and hidden
 in the context menu.
     -'Create Bookmark' should be hidden when tracks are queued in
      the playlist or nothing is currently playing (previously it was
      never hidden)
     -'List Bookmarks' should be hidden if and only if no bookmark
      file exists for the current playlist (previously it was hidden
      if tracks were queued or nothing was playing neither of which
      hinder loading bookmarks)
     -'Bookmarks' main menu should be hidden if both 'Create
      Bookmarks' and 'List Bookmarks' submenus are hidden

-fixes a problem where the 'Bookmark Error' message was not always
 displayed on bookmarking failure

-adds BOOKMARK_USB_CONNECTED return value to the bookmark functions
 to distinguish if the bookmark list was exited due to a USB
 connection.

-fixes other minor logic problems in the bookmarking functions

Change-Id: If6394b2e77f027773a7c94ffdcb52dbb15e2922b
Reviewed-on: http://gerrit.rockbox.org/177
Reviewed-by: Osborne Jacobs <ozziejacks@gmail.com>
Tested-by: Osborne Jacobs <ozziejacks@gmail.com>
Reviewed-by: Jonathan Gordon <rockbox@jdgordon.info>
2012-03-12 08:54:02 +01:00
..
bitmaps Sansa clip zip: fix pinkish outline around usb logo 2012-02-18 16:01:06 +01:00
codecs Fix FS#12580 - Elapsed time nit reset after track change when playing AC3 files. 2012-02-07 12:25:23 -05:00
eqs
gui Make %LC and %LR always have predictable and usable values. 2012-03-01 18:40:59 +01:00
hosted/android Rename 'mp3entry.embed_albumart' to 'mp3entry.has_embedded_albumart' (FS#12470). No functional changes. 2011-12-22 18:48:43 +00:00
keymaps Commit FS#12288 - Sansa Clip+: "Home" in the main menu to WPS/Radio. 2012-02-25 15:20:54 -05:00
lang Updated some missing items for Simplified-Chinese translation (FS#12584) 2012-03-02 21:32:46 +01:00
menus Change EQ settings to use a struct array in global_settings. 2012-03-12 00:18:33 +01:00
metadata Add the warble test program. 2012-03-03 16:41:49 +01:00
player
plugins Tweak paramters of mp3_play_data and callback. 2012-03-04 14:50:47 -05:00
radio Move radio power handling from apps/ to drivers. 2012-02-25 15:59:08 +01:00
recorder Revise the PCM callback system after adding multichannel audio. 2012-03-03 07:23:38 +01:00
abrepeat.c abrepeat: drop some inline's and rearrange code to save some size since this stuff is hardly speed critical. 2011-01-18 16:11:33 +00:00
abrepeat.h abrepeat: drop some inline's and rearrange code to save some size since this stuff is hardly speed critical. 2011-01-18 16:11:33 +00:00
action.c Correct actionable offense for misappropriation of action context. 2012-03-03 07:52:13 -05:00
action.h Correct actionable offense for misappropriation of action context. 2012-03-03 07:52:13 -05:00
alarm_menu.c Changed the FOR_NB_SCREENS macro to always be a for loop that declares its own loop variable. This removes the need to declare this variable in the outer scope. 2011-10-15 19:35:02 +00:00
alarm_menu.h
appevents.h Workaround an occasional problem where album art or cuesheets might not be ready by the time the track change event is send which can result in the WPS not immediately being aware that the handles are ready. A better solution will be sought that hopefully doesn't require the additional event. 2011-05-25 08:35:31 +00:00
applimits.h Remove two unused defines. 2010-08-21 15:49:42 +00:00
apps.make Android: use APPEXTRA instead of makefile hack 2011-03-11 16:08:36 +00:00
audio_path.c
beep.c Tweak paramters of mp3_play_data and callback. 2012-03-04 14:50:47 -05:00
bookmark.c Fix minor bookmark problems/Enhance bookmark functions 2012-03-12 08:54:02 +01:00
bookmark.h Fix minor bookmark problems/Enhance bookmark functions 2012-03-12 08:54:02 +01:00
buffering.c Provide a reasonable fix for FS#12093 - Playback hanging after codec/playback rework. Also, get rid of an impossible buffering case (BUF_USED is always less than buffer_len) and remove a buffering API that is not used anywhere and shouldn't be needed (plugin API has to be incompatible). 2011-05-09 21:19:11 +00:00
buffering.h Add more INIT_ATTR and add config.h includes to header files with INIT_ATTR. 2011-12-19 20:12:52 +00:00
codec_thread.c Commit to certain names for cache coherency APIs and discard the aliases. 2011-12-17 07:27:24 +00:00
codec_thread.h Add more INIT_ATTR and add config.h includes to header files with INIT_ATTR. 2011-12-19 20:12:52 +00:00
codecs.c Commit to certain names for cache coherency APIs and discard the aliases. 2011-12-17 07:27:24 +00:00
codecs.h Commit to certain names for cache coherency APIs and discard the aliases. 2011-12-17 07:27:24 +00:00
compressor.c Move to compressor out of dsp.c and into its own source to reduce DSP clutter. 2012-02-08 14:55:37 -05:00
compressor.h Move to compressor out of dsp.c and into its own source to reduce DSP clutter. 2012-02-08 14:55:37 -05:00
core_asmdefs.c
cuesheet.c Rename 'mp3entry.embed_cuesheet' to 'mp3entry.embedded_cuesheet' and pull out a field (FS#12473) 2011-12-22 18:56:11 +00:00
cuesheet.h FS #12419 : Support for embedded cuesheets. 2011-12-16 10:09:41 +00:00
debug_menu.c rds: show rds clock-time as broken down time instead of UTC time in debug menu 2012-03-12 08:42:53 +01:00
debug_menu.h dbg_ports() : move proto to system.h 2012-01-04 05:21:44 +00:00
dsp.c Change EQ settings to use a struct array in global_settings. 2012-03-12 00:18:33 +01:00
dsp.h Move to compressor out of dsp.c and into its own source to reduce DSP clutter. 2012-02-08 14:55:37 -05:00
dsp_arm.S
dsp_arm_v6.S
dsp_asm.h
dsp_cf.S
enc_config.c Fix different enum comparison warning when building with gcc 4.5 2010-12-20 20:56:22 +00:00
enc_config.h
eq.c Reduce FRACMUL calls in equalizer. 2011-05-18 20:06:37 +00:00
eq.h
eq_arm.S Avoid an obvious stall on everything newer then arm7tdmi. Note: this can probably be made a lot faster on newer arm targets. 2010-12-16 19:45:59 +00:00
eq_cf.S
features.txt Finally commit FS#5111 - piezo clicker for ipods! 2011-11-16 10:25:43 +00:00
filetree.c playlist handling: revert part of r30177. 2011-11-28 12:41:15 +00:00
filetree.h
filetypes.c Sprinkle around some static and const. 2011-12-05 19:23:46 +00:00
filetypes.h Add more INIT_ATTR and add config.h includes to header files with INIT_ATTR. 2011-12-19 20:12:52 +00:00
fixedpoint.c
fixedpoint.h
fracmul.h Relax constraints for arm asm to not break when gcc decides to not inline the function but also throw in a FORCE_INLINE for good measure. Remove a redundant 'inline'. 2011-06-30 08:22:56 +00:00
iap.c IAP: use a state machine for handling iap packets, based on FS#12135 2011-09-25 12:19:33 +00:00
keyboard.h
language.c Add stdio.h include for SEEK_SET define to various files. 2010-12-25 18:43:34 +00:00
language.h
logfdisp.c
logfdisp.h
main.c Fix FS#7631 : Archos V2 and FM Recorder charging screen problems 2011-12-31 18:31:47 +00:00
menu.c Force settings touchscreen mode in menus. 2012-01-27 09:15:05 +01:00
menu.h FS#12251 - User shortcuts in the main menu. 2011-11-15 13:22:02 +00:00
metadata.c Rename 'mp3entry.embed_cuesheet' to 'mp3entry.embedded_cuesheet' and pull out a field (FS#12473) 2011-12-22 18:56:11 +00:00
metadata.h Actually remove the pulled out field (sequel to r31406) 2011-12-23 16:09:06 +00:00
misc.c Tweak paramters of mp3_play_data and callback. 2012-03-04 14:50:47 -05:00
misc.h Correct actionable offense for misappropriation of action context. 2012-03-03 07:52:13 -05:00
mp3data.c Fix red: Mark variable as unused the rockbox way 2011-12-03 17:11:54 +00:00
mp3data.h GSoC/Buflib: Replace all direct accesses to audiobuf with buffer API functions. 2011-08-14 15:13:00 +00:00
mpeg.c Tweak paramters of mp3_play_data and callback. 2012-03-04 14:50:47 -05:00
mpeg.h
onplay.c Fix minor bookmark problems/Enhance bookmark functions 2012-03-12 08:54:02 +01:00
onplay.h FS#12251 - User shortcuts in the main menu. 2011-11-15 13:22:02 +00:00
pcmbuf.c Revise the PCM callback system after adding multichannel audio. 2012-03-03 07:23:38 +01:00
pcmbuf.h pcmbuf minor cleaning 2012-02-20 00:47:21 -05:00
playback.c Rename 'mp3entry.embed_albumart' to 'mp3entry.has_embedded_albumart' (FS#12470). No functional changes. 2011-12-22 18:48:43 +00:00
playback.h FS#12378 : Remove various unused code, and comment out some unused code and data for reference or future use. 2011-12-14 21:45:25 +00:00
playlist.c Fix FS#12499 - Directory playback fails after saving playlist 2011-12-31 16:47:58 +00:00
playlist.h Add more INIT_ATTR and add config.h includes to header files with INIT_ATTR. 2011-12-19 20:12:52 +00:00
playlist_catalog.c FS#11808 - Major playlist handling changes (on disk playlists) 2011-07-20 14:11:15 +00:00
playlist_catalog.h FS#11808 - Major playlist handling changes (on disk playlists) 2011-07-20 14:11:15 +00:00
playlist_menu.h
playlist_viewer.c FS#12378 : Remove various unused code, and comment out some unused code and data for reference or future use. 2011-12-14 21:45:25 +00:00
playlist_viewer.h FS#11808 - Major playlist handling changes (on disk playlists) 2011-07-20 14:11:15 +00:00
plugin.c One more *_filesize() to remove 2012-03-03 19:10:51 +01:00
plugin.h Tweak paramters of mp3_play_data and callback. 2012-03-04 14:50:47 -05:00
README
replaygain.c Display the correct sign of replaygain for levels from -0.99 to -0.01 dB. 2011-05-01 21:12:40 +00:00
replaygain.h Rework parts of the replaygain code to be able to differentiate between 0.00 dB set intentionally and having no replaygain information at all. Bump codec api. 2011-04-04 15:21:44 +00:00
root_menu.c root menu: Use - to reset the root menu order from a config 2012-02-27 09:34:37 +11:00
root_menu.h main menu: Add the ability to hide and reorder the main menu items. 2012-02-25 12:40:44 +01:00
screen_access.c lcd/skin_engine: Add the ability to draw onto the backdrop layer 2012-02-28 23:03:04 +11:00
screen_access.h lcd/skin_engine: Add the ability to draw onto the backdrop layer 2012-02-28 23:03:04 +11:00
screens.c Add a %cs(current screen) state for the "Track Info" screen 2012-03-03 10:45:51 +01:00
screens.h
scrobbler.c Buflib: Clarification about invalid handles 2011-09-07 23:16:29 +00:00
scrobbler.h Make scrobbler_flush_cache() static 2011-08-01 19:43:13 +00:00
settings.c Moved initial checking of sleeptimer_on_startup from root_menu.c to settings.c 2011-12-26 09:57:55 +00:00
settings.h Change EQ settings to use a struct array in global_settings. 2012-03-12 00:18:33 +01:00
settings_list.c Change EQ settings to use a struct array in global_settings. 2012-03-12 00:18:33 +01:00
settings_list.h
shortcuts.c oops, somehow a leading \ went missing making these checks a bit silly! 2012-01-01 11:34:00 +00:00
shortcuts.h shortcuts: talk the time and configure the sleep timeout 2011-12-08 10:23:46 +00:00
sound_menu.h Remove unneeded include. 2010-08-21 16:07:34 +00:00
SOURCES Move to compressor out of dsp.c and into its own source to reduce DSP clutter. 2012-02-08 14:55:37 -05:00
status.c
status.h
tagcache.c Add const to global pointers to strings. 2011-12-17 18:31:55 +00:00
tagcache.h Add more INIT_ATTR and add config.h includes to header files with INIT_ATTR. 2011-12-19 20:12:52 +00:00
tagnavi.config FS#12132 patch 7: Add a new default format for untagged tracks: 2011-07-31 16:26:39 +00:00
tagtree.c GSoC/Buflib: Enable compaction in buflib. 2011-08-30 14:01:45 +00:00
tagtree.h Add more INIT_ATTR and add config.h includes to header files with INIT_ATTR. 2011-12-19 20:12:52 +00:00
talk.c Tweak paramters of mp3_play_data and callback. 2012-03-04 14:50:47 -05:00
talk.h Add conditionals for functions only needed on SWCODEC targets. 2011-12-15 20:58:14 +00:00
tdspeed.c tdspeed: Use "INT64_MAX" instead of "~(1ll << 63)" to get the maximum int64_t value. 2012-01-13 17:54:43 -05:00
tdspeed.h GSoC/Buflib: Enable compaction in buflib. 2011-08-30 14:01:45 +00:00
tree.c keyclick: Add a callback so screens can cancel a click. Add a generic list callback to stop clicks when we are at the end of the list 2012-01-12 22:28:36 +11:00
tree.h Add more INIT_ATTR and add config.h includes to header files with INIT_ATTR. 2011-12-19 20:12:52 +00:00
usb_keymaps.c remove superfluous ifdef 2011-12-28 19:23:38 +00:00
usb_keymaps.h
voice_thread.c Tweak paramters of mp3_play_data and callback. 2012-03-04 14:50:47 -05:00
voice_thread.h Tweak paramters of mp3_play_data and callback. 2012-03-04 14:50:47 -05:00

README 

For general information see: docs/README
For API information see: docs/API