4dcd1a9ed8
This works around an odd issue in Mines involving the zoom feature. The chain of events leading to it is rather convoluted: 1. No save game is found, so no fonts are loaded from disk. 2. A new game is started. 3. The user selects the "Zoom" option. 4. The allocation of the zoom framebuffer causes the malloc code to grab the audiobuffer. This causes all further font_load() calls to FAIL, due to buflib allocations no longer working. 5. The user goes back to the normal view and uncovers a square. 6. Font loading fails, causing the drawing code to fall back to the system font. 7. An unrelated bug (not yet tracked down) causes font_get(FONT_UI) to return a different font. 8. font_getstringsize() returns the right size of the "wrong" font, leading to centering issues upon rb_draw_text(). The real solution to this would be to fix font_get(), but this fix should prevent the issue from happening if Mines has been run and saved at least once before. Change-Id: Ib9ad51376eeb3ca1113a1f3786124b612db88cd7 |
||
---|---|---|
.. | ||
dummy | ||
help | ||
src | ||
compress.c | ||
fonts.zip | ||
genhelp.sh | ||
help.h | ||
lz4tiny.c | ||
lz4tiny.h | ||
puzzles.make | ||
rbassert.h | ||
rbcompat.h | ||
rbmalloc.c | ||
rbwrappers.c | ||
README.rockbox | ||
rockbox.c | ||
SOURCES | ||
SOURCES.games |
Introduction ============ This is the readme for the Rockbox port of Simon Tatham's Portable Puzzle Collection. The upstream version used is subject to change, as it should be relatively trivial to update it to a newer version. Simply copying the upstream repo's contents into src/ and running genhelp.sh ought to do it (watch out for API changes, though!). Source structure ================ Most of the upstream files in src/ are essentially untouched, apart from some minor adjustments to make them compile and run happily on Rockbox. The majority of the rockbox-specific code is found in rockbox.c, with some minor stuff in rbwrappers.c and rbmalloc.c. NOTE: the build makefile (puzzles.make) automatically includes `rbcompat.h` when compiling! Check there when things break. Help feature ============ The Help feature is implemented by compiling each puzzle against a compressed version of each puzzle's section from the upstream documentation. These files are stored under help/, and are generated by genhelp.sh from the puzzles.but file in the source distribution. The compression is LZ4, implemented in lz4tiny.c (for decompression on target), and compress.c (for generation). genhelp.sh should be run whenever the documentation is changed. Kudos to Simon (duh), and Frank, for telling me about it. Franklin Wei (__builtin) Changelog ========= April 2017: Changes made to move upstream sources to a separate subdirectory, where they are completely unmodified from the original. Updating the upstream version is now as simple as copying a fresh set of sources to src/. Several hacks were used to accomplish this: a global include specified on the command line, and a directory of dummy header files. August 2017: Every game that can be played with only the cursor keys is now functional. October 2017: Added zoom feature. March 2018: Added help styling. Changed from simple_viewer to display_text for displaying help text. compress.c now does additional processing on the help text, and also requires a slightly modified halibut. April 2018: Finished up the rest of the games. All work now! Surely there's still bugs to fix, so stay tuned... December 2018: Resync to 3ece3d6. Happy holidays! May 2019: Resync to e2135d5. June 2020: Resync to 9aa7b7c. Fixed really embarrassing bug in loading saved games.