Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
rockbox/apps/gui
History
Aidan MacDonald c11ed99cb4 bugfix: redraw yes/no screen after a full skin update 
This fixes a bug reported on IRC:

1. Set 'bookmark on stop' to 'ask'
2. Play a track from the file browser
3. Stop playback, yes/no screen briefly flashes then disappears.

The screen still handles input correctly but the prompt will not
be displayed on the LCD. Long story short, get_action() can cause
the skin engine to do a full redraw which cleared the screen and
erased the prompt.

There is a special event, GUI_EVENT_NEED_UI_UPDATE, which the list
code uses to avoid precisely this problem.

Hooking up a handler for this event and redrawing the yes/no prompt
fixes the bug.

Change-Id: If3c26655540c13b488b3a11bd46e1d60d4111469
2021-08-29 21:15:34 +01:00
..
bitmap touchscreen: fix smooth scrolling in lists 2021-08-22 14:57:54 +00:00
skin_engine skin engine: handle bitmap read errors appropriately 2021-08-10 21:47:04 +00:00
backdrop.c
backdrop.h
color_picker.c LCD core move buf ptr and address look up function viewport struct 2020-10-26 12:28:48 -04:00
color_picker.h
folder_select.c folder_select prevent directory handle leak on error 2021-08-03 03:01:14 +00:00
folder_select.h New GUI browser to select one (or more) folders. 2012-07-30 21:20:51 +02:00
icon.c icon.c bug fix handle read errors 2021-08-15 11:27:30 +00:00
icon.h [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
line.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
line.h lcd-24bit: Introduce a 24-bit mid-level LCD driver 2014-06-21 00:15:53 +02:00
list.c touchscreen: fix smooth scrolling in lists 2021-08-22 14:57:54 +00:00
list.h touchscreen: fix smooth scrolling in lists 2021-08-22 14:57:54 +00:00
mask_select.c mask_select guard against null pointers 2021-08-03 11:00:59 +00:00
mask_select.h Selective Backlight/Advanced Softlock - Selective actions based on context 2017-01-17 23:06:17 +01:00
option_select.c Add open_plugin to core 2020-08-17 10:15:14 -04:00
option_select.h New port: FiiO M3K on bare metal 2021-03-28 00:01:37 +00:00
pitchscreen.c RFC: Fix a couple more dangling stack-allocated viewports 2021-07-07 15:19:43 +00:00
pitchscreen.h
quickscreen.c QuickScreen: Update status bar after changing volume 2021-04-04 00:14:37 +02:00
quickscreen.h Shortcuts.c -- Update 2021-03-07 10:07:49 -05:00
scrollbar.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
scrollbar.h [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
splash.c Whitespace cleanup on fb_viewport Rewrite 2020-10-26 12:38:22 -04:00
splash.h Move some gcc extensions to new gcc_extensions.h header 2010-07-25 14:44:29 +00:00
statusbar-skinned.c Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
statusbar-skinned.h [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
statusbar.c Battery Icon, Remove Hardcoded Overall Width 2021-03-03 03:11:02 +00:00
statusbar.h statusbar: Make statusbar height equal SYSFONT_HEIGHT 2020-10-26 19:52:40 +00:00
usb_screen.c LCD core move buf ptr and address look up function viewport struct 2020-10-26 12:28:48 -04:00
usb_screen.h Fix warning on USB_NONE targets 2010-10-14 12:29:19 +00:00
viewport.c Whitespace cleanup on fb_viewport Rewrite 2020-10-26 12:38:22 -04:00
viewport.h Whitespace cleanup on fb_viewport Rewrite 2020-10-26 12:38:22 -04:00
wps.c Drop HAVE_RTC_RAM 2021-08-15 20:41:58 +01:00
wps.h Add more INIT_ATTR and add config.h includes to header files with INIT_ATTR. 2011-12-19 20:12:52 +00:00
yesno.c bugfix: redraw yes/no screen after a full skin update 2021-08-29 21:15:34 +01:00
yesno.h Pull yesno_pop out of the radio code as it is a nice simple resuasble yesno api worth reusing 2011-07-21 06:40:01 +00:00