Jens Arnold
4dab6235cf
The second part of this expression always becomes true before the first part, so the first part is unnecessary.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17907 a1c6a512-1295-4272-9138-f99709370657
2008-07-01 17:45:16 +00:00
Jonathan Gordon
272f79aa1a
Fix the bug where the german language would crash the quickscreen on the nano.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17889 a1c6a512-1295-4272-9138-f99709370657
2008-06-30 11:26:33 +00:00
Peter D'Hoye
205f3df781
Remove a viewport ambiguity by changing the screens width/heigth members into lcdwidth/lcdheight. Normal usercode should always use getwidth()/getheigth() as that returns the viewport width/height. Fixes issues that would have appeared in many places when introducing viewports with sizes != lcd sizes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17857 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 20:45:21 +00:00
Daniel Stenberg
2acc0ac542
Updated our source code header to explicitly mention that we are GPL v2 or
...
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Jonathan Gordon
ff469ab573
Updated recording trigger screen (seems to be a feature almost noone uses?)
...
problems/complaints in http://forums.rockbox.org/index.php?topic=16837.0
there is a known issue that on this screen the stop icon wont update, I dont know why and noone else wants to look at it, so hopefully this will force another set of eyes on it.. this is only a graphical issue... recordings still work fine
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17643 a1c6a512-1295-4272-9138-f99709370657
2008-05-28 10:55:39 +00:00
Peter D'Hoye
f2d7270b70
Fix FS #9022 : space reserved for the icons in the quickscreen used the incorrect constant
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17616 a1c6a512-1295-4272-9138-f99709370657
2008-05-23 21:20:05 +00:00
Jonathan Gordon
10df05438e
more textarea to viewport conversion... yes/no screen...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17454 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 13:39:22 +00:00
Nils Wallménius
fc25f3f61b
Binsize optimization for targets without lcd remotes, whitespace/long lines police
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17453 a1c6a512-1295-4272-9138-f99709370657
2008-05-11 10:28:52 +00:00
Bertrik Sikken
7835a20347
Prototype declaration strictness fixes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17424 a1c6a512-1295-4272-9138-f99709370657
2008-05-08 20:37:26 +00:00
Stéphane Doyon
7e86e5d866
Polish voicing of quickscreen: make it like in FS#6171: announce
...
"quickscreen" on entering, announce when leaving, say option name
when changing values in case the user isn't entirely familiar with
the layout...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17358 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 15:02:46 +00:00
Jonathan Gordon
1ef5a836f8
doh! those talk functions dont check the setting (which for some reason I thought they did).. shut the quickscreen up if talk is disabled
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17354 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 13:39:54 +00:00
Jonathan Gordon
39bccd65b9
recommit the talking quickscreen... silly rename bug which I mised this morning
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17348 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 08:11:28 +00:00
Stéphane Doyon
49a73ca90f
Revert r17345 on jdgordon's request, until we figure out why it crashes my x5.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17346 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 02:57:30 +00:00
Jonathan Gordon
dd4e3848b8
make the quickscreen talk
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17345 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 02:11:24 +00:00
Jonathan Gordon
b234ef29b6
make the quickscreen not block so the statusbar gets updated
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17343 a1c6a512-1295-4272-9138-f99709370657
2008-05-04 01:42:11 +00:00
Jonathan Gordon
ea664e0647
Viewported quickscreen (take 2 :D) (FS#8553)
...
- no customization support
- no top item
- much better use of the screen
- deprecates 20 odd lang strings (the QS can now use the regular lang strings and user font)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17315 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 12:30:40 +00:00
Paul Louden
f7c938a7b7
(Hopefully) Revert the quickscreen changes. Many fixes need to be made,
...
and the exact implementation needs discussion. We apologize for the
inconvenience and hope to bring an improved quickscreen to you soon.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16224 a1c6a512-1295-4272-9138-f99709370657
2008-02-05 09:09:38 +00:00
Jonathan Gordon
7ca3ccd2a4
quiet the masses...
...
stop the wps scrolling happening in the quickscreen
green delta for non quickscreen targets
nfi why colours arnt working... hopefully bug in firmware/?
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16222 a1c6a512-1295-4272-9138-f99709370657
2008-02-05 08:21:54 +00:00
Jonathan Gordon
2c82494e66
updated the quickscreen's:
...
- use viewports
- dont change to system font, fiddle with item positions to make them fit small screens
- user customizable options (use the .cfg settings "quickscreen_left, quickscreen_right, quickscreen_top, quickscreen_bottom" for the name and the .cfg name for the setting you want to use. it can be any except the string settings... (e.g. quickscreen_left:talk menu)
- a top item! if there is none set the up button will exit the screen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16220 a1c6a512-1295-4272-9138-f99709370657
2008-02-05 05:50:20 +00:00
Nils Wallménius
7b71787bd8
Get rid of macros and do these calculations only once instead
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14770 a1c6a512-1295-4272-9138-f99709370657
2007-09-20 10:06:33 +00:00
Jonathan Gordon
f7675a244b
remove the need for action_signalscreenchange().
...
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13956 a1c6a512-1295-4272-9138-f99709370657
2007-07-22 06:05:53 +00:00
Nils Wallménius
c2a77563c2
Remove dead code.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13488 a1c6a512-1295-4272-9138-f99709370657
2007-05-24 19:03:26 +00:00
Nils Wallménius
6485db3b37
Make a couple of private functions 'static'
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12729 a1c6a512-1295-4272-9138-f99709370657
2007-03-11 21:48:20 +00:00
Jonathan Gordon
4de9fbeda6
Use the user font in the quickscreen if it fits. Still uses
...
LANG_SYSFONT_x...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12587 a1c6a512-1295-4272-9138-f99709370657
2007-03-04 13:04:15 +00:00
Linus Nielsen Feltzing
224c0a13eb
Finally, the new button action system is here, thanks to Jonathan Gordon. Some button mappings have changed and other things may break. Comments should go to the forum, http://forums.rockbox.org/index.php?topic=5829.0 or the mailing list.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10582 a1c6a512-1295-4272-9138-f99709370657
2006-08-15 12:27:07 +00:00
Zakk Roberts
a0a01b38e2
Readjusted quickscreen code so that it now actually scales to larger LCDs. Get rid of 'left_right_text' argument - this also means that 'scroll bar' and 'status bar' look better in some languages.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9602 a1c6a512-1295-4272-9138-f99709370657
2006-04-11 06:38:10 +00:00
Zakk Roberts
2f943b054c
Enabled the quickscreen for iAudio X5. Globally, REC enters the menu and holding REC enters the quickscreen. Also moved the quickscreen #define to model config files, which simplifies the checking for it and makes checking more consistent. Cleaned up keymappings in quickscreen.h.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9590 a1c6a512-1295-4272-9138-f99709370657
2006-04-10 03:51:17 +00:00
Hristo Kovachev
23dc42ce45
Use the display->width property instead of the hardcoded LCD_WIDTH. Now the quickscreen is displayed correctly on the LCD remotes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9482 a1c6a512-1295-4272-9138-f99709370657
2006-04-04 07:01:24 +00:00
Zakk Roberts
15b2eefd6b
Updated quickscreens, now they look better than before while still retaining the ability to scroll - this is about as good as it gets until viewports are implemented. Also enabled the quickscreen for iPods.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9421 a1c6a512-1295-4272-9138-f99709370657
2006-04-02 10:41:16 +00:00
Zakk Roberts
b1b0e42ddd
Redesigned F2/F3 quick screens to put each option and its value on its own, scrolling line - fixes the problems with long strings the old design had.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9017 a1c6a512-1295-4272-9138-f99709370657
2006-03-12 23:45:40 +00:00
Brandon Low
8d5a6609a3
AB-repeat mode for software codecs. Accessible through menu as a repeat mode, with buttom mappings much like those on other rockbox targets for now.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8409 a1c6a512-1295-4272-9138-f99709370657
2006-01-21 23:43:57 +00:00
Marcoen Hirschberg
b0fee17d6e
waiting is over: initial unicode commit
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8169 a1c6a512-1295-4272-9138-f99709370657
2005-12-06 13:27:15 +00:00
Daniel Stenberg
b05eec8b1e
Big Code Police raid. Pretty pretty please, we do no macrofy simple
...
assignments and things just to make them appear as function calls. That makes
code harder to follow. Did some gcc4 warning fixes as well.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8163 a1c6a512-1295-4272-9138-f99709370657
2005-12-05 23:37:14 +00:00
Christi Scarborough
9589324082
Quick screen patch by _firefly_
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8065 a1c6a512-1295-4272-9138-f99709370657
2005-11-25 21:22:28 +00:00
Kevin Ferrare
b737775b32
fix for the quick screen, now remote is working properly
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8061 a1c6a512-1295-4272-9138-f99709370657
2005-11-24 00:33:00 +00:00
Kevin Ferrare
f57d0220dd
Adapted and commited Markus Kaufhold's remote hold icon on statusbar patch for iriver ; generic logo handler (now it's possible to have a different USB logo on main screen and on remote), made the quickscreen behave as it was before
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8044 a1c6a512-1295-4272-9138-f99709370657
2005-11-22 21:55:05 +00:00
Jens Arnold
fd02642ee0
Fixed truncated option strings for numeric settings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8043 a1c6a512-1295-4272-9138-f99709370657
2005-11-22 11:31:28 +00:00
Kevin Ferrare
74b6af93b1
Added multi-screen support for quickscreen (mostly rewritten from scratch) and USB screen ; just looking at the hour makes me think it could be buggy
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8039 a1c6a512-1295-4272-9138-f99709370657
2005-11-22 03:38:07 +00:00