Paul Louden
a14aface6b
Okay. Really fix the red. It's a little ugly at this point, and clearly
...
I shouldn't be coding in whatever my mental state is. But the intent was
not to remove the use of Select for pausing in Mpegplayer, for those who
like it. The ugliness can be removed if we want to go back to a single
pause button.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15736 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 06:09:17 +00:00
Paul Louden
0ffe935d32
Fix my rampant making of mistakes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15735 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 06:04:44 +00:00
Paul Louden
ad97b0437f
Allow use of either A or Select to pause in mpegplayer. This means you
...
can pause it the same way you pause music, but I've not removed the old
button since mpegplayer currently has plenty of buttons, and not many
functions.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15734 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 05:49:00 +00:00
Paul Louden
cdb0721e1a
More e200 keymap changes. In the FM screen, holding Play/Pause now does
...
the function previously assigned to the Record button.
As well, added Power as a cancel button in STD context, alongside Left,
as it was previously unused in this context. This improves an
inconsistency in the text editor.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15733 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 05:41:01 +00:00
Paul Louden
a02ed1dd75
Oops yet again. "Play" shouldn't be the previous button for stopping
...
FM radio, since long-play is no longer used as part of it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15732 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 05:16:12 +00:00
Michael Sevakis
72df71a26d
speex voice: Detect the end of a clip the right way.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15731 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 03:09:54 +00:00
Jonas Häggqvist
e66d60ce63
Fix case
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15730 a1c6a512-1295-4272-9138-f99709370657
2007-11-21 02:57:22 +00:00
Mustapha Senhaji
ec2f64ff27
FS#8107 Update the finnish translation by Jani Kinnunen.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15726 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 22:51:30 +00:00
Mustapha Senhaji
0aa3afa236
Update the french translation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15725 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 22:47:58 +00:00
Michael Sevakis
398d9fd8b4
Hopefully the last word on getting rid of yield_codecs loops (cut read chunk to 16kB). Sansa ata driver also didn't yield enough so buffering would starve other threads. Bump priority of audio thread to keep UI more responsive.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15724 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 22:45:46 +00:00
Nils Wallménius
acbd780239
Make id's created with the TALK_ID macro work in 64 bit sims
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15723 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 19:50:52 +00:00
Nils Wallménius
ade8ae9acb
Whitespace/indent/codestyle tweaks, should make no functional difference
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15722 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 13:53:29 +00:00
Michael Sevakis
fadbf0a6f7
Make threads responsible for explicit cancellation of their own boosted status. Sleeping and timeouts will no longer cancel it.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15709 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 03:44:25 +00:00
Paul Louden
31bf5cc8e5
Oops. Was thinking _TREE_ not _STD_, so no changes to the text editor
...
after all.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15708 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 02:11:13 +00:00
Paul Louden
92b6ee91fa
Fix keymapping inconsistencies generated by my previous keymap change,
...
this touches the FM Radio, Recording, and Text Editors.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15706 a1c6a512-1295-4272-9138-f99709370657
2007-11-20 01:59:06 +00:00
Marcoen Hirschberg
852cf58f36
access memcpy through the plugin api..
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15702 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 21:14:42 +00:00
Marcoen Hirschberg
2b30bf9eac
check separately if the preferences and the bookmark need to be saved
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15701 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 20:51:42 +00:00
Marcoen Hirschberg
77af93b2cd
write a correct bookmark file when the viewer loads so we can safely skip the write on exit
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15700 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 20:51:38 +00:00
Nicolas Pennequin
b766f11701
Oops, wrong define. Fixes the warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15699 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 18:25:13 +00:00
Nicolas Pennequin
1d86dbffe3
Accept FS#7901 by Akio Idehara: Fix gradient for scrolling lines when more than one line is selected
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15698 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 18:14:51 +00:00
Nicolas Pennequin
2ff513237d
Fix FS#8040 (Gather Runtime Data not working) the right way. Also a few cosmetic changes and comments.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15696 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 17:30:46 +00:00
Marcoen Hirschberg
cb62c97054
prevent useless file reads
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15695 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 16:46:39 +00:00
Nicolas Pennequin
51923703fd
Make the sim sleep between each file chunk, so that its buffering behaves more like that of a real target.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15694 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 16:37:55 +00:00
Nicolas Pennequin
d3b8245ca8
Second part of FS#8104 by Bertrik Sikken: Simplification of audio_track_count, audio_have_tracks and audio_have_free_tracks. This hopefully won't affect anything, but the semantics of the functions have changed slightly.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15693 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 16:37:52 +00:00
Thom Johansen
3947b0c632
FS #8179 . Small Musepack speedup for ARM.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15692 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 16:31:10 +00:00
Marcoen Hirschberg
4c62c00f99
don't save the viewer position if it hasn't changed
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15689 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 16:02:45 +00:00
Nicolas Pennequin
cfa6495356
First part of FS#8104 by Bertrik Sikken: Simplification and consistency improvement for the track index incrementations. There should be no functional change.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15688 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 15:52:25 +00:00
Michael Sevakis
4f2473db6c
Do the wait for the audio thread init in such a way to avoid an unlikely but possible roundabout deadlock. Not pretty but will suffice for the moment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15686 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 13:26:46 +00:00
Michael Sevakis
d6f2a54654
Make sure initial menu item is voiced at startup. Voice thread must wait for the audio thread to finish initializing hardware. A known issue at speex commit time (perhaps only by myself ;). The behavioral refinement time begins.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15682 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 11:59:52 +00:00
Linus Nielsen Feltzing
e75327b332
FS#7738 - Scroll wheel acceleration for iPod
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15681 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 11:05:54 +00:00
Jonas Häggqvist
f4fcbb3747
Bring the tarball more in line with SVN. (notably, include rbspeexenc)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15678 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 01:20:45 +00:00
Michael Sevakis
371ebe1160
libspeex: let DEBUGF work correctly for both core and codec builds
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15677 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 23:17:39 +00:00
Thom Johansen
c31818ccf0
Disable some UWB mode stuff and lost package handling in voice codec.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15676 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 23:17:25 +00:00
Jens Arnold
34e7fdbf37
The voice thread needs a tad bit more stack.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15674 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 20:55:43 +00:00
Michael Sevakis
1a41c8afee
SPC Codec: Run SPC emulation on COP and audio sample processing on CPU on dual-core PortalPlayer targets.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15673 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 19:03:45 +00:00
Nils Wallménius
e25a65a198
plugged timeout depends on CONFIG_CHARGING and is not needed for all targets
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15671 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 18:27:36 +00:00
Michael Sevakis
e8d81f9036
Fix some sim warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15670 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 17:34:33 +00:00
Michael Sevakis
99617d71ba
Make speex the new voice format for SWCODEC targets (non-Archos). Remove codec swapping and build speex voice decoding directly into the core binary.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15668 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 17:12:19 +00:00
Nils Wallménius
bcde33b60b
include members for backlight timeout for all targets in settings struct as we assume they are present in some places
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15666 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 17:04:46 +00:00
Nils Wallménius
fedc7dc0c9
#ifdef out some setting struct members when they are not needed, fix some comments
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15665 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 16:45:58 +00:00
Nicolas Pennequin
720cfe3954
Improve clearing of pictures in conditional constructs. This fixes improper clearing of pictures used in several conditionals or in nested conditionals (FS#7856).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15663 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 15:32:45 +00:00
Nils Wallménius
4acae4da03
Use the strrsplt function in one more place
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15662 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 14:12:01 +00:00
Nicolas Pennequin
9446226276
Erase lasttrack_id3 when end-of-playlist is reached. Fixes FS#8148.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15659 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 13:41:04 +00:00
Nils Wallménius
5386cc205f
Move a few #defines to target specific config files
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15658 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 13:33:27 +00:00
Nicolas Pennequin
572ecef486
Smarter conditional handling by storing the previous value. Updates are done only if the value has changed. This avoids unnecessary line or picture clearing, and should help fix some problems WPS creators were having.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15657 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 13:24:39 +00:00
Magnus Holmgren
47167e7022
In the recent bookmarks list, show playlist/directory name, in addition to the file name.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15656 a1c6a512-1295-4272-9138-f99709370657
2007-11-18 12:59:08 +00:00
Nils Wallménius
e39fc28fdc
Code police, declare pointers in .c and expor them
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15653 a1c6a512-1295-4272-9138-f99709370657
2007-11-17 14:25:02 +00:00
Stepan Moskovchenko
7f1fbe4af2
MIDI: Increase percision of synthesizer by a factor of 4 - makes certain parts (guitar bends, mostly)
...
sound more natural. Also, completely rearrange the order of operations in the delta computation. Had to
use long longs. Probably not a good idea for speed, but the order can be optimized more later.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15652 a1c6a512-1295-4272-9138-f99709370657
2007-11-17 06:39:02 +00:00
Thom Johansen
65458ee71c
Speex encoder specially tailored to create voice UI snippets. Small fixups to libspeex to allow it to be built.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15640 a1c6a512-1295-4272-9138-f99709370657
2007-11-16 15:35:37 +00:00
Michael Sevakis
88c4748a4b
Couple more tiny changes. :)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15639 a1c6a512-1295-4272-9138-f99709370657
2007-11-16 14:49:17 +00:00
Michael Sevakis
18330a050c
Missed a couple changes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15638 a1c6a512-1295-4272-9138-f99709370657
2007-11-16 14:34:15 +00:00
Thom Johansen
869a7e7ca6
Trim some stuff and move some defines to a more logical place.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15637 a1c6a512-1295-4272-9138-f99709370657
2007-11-16 14:30:51 +00:00
Michael Sevakis
5398125fb3
Use sized data types for audio data in the pcm buffer. Speed up the clipping routine.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15636 a1c6a512-1295-4272-9138-f99709370657
2007-11-16 14:26:05 +00:00
Adam Gashlin
8e5a39c58b
High score list needed to be redrawn on return from hold, put it in a seperate function to avoid duplicating code.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15634 a1c6a512-1295-4272-9138-f99709370657
2007-11-16 09:29:34 +00:00
Linus Nielsen Feltzing
34d08b235e
Fix buffer overflow in the title padding code (FS#8163)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15633 a1c6a512-1295-4272-9138-f99709370657
2007-11-16 08:18:08 +00:00
Nils Wallménius
65331f1749
Revert some changes that broke looping in midiplayer
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15631 a1c6a512-1295-4272-9138-f99709370657
2007-11-15 21:20:29 +00:00
Magnus Holmgren
7aa4ae6e45
Improved use of album name when locating the album art file: replace chars that are invalid in file names; double quotes to single quotes, other invalid chars to underscore (now only very long album names could cause a problem). Also removed some unecessary code and reduced stack usage a bit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15630 a1c6a512-1295-4272-9138-f99709370657
2007-11-15 20:22:03 +00:00
Nils Wallménius
f801714572
Actually check if a voice file has the correct version before using it
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15629 a1c6a512-1295-4272-9138-f99709370657
2007-11-15 19:32:15 +00:00
Brandon Low
d1c6d53962
I'm a retard, this is definitely more correct
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15627 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 22:34:32 +00:00
Brandon Low
02467cffa0
Might fix FS#8158, I was unable to reproduce so no guarantee.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15626 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 22:29:26 +00:00
Nicolas Pennequin
83e190bcef
Hopefully fix the compile errors.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15625 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 22:18:51 +00:00
Nicolas Pennequin
31f76116f1
Make the WPS parser stricter with invalid parameter lists. It will now reject them instead of ignoring them (this includes the second parameter to %m|x|, which is invalid and now causes a failure). Also change the debugging code in order to allow more precise error messages, including the faulty token's index and description. Finally, add a few missing token description and fine-tune the #ifdefs.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15624 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 22:02:41 +00:00
Alessio Lenzi
7ddefe2a5d
Updated italian translation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15623 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 21:16:06 +00:00
Magnus Holmgren
92d99dfff5
FS#8126: Translated voice strings for Swedish, with a few changes by me.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15621 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 17:48:18 +00:00
Barry Wardell
34288fea43
FS#8157: H10 RTC alarm with some changes by me. The settings keymap had to be changed slightly, but it seems to work better for all setting screens with the new keymap. Thanks to
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15620 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 16:53:31 +00:00
Thom Johansen
2bb48eb8ed
Throw away the first samples to come out of the decoder to account for encoder latency.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15618 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 14:43:32 +00:00
Thom Johansen
8082148200
Sync latest Speex stereo changes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15617 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 12:11:13 +00:00
Linus Nielsen Feltzing
017e148655
Add midi/SOURCES
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15616 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 10:36:49 +00:00
Michael Sevakis
d3027d424b
Build libspeex for core voice on SWCODEC. Development phase - not currently utilized.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15615 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 10:31:57 +00:00
Thom Johansen
85b325fdb9
Sync Speex to SVN. Disable stereo compatibility hack since we don't needed it and it produced warnings. Remove unneeded math.h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15613 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 02:15:56 +00:00
Thom Johansen
91f618f1ba
Remove unneeded math wrappers. Clear state structs in decoder init. Start initial work at stripping away parts of Speex in preparation for its use as a statically linked voice UI codec.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15612 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 00:55:05 +00:00
Thom Johansen
d75a5486e6
New Speex stereo code in libspeex and speex.c, stereo should be more robust now. Remove last floating point code in speex.c and remove some unused stuff.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15611 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 00:46:49 +00:00
Nicolas Pennequin
f554e00b61
Allow setting a margin on a non-scrolling line by using %m|margin| instead of %s|margin|. This allows to easily place dynamic info next to album art.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15610 a1c6a512-1295-4272-9138-f99709370657
2007-11-14 00:45:04 +00:00
Nicolas Pennequin
bb999f9eb3
Check that the WPS uses album art before clearing its position on conditional. Without that check, having a conditional as very first token would cause undesired clearing. Thanks to PaulJam for spotting.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15609 a1c6a512-1295-4272-9138-f99709370657
2007-11-13 22:56:42 +00:00
Magnus Holmgren
6e06825fa0
Improve insert of playlists. Decode M3U files using current code page and strip any BOM. Also remove a few tabs.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15608 a1c6a512-1295-4272-9138-f99709370657
2007-11-13 18:49:20 +00:00
Alessio Lenzi
4de5b07cb4
Sansa C200 keymap: In the bookmark selection screen, move the delete command from "UP" to "REC" button.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15606 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 22:43:06 +00:00
Dave Chapman
a0f3443eab
Remove some stray ^Ms
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15605 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 22:10:36 +00:00
Dave Chapman
f6ef46b73f
FS#8135 - add an optional "left margin" parameter to the %s WPS tag - e.g. %s|100|. This patch uses parts of the scroll-margins patch (FS#2954), but is much smaller, only offers a left-margin, and only affects the WPS code.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15604 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 21:34:01 +00:00
Dave Chapman
d911481687
Remove unused x11 and win32 simulator rules
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15602 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 20:45:22 +00:00
Magnus Holmgren
a703930d84
Sansa E200 keymap: In the bookmark selection screen, move the delete command from play to rec.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15601 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 19:51:35 +00:00
Nicolas Pennequin
8537cbf091
Add detection for a previously ignored error case: a conditional token is present but no conditional start token (e.g. "%?C%al|>"). This would cause an inifnite loop in the displaying code. Thanks to markun for making the mistake and reporting it ;)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15598 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 18:43:38 +00:00
Nicolas Pennequin
87e5b1193c
The error checking for bitmap handling in bufopen was serioulsy broken, as loading a huge bitmap showed. Fix it and reorganise the code slightly.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15597 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 15:16:41 +00:00
Nicolas Pennequin
1480d078e7
Add an error check, just to be safe.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15596 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 14:26:47 +00:00
Robert Kukla
e1c45d227b
FS#6944 - honour the default codepage setting when reading cue sheets
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15595 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 12:39:56 +00:00
Nicolas Pennequin
81dedee7d0
Various album art improvements:
...
* Make the album art display tag static instead of dynamic, making it be drawn less often, which is good.
* Add the possibility of clearing the album art bitmap instead of drawing it, and use this abaility when the display tag is inside a conditional construct.
* Add the album art display tag to wps_debug.c.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15592 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 01:31:42 +00:00
Nicolas Pennequin
4963925767
Fix another NULL pointer dereference crash.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15591 a1c6a512-1295-4272-9138-f99709370657
2007-11-12 00:17:55 +00:00
Nicolas Pennequin
e71bc67d94
Fix an issue that appeared in r15577, where skipping back to a track that has no audio data left, but still has its metadata and album art, would fail. The fix is to also clear the filesize member (as it should have been previously) to force a rebuffer when skipping back. To prevent the album art bitmap from flashing on the back skip, the whole track info struct is cleared when the track isn't needed anymore, i.e. after the PCM track change.
...
Also a slightly unrelated but trivial change: only load album art if it's not already loaded.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15588 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 21:27:18 +00:00
Nicolas Pennequin
95db8f8022
Load the album art before the codec because find_albumart would yield to the codec, which would start requesting data before the audio handle is ready.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15584 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 20:09:13 +00:00
Barry Wardell
c495cdae59
FS#8046: H10 FM tuner support. Thanks to Przemyslaw Holubowski for doing the hard work in figuring out how to communicate with the tuner.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15578 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 16:00:33 +00:00
Nicolas Pennequin
496027d8bb
* Make the album art be updated on PCM track change, not codec track change (changes in audio_current_aa_hid).
...
* On codec track change, if not all the audio data is present, only get rid of the audio data and not all the track's handles. This will prevent alum art from disappearing on codec track change after resuming playback (changes in audio_check_new_track).
* Add audio_finalise_track_change() to handle what happens after the PCM track change (no functional change here).
* Add some comments about how the track transition works.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15577 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 15:50:52 +00:00
Nicolas Pennequin
5e0e2391ff
Really fix red this time.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15576 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 13:28:24 +00:00
Nicolas Pennequin
a384fb6d8a
Fix red on the iFP.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15575 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 13:15:36 +00:00
Nicolas Pennequin
cf37f4c079
Fix red.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15573 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 12:52:07 +00:00
Nicolas Pennequin
9d4bed7ff0
Album art support. Based on FS#3045, but heavily modified to adapt to MoB and for cleanness.
...
The cover pictures are loaded from external bitmaps. JPEG and embedded art are not supported. The pictures will only be drawn on the main display. There is no resizing but it is possible to specify the WPS bitmap size in the bitmap names (e.g. cover.100x100.bmp).
The bitmaps are stored in the main buffer and read directly from there. Currently, duplicate bitmaps will simply be present several times in the buffer, but this will be improved.
To enable for a target, #define HAVE_ALBUMART in its config file.
For more information, see the wiki page: http://www.rockbox.org/wiki/AlbumArt .
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15572 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 12:29:37 +00:00
Nils Wallménius
0fd4c2e455
Rearrange logic in the synthVoice loop to do less tests and remove need of a struct member for a small speedup, move some memory lookups out of the loop for a small speedup, further cosmetic changes to the synthVoice function. Change isUsed to a bool for clearer logic and also a tiny speedup
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15563 a1c6a512-1295-4272-9138-f99709370657
2007-11-11 01:02:45 +00:00
Karl Kurbjun
d185f9eba8
Fix the Gigabeat red and move it's hw specific code into the target tree
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15562 a1c6a512-1295-4272-9138-f99709370657
2007-11-10 23:13:27 +00:00
Karl Kurbjun
d3c0a7f169
Change the way the UART recieves data and how buttons pressed are processed. Also move some of the debug menu into the target tree and allow rockblox to build when the screen is rotated.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15560 a1c6a512-1295-4272-9138-f99709370657
2007-11-10 22:12:54 +00:00
Nicolas Pennequin
a677678e31
Fix a possible NULL pointer dereference I introduced in r15503 by making an unwise assumption. This would cause crashes on track skip in certain (very unlikely, I think) situations.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15557 a1c6a512-1295-4272-9138-f99709370657
2007-11-10 18:22:55 +00:00
Thom Johansen
a953e65dbd
Remove C++ style comment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15556 a1c6a512-1295-4272-9138-f99709370657
2007-11-10 15:43:40 +00:00
Thom Johansen
1730e406ed
Strip out a large unneeded portion of the Speex stereo decoding function, and port the rest of it to fixed point. Disable the unneeded stereo float decoding function. Correct the output buffer size and change some minor syntactic stuff in speex.c
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15554 a1c6a512-1295-4272-9138-f99709370657
2007-11-10 14:57:49 +00:00