The code was broken in a subtle but crucial way: storage idle
callbacks are oneshot so after the first flush everything would
stay in the buffer forever and would never be written to the disk
thus resulting into many events being lost. This changed correctly
registers the idle callback each time the buffer is not empty.
Note that the idle storage code checks if a callback
has is in the queue already so we don't register twice.
Change-Id: Ifdf331d4b757e05b8a6902bf5926cbc7689f5109
The quickscreen calls settings_apply() and the crossfeed code wasn't
checking that the right crossfeed was set before updating the filter
for the custom setting, which was overwriting the Meier crossfeed
data (custom and Meier share the same data space).
Change-Id: Ifaa2f46fe062d4497681a2dd0d5068ec906c96a3
This small patch aims to fix a trivial
problem: when exiting the "cube" plugin
in a hosted environment (at least on YP-R0)
this caused the whole program, and consequently
also the player, to be turned off.
I don't know why the exit() function was
used here...
Change-Id: I7b58d4ca5c01c230f2c53204b51ec553c5fe1287
Reviewed-on: http://gerrit.rockbox.org/321
Reviewed-by: Bertrik Sikken <bertrik@sikken.nl>
Remove the hackish elf_translate_addresses which should not have
existed in the first place, on write always compute the physical
address of a section using elf_translate_virtual_address which
makes it possible to specify any virtual to physical mapping and
fail nicely if there is none.
Change-Id: I4f436945e90280a6fd9430de6c642dbeb8e23d40
Implement standard values and functions to operate on power control
register. This allow to modify both reporting rate and sleep mode
in order to save power.
Change-Id: I2bdffd4160e10eec488eb5e19de8a2a258ddbb04
Reviewed-on: http://gerrit.rockbox.org/529
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
Using a better resolution causes havoc in the user interface
because it doesn't properly handle steps and people start to
believe I am responsible for all this mess.
Change-Id: I02b68dce5802692efde3da226eeeb49e4995f97a
These nearly identical files are multiplying like rabbits as PP targets
are added and make SoC-related changes a PITA. Just include the master
.lds file from the target one as was done for bootloader USB.
Change-Id: I65e9e653030f0688b1728e32ada16abf2932e029
Last core update for keymaps and manual. Manual is now 100% complete
Change-Id: I9ad33206ecea41a88cba7a355da911fa7ab0455d
Reviewed-on: http://gerrit.rockbox.org/521
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
Rename STOP command to EXIT, introduce ATEXIT, this gives better
control over the exit of the stub. Add stmp implementation.
Change-Id: I45442c8b88b9330d12ef439417ca5ffa1520477a
1) Now that recording is working a few keymaps update are required.
2) also implement the radio.c file so that fm dedicated keymaps
works.
3) implement some missing fm keymaps
4) manual updated accordingly
Change-Id: I40be3e245853ccb9ed7a5bc5a76fe4ed90772272
Reviewed-on: http://gerrit.rockbox.org/513
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
After the recent soft lock implementation for FM, this adds the
related information in the manual for Fuze+ and Clip/clip+ (basicaly it's a
copy/paste from WPS section).
Change-Id: I23c39d7b3763eb2b9897187baa3a9b2663003cf7
Reviewed-on: http://gerrit.rockbox.org/495
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
A few keymaps hint were wrong, this correct them:
- database/filemanager on cancelling songs insertion
- alarm clock
- set alarm
Change-Id: Ifb50a9452c208a7d5c28bdac96c825030b943c25
Reviewed-on: http://gerrit.rockbox.org/508
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
an incorrect value caused the shuffle icon to not display the correct status while true by way of pushing the image to be displayed far from the bounds of its viewport.
Change-Id: I2bd5db05b053952306d62f9cbd0d13d720141e58
Reviewed-on: http://gerrit.rockbox.org/517
Reviewed-by: Thomas Martitz <kugel@rockbox.org>
Set an alternative touchpad sensitivity setting if
the 3 following variables are defined:
DEFAULT_TOUCHPAD_SENSITIVITY_SETTING
MIN_TOUCHPAD_SENSITIVITY_SETTING
MAX_TOUCHPAD_SENSITIVITY_SETTING
aside from the usual:
HAVE_TOUCHPAD
HAVE_TOUCHPAD_SENSITIVITY_SETTING
In such a case the setting will allow the user to set a precise
value within the defined range unstead of the boolean choice
HIGH/NORMAL
Change-Id: Iba8140285317077381191e494df0d3f6ab556872
Reviewed-on: http://gerrit.rockbox.org/123
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
Completely rewrite the Mafile, properly put the usb driver in its
own file and the target specific files in a subdirectory.
Change-Id: Iaeee0128e021d5dad76b4d6035a63e33e2d946c1
This change activate the newly implemented fm softlock (thanks to
Pamaury) on the FM Ondio target. Thanks to Lebellium for testing.
Change-Id: I903f05be892e7537a34ba40bc0f3c65541a497a4
Reviewed-on: http://gerrit.rockbox.org/498
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
* Remove explicit tracking of elapsed time of previous track.
* Remove function to obtain auto skip flag.
* Most playback events now carry the extra information instead and
pass 'struct track_event *' for data.
* Tweak scrobbler to use PLAYBACK_EVENT_TRACK_FINISH, which makes
it cleaner and removes the struct mp3entry.
Change-Id: I500d2abb4056a32646496efc3617406e36811ec5
