Commit graph

14311 commits

Author SHA1 Message Date
Nicolas Pennequin
db15e5d3ba Add an error check in get_mp3_metadata()
Check whether getonglength() succeeded or not, to prevent get_mp3_metadata()
from returning a success value when in fact it failed.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14327 a1c6a512-1295-4272-9138-f99709370657
2007-08-14 11:56:14 +00:00
Nicolas Pennequin
6a92e475ac Make get_metadata act on a struct mp3entry rather than a struct track_info.
This should make it easy to use a buffer handle to put the ID3 data in.
The changes in get_metadata are mostly search and replace. The only thing
it actually used to do on the struct track_info was set taginfo_ready to
true.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14326 a1c6a512-1295-4272-9138-f99709370657
2007-08-14 11:56:13 +00:00
Will Robertson
7b055ab665 Updated the Japanese lang file to the new lang format. Many strings still missing, but provides a better starting point for anyone wanting to do a proper sync.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14325 a1c6a512-1295-4272-9138-f99709370657
2007-08-14 05:38:46 +00:00
Peter D'Hoye
043c966ebf Add another file extension viewing option that mimics the old behaviour and make this default. Also update Dutch lang file and manual for this.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14324 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 23:11:30 +00:00
Jonas Häggqvist
62b0d4b685 Add a warning not to use the 64MB build on a an Ipod with 32MB RAM.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14323 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 23:09:49 +00:00
Peter D'Hoye
4060a8c4f7 Now get those keywords right...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14322 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 22:37:44 +00:00
Peter D'Hoye
a5d4d67763 Also keep the backlight on in mpegplayer when plugged in. Fixes FS #7584. Created two helper functions for this, because this issue also exists in other plugins (to do). The helper functions are in the pluginlib in helper.[ch], where other common stuff can be put.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14321 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 22:31:11 +00:00
Jonas Häggqvist
07a09041d6 Updated Danish language.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14320 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 21:39:45 +00:00
Peter D'Hoye
7ac9a5febe Fix a typo, thanks to Alistair Marshall for spotting (FS #7594)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14319 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 21:31:55 +00:00
Peter D'Hoye
f87a32f61b Update the manual for the new file extension setting
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14318 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 21:07:40 +00:00
Marianne Arnold
f522304a95 Vector drawing of the 2nd generation Ipod, including a png and pdf version too so it can be used in the 1st and 2nd gen Ipod manual.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14317 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 20:31:33 +00:00
Peter D'Hoye
bbb8c3fe6c While I'm at it, update Dutch language again ;)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14316 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 20:19:16 +00:00
Peter D'Hoye
37fd439fc0 Accept FS #7346 and take it a whole step further. Gives a separate setting to control the displaying of file extensions: off, on, or only how unknown extensions.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14315 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 19:29:49 +00:00
Jens Arnold
1e28f59f26 Mini G1: Enabled backlight fading. Attn. Mini G1 voice users: a new voice file is required.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14314 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 17:57:34 +00:00
Robert Kukla
2ae0d63c88 corrected logic in expression of jdgordon's r14187 commit; should fix FS#7590. Tidied up exit paths while I was at it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14313 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 13:53:33 +00:00
Jonas Häggqvist
41a5776539 Two oops commits for the price of one.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14312 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 12:44:45 +00:00
Jonas Häggqvist
8a6383884b More elegant (and robust) check for program availability.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14311 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 12:31:18 +00:00
Nils Wallménius
45ffc87030 Const-police, use less bytes where possible, get rid of duplicated backlight timeout array
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14310 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 12:21:27 +00:00
Jonas Häggqvist
58537b43e6 Voice related changes:
- It's now possible to select multiple languages to build
- Added encoder and TTS engine configuration to configure (per-language)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14309 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 12:21:16 +00:00
Nils Wallménius
414ee9fcc5 Fix wheel in sansa simulator, closes FS#7591
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14308 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 09:43:50 +00:00
Barry Wardell
121af38dee Simpler fix for rockboxdev.sh make/gmake detection in Mac OS X/Darwin.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14307 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 00:43:01 +00:00
Barry Wardell
7c371f6a8c Accept FS#6499 - fix rockboxdev.sh make/gmake detection in Mac OS X/Darwin. Thanks to Lenny Koepsell.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14306 a1c6a512-1295-4272-9138-f99709370657
2007-08-13 00:10:00 +00:00
Peter D'Hoye
4a934ac91f Update Dutch lang file
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14305 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 22:34:54 +00:00
Peter D'Hoye
05221a9d87 Convert IDs to strings before using them, fixes FS #7564
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14304 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 21:59:42 +00:00
Nils Wallménius
542ff8b8c3 Remove unnecessary sim stubs and includes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14303 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 21:20:54 +00:00
Dominik Riebeling
26eb048e7a simplify a bit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14302 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 20:40:50 +00:00
Nils Wallménius
f14a492c6b Save a few bytes and make types more consistent
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14301 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 20:22:08 +00:00
Nils Wallménius
f73d346ba4 Fix FS#7587, the splash when building the database told the user to press the wrong button to return
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14300 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 20:00:37 +00:00
Nils Wallménius
f28da1a35a Enable a lot more features for simulators and add stubs where necessary, simulators should now work with identical lng and voice files as the respective target
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14299 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 19:49:03 +00:00
Dominik Riebeling
90c40b7fea use alternating row colors in list views.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14298 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 19:18:11 +00:00
Dominik Wenger
c1e0932eca RbutilQt: Ups, another forgotten file.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14297 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 16:53:15 +00:00
Dominik Wenger
e40b4df140 rbutilQt:Ups.. the forgotten uninstall files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14296 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 16:47:35 +00:00
Jens Arnold
451dec17fe Clock: * Correct aspect ratio on archos recorders (target only, checking for LCD type). * Don't let the hands vanish if they are thin.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14295 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 15:50:07 +00:00
Robert Kukla
0bd027aa1a ignore comments containing iTunes 7 gapless data; should solve issues reported in http://forums.rockbox.org/index.php?topic=12048.0 and http://forums.rockbox.org/index.php?topic=12053.0
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14294 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 14:13:33 +00:00
Jens Arnold
ea88571493 Fix red simulator builds. queue_broadcast() was missing...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14293 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 11:59:06 +00:00
Jens Arnold
671f5d4412 Removed special X5 backlight handling, and replaced it with a generic system that makes the backlight light up on shutdown and not time out unless it's completely disabled in the current player state.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14292 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 11:18:52 +00:00
Jonathan Gordon
07a7d47cc1 Revert my filetypes commits from today. the nvram buffer is 44bytes of which 43 are currently being used. We need to figure out what to do about this.
So in the mean time, set the MAX_FILETYPES to a huge value so we don't have to worry about this for a long while.

This build shold be safe to use again. If you downloaded a build after r14286 make sure you grab a new one


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14291 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 09:53:41 +00:00
Jonathan Gordon
7cb80a2a70 Fix a problem with the nvram settings which meant adding new items to the end needed the version bump (they dont anymore, but I'm bumping it now anyway to save some bug reports)
Also operator precedence fixing.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14290 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 07:22:38 +00:00
Dave Bryant
bcf97a4801 Move WavPack metadata parsing to its own file and add handling of non-standard sampling rates
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14289 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 06:36:06 +00:00
Jonathan Gordon
53095684f7 Flip the balance setting list on scrollwheel targets so it feels more natural
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14288 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 02:18:12 +00:00
Jonathan Gordon
eff14cceec Change the way the MAX_FILETYPES define works. It now allocates enough filetype icons as it needed last boot + 8, this means we should never have to edit the define again.
If you get the "filetypes array full" splash, do a clean reboot and it shuold go away. if it doesnt make sure you file a bug report and let us know you did reboot and it stayed there... it means that define does actually need increeasing.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14287 a1c6a512-1295-4272-9138-f99709370657
2007-08-12 02:10:45 +00:00
Jonas Häggqvist
ca42a2f0dd Only allow make voice if voice building has been configured.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14286 a1c6a512-1295-4272-9138-f99709370657
2007-08-11 22:41:15 +00:00
Jonas Häggqvist
dbeee722db Use md5sum of the string for pool clip filenames rather than the string itself. Avoids problems with illegal characters. This should be a proper fix of FS#7575 unless there are other, similar issues.
Also correctly check number of arguments to genvoice.sh.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14285 a1c6a512-1295-4272-9138-f99709370657
2007-08-11 22:16:50 +00:00
Magnus Holmgren
9824dac9e5 Fix bug that caused the bookmark autoload screen to always resume the first bookmark, even if another was selected. Also remove a bogus comment.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14284 a1c6a512-1295-4272-9138-f99709370657
2007-08-11 14:44:05 +00:00
Nils Wallménius
e8361ef2c4 Fix FS#7575 and remove an obsolete comment
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14283 a1c6a512-1295-4272-9138-f99709370657
2007-08-11 12:16:42 +00:00
Jonathan Gordon
6dbd02bcb5 mandlebrot is a demo, not a game
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14282 a1c6a512-1295-4272-9138-f99709370657
2007-08-11 10:29:28 +00:00
Jonathan Gordon
d0af35464c Accept FS#7558 - updated russian translation
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14281 a1c6a512-1295-4272-9138-f99709370657
2007-08-11 09:59:09 +00:00
Marianne Arnold
31ea4ba253 Fix width of the '1' and the '7', so that they have the same width as the other numerals and e.g. playing time in the wps doesn't wobble anymore.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14280 a1c6a512-1295-4272-9138-f99709370657
2007-08-11 09:29:31 +00:00
Jens Arnold
4211011b82 Package test plugins as apps, instead of munging them into a file 'test', leaving only the last found one available with no proper extension to run it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14279 a1c6a512-1295-4272-9138-f99709370657
2007-08-11 05:31:40 +00:00
Peter D'Hoye
9bc2c47ada Dutch language file update
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14278 a1c6a512-1295-4272-9138-f99709370657
2007-08-10 23:41:14 +00:00