Commit graph

27945 commits

Author SHA1 Message Date
Michael Sevakis
b15aa47c56 All kernel objects in code shared amongs targets (core, plugins, codecs) should be declared SHAREDBSS_ATTR as any core could potentially touch them even though they seem only to involve threads on one core. The exception is target code for particular CPUs where proper allocation is fixed. playlist.c was a little odd too-- use one mutex for the current playlist and a separate one for created playlists (still pondering the necessity of more than one).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29305 a1c6a512-1295-4272-9138-f99709370657
2011-02-14 11:27:45 +00:00
Michael Sevakis
8f14357064 Code police buffering.c a little - use already predominant style - shorted lines over 80 cols.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29304 a1c6a512-1295-4272-9138-f99709370657
2011-02-14 09:18:58 +00:00
Michael Sevakis
6938255b6b Buffering: tin cup. Update threading structure and handle rebuffer more reliably on buffer thread using a single message send.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29303 a1c6a512-1295-4272-9138-f99709370657
2011-02-14 08:36:29 +00:00
Michael Sevakis
0fde635fb0 Leave a gap between all handles because ringbuf_add_cross interprets equal pointers as empty, corruption guard check could fail to detect overlap if buffering ran right up to the next handle and it gets asked to buffer again before freeing the following handles (adds a byte on average). Storage alignment on handle reset must at times avoid alignment increments if after a stopped rebuffer, the handle was shrunk too close to the next one or the reading position in a prior rebuffer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29302 a1c6a512-1295-4272-9138-f99709370657
2011-02-14 02:14:26 +00:00
Alex Parker
f8a4fbc843 FS#11937 by Marcin Bukat - update Polish translation.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29301 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 21:42:32 +00:00
Andree Buschmann
c0b0cd5905 Do not fiddle with audiobuf in talk_init() when no voice file is present. Avoids stopping of audio playback when changing languages without using voice files. Closes FS#10479.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29300 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 21:30:13 +00:00
Andree Buschmann
46dbe3036c Explicitly say 'minutes' when speaking the runtime, fixes FS#11934.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29299 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 19:14:43 +00:00
Andree Buschmann
f7c6034728 Update german translation.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29298 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 17:49:24 +00:00
Nils Wallménius
4ca36ca90c Explicitely say 'minutes' when speaking the battery time, fixes FS#11932.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29297 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 16:02:17 +00:00
Dave Chapman
82140061a6 Update Android README in line with configure changes from r29286
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29296 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 13:26:16 +00:00
Thomas Jarosch
fb790be29e Fix SDL detection on Nokia N8xx
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29295 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 11:57:32 +00:00
Michael Sevakis
efdf49668e Needed to do a few more things to have r29291 correct.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29294 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 11:02:37 +00:00
Alex Parker
78a71d4701 FS#11928 by Marek Salaba - Update of Czech language
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29293 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 10:46:48 +00:00
Alex Parker
0c9e0dfeea FS#11929 by Gabriel Maia - Portuguese translation update.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29292 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 10:46:43 +00:00
Michael Sevakis
b474d0d98f Change add_handle to never have side effects on the buffer if it fails. It actually seems ok and I'm not sure if's responsible for anything, but it's more sane and keeps buffer_handle from regressing buf_widx later if buffering cur_handle.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29291 a1c6a512-1295-4272-9138-f99709370657
2011-02-13 10:44:13 +00:00
Dave Chapman
e8e0ca2c57 Use target names instead of model numbers in #if statements - nowhere else uses MODEL_NUMBER.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29290 a1c6a512-1295-4272-9138-f99709370657
2011-02-12 21:28:23 +00:00
Michael Sevakis
50c727ce7a Oops. Put back some changes to go only with others.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29289 a1c6a512-1295-4272-9138-f99709370657
2011-02-12 12:33:43 +00:00
Michael Sevakis
3c81bf0c13 Fix move_handle in buffering. Calculating wraps by buffer_len - 1 is incorrect. Switch handle movement to memmove calls exclusively.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29288 a1c6a512-1295-4272-9138-f99709370657
2011-02-12 12:18:09 +00:00
Dave Chapman
b27de9fddc Remove unused variable "need_full_path" - it was removed in r28592
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29287 a1c6a512-1295-4272-9138-f99709370657
2011-02-12 00:37:22 +00:00
Dave Chapman
9e638c7bc8 FS#11924 - Use separate targets for RaaA devices. This changes tools/configure to present the (currently four) possible RaaA targets as separate menu items instead of a single "Application" item with a follow-up question.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29286 a1c6a512-1295-4272-9138-f99709370657
2011-02-11 19:51:29 +00:00
Michael Hohmuth
751e922783 Use generic keyboard actions rather than the device-dependent
\ButtonLeft / \ButtonRight

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29285 a1c6a512-1295-4272-9138-f99709370657
2011-02-11 18:45:04 +00:00
Michael Hohmuth
97ba12e336 Describe autoresume in the manual.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29284 a1c6a512-1295-4272-9138-f99709370657
2011-02-11 17:17:39 +00:00
Andree Buschmann
3f377e568e Use menu layout for sleep timer that is consistent to other timers. Closes FS#11923.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29283 a1c6a512-1295-4272-9138-f99709370657
2011-02-11 16:15:11 +00:00
Andree Buschmann
5ead6a6056 Submit FS#11926, calibrate charge curve for e200v1. Thanks to Martin Ritter.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29282 a1c6a512-1295-4272-9138-f99709370657
2011-02-11 15:58:39 +00:00
Frank Gevaerts
4421cfedf0 Make sure there is a logo for LCD_WIDTH>480 && LCDWIDTH<600 (useful for 600x1024 LCDs)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29281 a1c6a512-1295-4272-9138-f99709370657
2011-02-11 11:28:21 +00:00
Michael Hohmuth
a5303765ec autoresume: Match full directory path names only in autoresumable()
Removed genre-tag matching (considered too fragile for real-world use).

Removed substring matching for file names.  To avoid unintended
matches, the search pattern now must match the file's full dir name
(or a parent directory thereof), anchored in the root directory.

Search strings now must be delimited with ":" rather than ",".  The
default list of directories is "/podcast:/podcasts" (case-insensitive).

Made implementation somewhat more efficient (don't use strtok -> no
need to copy the string to private storage (stack) before tokenizing
it).

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29280 a1c6a512-1295-4272-9138-f99709370657
2011-02-11 00:20:03 +00:00
Michael Sevakis
bdec638b9b Always do proper mp3entry copying instead of using bufread directly. Add bufreadid3() helper.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29279 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 22:03:39 +00:00
Alexander Levin
82a8ad643a Fix a couple of typos in the comment in english.lang. Whether the comment is correct is another question which is not the subject of this commit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29278 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 20:55:39 +00:00
Andree Buschmann
57ca48458f Fix test plugin build.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29277 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 20:20:12 +00:00
Michael Sparmann
40e76916cd iPod Nano2g/Classic clickwheel: Configure GPIO pins as Hi-Z while hold switch is engaged
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29276 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 19:13:30 +00:00
Michael Sevakis
edfff8a5ef audio_peek_track should copy the struct mp3entry instead of pointing directly into the buffer. Despite the dire warning, caller does in fact yield/sleep and its usage is too nonlocalized to control that reliably.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29275 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 10:26:07 +00:00
Michael Sparmann
6f9d2ad130 Fix more red. Two had been hiding.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29274 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 10:22:44 +00:00
Michael Sparmann
42c0c9a619 Fix red
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29273 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 10:16:27 +00:00
Michael Sparmann
cd8e8419f7 iPod Nano 2G: Fix current leak through clickwheel GPIOs when clickwheel is powered down
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29272 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 10:10:27 +00:00
Michael Hohmuth
e93713ba3c autoresume: Simplify configuration option for resume on automatic
track change

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29271 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 09:37:58 +00:00
Michael Sevakis
88d91faba5 buffering: Don't execute move-handle-ony case if handle is of metadata type (atomic) and must be kept fully buffered. Manage handle corruption guard and handle buffering with one set of logic which allows reading of the maximum amount of data without overflow. 'FIXME' regarding handle corruption guard is really part of expected operation when thread that does the handle closing hasn't yet performed the delegated task before rebuffering starts.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29270 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 05:56:21 +00:00
Michael Sparmann
2007d67bce Fix red (remove accidentally committed debugging code)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29269 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 00:35:46 +00:00
Michael Sparmann
fdf092ebd3 iPod Classic: Do boosting the right way round ;-)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29268 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 00:30:42 +00:00
Michael Sparmann
2db7f00255 iPod Classic: Fix current leak through clickwheel GPIOs when clickwheel is powered down
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29267 a1c6a512-1295-4272-9138-f99709370657
2011-02-10 00:14:21 +00:00
Alex Parker
40531597f3 Manual: We now support embedded JPEG album art in ID3v2 tags.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29266 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 22:12:37 +00:00
Michael Sparmann
44870b7415 iPod Classic: Enable boosting by switching the CPU between 1x and 2x AHB clock
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29265 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 21:45:57 +00:00
Michael Sparmann
acf54bed55 iPod Classic: This time really fix the hold switch. Read it out through the power manager, and cache the result for 100 milliseconds because the power manager doesn't like being spammed
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29264 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 21:39:40 +00:00
Thomas Martitz
bf1ca7041e Hopefully all green now
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29263 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 20:51:11 +00:00
Thomas Martitz
c64e5e675a Fix remaining reds.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29262 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 20:38:36 +00:00
Thomas Martitz
86cab2e27a Disable buffering codecs (and code generally) on RaaA.
It's not useful to do it since you need to write back the code to disk to be able to load it from memory, it also requires writing to an executable directory.
Keep it for the simulator for the sake of simulating.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29261 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 20:27:23 +00:00
Thomas Martitz
82eec87dd6 Fix red. Not all targets have album art support.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29260 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 20:22:55 +00:00
Thomas Martitz
f577a6a22c Embedded album art support in MP3/ID3v2 tags.
- Support is limited to non-desync jpeg in id3v2 tags. Other formats (hopefully) follow in the future.
- Embedded album art takes precedence over files in album art files.
- No additional buffers are used, the jpeg is read directly from the audio file.

Flyspray: FS#11216
Author: Yoshihisa Uchida and I

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29259 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 20:13:13 +00:00
Michael Sevakis
0d902c8c54 Buffering should align itself and not rely on buffering_reset parameters when storage alignment matters so that wrapped reads maintain alignment.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29258 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 09:30:09 +00:00
Michael Sevakis
19ea72ff63 buffering: Fix a case that could allow widx to fully wrap to ridx and overflow the ringbuffer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29257 a1c6a512-1295-4272-9138-f99709370657
2011-02-09 08:44:37 +00:00
Thomas Jarosch
06023f3110 debian directory needed to build maemo packages
The build rules in the debain directoy are currently
maemo specific and won't build on debian.

Later on we could add automatic distribution detection
and switch the build rules based on that if someone
wants to build a generic RaaA package for debian.

Maemo binary packages get build like this (in scratchbox):

dpkg-buildpackage -rfakeroot -sa

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29256 a1c6a512-1295-4272-9138-f99709370657
2011-02-08 22:09:36 +00:00