Bertrik Sikken
e15f8a21a9
Made source files #include the header file that they implement to make sure they are in sync. Made some local functions static.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17312 a1c6a512-1295-4272-9138-f99709370657
2008-05-03 08:35:14 +00:00
Jonathan Gordon
fa64dbb525
So, I was skimming the irc logs from my 3 day absense and I was pinged about a bug in the simplelist code and this function in particular. Neither time was the actual bug explained so I dont know what this commit fixes... I'm fairly certain it does fix it though because the old code was rediculously wrong. MY guess is it has something to do with the radio debug screen seen as its the only call to this with the param != 0.
...
Please use the damn tracker for bug reports.. pinging someone when they arnt even online (as opposed to idling in the channel) really is a waste of time.)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17204 a1c6a512-1295-4272-9138-f99709370657
2008-04-21 13:32:10 +00:00
Nils Wallménius
6848961aa5
Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
2008-04-09 15:25:17 +00:00
Jonathan Gordon
be185a1eaf
fix the buttonbar in the browser and menus.
...
fix a problem where the menus wouldnt redraw when they should have when settings change
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16816 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 09:05:42 +00:00
Jonathan Gordon
5ca1539969
the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-03-26 03:35:24 +00:00
Jonathan Gordon
885283c424
more fixes for button bar... this will all disappear when viewports are handled by a manager of some sort
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16589 a1c6a512-1295-4272-9138-f99709370657
2008-03-09 09:37:39 +00:00
Jonathan Gordon
3f686d7034
fix recorder, buttonbar caused list problems
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16584 a1c6a512-1295-4272-9138-f99709370657
2008-03-09 02:00:31 +00:00
Jonathan Gordon
f444f1ecbe
fix the touchpad list code
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16528 a1c6a512-1295-4272-9138-f99709370657
2008-03-05 10:38:10 +00:00
Jonathan Gordon
0e5cec2d18
FS#8457 - convert the list drawing code to use viewports. This does not include any of the customizability which was in the patch, so unless any bugs show up users should not notice any difference.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16527 a1c6a512-1295-4272-9138-f99709370657
2008-03-05 09:58:30 +00:00
Jens Arnold
bf9ae1f303
Fix the simplelist redraw behaviour. It caused e.g. the 'Open with...' menu items to not scroll as they should, making it partially unusable with small displays and/or large fonts. Thanks to JdGordon for pointing me into the right direction.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16415 a1c6a512-1295-4272-9138-f99709370657
2008-02-25 07:41:30 +00:00
Peter D'Hoye
c4c678ff1a
Accept FS #8490 by Vuong Minh Hiep: fix wrong selection in multi-line lists
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16135 a1c6a512-1295-4272-9138-f99709370657
2008-01-21 22:28:25 +00:00
Jonathan Gordon
b684b82fd0
Accept and Fix FS#8427 - problem with empty screens in lists with pages scrolling enabled
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16023 a1c6a512-1295-4272-9138-f99709370657
2008-01-08 08:12:32 +00:00
Jonathan Gordon
213d9a2ca1
fix touchpad list code
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15948 a1c6a512-1295-4272-9138-f99709370657
2007-12-17 04:23:34 +00:00
Jonathan Gordon
f5ec3e49e0
remove the duplicated gui_list struct and only duplicate the members which are actually different on each screen. should translate to a smaller bin and easier code (users shouldnt notice any difference)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15947 a1c6a512-1295-4272-9138-f99709370657
2007-12-17 02:37:21 +00:00
Nicolas Pennequin
485bbbdb30
Make the "current line" value in the gradient style code zero-based, and an attempt at more understandable names and better comments.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15886 a1c6a512-1295-4272-9138-f99709370657
2007-12-06 17:09:24 +00:00
Nicolas Pennequin
b766f11701
Oops, wrong define. Fixes the warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15699 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 18:25:13 +00:00
Nicolas Pennequin
1d86dbffe3
Accept FS#7901 by Akio Idehara: Fix gradient for scrolling lines when more than one line is selected
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15698 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 18:14:51 +00:00
Linus Nielsen Feltzing
e75327b332
FS#7738 - Scroll wheel acceleration for iPod
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15681 a1c6a512-1295-4272-9138-f99709370657
2007-11-19 11:05:54 +00:00
Jonathan Gordon
04d0e3bc41
fix talking simplelists which I broke yesterday. dont talk if the list is being redrawn because get_action() timed out.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15459 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 12:52:32 +00:00
Jonathan Gordon
eb20149804
minor touchpad tweaking...
...
lists - dont do ACTION_STD_OK if pressing an area under the last item
colour chooser - change the seelcted colour straight away without having to swicth sliders first
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15455 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 10:51:11 +00:00
Jonathan Gordon
e247230e0d
redraw the siplelist more often
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15446 a1c6a512-1295-4272-9138-f99709370657
2007-11-04 01:04:10 +00:00
Karl Kurbjun
38548c7118
Build some more plugins for M:Robe most work, doom builds and runs if you use a hack - need to fix the user timer so that it works properly.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15403 a1c6a512-1295-4272-9138-f99709370657
2007-11-02 05:21:34 +00:00
Michael Sevakis
d6af287397
Implement as genuine a set_irq_level function for the sim as possible. The yield added earlier is still nescessary since other threads won't run anyway while viewing the database screen on either sim or target.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15321 a1c6a512-1295-4272-9138-f99709370657
2007-10-26 23:11:18 +00:00
Steve Bavin
ab784649cd
Don't lock up simulators when lists are used with TIMEOUT_NOBLOCK. Fixes FS#8030.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15318 a1c6a512-1295-4272-9138-f99709370657
2007-10-26 18:04:42 +00:00
Steve Bavin
072a3c5017
Complete info screen voicing; now consistent with displayed screen
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15284 a1c6a512-1295-4272-9138-f99709370657
2007-10-24 12:32:12 +00:00
Jonathan Gordon
eed41ff985
mrobe changes:
...
stop it thinking the battery is always flat and shutting down
add keymap for time/date screen
pressing a list item will highlight it before accepting it (looks better than it just entering the item without the selection changing first)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15280 a1c6a512-1295-4272-9138-f99709370657
2007-10-23 14:33:16 +00:00
Stéphane Doyon
a82a860c7e
Small voice-related tweaks and fixes to simplelists.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15276 a1c6a512-1295-4272-9138-f99709370657
2007-10-23 05:19:03 +00:00
Jonathan Gordon
fa13cbee80
First go at getting the touchpad working in the ui. lists only for now.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15264 a1c6a512-1295-4272-9138-f99709370657
2007-10-22 12:26:53 +00:00
Jonathan Gordon
0465101f92
allow simplelists to set the timeout and the start selection.
...
set a slightly saner default timeout
talk the selected item when the list is first displayed
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15247 a1c6a512-1295-4272-9138-f99709370657
2007-10-21 13:47:43 +00:00
Miika Pekkarinen
caff835d78
Fixed debug menu crashing. Show last file processed by tagcache engine in debug menu. Enabled autoupdating of deleted files for flash storage devices.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15244 a1c6a512-1295-4272-9138-f99709370657
2007-10-21 11:06:30 +00:00
Jonathan Gordon
616971c71e
remove the seelection_size param from the info init call to hopefully decrease the bin size a bit
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15237 a1c6a512-1295-4272-9138-f99709370657
2007-10-21 06:42:52 +00:00
Jonathan Gordon
5eac0108f9
simplify the simpelist api slightly so not every struct member needs to be init manually.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15236 a1c6a512-1295-4272-9138-f99709370657
2007-10-21 01:27:17 +00:00
Stéphane Doyon
8486c0413e
Accept FS#7774: Voice callback for gui_synclist.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15231 a1c6a512-1295-4272-9138-f99709370657
2007-10-21 00:20:10 +00:00
Jonathan Gordon
5f893be2a3
add a list API for simple lists which dont need lots of code to run.
...
Example uses in debug_menu.c
This API works best if most of the text is static, or not many actions
need to acted on. (of course, any list could use this)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15221 a1c6a512-1295-4272-9138-f99709370657
2007-10-20 12:32:55 +00:00
Antoine Cellerier
d66b3c0f61
Remove the "invert scroll" code since it's not used anywhere anymore (and it was broken on color targets with gradients anyway). Closes FS #7875 .
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15125 a1c6a512-1295-4272-9138-f99709370657
2007-10-15 20:42:51 +00:00
Nicolas Pennequin
7eedcb49d9
Fix buggy gradient display when a coloured file is selected in the browser. Thanks to smably for the report.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14891 a1c6a512-1295-4272-9138-f99709370657
2007-09-28 19:47:28 +00:00
Nicolas Pennequin
49a9e1ef35
Make the gradient look better when more than one line is selected (running time, ID3 info, cuesheet viewer...). I haven't found a solution for scrolling yet, so that won't look too good.
...
The recording screen code needs a bit of adapting too, but I don't have a target to test on, so leave it for now.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14884 a1c6a512-1295-4272-9138-f99709370657
2007-09-28 13:49:43 +00:00
Nicolas Pennequin
f3b015f73b
FS#7808 by Tom Ross, Ken Fazzone and me, with help from Antoine Cellerier.
...
Add two new line selector types: solid colour and gradient. Solid colour only uses the primary colour setting.
The secondary colour setting is used for the gradient. Text colour for the selected item is also changeable.
These new settings are a bit controversial so they may be removed later.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14868 a1c6a512-1295-4272-9138-f99709370657
2007-09-27 15:42:55 +00:00
Jonathan Gordon
cf1cef5f57
minor update to gui_synclist_do_button() which will hopefully simplify things later.
...
Now returns true if the action was handled in that function instead of returning the handled action.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
2007-09-17 10:08:50 +00:00
Jonathan Gordon
ffeccda8cd
Fix the bug where holding left no longer stopped at the browser root.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13983 a1c6a512-1295-4272-9138-f99709370657
2007-07-25 12:37:09 +00:00
Michael Sevakis
873e0fd1ef
Wheel acceleration for e200. A general acceleration interface intended for use on any scroll target and by any code. A general interface to obtain data associated with most recently dequeued button presses and actions. Use #define HAVE_SCROLLWHEEL and set appropriate constants, values in the scroller driver that feel right.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13959 a1c6a512-1295-4272-9138-f99709370657
2007-07-22 21:02:24 +00:00
Jonathan Gordon
2d4ee368e3
Fix problems with the list when you change font size
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13680 a1c6a512-1295-4272-9138-f99709370657
2007-06-21 13:21:33 +00:00
Brandon Low
488de5e09c
Fix yellow
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13657 a1c6a512-1295-4272-9138-f99709370657
2007-06-17 21:29:24 +00:00
Brandon Low
74cbb0a1b2
Give color targets the ability to display each LCD line a different color and use this newfangled ability to provide themable colored file types. See the comments on read_color_theme_file and the sample.colors file provided for how to use this. .colors files go in themes directory for now. This separate line color function should be trivial to add to menus and wpss.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13656 a1c6a512-1295-4272-9138-f99709370657
2007-06-17 21:16:34 +00:00
Jonathan Gordon
57440d5292
Fix a minor annoyance with the last commit where selecting an item could result in having empty space under the list.
...
Also very very minor code reduction.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13607 a1c6a512-1295-4272-9138-f99709370657
2007-06-10 08:18:19 +00:00
Jonathan Gordon
f4d0f053e6
Really fix FS#7274
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13606 a1c6a512-1295-4272-9138-f99709370657
2007-06-10 07:12:39 +00:00
Jonathan Gordon
f3145ba07c
simple fix for FS#7274 - selected item might not be shown when a list is drawn in paged scroll mode
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13602 a1c6a512-1295-4272-9138-f99709370657
2007-06-09 09:41:13 +00:00
Jonathan Gordon
3823486a58
Add a mode the lists which doesnt show the selection marker.
...
Useful for the debug menus where users shouldn't think pressing select would do anything.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13588 a1c6a512-1295-4272-9138-f99709370657
2007-06-07 12:14:31 +00:00
Jonathan Gordon
fea88888f0
Fix most (all) known list wierdness bugs, hopefully simplifies the code a bit, plenty of room for optimizing, but wanted to get it working first. (fixes FS#7255 and possibly others)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13556 a1c6a512-1295-4272-9138-f99709370657
2007-06-05 02:57:43 +00:00
Jonathan Gordon
20a8a9a3c8
Move the old api out of the core and into the plugin lib.
...
ew plugins shuold use the new api and not this one.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13537 a1c6a512-1295-4272-9138-f99709370657
2007-06-03 04:06:58 +00:00