Jonathan Gordon
f531adc312
pass pointers around instead of coping whole structs
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26197 a1c6a512-1295-4272-9138-f99709370657
2010-05-20 15:27:17 +00:00
Jonathan Gordon
b8176a6761
redo r25569 so the screen is only cleared once instead of every update (which is ~2Hz
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26196 a1c6a512-1295-4272-9138-f99709370657
2010-05-20 15:21:10 +00:00
Teruaki Kawashima
7042d9516b
skin_tokne.c: move WPS_TOKEN_TRACK_STARTING and WPS_TOKEN_TRACK_ENDING to get_id3_token().
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26193 a1c6a512-1295-4272-9138-f99709370657
2010-05-20 13:41:22 +00:00
Teruaki Kawashima
0a4eda4d46
skin_parser.c: fix possibile overflow in parse_setting_and_lang(). simplify comparison of string in parameter in parse_touchregion().
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26168 a1c6a512-1295-4272-9138-f99709370657
2010-05-19 15:47:54 +00:00
Teruaki Kawashima
4862fe4451
splash.c: correct calculation of y coordinate of splash.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26108 a1c6a512-1295-4272-9138-f99709370657
2010-05-17 14:09:35 +00:00
Jonathan Gordon
0a7a7ce213
count is being used as the value of the last item to show, so rename it to not be confusing
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26096 a1c6a512-1295-4272-9138-f99709370657
2010-05-17 04:08:07 +00:00
Jonathan Gordon
908a5b6a7b
the fm presets list should wrap.. so make that work
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26095 a1c6a512-1295-4272-9138-f99709370657
2010-05-17 02:29:20 +00:00
Alexander Levin
53a858b36c
Rearrange statements for a small binsize reduction; delete unneeded braces
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26089 a1c6a512-1295-4272-9138-f99709370657
2010-05-16 15:05:58 +00:00
Jonathan Gordon
caa4f54e42
fix a minor fms presetlist viewer bug with displaying prev when you are on the first playlist
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26087 a1c6a512-1295-4272-9138-f99709370657
2010-05-16 13:32:43 +00:00
Jonathan Gordon
7d5e0d7375
FS#11263 - Radio Art support! %C and %Cl tags work in the radio screen and Base Skin when the radio is running.
...
put your station images in .rockbox/fmpresets/<preset name>.bmp or .jpg. Must be in preset mode and the preset name must match the filename
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26078 a1c6a512-1295-4272-9138-f99709370657
2010-05-16 11:13:42 +00:00
Alexander Levin
edb6bedddb
Format FM frequency depending on the regional settings (FS#11273)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26069 a1c6a512-1295-4272-9138-f99709370657
2010-05-15 21:47:30 +00:00
Jeffrey Goode
ff548fad86
Fix include problem
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26039 a1c6a512-1295-4272-9138-f99709370657
2010-05-15 03:17:12 +00:00
Thomas Martitz
0246f0ceb4
Fix remaining reds/yellows.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26024 a1c6a512-1295-4272-9138-f99709370657
2010-05-14 13:21:40 +00:00
Alexander Levin
230f0405eb
Correct detection of the absence of the current preset
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25990 a1c6a512-1295-4272-9138-f99709370657
2010-05-13 08:36:38 +00:00
Jonathan Gordon
182d13e3ab
fix the freq bar after music plays
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25983 a1c6a512-1295-4272-9138-f99709370657
2010-05-13 06:59:16 +00:00
Jonathan Gordon
3fbe4d275e
fix FS#11264 - frequency bar and presets not working in the sbs
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25982 a1c6a512-1295-4272-9138-f99709370657
2010-05-13 06:56:21 +00:00
Alexander Levin
6e294e2fc6
Avoid duplicated code, create a formatting function for FM frequency
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25973 a1c6a512-1295-4272-9138-f99709370657
2010-05-12 21:44:24 +00:00
Jonathan Gordon
a5d8d21596
fix the last of the reds, and make RDS tags actually work (and add them to the hardcoded radio skin)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25966 a1c6a512-1295-4272-9138-f99709370657
2010-05-12 11:44:09 +00:00
Jonathan Gordon
7b931f0a5a
fix red and yellow (most of it anyway)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25965 a1c6a512-1295-4272-9138-f99709370657
2010-05-12 10:59:20 +00:00
Jonathan Gordon
1bd072c92d
FS#10853 - Skin support in the radio screen! Check CustomWPS for the new tags
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25964 a1c6a512-1295-4272-9138-f99709370657
2010-05-12 10:38:00 +00:00
Jonathan Gordon
f9736c0b63
ok, use a smaller font size on shorter display targets (3K instead of 10K)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25963 a1c6a512-1295-4272-9138-f99709370657
2010-05-12 10:22:00 +00:00
Jonathan Gordon
d6dbfef452
Borrow another 10K to make sure multifont will have room on even the smallerst screens
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25962 a1c6a512-1295-4272-9138-f99709370657
2010-05-12 09:31:40 +00:00
Michael Sevakis
35fd1e4e99
Fix F_T_SOUND voicing for decimals and physical values.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25961 a1c6a512-1295-4272-9138-f99709370657
2010-05-12 06:44:29 +00:00
Michael Sevakis
1de56ac367
Have option_get_valuestring always call sound_val2phys before formatting rather than only if fractional places are specified.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25960 a1c6a512-1295-4272-9138-f99709370657
2010-05-12 05:23:02 +00:00
Jonathan Gordon
38ef849d06
slightly rework peakmeter handling to make it cleaner and be able to be used in conditionals
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25913 a1c6a512-1295-4272-9138-f99709370657
2010-05-09 13:01:59 +00:00
Jonathan Gordon
52a8a540b1
revert those last few...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25910 a1c6a512-1295-4272-9138-f99709370657
2010-05-09 06:52:13 +00:00
Jonathan Gordon
bbb22fa9fc
mono targets dont support backdrops so dont use that #define
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25909 a1c6a512-1295-4272-9138-f99709370657
2010-05-09 06:43:04 +00:00
Jonathan Gordon
66e78ff6df
fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25908 a1c6a512-1295-4272-9138-f99709370657
2010-05-09 06:36:12 +00:00
Jonathan Gordon
3a1d661821
use a better value for the needed skin buffer size
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25907 a1c6a512-1295-4272-9138-f99709370657
2010-05-09 06:31:42 +00:00
Jeffrey Goode
847bd281e2
Fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25906 a1c6a512-1295-4272-9138-f99709370657
2010-05-09 02:07:42 +00:00
Jeffrey Goode
1ad76ff25b
FS#11250: Hotkey setting method changed to menu item vs button pres in context menu. Manuals updated to match.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25905 a1c6a512-1295-4272-9138-f99709370657
2010-05-09 02:02:51 +00:00
Steve Bavin
b08222caec
Minor const police raid.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25879 a1c6a512-1295-4272-9138-f99709370657
2010-05-07 16:35:37 +00:00
Jeffrey Goode
32ad1f84ee
Revert hotkey bitmaps
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25875 a1c6a512-1295-4272-9138-f99709370657
2010-05-07 14:46:42 +00:00
Jeffrey Goode
16e0c5730d
Hotkey menu items have their own icon
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25866 a1c6a512-1295-4272-9138-f99709370657
2010-05-07 03:21:12 +00:00
Thomas Martitz
55e4fe73cc
Fix the remaining reds.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25858 a1c6a512-1295-4272-9138-f99709370657
2010-05-06 22:33:57 +00:00
Thomas Martitz
b91f15d842
Fix c&p error from r25853 that should've fixed some snprintf warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25857 a1c6a512-1295-4272-9138-f99709370657
2010-05-06 22:22:47 +00:00
Thomas Martitz
77dfff5a55
Fix some more snprintf related warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25853 a1c6a512-1295-4272-9138-f99709370657
2010-05-06 21:37:03 +00:00
Thomas Martitz
50a6ca39ad
Move c/h files implementing/defining standard library stuff into a new libc directory, also standard'ify some parts of the code base (almost entirely #include fixes).
...
This is to a) to cleanup firmware/common and firmware/include a bit, but also b) for Rockbox as an application which should use the host system's c library and headers, separating makes it easy to exclude our files from the build.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25850 a1c6a512-1295-4272-9138-f99709370657
2010-05-06 21:04:40 +00:00
Jonathan Gordon
49f2709a01
If dircache and database "load to ram" is enabled then get the id3 info from the database in the WPS playlist viewer for non buffered tracks
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25841 a1c6a512-1295-4272-9138-f99709370657
2010-05-06 09:22:55 +00:00
Jonathan Gordon
14532754a7
fix player red.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25827 a1c6a512-1295-4272-9138-f99709370657
2010-05-05 13:56:44 +00:00
Jonathan Gordon
efd1f4e49f
Make it possible to move the UI viewport using conditional viewports.
...
%Vi|<label>|<Usual %Vi params>| <- specify the possible viewports to use
%VI<label> <- make the UI viewport use the %Vi definition with the <label> label.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25826 a1c6a512-1295-4272-9138-f99709370657
2010-05-05 13:48:50 +00:00
Jonathan Gordon
4c03e9a6f0
fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25756 a1c6a512-1295-4272-9138-f99709370657
2010-04-29 10:38:03 +00:00
Jonathan Gordon
886ecaa7a4
centre splashes inside the UI viewport instead of the whole screen. Fixes the flickering statusbar issue and saves alot of fullscreen clears
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25755 a1c6a512-1295-4272-9138-f99709370657
2010-04-29 10:27:35 +00:00
Jonathan Gordon
4c65a1970e
Make battery level (%bl) work with the bmp bars drawer like %pb and %pv
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25710 a1c6a512-1295-4272-9138-f99709370657
2010-04-25 11:32:51 +00:00
Alexander Levin
847a0fd56c
Fix grammar in the comment (make code non offending :-)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25695 a1c6a512-1295-4272-9138-f99709370657
2010-04-21 19:59:49 +00:00
Jonathan Gordon
34cd2c31ae
really fix "%pv|something else" this time
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25684 a1c6a512-1295-4272-9138-f99709370657
2010-04-20 07:17:59 +00:00
Jonathan Gordon
58a0393154
2 quick fixes
...
1) fix %pv| where the | is for a conditional break and not for long form %pv
2) only draw bmp-bars if they are enabled (by a conditional or always on.)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25677 a1c6a512-1295-4272-9138-f99709370657
2010-04-19 08:43:42 +00:00
Bertrik Sikken
44454c3203
Move audio_peek_track declaration from skin_display.c to audio.h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25670 a1c6a512-1295-4272-9138-f99709370657
2010-04-18 14:59:43 +00:00
Jonathan Gordon
69710e54f1
fix escaped chars being displayed twice in the playlist viewer (i.e %> showing as >> )
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25663 a1c6a512-1295-4272-9138-f99709370657
2010-04-17 12:45:52 +00:00
Jonathan Gordon
6c175effc5
drop the playlist viewer stack usage by reading straiught off the buffer instead of copying it.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25661 a1c6a512-1295-4272-9138-f99709370657
2010-04-17 12:02:02 +00:00