Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
30116 commits 17 branches 142 tags 291 MiB
Commit graph

272 commits

Author SHA1 Message Date
Hardeep Sidhu
10ad0a2a94 Fixed problem with first_index being incorrectly updated when prepending tracks. Fixes example 1 in B#6005. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10996 a1c6a512-1295-4272-9138-f99709370657
 2006-09-18 20:47:27 +00:00
Miika Pekkarinen
a85044bf9e New scheduler, with priorities for swcodec platforms. Frequent task 
switching should be more efficient and tasks are stored in linked
lists to eliminate unnecessary task switching to improve performance.
Audio should no longer skip on swcodec targets caused by too CPU
hungry UI thread or background threads.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10958 a1c6a512-1295-4272-9138-f99709370657
 2006-09-16 16:18:11 +00:00
Hardeep Sidhu
16c55277f7 Only maintain the last insert position after the playlist has started. Fixes B#6004. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10955 a1c6a512-1295-4272-9138-f99709370657
 2006-09-15 23:37:07 +00:00
Steve Bavin
22599d0a0d Playlist resume no longer uses voice file buffer. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10944 a1c6a512-1295-4272-9138-f99709370657
 2006-09-14 12:50:34 +00:00
Magnus Holmgren
e605786b2a Patch #5770 by Dominik Riebeling: Skip BOM in playlists. Add '.m3u8' as a supported playlist extension. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10917 a1c6a512-1295-4272-9138-f99709370657
 2006-09-10 10:59:51 +00:00
Linus Nielsen Feltzing
224c0a13eb Finally, the new button action system is here, thanks to Jonathan Gordon. Some button mappings have changed and other things may break. Comments should go to the forum, http://forums.rockbox.org/index.php?topic=5829.0 or the mailing list. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10582 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 12:27:07 +00:00
Miika Pekkarinen
54ec1f5f6d Better UI response with playlist operations. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10544 a1c6a512-1295-4272-9138-f99709370657
 2006-08-12 11:00:39 +00:00
Miika Pekkarinen
887cfeb9f5 Only sync playlist once when adding bunch of files from tagcache. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10508 a1c6a512-1295-4272-9138-f99709370657
 2006-08-10 09:50:45 +00:00
Linus Nielsen Feltzing
da0525f54f Patch #5179 by Sebastian Henriksen and Hardeep Sidhu - Playlist catalog 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10232 a1c6a512-1295-4272-9138-f99709370657
 2006-07-18 13:54:12 +00:00
Hardeep Sidhu
685356cb89 Store playlist index for prepended/appended tracks in control file. Fixes resume problem with these tracks and insert shuffled. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10115 a1c6a512-1295-4272-9138-f99709370657
 2006-06-12 23:06:51 +00:00
Hardeep Sidhu
1386034044 Always set first_index to value stored in settings when resuming. Fixes incorrect index problem when resuming an insert_shuffle'd playlist. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10024 a1c6a512-1295-4272-9138-f99709370657
 2006-05-30 23:52:58 +00:00
Hardeep Sidhu
bda2d5e798 Boost cpu when performing large insertions or saving playlist to disk 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9942 a1c6a512-1295-4272-9138-f99709370657
 2006-05-15 19:15:04 +00:00
Hardeep Sidhu
cab3a16417 Return immediately if we have no control commands to flush. Fixes erroneous playlist control update error when inserting tracks 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9912 a1c6a512-1295-4272-9138-f99709370657
 2006-05-11 19:14:18 +00:00
Hardeep Sidhu
83d1a5eabe Only flush and reload tracks after the playlist has started. Fixes B#5312. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9895 a1c6a512-1295-4272-9138-f99709370657
 2006-05-09 14:43:49 +00:00
Hardeep Sidhu
ed41ba0ca7 Fixed bug with playlist_skip_entry when track to be skipped was less then current index 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9879 a1c6a512-1295-4272-9138-f99709370657
 2006-05-05 08:32:07 +00:00
Hardeep Sidhu
b236dc63ff Fixed problem with incorrect first index after resume 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9835 a1c6a512-1295-4272-9138-f99709370657
 2006-04-30 05:29:04 +00:00
Hardeep Sidhu
fede7ff6f2 Fixed playlist control corruption on dircache systems 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9834 a1c6a512-1295-4272-9138-f99709370657
 2006-04-30 04:40:56 +00:00
Hardeep Sidhu
3f7292e13a Don't call playlist_start() when changing directories on swcodec devices. Fixes problem with previous dir not working. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9774 a1c6a512-1295-4272-9138-f99709370657
 2006-04-23 17:15:45 +00:00
Hardeep Sidhu
24f0a374c6 Fixed problem with forced reload of dircached filenames when playlist is sorted 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9738 a1c6a512-1295-4272-9138-f99709370657
 2006-04-20 05:56:34 +00:00
Hardeep Sidhu
195a9f2766 No need to force a sync of control file until playlist has started. This should improve tagcache playlist creation performance on Archos devices (esp. Ondio). Also fixed a small bug in playlist_set_current. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9735 a1c6a512-1295-4272-9138-f99709370657
 2006-04-20 01:43:16 +00:00
Hardeep Sidhu
b79c9a6145 Allow insert shuffled option for directories when playlist is empty. Based on patch #3011 by Jonathan Gordon. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9728 a1c6a512-1295-4272-9138-f99709370657
 2006-04-19 02:22:23 +00:00
Brandon Low
2b18727a8a Fix dir skipping with new playback arch. Enable dir skipping on ipod with a couple of difficult combos (select|right/left) or short-long left / short-long right. The latter causes stuck in pause sometimes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9720 a1c6a512-1295-4272-9138-f99709370657
 2006-04-18 18:33:09 +00:00
Hardeep Sidhu
095ad1a39c Minor fix for insert_shuffle when playlist is empty 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9716 a1c6a512-1295-4272-9138-f99709370657
 2006-04-18 16:44:51 +00:00
Hardeep Sidhu
d0de1aafac Fixed problem with auto change directory not working when browsing plugins 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9715 a1c6a512-1295-4272-9138-f99709370657
 2006-04-18 16:24:12 +00:00
Hardeep Sidhu
6dd728cdea Fixed problems with playlist buffer full handling 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9454 a1c6a512-1295-4272-9138-f99709370657
 2006-04-03 14:25:47 +00:00
Hardeep Sidhu
30db2b4ac3 Fix for repeat shuffle on SW codec devices 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9453 a1c6a512-1295-4272-9138-f99709370657
 2006-04-03 13:48:38 +00:00
Jens Arnold
67de1d3d9b Thorough .lang rework: Removed all deprecated strings, combined string which were only split because long ago we had no splash(), sorted strings into logical groups to ease the transition to langv2. Bunped binary .lng version. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9398 a1c6a512-1295-4272-9138-f99709370657
 2006-04-01 13:36:33 +00:00
Jens Arnold
e523041468 Fix 64bit warnings 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9375 a1c6a512-1295-4272-9138-f99709370657
 2006-03-30 21:43:24 +00:00
Miika Pekkarinen
3881ce94bd Dircache support for simulator also. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9365 a1c6a512-1295-4272-9138-f99709370657
 2006-03-30 18:53:44 +00:00
Hardeep Sidhu
0cca6caa8a Currently playing playlist can now be overwritten. Save playlist screen defaults to this. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8641 a1c6a512-1295-4272-9138-f99709370657
 2006-02-09 09:09:32 +00:00
Hardeep Sidhu
75a60fbf69 Added a cache for playlist control commands. On non-dircache systems, behaviour should be the same as before (all commands except shuffle flushed immediately). On dircache systems, commands are only flushed when disk is accessed or during shutdown. This especially reduces disk accesses when playing queued files and should fix the problem with gapless playback. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8584 a1c6a512-1295-4272-9138-f99709370657
 2006-02-05 18:17:41 +00:00
Brandon Low
8d5a6609a3 AB-repeat mode for software codecs. Accessible through menu as a repeat mode, with buttom mappings much like those on other rockbox targets for now. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8409 a1c6a512-1295-4272-9138-f99709370657
 2006-01-21 23:43:57 +00:00
Miika Pekkarinen
178a85f31c iriver: Better fix for the previous problem, stop playback if next 
song is not immediately available, don't flush buffer when changing to
next directory,


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8393 a1c6a512-1295-4272-9138-f99709370657
 2006-01-19 20:35:06 +00:00
Daniel Stenberg
f981ea93fb kill gcc4 warnings 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8162 a1c6a512-1295-4272-9138-f99709370657
 2005-12-05 22:44:42 +00:00
Miika Pekkarinen
6a4bfb5dcf iRiver: Fixed several problems with playback on track skipping & loading: 
* Correctly detecting codec type from metadata.
* Skipping incorrect tracks correctly if there are more than one unloadable track.
* Fixed internal ram skipping when codec switching is required.
* Fixed hang if no files in playlist is playable.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8116 a1c6a512-1295-4272-9138-f99709370657
 2005-12-01 18:44:11 +00:00
Miika Pekkarinen
caee4b3e37 One more fix to revert a part of an incorrect change from the previous commit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8023 a1c6a512-1295-4272-9138-f99709370657
 2005-11-21 13:23:06 +00:00
Miika Pekkarinen
4394cc787e The previous commit didn't fully fix the problem. Now it should have 
been fixed.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8022 a1c6a512-1295-4272-9138-f99709370657
 2005-11-21 11:31:15 +00:00
Miika Pekkarinen
d1704f6894 Fixed playlist skipping of incorrect files and playback engine not to 
hang if codec loading fails. Also displaying a "Loading..." message on
resume and not calling queue_post too often.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8021 a1c6a512-1295-4272-9138-f99709370657
 2005-11-21 11:14:51 +00:00
Miika Pekkarinen
bae4fed19d Fix to the previous commit: Pointers were not always correctly erased. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7932 a1c6a512-1295-4272-9138-f99709370657
 2005-11-17 19:41:16 +00:00
Miika Pekkarinen
735f453730 Added dircache support to playlist. Now playlist filename pointers are 
automatically accuired from dircache. WPS UI response with dircache
enabled should be instant.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7931 a1c6a512-1295-4272-9138-f99709370657
 2005-11-17 19:31:29 +00:00
Anton Oleynikov
ffc3963d57 fixed a bug in folder skipping preventing a feature to work in some cases 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7815 a1c6a512-1295-4272-9138-f99709370657
 2005-11-11 19:58:08 +00:00
Anton Oleynikov
00928af4dd iRiver: more robust folder skip routines + folder navigation on main unit via 
either PLAY+LEFT/RIGHT or short then long LEFT/RIGHT


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7810 a1c6a512-1295-4272-9138-f99709370657
 2005-11-10 22:31:47 +00:00
Kevin Ferrare
3aa842c9a3 some multi-screen work in playlist.c, properly formated splash.h 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7766 a1c6a512-1295-4272-9138-f99709370657
 2005-11-06 17:30:53 +00:00
Anton Oleynikov
d102e1f345 patch 1328447: folder skip routines in playlist API plus next/prev folder navigation for iRiver's remote 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7735 a1c6a512-1295-4272-9138-f99709370657
 2005-11-02 22:32:04 +00:00
Miika Pekkarinen
56bb45cfaf We reserved two bits instead of one bit for the new skipped attribute. 
Fixed.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7648 a1c6a512-1295-4272-9138-f99709370657
 2005-10-21 07:25:19 +00:00
Miika Pekkarinen
c52f7f1b5e iRiver: Fixed broken items skipping on playlist: Now skipping and 
marking them as bad instead of deleting the entries from playlist.
Faster buffered track skipping and preventing glitches from previous
tracks (still something might occur though, please report them).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7647 a1c6a512-1295-4272-9138-f99709370657
 2005-10-21 06:40:45 +00:00
Jens Arnold
d6c054575b Renamed CONFIG_HWCODEC and MASNONE to the more appropriate CONFIG_CODEC and SWCODEC, respectively. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7416 a1c6a512-1295-4272-9138-f99709370657
 2005-08-29 21:15:27 +00:00
Linus Nielsen Feltzing
0ad617cbf0 Patch #1105616 by Ray Lambert - A-B Repeat for Archos studio/recorder, still not 100% complete, but I wanted to commit it before the 2.5 feature freeze 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7380 a1c6a512-1295-4272-9138-f99709370657
 2005-08-21 23:01:12 +00:00
Miika Pekkarinen
159c52dd36 Initial voice ui support for software codec platforms. Added also a 
beep when changing tracks.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7360 a1c6a512-1295-4272-9138-f99709370657
 2005-08-20 11:13:19 +00:00
Ryan Jackson
1476fecf72 All repeat modes now work correctly if there is only one track in the playlist. Fixed a track-changing bug in 'Move to Next Folder' mode that could cause Rockbox to crash. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7268 a1c6a512-1295-4272-9138-f99709370657
 2005-07-30 19:36:06 +00:00
Magnus Holmgren
97c6fd0892 'Move to Next Folder' didn't work if it involved going up to the root of the drive. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7265 a1c6a512-1295-4272-9138-f99709370657
 2005-07-30 18:12:25 +00:00
Hardeep Sidhu
348d8f6bab A couple of bug fixes: 1. Take mutex before all playlist control file operations including fsync. 2. Don't flush and reload tracks if nothing is playing. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7060 a1c6a512-1295-4272-9138-f99709370657
 2005-07-08 00:52:54 +00:00
Hardeep Sidhu
839dbcaed7 Moved resume info updating to the mpeg/playback threads so that it's saved even when not in the WPS 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7018 a1c6a512-1295-4272-9138-f99709370657
 2005-07-04 22:50:57 +00:00
Hardeep Sidhu
71d2281d8b Added new feature to move to next folder once the current one completes when playing directories 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6963 a1c6a512-1295-4272-9138-f99709370657
 2005-07-01 11:25:16 +00:00
Hardeep Sidhu
965c86a845 Forgot a const 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6862 a1c6a512-1295-4272-9138-f99709370657
 2005-06-25 06:28:55 +00:00
Hardeep Sidhu
74d082c038 Added new shuffle repeat mode that reshuffles playlist before repeating. Also added new shuffled insert mode that randomly inserts selected track(s) somewhere between current track and end of playlist. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6861 a1c6a512-1295-4272-9138-f99709370657
 2005-06-25 04:46:25 +00:00
Linus Nielsen Feltzing
d34865a530 mp3buf renamed to audiobuf 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6252 a1c6a512-1295-4272-9138-f99709370657
 2005-04-05 11:33:58 +00:00
Linus Nielsen Feltzing
8a237a829e More audio code restructuring, mostly renaming functions so far 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6246 a1c6a512-1295-4272-9138-f99709370657
 2005-04-04 12:06:29 +00:00
Daniel Stenberg
22b7701fe7 Build cleanup and general fixes. fprintf() is now fdprintf(), the separation 
between uisimulator files and firmware/apps files are better done.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6031 a1c6a512-1295-4272-9138-f99709370657
 2005-02-22 12:19:12 +00:00
Linus Nielsen Feltzing
b9c9d80fef Recursive insert now works again 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6028 a1c6a512-1295-4272-9138-f99709370657
 2005-02-21 23:38:13 +00:00
Jean-Philippe Bernardy
5203f0645e long policy 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5934 a1c6a512-1295-4272-9138-f99709370657
 2005-02-12 12:57:16 +00:00
Björn Stenberg
3c10fd592c Fixed 'Insert directory' bug. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5788 a1c6a512-1295-4272-9138-f99709370657
 2005-02-04 13:20:25 +00:00
Björn Stenberg
30d8f6192f Added music playing from ID3 browser. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5616 a1c6a512-1295-4272-9138-f99709370657
 2005-01-20 16:24:26 +00:00
Björn Stenberg
cdd79a35d4 Repaired broken resume 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5596 a1c6a512-1295-4272-9138-f99709370657
 2005-01-18 22:50:47 +00:00
Björn Stenberg
84c7d88021 Added support for very large tables in ID3 database. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5595 a1c6a512-1295-4272-9138-f99709370657
 2005-01-18 22:45:00 +00:00
Björn Stenberg
a50cc0bd34 Minor tweaks to compile on win32. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5578 a1c6a512-1295-4272-9138-f99709370657
 2005-01-17 12:56:00 +00:00
Björn Stenberg
8a5de5fec9 Added ID3 database support. Still very early. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5575 a1c6a512-1295-4272-9138-f99709370657
 2005-01-17 11:39:46 +00:00
Linus Nielsen Feltzing
1c9ab1ba69 Reverted to the earlier modulo method for creating a range of random numbers, since the new method could generate too large numbers 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5386 a1c6a512-1295-4272-9138-f99709370657
 2004-11-06 23:37:21 +00:00
Jörg Hohensohn
593cc00447 a hell of a commit: changed several HAVE_xx configuration flags into multiple choice values (keypad, tuner, CPU, h/w codec) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5126 a1c6a512-1295-4272-9138-f99709370657
 2004-09-28 22:13:26 +00:00
Björn Stenberg
6c33c51a4c Redesigned the button handling. The code now uses symbolic function defines instead of checking for specific buttons. This makes it easier to add support for new devices with different button layouts. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5091 a1c6a512-1295-4272-9138-f99709370657
 2004-09-19 21:58:37 +00:00
Henrik Backe
66b45eeb59 Added check for missing .rockbox directory to playlist code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5063 a1c6a512-1295-4272-9138-f99709370657
 2004-09-10 20:51:12 +00:00
Jörg Hohensohn
24c7c04899 adjustment for the Ondio: button driver has an Odio part, for now it has a Player layout. Some fixes in the app code were necessary to remove dependencies of LCD, keypad, this wasn't independent everywhere. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5055 a1c6a512-1295-4272-9138-f99709370657
 2004-09-10 10:51:54 +00:00
Jens Arnold
cd12a03cf9 Since open() does now handle O_TRUNC correctly, the previous fix is no longer needed 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5049 a1c6a512-1295-4272-9138-f99709370657
 2004-09-06 23:44:22 +00:00
Jens Arnold
ac9ad1a25d Bug fix: Longish .playlist_control files got corrupted when doing ON->resume after stop without rebooting first 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5033 a1c6a512-1295-4272-9138-f99709370657
 2004-09-01 21:34:20 +00:00
Jens Arnold
943ac26cf6 Reverted an erroneous const, and fixed & optimized relative path handling. The bug didn't show up because FAT is inherently able to handle relative paths itself. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5028 a1c6a512-1295-4272-9138-f99709370657
 2004-08-31 23:44:24 +00:00
Jens Arnold
8fb336148f Const policed pointer arguments to functions, part 3 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4999 a1c6a512-1295-4272-9138-f99709370657
 2004-08-18 01:09:31 +00:00
Hardeep Sidhu
586ec8274d Added extra error reporting 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4981 a1c6a512-1295-4272-9138-f99709370657
 2004-08-02 05:11:20 +00:00
Linus Nielsen Feltzing
12bf7f39b1 Slightly better randomness when shuffling 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4922 a1c6a512-1295-4272-9138-f99709370657
 2004-07-23 10:45:16 +00:00
Hardeep Sidhu
2459d23d0b Abort resume if control file doesn't end with a newline. Fixes hang when resuming from a corrupt control file. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4882 a1c6a512-1295-4272-9138-f99709370657
 2004-07-14 18:02:38 +00:00
Linus Nielsen Feltzing
fbca8aaa19 Some code cleanup 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4480 a1c6a512-1295-4272-9138-f99709370657
 2004-04-09 17:44:35 +00:00
Jörg Hohensohn
fa97f161ab Third step of the voice-UI: numerical settings are spoken (composed at runtime), needs new voicefont at the new location ".rockbox/langs/english.voice" 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4414 a1c6a512-1295-4272-9138-f99709370657
 2004-03-19 22:15:53 +00:00
Jörg Hohensohn
4f36ea8fbf First step of the voice-UI: the menus can talk. You need a "voicefont" file in .rockbox to use this. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4381 a1c6a512-1295-4272-9138-f99709370657
 2004-03-14 21:33:53 +00:00
Hardeep Sidhu
41354a85d9 Fixed bug when inserting playlists where comment and empty lines were not being skipped. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4284 a1c6a512-1295-4272-9138-f99709370657
 2004-01-29 05:37:54 +00:00
Hardeep Sidhu
107ebc5ba9 Modified playlist handling to allow for multiple playlists to be edited at the same time. Added support in playlist viewer for viewing/editing playlists on disk (accessed via ON+PLAY->Playlist->View on a playlist). Added menu in playlist viewer for changing a few settings and saving playlist. Added File Options menu in playlist viewer ON+PLAY menu. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4276 a1c6a512-1295-4272-9138-f99709370657
 2004-01-26 17:05:21 +00:00
Björn Stenberg
a108ec2ebd Added Benjamin Metzlers bookmarking feature (patch #669440) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4227 a1c6a512-1295-4272-9138-f99709370657
 2004-01-14 00:13:04 +00:00
Daniel Stenberg
1afa395c2f The splash() function's second argument (keymask) is now removed, as it 
was not used by any code.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4201 a1c6a512-1295-4272-9138-f99709370657
 2004-01-08 09:58:58 +00:00
Daniel Stenberg
8e43ccbec6 Initial suppport for building Rockbox for Neo. The Neo has a different 
key layout so we need to check for this.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4138 a1c6a512-1295-4272-9138-f99709370657
 2003-12-12 13:34:27 +00:00
Hardeep Sidhu
00acdfa6ef Added viewer for currently playing playlist. Accessed from Menu->Playlist Options->View Current Playlist. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4124 a1c6a512-1295-4272-9138-f99709370657
 2003-12-10 00:11:25 +00:00
Hardeep Sidhu
58bafee963 Don't write playlist shuffle settings immediately to disk. Instead, save them in global settings and only flush to disk when the playlist is modified \(e.g. insert,delete\). As part of the changes the resume index was changed from an int to a short to give an extra 2 bytes in RTC ram to be used for another playlist index. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4121 a1c6a512-1295-4272-9138-f99709370657
 2003-12-09 08:18:03 +00:00
Jörg Hohensohn
8b813d0b99 table-driven internal handling of file types, so we can have many of them 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4115 a1c6a512-1295-4272-9138-f99709370657
 2003-12-07 16:57:43 +00:00
Björn Stenberg
de5477cc00 Brian King's .rockbox browsing patch 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3964 a1c6a512-1295-4272-9138-f99709370657
 2003-09-29 21:26:53 +00:00
Hardeep Sidhu
b3621b7e1c Don't delete queued tracks in repeat one mode. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3929 a1c6a512-1295-4272-9138-f99709370657
 2003-08-11 16:32:56 +00:00
Linus Nielsen Feltzing
f937912b5c The creation of the playlist control file failed when control_fd == 0 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3814 a1c6a512-1295-4272-9138-f99709370657
 2003-07-08 06:31:23 +00:00
Hardeep Sidhu
14078864a0 Allow playing even if we are unable to access the playlist control file (e.g. no .rockbox dir). However, dynamic playlists and resume will not work in this case. Also, there are no playlist options for m3u files when nothing is playing. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3813 a1c6a512-1295-4272-9138-f99709370657
 2003-07-06 16:05:44 +00:00
Hardeep Sidhu
a8950c3d3b Dos-style pathnames were being copied incorrectly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3800 a1c6a512-1295-4272-9138-f99709370657
 2003-07-02 16:14:49 +00:00
Hardeep Sidhu
11e7ad50a0 Added "Ask" option to recursive dir insert which, if enabled, will ask users whether they want to recursively insert selected dir. Also, renamed "Insert first" and "Queue first" to "Insert next" and "Queue next" respectively. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3799 a1c6a512-1295-4272-9138-f99709370657
 2003-07-02 15:54:44 +00:00
Hardeep Sidhu
9e4262081b Added dynamic playlists. ON+PLAY->Playlist on a track, directory, or playlist from file browser to see available options. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3796 a1c6a512-1295-4272-9138-f99709370657
 2003-07-01 21:05:43 +00:00
Linus Nielsen Feltzing
7f5ce80932 The playlist buffer was too small, causing all kinds of weird errors when playing large playlists 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3706 a1c6a512-1295-4272-9138-f99709370657
 2003-05-29 22:42:57 +00:00
Linus Nielsen Feltzing
20d031f9c7 Configurable dir browser file buffer size. No more 400-file limit. No more whining. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3661 a1c6a512-1295-4272-9138-f99709370657
 2003-05-09 16:01:21 +00:00
Björn Stenberg
7bb746b4fe Changed to runtime playlist initialization 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3602 a1c6a512-1295-4272-9138-f99709370657
 2003-04-24 17:31:36 +00:00
Daniel Stenberg
4793f3b6de init the playlist struct so that fd is -1 at startup, which then no longer 
makes us close fd zero at startup.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3595 a1c6a512-1295-4272-9138-f99709370657
 2003-04-23 21:07:30 +00:00
Daniel Stenberg
583821bc32 Keep the playlist open all the time, to reduce mid-song times caused by the 
closure and reopening of the playlist.

Consider this slightly experimental. Can you detect a speed difference?


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3592 a1c6a512-1295-4272-9138-f99709370657
 2003-04-23 18:45:51 +00:00
Linus Nielsen Feltzing
9d860e19d2 Better handling of next/prev 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3528 a1c6a512-1295-4272-9138-f99709370657
 2003-04-11 00:29:15 +00:00
Linus Nielsen Feltzing
570f16fd6d Improved responsiveness for dirplay, plus fixed a bug that could cause a file handle leak, and sometimes playlist loading problems 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3518 a1c6a512-1295-4272-9138-f99709370657
 2003-04-08 02:05:14 +00:00
Robert Hak
f6ee2f645e make use of the splash screen, kill displays we don't need anymore 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3480 a1c6a512-1295-4272-9138-f99709370657
 2003-03-18 23:11:12 +00:00
Björn Stenberg
6a2b9367dd The simulators can't use the mp3 buffer. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3399 a1c6a512-1295-4272-9138-f99709370657
 2003-03-07 15:09:23 +00:00
Björn Stenberg
728868a863 I am silly. We need the dedicated buffer for ram playlists (dir play). Now only uses the mp3 buffer when loading a list from disk. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3398 a1c6a512-1295-4272-9138-f99709370657
 2003-03-07 14:38:51 +00:00
Björn Stenberg
050cc90801 Wrong declaration order. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3396 a1c6a512-1295-4272-9138-f99709370657
 2003-03-07 09:29:14 +00:00
Björn Stenberg
f75a774b14 Use mp3buf for playlist loading instead of a dedicated buffer. Speeds up loading and saves 16 KB ram. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3395 a1c6a512-1295-4272-9138-f99709370657
 2003-03-07 09:24:56 +00:00
Mats Lidell
74cc9e41fa Remove use of rockbox-mode.el in local variables list. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3157 a1c6a512-1295-4272-9138-f99709370657
 2003-01-24 10:56:06 +00:00
Mats Lidell
4042ec8d33 Use lang definition for shuffling. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3100 a1c6a512-1295-4272-9138-f99709370657
 2003-01-15 16:48:25 +00:00
Hardeep Sidhu
86ced78567 Comments. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3044 a1c6a512-1295-4272-9138-f99709370657
 2003-01-09 06:08:41 +00:00
Björn Stenberg
c78e1b07fe The much-anticipated queue patch by Hardeep Sidhu. Queue a file by holding down PLAY on it while playing other music. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3040 a1c6a512-1295-4272-9138-f99709370657
 2003-01-09 00:55:00 +00:00
Björn Stenberg
0e342181c3 Remove bogus dirs from beginning of playlist file path. Patch by Hardeep Sidhu. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3039 a1c6a512-1295-4272-9138-f99709370657
 2003-01-09 00:18:47 +00:00
Robert Hak
73926ef5e5 %pn now allows for conditional checking 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2698 a1c6a512-1295-4272-9138-f99709370657
 2002-10-17 09:34:48 +00:00
Robert Hak
ec7b5cde2e missed an snprintf arg 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2656 a1c6a512-1295-4272-9138-f99709370657
 2002-10-15 12:21:19 +00:00
Robert Hak
f9d3d1cd91 added %pn (playlist name) to wps 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2651 a1c6a512-1295-4272-9138-f99709370657
 2002-10-15 11:49:15 +00:00
Hardeep Sidhu
3735a15aca Retrieve the first_index from playlist when updating resume settings instead of incorrectly using start_index 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2575 a1c6a512-1295-4272-9138-f99709370657
 2002-10-11 09:14:30 +00:00
Daniel Stenberg
d035a9b0bc the playlist variables are now all static, and the wps code use the new 
playlist_amount() function to get amount of songs in the current list.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2549 a1c6a512-1295-4272-9138-f99709370657
 2002-10-09 13:42:59 +00:00
Daniel Stenberg
a5c0fad617 added playlist_amount(), no longer trying to stop insane looping in the 
playlist code, that should be done by the mpeg thread (or somewhere). The
playlist code just can't know when to stop.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2548 a1c6a512-1295-4272-9138-f99709370657
 2002-10-09 13:36:49 +00:00
Hardeep Sidhu
83611fe8c3 Store the first index of the playlist and use it when calculating the next index in repeat off mode so that shuffled dirplay works correctly when "play selected" is enabled. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2514 a1c6a512-1295-4272-9138-f99709370657
 2002-10-06 05:50:41 +00:00
Björn Stenberg
a6d0abb602 Repeat off/all/one toggle. By Hardeep Sidhu. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2498 a1c6a512-1295-4272-9138-f99709370657
 2002-10-04 08:48:20 +00:00
Björn Stenberg
505eca76e6 New language/string handling 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2327 a1c6a512-1295-4272-9138-f99709370657
 2002-09-18 14:08:05 +00:00
Linus Nielsen Feltzing
25316c5417 Added play_selected option 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2323 a1c6a512-1295-4272-9138-f99709370657
 2002-09-18 10:13:09 +00:00
Robert Hak
174f4945f3 adi is stupid improvements 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2266 a1c6a512-1295-4272-9138-f99709370657
 2002-09-12 09:20:03 +00:00
Robert Hak
e9d5127eaa efficiency improvement 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2265 a1c6a512-1295-4272-9138-f99709370657
 2002-09-12 09:11:59 +00:00
Linus Nielsen Feltzing
0be1d26674 Only handle # comments in file based playlists 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2264 a1c6a512-1295-4272-9138-f99709370657
 2002-09-12 07:51:49 +00:00
Hardeep Sidhu
62bec9e0d2 Flush and reload preloaded tracks if playlist changes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2259 a1c6a512-1295-4272-9138-f99709370657
 2002-09-10 08:50:40 +00:00
Daniel Stenberg
71a07bebe6 modified the playlist system slightly: 
playlist_peek() returns info relative the current index
playlist_next() advances the index back or forth

(this breaks the build, mpeg fixes are pending)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@2022 a1c6a512-1295-4272-9138-f99709370657
 2002-08-28 09:22:44 +00:00
Hardeep Sidhu
f8c87e6c50 When toggling shuffle from on to off while a playlist is playing, update the current playlist index to the new index of the current song 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1977 a1c6a512-1295-4272-9138-f99709370657
 2002-08-26 08:25:52 +00:00
Björn Stenberg
3df58d30e1 Removed typedef 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1958 a1c6a512-1295-4272-9138-f99709370657
 2002-08-23 20:04:31 +00:00
Daniel Stenberg
3625dedcce playlist_next() now returns NULL on excessive 'step' amounts 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1940 a1c6a512-1295-4272-9138-f99709370657
 2002-08-23 07:33:35 +00:00
Daniel Stenberg
01bc8e682a play_list() is now modified to accept a playlist index that is either 
meant in the unshuffled list or in the shuffled. There's an extra
parameter giving that info (which of course only makes sense when
shuffle is enabled).

This should make resume work with play-all-dir in shuffled mode.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1889 a1c6a512-1295-4272-9138-f99709370657
 2002-08-21 15:08:01 +00:00
Markus Braun
c41dcb9ae9 Now using lcd margins instead of a line offset for displaying status bar. 
Needed to support fonts smaller than 8 pixels.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1823 a1c6a512-1295-4272-9138-f99709370657
 2002-08-20 19:39:55 +00:00
Daniel Stenberg
5e5f1e247b When shuffle is ENABLED. And you press PLAY in a dir, the selected song 
is now the first song to get played. To do this, we first remember which
song that was selected, shuffle the list and then find the selected song
in the shuffled list and play that.

This will have some interesting side effects if the song ends up for example
last in the shuffled list when we consider not always doing repeat-all as
then it'll reach the end of the playlist after one song.

We could optionally put the selected song first in the playlist and then
shuffle all the rest, as that would possibly be closer to what people will
assume it will do.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1803 a1c6a512-1295-4272-9138-f99709370657
 2002-08-19 12:45:01 +00:00
Björn Stenberg
6224cdb166 Added resume. Works in dirs and playlists, shuffled or not. Resumes mid-song, but press pause on players before you shutdown so they get a chance to store the position on disk. Recorders use RTC ram. Todo: Time display is wrong after mid-track resume and ffd/rew is not handled. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1787 a1c6a512-1295-4272-9138-f99709370657
 2002-08-16 14:41:47 +00:00
Linus Nielsen Feltzing
5917e8157a Now we can have up to 400 files in a directory 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1761 a1c6a512-1295-4272-9138-f99709370657
 2002-08-15 12:28:52 +00:00
Björn Stenberg
ebb14ca5f9 Gained about 128 KB buffer space by removing malloc() and the heap 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1726 a1c6a512-1295-4272-9138-f99709370657
 2002-08-13 23:13:01 +00:00
Björn Stenberg
e33d66a3ac Tell user when limits are reached 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1692 a1c6a512-1295-4272-9138-f99709370657
 2002-08-12 22:52:19 +00:00
Björn Stenberg
a2f9fb6a33 Support double negative wrap (with a half nelson) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1632 a1c6a512-1295-4272-9138-f99709370657
 2002-08-09 08:54:46 +00:00
Björn Stenberg
523c51a944 Allow reverse playlist wrap in repeat mode 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1626 a1c6a512-1295-4272-9138-f99709370657
 2002-08-08 21:12:09 +00:00
Björn Stenberg
514a3fbbbe Prevent negative playlist.index 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1623 a1c6a512-1295-4272-9138-f99709370657
 2002-08-08 19:10:09 +00:00
Björn Stenberg
d76116a211 Fix for double-slash fix 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1614 a1c6a512-1295-4272-9138-f99709370657
 2002-08-08 13:58:53 +00:00
Linus Nielsen Feltzing
1cbe4c2e05 Removed the extra slash between the dir and filename for relative paths 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1608 a1c6a512-1295-4272-9138-f99709370657
 2002-08-08 10:29:14 +00:00
Markus Braun
de8fbf00a8 Added status bar to file browser and wps 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1582 a1c6a512-1295-4272-9138-f99709370657
 2002-08-07 10:35:26 +00:00
Linus Nielsen Feltzing
8abcf1bd20 Changed playlist API again 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1575 a1c6a512-1295-4272-9138-f99709370657
 2002-08-07 06:04:24 +00:00
Linus Nielsen Feltzing
d8cc285034 RAM-based playlists added 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1559 a1c6a512-1295-4272-9138-f99709370657
 2002-08-06 13:09:48 +00:00
Daniel Stenberg
360ae3ebdc Magnus Holmgren's fix that now enables us to toggle shuffle on/off from the 
menu and it'll "take effect" immediately when needing to reload the playlist.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1526 a1c6a512-1295-4272-9138-f99709370657
 2002-08-02 13:20:03 +00:00
Daniel Stenberg
af6ceba2a3 support for relative paths in playlists by Brian King <brking@charter.net> 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1506 a1c6a512-1295-4272-9138-f99709370657
 2002-08-01 11:37:26 +00:00
Linus Nielsen Feltzing
6f75d1739f Slightly improved shuffle algorithm. Patch by Hardeep Sidhu 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@1397 a1c6a512-1295-4272-9138-f99709370657
 2002-07-22 15:36:39 +00:00