Dominik Riebeling
7adc200564
Make convttf build with C89 compilers.
...
- Move variable declarations to the top of blocks to be compatible with C89
compilers (like MSVS).
- Remove unnecessary Windows includes.
- Paths on Windows usually use backslash as path delimiter so accept that as
well.
- Rename some variables to avoid shadowing functions (like index()).
No functional changes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29698 a1c6a512-1295-4272-9138-f99709370657
2011-04-09 20:35:17 +00:00
Michael Sevakis
d5849e0d30
Playlists forget to set playlist.started when creating new playlist on SWCODEC and which leads to flush-and-rebuffer messages never being sent again until playback is restarted.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29697 a1c6a512-1295-4272-9138-f99709370657
2011-04-09 13:07:08 +00:00
Bertrik Sikken
59e37cbccb
AMS sd: use defines instead of direct values for drive number
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29696 a1c6a512-1295-4272-9138-f99709370657
2011-04-09 07:57:53 +00:00
Bertrik Sikken
67a4e9befc
Sansa Clip v2: there's no need to use |= or &= to manipulate a GPIO for the button light
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29695 a1c6a512-1295-4272-9138-f99709370657
2011-04-08 21:51:46 +00:00
Nils Wallménius
e7c6ba66aa
Whitespace and cosmetics consistency cleanup in playlist_viewer.c, no functional changes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29694 a1c6a512-1295-4272-9138-f99709370657
2011-04-08 13:39:56 +00:00
Nils Wallménius
a0791178ae
Voice filenames in the playlist viewer, closes FS#11951
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29693 a1c6a512-1295-4272-9138-f99709370657
2011-04-08 13:10:32 +00:00
Andree Buschmann
29a855245c
Fix residual red. Keep index in mp3entry for HWCODEC.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29692 a1c6a512-1295-4272-9138-f99709370657
2011-04-07 22:11:12 +00:00
Andree Buschmann
39d9d8bab1
Fix red and yellow. Move resume_index from mp3entry to playlist_info struct. Bump codec api.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29691 a1c6a512-1295-4272-9138-f99709370657
2011-04-07 21:38:51 +00:00
Andree Buschmann
4df825be43
Fix regressions of r29682. Update playlist index resume position when playlist changes (e.g. shuffling, inserting, removing, ...).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29690 a1c6a512-1295-4272-9138-f99709370657
2011-04-07 20:33:00 +00:00
Nils Wallménius
37990206dd
Fix FS#12003 'langtool.pl --deprecate is broken'
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29688 a1c6a512-1295-4272-9138-f99709370657
2011-04-07 07:50:29 +00:00
Alex Parker
0e8e166f25
Bump to 3.8.1 release.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29686 a1c6a512-1295-4272-9138-f99709370657
2011-04-06 21:43:50 +00:00
Björn Stenberg
2d00f0c8b2
Removed some dead code identified by clang-analyzer.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29685 a1c6a512-1295-4272-9138-f99709370657
2011-04-06 21:08:31 +00:00
Dominik Riebeling
2c297760df
deploy.py: insert version number into sources.
...
After downloading the sources insert the number of the revision checked out
into the code. Results in the Rockbox Utility about dialog showing the actual
revision instead of the one of the last change to version.h. Only applied when
building from trunk for now.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29684 a1c6a512-1295-4272-9138-f99709370657
2011-04-06 20:17:29 +00:00
Andree Buschmann
3184cbe10a
Fix FS#12043. Next track was resumed when pausing and shutting down the player in the last seconds of a track.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29682 a1c6a512-1295-4272-9138-f99709370657
2011-04-06 19:11:40 +00:00
Dominik Riebeling
c7227a7620
Fix a warning.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29681 a1c6a512-1295-4272-9138-f99709370657
2011-04-05 20:02:07 +00:00
Andree Buschmann
d1766a1510
Rework parts of the replaygain code to be able to differentiate between 0.00 dB set intentionally and having no replaygain information at all. Bump codec api.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29679 a1c6a512-1295-4272-9138-f99709370657
2011-04-04 15:21:44 +00:00
Michael Chicoine
f0132528fd
Manual correction for entering quick screen from file browser
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29677 a1c6a512-1295-4272-9138-f99709370657
2011-04-04 01:55:56 +00:00
Dominik Riebeling
86f70de809
Properly remove the configuration dialog.
...
The configuration dialog isn't needed anymore once the finished() signal is
emitted. In that case schedule it for deletion by the event loop.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29674 a1c6a512-1295-4272-9138-f99709370657
2011-04-03 14:04:21 +00:00
Dominik Riebeling
1c635a8c3c
OS X TTS: add pitch setting.
...
The current TTS configuration doesn't allow querying the system values so it
currently can't be displayed. A value of 0 will use the system default. The
default pitch is dependent on the voice; most voices should have a default
pitch of 45 - 55.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29673 a1c6a512-1295-4272-9138-f99709370657
2011-04-03 09:23:21 +00:00
Dominik Riebeling
746f01dd77
Add capability to speak directly from the TTS engine.
...
The OS X TTS engine (and likely others) allows outputting its speech directly
to the sound system. This avoids the extra step of creating a temporary file to
play for TTS preview. Currently implemented as TTS capability reported.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29672 a1c6a512-1295-4272-9138-f99709370657
2011-04-03 08:06:59 +00:00
Dominik Riebeling
76c112ce6e
Update build instructions for Rockbox Utility.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29671 a1c6a512-1295-4272-9138-f99709370657
2011-04-02 19:51:01 +00:00
Dominik Riebeling
96fad95bcf
Fix a warning.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29670 a1c6a512-1295-4272-9138-f99709370657
2011-04-02 19:03:50 +00:00
Dominik Riebeling
2f7cf08532
Use template pattern for genlang url.
...
Instead of hard coding the query part of the genlang url store the full url as
template and replace parts as done for other urls as well.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29669 a1c6a512-1295-4272-9138-f99709370657
2011-04-02 08:59:00 +00:00
Bertrik Sikken
f608229f32
Sansa clip+: do not set GPIO B7 in the display driver, it's already used for FM radio I2C
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29668 a1c6a512-1295-4272-9138-f99709370657
2011-04-02 08:24:14 +00:00
Bertrik Sikken
eab630a1e1
AMSv2: fix dependency between button light and sd card control for fuze v2 variant 0
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29667 a1c6a512-1295-4272-9138-f99709370657
2011-04-01 21:29:08 +00:00
Andree Buschmann
a7354e7925
Cosmetic change of a comment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29666 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 22:06:52 +00:00
Andree Buschmann
29164ccbcc
Changing convert_gain() also implicitly changed get_replaygain_int() which could lead to div by zero. This patch finds another way to fix the replaygain fallback.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29665 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 21:46:09 +00:00
Andree Buschmann
4f7930b883
Fix for replaygain: Ensure fallback to track gain in case of missing album gain.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29664 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 12:44:29 +00:00
Björn Stenberg
ce755dd9c5
Only set volume on SYS_VOLUME_CHANGED the first time. Workaround for FS#12034.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29663 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 07:04:44 +00:00
Nils Wallménius
277b8fba71
Delete empty dir.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29662 a1c6a512-1295-4272-9138-f99709370657
2011-03-30 21:57:47 +00:00
Bertrik Sikken
81d67d0dda
Revert accidental commit of apps/plugins/SOURCES
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29661 a1c6a512-1295-4272-9138-f99709370657
2011-03-29 20:44:09 +00:00
Bertrik Sikken
8351a1aa9d
AMSv2 sd: do not try to switch sd cards into high-speed mode.
...
High-speed mode is only half implemented (sd controller still uses normal speed) and causes card detection problems.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29660 a1c6a512-1295-4272-9138-f99709370657
2011-03-29 20:37:40 +00:00
Rafaël Carré
8c3fc23ae6
remove set but unused variable
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29659 a1c6a512-1295-4272-9138-f99709370657
2011-03-28 21:44:36 +00:00
Rafaël Carré
cde3c9a08e
maze: fix warning spotted by gcc 4.6.0
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29658 a1c6a512-1295-4272-9138-f99709370657
2011-03-28 21:44:23 +00:00
Bertrik Sikken
5c4c691cd3
AMSv2 sd: correct CLKENA settings (to stop sd clock when idle) for AMSv2 variant 1 players
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29657 a1c6a512-1295-4272-9138-f99709370657
2011-03-28 20:46:56 +00:00
Bertrik Sikken
7d74fdec02
AMSv2 sd: do sd slot switching with GPIO B5 only for AMSv2 variant 1
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29656 a1c6a512-1295-4272-9138-f99709370657
2011-03-28 18:08:03 +00:00
Jonathan Gordon
87aa86cedd
Skin variables for touchscreen targets (origional implementation by Jens Theeß)
...
%vs(name, [set|inc|dec], value [,max]) - name is the id, set sets the value, inc increments by value, dec decrements by value
%vg(name) - get the current value
%vl(name [,timeout]) - 'has it changed in [timeout]'?
values start at 1 and are all reset to 1 on skin load
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29655 a1c6a512-1295-4272-9138-f99709370657
2011-03-27 08:01:58 +00:00
Jonathan Gordon
969381322d
Fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29654 a1c6a512-1295-4272-9138-f99709370657
2011-03-27 07:30:23 +00:00
Jonathan Gordon
443b134983
Fix touchregions muting volume, and change &<action> to mean 'needs long press but only fire once'. Use *<action> for 'long press and allow repeats'
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29653 a1c6a512-1295-4272-9138-f99709370657
2011-03-27 07:23:38 +00:00
Bertrik Sikken
86c4ec7277
AMSv2 SD: use INTERNAL_AS3525 and SD_SLOT_AS3525 defines instead of a direct value
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29652 a1c6a512-1295-4272-9138-f99709370657
2011-03-26 23:31:29 +00:00
Bertrik Sikken
502e9e97b6
AMSv2 SD: wait for response to command SD_STOP_TRANSMISSION instead of ignoring the response
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29651 a1c6a512-1295-4272-9138-f99709370657
2011-03-26 21:22:30 +00:00
Bertrik Sikken
6512f0fb52
AMSv2 SD: reorganise code to select 4-bit mode data transfer mode a bit and add comments
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29648 a1c6a512-1295-4272-9138-f99709370657
2011-03-26 21:12:16 +00:00
Bertrik Sikken
2543340bf4
AMSv2 SD: sd card communication speed can be changed back to full speed after CMD3 (SEND_RCA)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29647 a1c6a512-1295-4272-9138-f99709370657
2011-03-26 19:52:42 +00:00
Robert Kukla
d9bc251de1
use correct define for gigabeat fx to enable lineout (was broken in r29588)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29646 a1c6a512-1295-4272-9138-f99709370657
2011-03-26 13:12:24 +00:00
Dominik Riebeling
8c1d114dcf
Rockbox Utility: Replace OSDaB Zip with QuaZip.
...
This change fixes problems with zip files created with newer zip utilities (a
known issue is the iLike theme). QuaZip also allows better feedback during
operations without changing the imported code. Additionally Rockbox Utility and
the Theme Editor are now both using QuaZip; currently Rockbox Utility uses a
copy of the sources, merging them later is planned.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29645 a1c6a512-1295-4272-9138-f99709370657
2011-03-25 22:16:12 +00:00
Andree Buschmann
0258895faa
Fix error in Ohm's law formula as provided in FS#12023. Thanks to Leif Andersen.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29644 a1c6a512-1295-4272-9138-f99709370657
2011-03-25 07:22:38 +00:00
Andree Buschmann
afe6ee4300
Fix FS#12024. Scroll acceleration did not work -- at least reported for iRiver H10 -- caused by too short duration for button repeat recognition.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29642 a1c6a512-1295-4272-9138-f99709370657
2011-03-24 18:42:27 +00:00
Michael Sparmann
26f63070c2
iPod Classic storage driver: Fix some implicit casts, typos, ...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29640 a1c6a512-1295-4272-9138-f99709370657
2011-03-24 14:51:23 +00:00
Rafaël Carré
688545ea16
fix warning, use unsigned variable
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29638 a1c6a512-1295-4272-9138-f99709370657
2011-03-24 10:54:30 +00:00
Rafaël Carré
669313a11d
SD AMSv2: fix r29625
...
The number of blocks could have been checked while the card was not initialized yet.
See FS#11870 for details
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29637 a1c6a512-1295-4272-9138-f99709370657
2011-03-24 10:43:47 +00:00