Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
30676 commits 17 branches 142 tags 291 MiB
Commit graph

1597 commits

Author SHA1 Message Date
Thomas Martitz
71610fbf62 Backdrop dir needs to go through get_user_file_path() 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27791 a1c6a512-1295-4272-9138-f99709370657
 2010-08-12 17:32:59 +00:00
Jonathan Gordon
70ebe46d74 New feature for the %xl (image load) tag. If you give it the filename __list_icons__ it will use the list icon strip instead of loading a different bmp. 
example:
%xl(I, __list_icons__, 0, 0)
%xd(I, %Li)

^ display the list icon at position 0,0 in that viewport. (you can of course %xd(Ia) if you really wanted also.)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27787 a1c6a512-1295-4272-9138-f99709370657
 2010-08-12 13:27:10 +00:00
Magnus Holmgren
6d7900e330 When using the tag argument in %%xd(): 1) clear the image first, so that images with transparency can be used; 2) allow things like battery level or volume, where a value is limited to the number of sub-images. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27786 a1c6a512-1295-4272-9138-f99709370657
 2010-08-12 10:01:46 +00:00
Magnus Holmgren
c6078fe2a8 Slightly change bl (battery level) when used in an enum: if the enum contained 10 items, bl would return 11 if the battery level was 100 percent (the enum would then display the last entry). Now bl returns a value within the given range. Themes may need to be updated to look as intended. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27784 a1c6a512-1295-4272-9138-f99709370657
 2010-08-12 09:25:26 +00:00
Magnus Holmgren
113764d9c0 Fix FS#11175. playlist_peek() wasn't thread safe (due to a static filename buffer), so frequent calls from the main thread would cause the audio thread to buffer the wrong track. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27773 a1c6a512-1295-4272-9138-f99709370657
 2010-08-11 19:01:50 +00:00
Jonathan Gordon
489962dc4e Fix FS#11526 - %Vf(<hex>) was acceptable on grey remotes with colour main 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27768 a1c6a512-1295-4272-9138-f99709370657
 2010-08-10 14:15:03 +00:00
Jonathan Gordon
a547fc1b35 Fix FS#11527 - remote wps/sbs doesnt update correctly 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27767 a1c6a512-1295-4272-9138-f99709370657
 2010-08-10 13:56:48 +00:00
Jonathan Gordon
1b53b99b75 Accept FS#11523 by Fred Bauer - fix a bug where the skin fonts dont check the correct path so it would load the same font twice when it shouldnt. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27766 a1c6a512-1295-4272-9138-f99709370657
 2010-08-10 13:36:14 +00:00
Jonathan Gordon
f3a6d2476a Dont redraw the AA every single update, only when needed 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27719 a1c6a512-1295-4272-9138-f99709370657
 2010-08-05 12:45:46 +00:00
Jonathan Gordon
3f8e7fc26f New feature for the %xd() (display a preloaded image) skin tag. 
It can now automatically load the correct subimage from a strip (assuming the strip is in the correct order)  by giving a tag for the 2nd param.
example: %xd(F, %mp) which is equivilant to %?mp<%xd(Fa)|%xd(Fb)|%xd(Fc)|%xd(Fd)|%xd(Fe)>
You can also set the subimage offset.. i.e %xd(E, %mm, -1) which means "show nothing for the first value of %mm and use the bitmap strip for the remaining values"

if a tag+offset is <0 or greater than the number of subimages in a strip he image is cleared (I'm open to changing this if someone has a better idea)

cabbiev2.176x220x16.wps is an example of how to use this

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27717 a1c6a512-1295-4272-9138-f99709370657
 2010-08-05 11:28:48 +00:00
Jonathan Gordon
f0611f8781 Force touchscreen targets into 3x3 grid mode when entering the wps/radio if the skin hasnt set any regions 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27692 a1c6a512-1295-4272-9138-f99709370657
 2010-08-04 12:00:18 +00:00
Jonathan Gordon
75556fd57f Fix FS#10926 - h300 wps wouldnt be updated correctly when the backlight turns off because the remote is being naughty 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27666 a1c6a512-1295-4272-9138-f99709370657
 2010-08-02 14:12:44 +00:00
Jonathan Gordon
ee4f8a9a6b Allow viewport labels to be mostly free text instead of only one character. If this is useful the same will be done for images 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27665 a1c6a512-1295-4272-9138-f99709370657
 2010-08-02 12:50:23 +00:00
Thomas Martitz
9c0b2479f7 Rockbox as an application: add get_user_file_path(). 
For RaaA it evaluates user paths at runtime. For everything but codecs/plugins it will give the path under $HOME/.config/rockbox.org if write access is needed or if the file/folder in question exists there (otherwise it gives /usr/local/share/rockbox).
This allows for installing themes under $HOME as well as having config.cfg and other important files there while installing the application (and default themes) under /usr/local.

On the DAPs it's a no-op, returing /.rockbox directly.

Not converted to use get_user_file_path() are plugins themselves, because RaaA doesn't build plugins yet.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27656 a1c6a512-1295-4272-9138-f99709370657
 2010-08-01 16:15:27 +00:00
Jonathan Gordon
9e2cd39d52 Fix FS#11508 - remote LCD targets crash because the remote wps fails to load 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27653 a1c6a512-1295-4272-9138-f99709370657
 2010-08-01 11:37:02 +00:00
Jonathan Gordon
52e67f3366 woopsies 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27651 a1c6a512-1295-4272-9138-f99709370657
 2010-08-01 10:48:27 +00:00
Jonathan Gordon
bb45110de2 woopsies 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27650 a1c6a512-1295-4272-9138-f99709370657
 2010-08-01 10:43:29 +00:00
Jonathan Gordon
6dc4d65aa1 FS#11507 - fix 'track starting/ending' tags, and minor timeout cleanup 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27649 a1c6a512-1295-4272-9138-f99709370657
 2010-08-01 10:40:29 +00:00
Bertrik Sikken
76f4c02dc5 Various minor clean-ups for mrobe 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27639 a1c6a512-1295-4272-9138-f99709370657
 2010-07-31 13:41:06 +00:00
Jonathan Gordon
b3740b7bb6 remove an unused variable 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27632 a1c6a512-1295-4272-9138-f99709370657
 2010-07-31 08:58:34 +00:00
Bertrik Sikken
57933f2bc6 Make some global function/variables local (by making them static) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27631 a1c6a512-1295-4272-9138-f99709370657
 2010-07-30 23:47:49 +00:00
Jonathan Gordon
e63e19b507 Fix Database red, move the cuesheet->token code into the skin engine 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27616 a1c6a512-1295-4272-9138-f99709370657
 2010-07-29 13:23:33 +00:00
Jonathan Gordon
37d605a578 fix touchscreen errors 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27614 a1c6a512-1295-4272-9138-f99709370657
 2010-07-29 12:48:59 +00:00
Jonathan Gordon
2d31d77a8b FS#11470 - new skin code, finally svn uses the new parser from the theme editor. This means that a skin that passes the editor WILL pass svn and checkwps (unless the target runs out of skin buffer or something. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27613 a1c6a512-1295-4272-9138-f99709370657
 2010-07-29 12:37:48 +00:00
Rafaël Carré
a72aa856bd Move some gcc extensions to new gcc_extensions.h header 
- Move ATTRIBUTE_PRINTF/ATTRIBUTE_SCANF from _ansi.h
  They are not related at all to this file, and this broke compilation
  with Code Sourcery GCC which ships its own _ansi.h
- Move LIKELY/UNLIKELY from system.h

There is likely a lot more GCC extensions used everywhere in the source,
conditionally on __GNUC__ or unconditionally

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27548 a1c6a512-1295-4272-9138-f99709370657
 2010-07-25 14:44:29 +00:00
Nils Wallménius
7668c434a4 Fix FS#11204 logf build on h300 hung on bootup 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27541 a1c6a512-1295-4272-9138-f99709370657
 2010-07-24 11:39:28 +00:00
Thomas Martitz
ee166960b4 The previous commit was broken, not only because of the red. Fix it. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27532 a1c6a512-1295-4272-9138-f99709370657
 2010-07-23 16:33:16 +00:00
Thomas Martitz
a0e83f3821 Make %tx work as intended, so that it ignores the true case for non-RDS targets. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27531 a1c6a512-1295-4272-9138-f99709370657
 2010-07-23 16:24:12 +00:00
Rafaël Carré
7d4414ebd8 AB_REPEAT_ENABLE was never defined to 2 
There's only 2 possibilities: defined or undefined

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27483 a1c6a512-1295-4272-9138-f99709370657
 2010-07-18 18:13:53 +00:00
Jonathan Gordon
bb236ce89c prevent the parser crashing if a font fails to load and is refresencd in more than one viewport 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27443 a1c6a512-1295-4272-9138-f99709370657
 2010-07-16 01:05:24 +00:00
Rafaël Carré
bc48fed0e7 skin engine: fix simulator builds 
include the needed headers before checking DEBUG_SKIN_ENGINE

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27390 a1c6a512-1295-4272-9138-f99709370657
 2010-07-11 16:54:02 +00:00
Rafaël Carré
4b94912628 enable skin debug only in the simulator 
it's controled by sim --debugwps option

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27389 a1c6a512-1295-4272-9138-f99709370657
 2010-07-11 16:46:54 +00:00
Teruaki Kawashima
e87ff2bf91 tweak position of splash so that it is displayed inside the ui viewport. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27371 a1c6a512-1295-4272-9138-f99709370657
 2010-07-10 13:40:35 +00:00
Bertrik Sikken
5565a28c7d Remove some redundant #include's 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27183 a1c6a512-1295-4272-9138-f99709370657
 2010-06-29 20:13:22 +00:00
Maurus Cuelenaere
5da84ec4da I somehow messed up the previous commit, undo the unrelated changes. 
Also, r26922 wasn't the culprit but r27004.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27108 a1c6a512-1295-4272-9138-f99709370657
 2010-06-24 14:32:25 +00:00
Maurus Cuelenaere
3f4838585f Fix touchscreen scrollbar behaviour when it's on the right. 
This was broken since r26922.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27107 a1c6a512-1295-4272-9138-f99709370657
 2010-06-24 14:22:36 +00:00
Jonathan Gordon
f101c8ad62 r27028 again.. properly close font fd's and reload the skins on usb exit (disk should be spinning so hopefully not disastrous!) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27077 a1c6a512-1295-4272-9138-f99709370657
 2010-06-23 05:48:35 +00:00
Jonathan Gordon
6281d8e214 revert r27027,27028, 27071 - need to find a correct way to close font fd's. 27027 caused data aborts, 27028 caused multifont issues after returning from usb 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27072 a1c6a512-1295-4272-9138-f99709370657
 2010-06-23 02:57:04 +00:00
Jonathan Gordon
7dae58ddaf fix charcell 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27046 a1c6a512-1295-4272-9138-f99709370657
 2010-06-22 09:48:58 +00:00
Jonathan Gordon
7de980cd7a fiddle with the code a bit so gcc doesnt optimise out a struct viewport causeing crashes in text_viewer 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27045 a1c6a512-1295-4272-9138-f99709370657
 2010-06-22 09:44:55 +00:00
Michael Sparmann
f86ee556cf Fix charcell red. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27029 a1c6a512-1295-4272-9138-f99709370657
 2010-06-21 20:24:57 +00:00
Michael Sparmann
286ed6fab5 Unload fonts when entering UMS mode to close their file handles. Closes FS#11428 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27028 a1c6a512-1295-4272-9138-f99709370657
 2010-06-21 20:19:30 +00:00
Jonathan Gordon
49dac9ae04 Make the title area go up one level in the lists again. This Doesnt work if you have the title in a seperate viewport in the sbs, but that isnt really a problem because if you are doing that there is a good chance you will setup a region for that press anyway 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27015 a1c6a512-1295-4272-9138-f99709370657
 2010-06-21 14:57:44 +00:00
Jonathan Gordon
adc9cb1adc Allow the progressbar and volume touch regions to be reverse by prepending them with ! (so full is the left/top instead of right/bottom) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27013 a1c6a512-1295-4272-9138-f99709370657
 2010-06-21 12:43:08 +00:00
Jonathan Gordon
c201772940 Fix the hotkey touch region in the wps 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27009 a1c6a512-1295-4272-9138-f99709370657
 2010-06-21 12:14:16 +00:00
Jonathan Gordon
a398c2846a Touchregion support for the Base Skin and FM Skins. display obviously needs to be in stylus mode for this to work. Just about all screens should be mostly useable if your sbs has the next/prev/select/cancel/menu regions defined. 
Plenty of room to add new action abilities if they are wanted.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27004 a1c6a512-1295-4272-9138-f99709370657
 2010-06-21 06:04:19 +00:00
Jonathan Gordon
8a798179fc woops, this chaneg too 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26992 a1c6a512-1295-4272-9138-f99709370657
 2010-06-20 13:21:41 +00:00
Jonathan Gordon
eada0907ff fix ffwd/rewind on touchscreen targets using regions 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26991 a1c6a512-1295-4272-9138-f99709370657
 2010-06-20 13:17:24 +00:00
Maurus Cuelenaere
6be8306ae0 Fix error: assignment of read-only variable 'list_width' 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26923 a1c6a512-1295-4272-9138-f99709370657
 2010-06-18 14:45:44 +00:00
Maurus Cuelenaere
4c4285df9a Simplify check in gui_synclist_do_touchscreen(), no functional changes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26922 a1c6a512-1295-4272-9138-f99709370657
 2010-06-18 14:41:49 +00:00
Jonathan Gordon
9a7a542de2 first step of making touch regions usable in all skins, not just the WPS.. no user viewable changes just yet 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26854 a1c6a512-1295-4272-9138-f99709370657
 2010-06-15 08:38:23 +00:00
Steve Bavin
dddd15746f FS#10336 - Simplify list redrawing to improve voicing when scrolling to top/bottom. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26853 a1c6a512-1295-4272-9138-f99709370657
 2010-06-15 07:08:35 +00:00
Jonathan Gordon
f98ea7142e FS#11096 - fix the "last touch" tag from being true on boot 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26852 a1c6a512-1295-4272-9138-f99709370657
 2010-06-15 06:55:18 +00:00
Jonathan Gordon
ee6aca9860 add a hotkey option to the wps touchregion. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26740 a1c6a512-1295-4272-9138-f99709370657
 2010-06-10 13:05:23 +00:00
Jonathan Gordon
9cf09f33aa crappy editor and crappy svn missing crappy merge crappy crappy 2am crappy 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26728 a1c6a512-1295-4272-9138-f99709370657
 2010-06-09 16:17:17 +00:00
Jonathan Gordon
9ac4b44610 SKIN BREAK: %pb, %bl and %pv (bar types) changed so the image is the last param instead of the first. skin updater, skins and manual all updated. 
NEW PARSER: add an 'N' param type which will accept any number of strings, will cause very big problems if this isnt the last param for a tag.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26727 a1c6a512-1295-4272-9138-f99709370657
 2010-06-09 16:15:01 +00:00
Teruaki Kawashima
bc58b7d984 some clean up. add checks for terminating ')'. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26723 a1c6a512-1295-4272-9138-f99709370657
 2010-06-09 14:06:42 +00:00
Jonathan Gordon
10e24d22c4 rename HAVE_PICTUREFLOW to HAVE_PICTUREFLOW_INTEGRATION to make it more clear what it is needed for 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26716 a1c6a512-1295-4272-9138-f99709370657
 2010-06-09 08:51:29 +00:00
Jonathan Gordon
881a5b9759 reclaim most of the delta from the pictureflow commit 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26715 a1c6a512-1295-4272-9138-f99709370657
 2010-06-09 08:14:41 +00:00
Jonathan Gordon
d871ff8cce FS#11270 by Chris Savery - WPS integration for pictureflow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26710 a1c6a512-1295-4272-9138-f99709370657
 2010-06-09 04:25:41 +00:00
Jonathan Gordon
c2a79aae16 fix %pb and other progressbars which are shown one line down from where they should be in viewports 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26698 a1c6a512-1295-4272-9138-f99709370657
 2010-06-08 15:26:25 +00:00
Jonathan Gordon
2d62a570e3 Fix yellow and all the shipped themes that show AA 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26697 a1c6a512-1295-4272-9138-f99709370657
 2010-06-08 15:17:39 +00:00
Jonathan Gordon
50356d8387 The real reason to change the %C was to remove a very nasty hack! 
%CL - load the AA
%C - check if AA is avilable
%Cd - display the AA


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26696 a1c6a512-1295-4272-9138-f99709370657
 2010-06-08 15:09:32 +00:00
Jonathan Gordon
2309d6d1e1 change to %Cd to display albumart (instead of %C to make it more consistant with %Vd/%Vl and %xd/%xl) 
Also assume ; in skins are for sublines.. this means if you want ; in text you need to manually escape it (%;) far less false positives then


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26693 a1c6a512-1295-4272-9138-f99709370657
 2010-06-08 14:52:03 +00:00
Teruaki Kawashima
e6c9691f0b don't disable backdrop when the file name starts with 'd', e.g. %X(dock.bmp). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26689 a1c6a512-1295-4272-9138-f99709370657
 2010-06-08 13:31:39 +00:00
Jonathan Gordon
fa99c614b9 hopefully fix the problem with lines in viewports being pushed down one line. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26682 a1c6a512-1295-4272-9138-f99709370657
 2010-06-08 07:24:42 +00:00
Jonathan Gordon
bb417260b2 this probably fixes FS#11373 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26658 a1c6a512-1295-4272-9138-f99709370657
 2010-06-07 12:40:59 +00:00
Jonathan Gordon
fe72cbe6ac Fix FS#11370 - BEWARE when useing viewport colours. 
%Vf() and %Vb() need to be straight after the %V() or else the colours wont be set on the viewport (but on the line instead). This means scrolling lines dont work.

To make sure the colours are used for the whole viewport dont leave any gaps between %V and %Vf/%Vb. (of course, if you want a single line to be a different colour then use the %Vf as normal.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26656 a1c6a512-1295-4272-9138-f99709370657
 2010-06-07 11:45:02 +00:00
Jonathan Gordon
4c040943bb off by one. FS#11369 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26655 a1c6a512-1295-4272-9138-f99709370657
 2010-06-07 11:13:56 +00:00
Jonathan Gordon
04fd0ce374 fix FS#11368 - %V was eating the whole line so the %Vf() and %Vb() tags were being ignored 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26653 a1c6a512-1295-4272-9138-f99709370657
 2010-06-07 10:47:21 +00:00
Jonathan Gordon
4a9398e3fc make %t work 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26649 a1c6a512-1295-4272-9138-f99709370657
 2010-06-07 07:32:28 +00:00
Jonathan Gordon
0d8fb6015c make the parser work with the changed %Cl format. 
%Cl(x, y, width, height [,xalign flag] [, yalign flag])
xalign can be l,c,r (or - to keep default)
yalign can be t,c,b

xalign must be there if you want to use a yalign flag


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26646 a1c6a512-1295-4272-9138-f99709370657
 2010-06-07 04:40:46 +00:00
Jonathan Gordon
4f3fb96d34 bah 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26644 a1c6a512-1295-4272-9138-f99709370657
 2010-06-07 04:11:49 +00:00
Jonathan Gordon
4e0b47cb4e this should be the last of the warnings 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26643 a1c6a512-1295-4272-9138-f99709370657
 2010-06-07 04:00:39 +00:00
Jonathan Gordon
32455131e7 fix errors 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26642 a1c6a512-1295-4272-9138-f99709370657
 2010-06-07 03:55:40 +00:00
Jonathan Gordon
5b0521c9aa Changeover to the new skin format. SkinBreakingChange in the wiki has the runown of the changes. 
Major changes are paramerterised tags now use %tag(param,param), colours are removed from the %V() tag, %Vi gets a required (but can be -) label as its first param).

utils/skinupdater/ has a program to update individual skins, and a perl script to update a whole zip.
Themesite will be unusable for the time being (you should be able to upload new themes once it updates checkwps though).

I obviously havnt tested every updated wps in this change so let me know if one doesnt load


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26641 a1c6a512-1295-4272-9138-f99709370657
 2010-06-07 03:44:11 +00:00
Jonathan Gordon
28833f09e2 don't draw the presets on the FM frequency bar, they look like crap. This will come back when they are configurable shortly 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26628 a1c6a512-1295-4272-9138-f99709370657
 2010-06-06 13:23:52 +00:00
Jonathan Gordon
b8d98fcc19 Change cuesheet handling so the id3 info is not spoofed anymore. If something wants the subtracks info it is easy to get to. This makes next track display in the skins show the next subtrack if we are in a cuesheet 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26611 a1c6a512-1295-4272-9138-f99709370657
 2010-06-06 06:28:40 +00:00
Teruaki Kawashima
6e39dc9e27 Correct reusing buffers if the backdrop file is already loaded. 
FS#11305 by myself.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26510 a1c6a512-1295-4272-9138-f99709370657
 2010-06-03 13:32:12 +00:00
Jonathan Gordon
22b12cafbb draw markers on the FM frequency bar for presets (like cuesheet markers in the WPS). 
seems nice but if it ends up looking crap we can revert..


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26429 a1c6a512-1295-4272-9138-f99709370657
 2010-05-31 11:12:15 +00:00
Jonathan Gordon
684b108666 fix red, but this might not be the best long term solution. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26278 a1c6a512-1295-4272-9138-f99709370657
 2010-05-25 04:08:37 +00:00
Jonathan Gordon
f557beac56 remove a stray printf 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26277 a1c6a512-1295-4272-9138-f99709370657
 2010-05-25 04:06:18 +00:00
Jonathan Gordon
5c7be3e6cc fix FS#11321 - the x5 remote used the wrong colours 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26276 a1c6a512-1295-4272-9138-f99709370657
 2010-05-25 04:02:09 +00:00
Jonathan Gordon
9fe7b6cd20 fix remote statusbar not being updated if it is enabled on both displays 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26275 a1c6a512-1295-4272-9138-f99709370657
 2010-05-25 04:00:20 +00:00
Jonathan Gordon
dda102ed4a fix the %Ti (preset index) not working with conditionls correctly 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26246 a1c6a512-1295-4272-9138-f99709370657
 2010-05-24 09:18:03 +00:00
Jonathan Gordon
dcbf4bbdea make radioart work in the sbs 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26221 a1c6a512-1295-4272-9138-f99709370657
 2010-05-21 02:35:11 +00:00
Jonathan Gordon
f531adc312 pass pointers around instead of coping whole structs 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26197 a1c6a512-1295-4272-9138-f99709370657
 2010-05-20 15:27:17 +00:00
Jonathan Gordon
b8176a6761 redo r25569 so the screen is only cleared once instead of every update (which is ~2Hz 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26196 a1c6a512-1295-4272-9138-f99709370657
 2010-05-20 15:21:10 +00:00
Teruaki Kawashima
7042d9516b skin_tokne.c: move WPS_TOKEN_TRACK_STARTING and WPS_TOKEN_TRACK_ENDING to get_id3_token(). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26193 a1c6a512-1295-4272-9138-f99709370657
 2010-05-20 13:41:22 +00:00
Teruaki Kawashima
0a4eda4d46 skin_parser.c: fix possibile overflow in parse_setting_and_lang(). simplify comparison of string in parameter in parse_touchregion(). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26168 a1c6a512-1295-4272-9138-f99709370657
 2010-05-19 15:47:54 +00:00
Teruaki Kawashima
4862fe4451 splash.c: correct calculation of y coordinate of splash. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26108 a1c6a512-1295-4272-9138-f99709370657
 2010-05-17 14:09:35 +00:00
Jonathan Gordon
0a7a7ce213 count is being used as the value of the last item to show, so rename it to not be confusing 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26096 a1c6a512-1295-4272-9138-f99709370657
 2010-05-17 04:08:07 +00:00
Jonathan Gordon
908a5b6a7b the fm presets list should wrap.. so make that work 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26095 a1c6a512-1295-4272-9138-f99709370657
 2010-05-17 02:29:20 +00:00
Alexander Levin
53a858b36c Rearrange statements for a small binsize reduction; delete unneeded braces 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26089 a1c6a512-1295-4272-9138-f99709370657
 2010-05-16 15:05:58 +00:00
Jonathan Gordon
caa4f54e42 fix a minor fms presetlist viewer bug with displaying prev when you are on the first playlist 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26087 a1c6a512-1295-4272-9138-f99709370657
 2010-05-16 13:32:43 +00:00
Jonathan Gordon
7d5e0d7375 FS#11263 - Radio Art support! %C and %Cl tags work in the radio screen and Base Skin when the radio is running. 
put your station images in .rockbox/fmpresets/<preset name>.bmp or .jpg. Must be in preset mode and the preset name must match the filename


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26078 a1c6a512-1295-4272-9138-f99709370657
 2010-05-16 11:13:42 +00:00
Alexander Levin
edb6bedddb Format FM frequency depending on the regional settings (FS#11273) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26069 a1c6a512-1295-4272-9138-f99709370657
 2010-05-15 21:47:30 +00:00
Jeffrey Goode
ff548fad86 Fix include problem 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26039 a1c6a512-1295-4272-9138-f99709370657
 2010-05-15 03:17:12 +00:00
Thomas Martitz
0246f0ceb4 Fix remaining reds/yellows. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26024 a1c6a512-1295-4272-9138-f99709370657
 2010-05-14 13:21:40 +00:00
Alexander Levin
230f0405eb Correct detection of the absence of the current preset 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25990 a1c6a512-1295-4272-9138-f99709370657
 2010-05-13 08:36:38 +00:00
Jonathan Gordon
182d13e3ab fix the freq bar after music plays 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25983 a1c6a512-1295-4272-9138-f99709370657
 2010-05-13 06:59:16 +00:00
Jonathan Gordon
3fbe4d275e fix FS#11264 - frequency bar and presets not working in the sbs 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25982 a1c6a512-1295-4272-9138-f99709370657
 2010-05-13 06:56:21 +00:00
Alexander Levin
6e294e2fc6 Avoid duplicated code, create a formatting function for FM frequency 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25973 a1c6a512-1295-4272-9138-f99709370657
 2010-05-12 21:44:24 +00:00
Jonathan Gordon
a5d8d21596 fix the last of the reds, and make RDS tags actually work (and add them to the hardcoded radio skin) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25966 a1c6a512-1295-4272-9138-f99709370657
 2010-05-12 11:44:09 +00:00
Jonathan Gordon
7b931f0a5a fix red and yellow (most of it anyway) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25965 a1c6a512-1295-4272-9138-f99709370657
 2010-05-12 10:59:20 +00:00
Jonathan Gordon
1bd072c92d FS#10853 - Skin support in the radio screen! Check CustomWPS for the new tags 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25964 a1c6a512-1295-4272-9138-f99709370657
 2010-05-12 10:38:00 +00:00
Jonathan Gordon
f9736c0b63 ok, use a smaller font size on shorter display targets (3K instead of 10K) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25963 a1c6a512-1295-4272-9138-f99709370657
 2010-05-12 10:22:00 +00:00
Jonathan Gordon
d6dbfef452 Borrow another 10K to make sure multifont will have room on even the smallerst screens 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25962 a1c6a512-1295-4272-9138-f99709370657
 2010-05-12 09:31:40 +00:00
Michael Sevakis
35fd1e4e99 Fix F_T_SOUND voicing for decimals and physical values. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25961 a1c6a512-1295-4272-9138-f99709370657
 2010-05-12 06:44:29 +00:00
Michael Sevakis
1de56ac367 Have option_get_valuestring always call sound_val2phys before formatting rather than only if fractional places are specified. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25960 a1c6a512-1295-4272-9138-f99709370657
 2010-05-12 05:23:02 +00:00
Jonathan Gordon
38ef849d06 slightly rework peakmeter handling to make it cleaner and be able to be used in conditionals 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25913 a1c6a512-1295-4272-9138-f99709370657
 2010-05-09 13:01:59 +00:00
Jonathan Gordon
52a8a540b1 revert those last few... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25910 a1c6a512-1295-4272-9138-f99709370657
 2010-05-09 06:52:13 +00:00
Jonathan Gordon
bbb22fa9fc mono targets dont support backdrops so dont use that #define 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25909 a1c6a512-1295-4272-9138-f99709370657
 2010-05-09 06:43:04 +00:00
Jonathan Gordon
66e78ff6df fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25908 a1c6a512-1295-4272-9138-f99709370657
 2010-05-09 06:36:12 +00:00
Jonathan Gordon
3a1d661821 use a better value for the needed skin buffer size 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25907 a1c6a512-1295-4272-9138-f99709370657
 2010-05-09 06:31:42 +00:00
Jeffrey Goode
847bd281e2 Fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25906 a1c6a512-1295-4272-9138-f99709370657
 2010-05-09 02:07:42 +00:00
Jeffrey Goode
1ad76ff25b FS#11250: Hotkey setting method changed to menu item vs button pres in context menu. Manuals updated to match. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25905 a1c6a512-1295-4272-9138-f99709370657
 2010-05-09 02:02:51 +00:00
Steve Bavin
b08222caec Minor const police raid. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25879 a1c6a512-1295-4272-9138-f99709370657
 2010-05-07 16:35:37 +00:00
Jeffrey Goode
32ad1f84ee Revert hotkey bitmaps 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25875 a1c6a512-1295-4272-9138-f99709370657
 2010-05-07 14:46:42 +00:00
Jeffrey Goode
16e0c5730d Hotkey menu items have their own icon 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25866 a1c6a512-1295-4272-9138-f99709370657
 2010-05-07 03:21:12 +00:00
Thomas Martitz
55e4fe73cc Fix the remaining reds. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25858 a1c6a512-1295-4272-9138-f99709370657
 2010-05-06 22:33:57 +00:00
Thomas Martitz
b91f15d842 Fix c&p error from r25853 that should've fixed some snprintf warnings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25857 a1c6a512-1295-4272-9138-f99709370657
 2010-05-06 22:22:47 +00:00
Thomas Martitz
77dfff5a55 Fix some more snprintf related warnings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25853 a1c6a512-1295-4272-9138-f99709370657
 2010-05-06 21:37:03 +00:00
Thomas Martitz
50a6ca39ad Move c/h files implementing/defining standard library stuff into a new libc directory, also standard'ify some parts of the code base (almost entirely #include fixes). 
This is to a) to cleanup firmware/common and firmware/include a bit, but also b) for Rockbox as an application which should use the host system's c library and headers, separating makes it easy to exclude our files from the build.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25850 a1c6a512-1295-4272-9138-f99709370657
 2010-05-06 21:04:40 +00:00
Jonathan Gordon
49f2709a01 If dircache and database "load to ram" is enabled then get the id3 info from the database in the WPS playlist viewer for non buffered tracks 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25841 a1c6a512-1295-4272-9138-f99709370657
 2010-05-06 09:22:55 +00:00
Jonathan Gordon
14532754a7 fix player red. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25827 a1c6a512-1295-4272-9138-f99709370657
 2010-05-05 13:56:44 +00:00
Jonathan Gordon
efd1f4e49f Make it possible to move the UI viewport using conditional viewports. 
%Vi|<label>|<Usual %Vi params>|  <- specify the possible viewports to use
%VI<label> <- make the UI viewport use the %Vi definition with the <label> label.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25826 a1c6a512-1295-4272-9138-f99709370657
 2010-05-05 13:48:50 +00:00
Jonathan Gordon
4c03e9a6f0 fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25756 a1c6a512-1295-4272-9138-f99709370657
 2010-04-29 10:38:03 +00:00
Jonathan Gordon
886ecaa7a4 centre splashes inside the UI viewport instead of the whole screen. Fixes the flickering statusbar issue and saves alot of fullscreen clears 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25755 a1c6a512-1295-4272-9138-f99709370657
 2010-04-29 10:27:35 +00:00
Jonathan Gordon
4c65a1970e Make battery level (%bl) work with the bmp bars drawer like %pb and %pv 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25710 a1c6a512-1295-4272-9138-f99709370657
 2010-04-25 11:32:51 +00:00
Alexander Levin
847a0fd56c Fix grammar in the comment (make code non offending :-) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25695 a1c6a512-1295-4272-9138-f99709370657
 2010-04-21 19:59:49 +00:00
Jonathan Gordon
34cd2c31ae really fix "%pv|something else" this time 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25684 a1c6a512-1295-4272-9138-f99709370657
 2010-04-20 07:17:59 +00:00
Jonathan Gordon
58a0393154 2 quick fixes 
1) fix %pv| where the | is for a conditional break and not for long form %pv
2) only draw bmp-bars if they are enabled (by a conditional or always on.)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25677 a1c6a512-1295-4272-9138-f99709370657
 2010-04-19 08:43:42 +00:00
Bertrik Sikken
44454c3203 Move audio_peek_track declaration from skin_display.c to audio.h 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25670 a1c6a512-1295-4272-9138-f99709370657
 2010-04-18 14:59:43 +00:00
Jonathan Gordon
69710e54f1 fix escaped chars being displayed twice in the playlist viewer (i.e %> showing as >> ) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25663 a1c6a512-1295-4272-9138-f99709370657
 2010-04-17 12:45:52 +00:00
Jonathan Gordon
6c175effc5 drop the playlist viewer stack usage by reading straiught off the buffer instead of copying it. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25661 a1c6a512-1295-4272-9138-f99709370657
 2010-04-17 12:02:02 +00:00
Jonathan Gordon
bc18c89434 use strlcat() instead of snprintf in the playlist viewer, and fix it so it will show the whole playlist if it would fit in the viewport (instead of missing the last item) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25660 a1c6a512-1295-4272-9138-f99709370657
 2010-04-17 11:41:01 +00:00
Jonathan Gordon
99a2299654 allow %pb and %pv (long form) to be put inside conditionals (i.ee not eat the whole line). 
If this causes your theme to break you need to add a # after the line.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25616 a1c6a512-1295-4272-9138-f99709370657
 2010-04-13 07:32:00 +00:00
Jens Arnold
268c6d1e7f Fix two viewport related charcell bugs: crashes in the yesno screen and the USB screen. This mess should really be fixed properly by enabling viewport management for charcell. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25587 a1c6a512-1295-4272-9138-f99709370657
 2010-04-11 12:28:02 +00:00
Jonathan Gordon
a1c0d5597f shuld fix red and yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25585 a1c6a512-1295-4272-9138-f99709370657
 2010-04-11 11:40:47 +00:00
Jonathan Gordon
4421746357 Rework how progressbars are managed so you can have as many bars in a viewport as you want (!). 
Change %pv (volume) to be able to be drawn in the same style as %pb (using a line or a bmp). %pv - no change, %pv|bmp|x|y|width|height| exactly like %pb
DO NOT use %?pv|....| because it will draw when you dont want it to!


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25584 a1c6a512-1295-4272-9138-f99709370657
 2010-04-11 11:18:45 +00:00
Alexander Levin
4702770933 Use the existing type instead of defining an ad hoc one 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25575 a1c6a512-1295-4272-9138-f99709370657
 2010-04-10 21:11:19 +00:00
Alexander Levin
f23251999c Reset the number of lines to 0 when initializing the simple list 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25573 a1c6a512-1295-4272-9138-f99709370657
 2010-04-10 20:25:23 +00:00
Michael Chicoine
e3379ed812 Fix scrolling line artifacts on USB screen - should fix FS#11154 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25569 a1c6a512-1295-4272-9138-f99709370657
 2010-04-10 15:55:31 +00:00
Torne Wuff
52e528e057 Boot charting support. 
Select (B)ootchart in advanced options in configure, and logf will record timings for various stages of boot, for performance comparisons. Format logged is:
BC:>function_name,123,80
where 123 is the line number, 80 is the number of ticks since boot. This can be loaded as CSV into a spreadsheet.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25426 a1c6a512-1295-4272-9138-f99709370657
 2010-04-01 16:27:21 +00:00
Jeffrey Goode
d5e6bc7a8c FS#11081 - Hotkey patch. Many targets supported, but some keymaps need work before they can be switched on 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25414 a1c6a512-1295-4272-9138-f99709370657
 2010-04-01 03:14:44 +00:00
Torne Wuff
05ace8e095 Fix "bookmark on stop: ask" when idle poweroff triggers. 
Previously, the prompt would come up during poweroff, and then if the user did not respond, the shutdown timeout would be hit and a hard poweroff would happen, which is bad. Now it just assumes you don't want a bookmark.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25376 a1c6a512-1295-4272-9138-f99709370657
 2010-03-28 23:27:49 +00:00
Jonathan Gordon
dafca1405e revert r25271 which caused more problems than it tried to fix 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25296 a1c6a512-1295-4272-9138-f99709370657
 2010-03-23 02:19:48 +00:00
Jonathan Gordon
4160fd91a7 there is a difference between viewports which shouldnt be cleared (the default viewport in the sbs) and viewports which should never be shown (%Vi viewport). so do this properly 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25271 a1c6a512-1295-4272-9138-f99709370657
 2010-03-21 13:27:55 +00:00
Jonathan Gordon
9c159c5d67 woops, elapsed is ms not HZ and how did that extra + get in there? 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25241 a1c6a512-1295-4272-9138-f99709370657
 2010-03-18 08:00:22 +00:00
Jonathan Gordon
e1fd5c2801 fix yelllow and add those tags to the debug output 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25240 a1c6a512-1295-4272-9138-f99709370657
 2010-03-18 07:20:14 +00:00
Jonathan Gordon
d2e2c2ad96 2 new tags: 
%pS - track is starting.
%pE - track is ending. both can optionally have a number straight after to change how long that tag should stay true for (e.g %pS10 will stay true for the first 10s of the track)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25239 a1c6a512-1295-4272-9138-f99709370657
 2010-03-18 07:08:49 +00:00
Jonathan Gordon
d384f8d064 rearrange the skin loading to remove some code dupe 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25196 a1c6a512-1295-4272-9138-f99709370657
 2010-03-15 07:35:27 +00:00
Jonathan Gordon
1a8f29ca33 fix the remote font not working when there is no .rsbs loaded 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25195 a1c6a512-1295-4272-9138-f99709370657
 2010-03-15 07:12:33 +00:00
Jonathan Gordon
0f69a8152f fiddle with the skin debug output so the load lines arnt shown unless debugwps is enabled 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25162 a1c6a512-1295-4272-9138-f99709370657
 2010-03-14 11:32:03 +00:00
Jonathan Gordon
1759a299f1 fix FS#11100 - statusbar would show up on multiscreen targets if either screen had it enabled 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25159 a1c6a512-1295-4272-9138-f99709370657
 2010-03-13 22:26:03 +00:00
Torne Wuff
86dc6c1204 Change USB HID mode string from just "Multimedia Mode" (or similar) to say "USB keypad mode: Multimedia" (or similar). 
This will hopefully reduce the huge confusion from new users who think that multimedia mode means it's doing MTP or some other thing which is not MSC.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25132 a1c6a512-1295-4272-9138-f99709370657
 2010-03-12 17:32:24 +00:00
Thomas Martitz
61320ce0eb Make mini2440 compile again. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25081 a1c6a512-1295-4272-9138-f99709370657
 2010-03-08 23:43:11 +00:00
Jonathan Gordon
0376208a48 revert r25054 - tags which have an off and a list of option should have off as the first not last option. also fix it so the no icon position actually works. 
you can use %?Li<no|yes> if you want to.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25063 a1c6a512-1295-4272-9138-f99709370657
 2010-03-07 21:07:41 +00:00
Teruaki Kawashima
ce92b8bf34 Slightly change how %Li works when used as a conditional. last part is selected if and only if icon is not presented (i.e. is no icon) so that it can be used like true/false type conditional tag, e.g. "%?Li<Icon|No Icon>". 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25054 a1c6a512-1295-4272-9138-f99709370657
 2010-03-07 13:39:19 +00:00
Teruaki Kawashima
f50885534e Pass width instead of x+width to ab_draw_markers()/cue_draw_markers() and don't recalculate the width in these functions. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25053 a1c6a512-1295-4272-9138-f99709370657
 2010-03-07 12:51:23 +00:00
Teruaki Kawashima
1fbdd91333 skin: don't calculate id3->elapsed+state->ff_rewind_count each time. remove trailing spaces. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25045 a1c6a512-1295-4272-9138-f99709370657
 2010-03-06 14:14:44 +00:00
Magnus Holmgren
a14f4acb0c Restore the 'read_disk' flag for settings_apply that was removed in r24922. It is still needed to prevent uncessary disk I/O for fonts etc. Should fix FS#11071 (I haven't tested it on a HD-based player). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25042 a1c6a512-1295-4272-9138-f99709370657
 2010-03-06 12:14:12 +00:00
Jonathan Gordon
f1b209c057 fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25039 a1c6a512-1295-4272-9138-f99709370657
 2010-03-06 00:37:01 +00:00
Jonathan Gordon
a9b5f4d810 cleanup statusbar+base skin relationship... 
* remove the "custom" option from the statusbar setting. if a sbs file is set then statusbar setting is ignored, no other user visible change there.
* new tag, %wi  - use to draw the inbuilt statusbar in the current viewport


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25038 a1c6a512-1295-4272-9138-f99709370657
 2010-03-06 00:29:46 +00:00
Thomas Martitz
4cdcb63de1 Don't call this two, it's uneeded (and would crash since they're INIT_ATTR). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25015 a1c6a512-1295-4272-9138-f99709370657
 2010-03-03 23:38:46 +00:00
Thomas Martitz
f8edc32589 FS#10756 - Free unused init code 
Introduce a new .init section for initialisation code, so that it can be copied to an area which is later overwritten before calling. The stack/bss can then overwrite that code, effectively freeing the code size that the initialisation routines need. Gives a few kB ram usage back.
Only implemented for PP and as3525 so far. More targets could be added, as well as more functions.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25013 a1c6a512-1295-4272-9138-f99709370657
 2010-03-03 23:20:32 +00:00
Jonathan Gordon
d9adfa1c73 FS#11072 - display the filename of the skin begin parsed in the debug output 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25003 a1c6a512-1295-4272-9138-f99709370657
 2010-03-03 08:30:31 +00:00
Jonathan Gordon
779d4e3ff7 remove some gremlins... viewport_set_*() sets the font to the UI font for that screen which is bad for the parser. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25002 a1c6a512-1295-4272-9138-f99709370657
 2010-03-03 05:57:15 +00:00
Jonathan Gordon
25d9771ebc make %Fl (font load) more consistant with bmp loading and require the whole filename, i.e require the .fnt. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25001 a1c6a512-1295-4272-9138-f99709370657
 2010-03-03 05:43:02 +00:00
Jonathan Gordon
b8eb44d7db fix FS#10926 - backlight turning off stops track info being updated 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24998 a1c6a512-1295-4272-9138-f99709370657
 2010-03-03 02:20:40 +00:00
Jonathan Gordon
e89f0dc8a6 Fix FS#11058 - conditionl viewports cause sublines to go a bit crazy 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24997 a1c6a512-1295-4272-9138-f99709370657
 2010-03-03 02:10:26 +00:00
Jonathan Gordon
6a6df5a1eb some small debug info fixes, add %Li and %lt and make uppercase subimage labels display correctly 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24996 a1c6a512-1295-4272-9138-f99709370657
 2010-03-03 01:38:25 +00:00
Jonathan Gordon
cc4363ad18 remove a nonsense outdate warning. there is no token limit anymore 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24995 a1c6a512-1295-4272-9138-f99709370657
 2010-03-03 00:54:41 +00:00
Jonathan Gordon
f37b5078f6 undo that last undo, make the font loader more forgiving to user errors 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24994 a1c6a512-1295-4272-9138-f99709370657
 2010-03-03 00:53:07 +00:00
Jonathan Gordon
9e611b1b00 revert r24989 ad r24990 which are cuasing segfaults... they were working fine for me though :( (stupid font stuff is cursed!) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24993 a1c6a512-1295-4272-9138-f99709370657
 2010-03-02 21:47:35 +00:00
Jonathan Gordon
04e0d6c12c fix %pb when the height isnt given and it is in a viewport with a user font (so the height is calculated on the font height at display time) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24991 a1c6a512-1295-4272-9138-f99709370657
 2010-03-02 08:47:45 +00:00
Jonathan Gordon
3f09d7eed1 fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24990 a1c6a512-1295-4272-9138-f99709370657
 2010-03-02 08:32:55 +00:00
Jonathan Gordon
34f51ccb04 * Make the user font count more sane 
* font 2-9 in the skins will always be user fonts in the skins
* init the skinfonts array so it doesnt think id 'x' is used already
* make the parser work with FONT_UI untill the very end, even on remote fonts


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24989 a1c6a512-1295-4272-9138-f99709370657
 2010-03-02 08:24:50 +00:00
Thomas Martitz
3b52937c8a Revert r24958. It didn't fix anything (in fact, the problem described didn't exist). Increase MAXFONTS by 1 to allow for remote screen targets to load fonts 2-9. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24983 a1c6a512-1295-4272-9138-f99709370657
 2010-03-01 15:16:05 +00:00
Bertrik Sikken
7ab1cd7b1b Save some RAM by changing a char[] into a const char * in struct afmt_entry. Make other fields const too. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24970 a1c6a512-1295-4272-9138-f99709370657
 2010-02-28 14:13:35 +00:00
Teruaki Kawashima
38efc71615 set viewport to default one just for safe. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24969 a1c6a512-1295-4272-9138-f99709370657
 2010-02-28 14:12:41 +00:00
Jonathan Gordon
6434e760fc move a #ifdef so the full amount of user choosable skin fonts are avilable on non remote targets (i.e 2-9 inclusive) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24958 a1c6a512-1295-4272-9138-f99709370657
 2010-02-28 08:48:04 +00:00
Jonathan Gordon
8717c1eaa1 redo r24943. the font mappings are not needed once the skin is finished parsing so using the skin buffer there is a waste and overcomplicates things. 
Also that commit breaks plain %pb so make sure you dont use %pb inside a viewport with a font number > 1


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24957 a1c6a512-1295-4272-9138-f99709370657
 2010-02-28 08:36:13 +00:00
Michael Giacomelli
1fefb48e87 Fix System/Running Time to reset the running time whenever a charger or USB cable is inserted, not just when the cable is inserted in the running time screen. Should now make the running time actually be the amount of time rockbox has run since the battery was last charged, which is as far as I can tell the original idea behind the runtime menu. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24954 a1c6a512-1295-4272-9138-f99709370657
 2010-02-27 22:47:49 +00:00
Thomas Martitz
ea4eadc582 Add playlist viewer screen to %cs. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24953 a1c6a512-1295-4272-9138-f99709370657
 2010-02-27 21:24:50 +00:00
Thomas Martitz
81ebf2be6f Fix dead parts of the wps when leaving it. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24952 a1c6a512-1295-4272-9138-f99709370657
 2010-02-27 21:19:34 +00:00
Nils Wallménius
722ae97836 Set missing svn properties 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24947 a1c6a512-1295-4272-9138-f99709370657
 2010-02-27 18:07:38 +00:00
Nils Wallménius
519b3e25b8 mark array as const and use ARRAYLEN macro for calculating length of the array 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24946 a1c6a512-1295-4272-9138-f99709370657
 2010-02-27 17:46:51 +00:00
Thomas Martitz
226308663f Store the list of fonts in a linked list instead of in a static array (together with the base filename) and load all fonts in a second step. This aids debugging missing fonts, skips fonts that are not used in viewports, and is preparation of a resizable (on boot) skin buffer. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24943 a1c6a512-1295-4272-9138-f99709370657
 2010-02-27 16:51:51 +00:00
Jonathan Gordon
92f0aa85fc fix 64bit warning 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24923 a1c6a512-1295-4272-9138-f99709370657
 2010-02-26 08:43:26 +00:00
Jonathan Gordon
4c6b3551b5 split the theme settings apply() sutff out of settings_apply(). this should fix splashes not being loc'ed, statusbar over the splash (fixed in sim, not on my mini2g though), and the supposed boot time slowdown. 
What this also does is remove a bunch of unnecessary settings_Apply()'s from the ipod accessory code, and causes all non-skin settings to get applied each time (this includes font and langs which we wernt doing to stop disk access)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24922 a1c6a512-1295-4272-9138-f99709370657
 2010-02-26 08:01:41 +00:00
Jonathan Gordon
321148124a Fix the list showing an empty line at the bottom if the sbs is handling the title 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24919 a1c6a512-1295-4272-9138-f99709370657
 2010-02-26 06:45:50 +00:00
Jonathan Gordon
cf6be66db6 small change to how the quickscreen fixes its viewports 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24918 a1c6a512-1295-4272-9138-f99709370657
 2010-02-26 06:17:04 +00:00
Jonathan Gordon
466e5d9aa4 2 new tags for the base skin. 
%Lt - the title text for the current list
%Li - the icon number. Same order as the CustomIcons list, except the first icon is the "no icon" icon.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24917 a1c6a512-1295-4272-9138-f99709370657
 2010-02-26 03:45:41 +00:00
Teruaki Kawashima
51bc09e88e Quickscreen: add more check for case that qs item is not set. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24901 a1c6a512-1295-4272-9138-f99709370657
 2010-02-25 06:01:53 +00:00
Jonathan Gordon
31fb4f6ff6 Change how touchscreen regions work slightly... "It modifies the behaviour of touch buttons to be more similar to the way gui buttons operate in desktop applications. Upon a touch press event, the button at the touch position is armed. Upon a touch repeat or release, the button at the touch position is triggered only if it is armed. Upon release (and wps entry), all buttons are disarmed. E.g. when you touch press on an empty area, then while pressing drag your finger on a button, then release the button, the button is not triggered." 
Author: Jens Theeß 
Flyspray: FS#10982


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24876 a1c6a512-1295-4272-9138-f99709370657
 2010-02-24 06:19:25 +00:00
Jonathan Gordon
6c4b80c67b make the parser spit out filenames of images it cant load 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24875 a1c6a512-1295-4272-9138-f99709370657
 2010-02-24 06:15:55 +00:00
Jonathan Gordon
0acb38b61c some minor changes to checkwps, shouldn't change anything 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24874 a1c6a512-1295-4272-9138-f99709370657
 2010-02-24 05:58:16 +00:00
Tomer Shalev
9d268d796c Quickscreen: Hande case where not all quick settings are defines 
This happens in Archos Recorder, see quick_screen_f3(), which caused crash
(FS#11037), due to top item not defined.
The commit explicitly sets items[QUICKSCREEN_TOP] to NULL, and also draws an
arrow only if the item is defined.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24871 a1c6a512-1295-4272-9138-f99709370657
 2010-02-23 21:30:16 +00:00
Teruaki Kawashima
d151371836 correct checking size in function get_image_filename. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24844 a1c6a512-1295-4272-9138-f99709370657
 2010-02-22 06:00:49 +00:00
Frank Gevaerts
84a4a1d5cc statusbar_position should also return enum statusbar_values if it's a macro 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24833 a1c6a512-1295-4272-9138-f99709370657
 2010-02-21 22:05:32 +00:00
Thomas Martitz
a31624e76e Fix the mechanism to fail to parse skins if images fail to load and fix having no backdrop at all (neither %X nor backdrop setting, DancePuffDuo was broken). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24814 a1c6a512-1295-4272-9138-f99709370657
 2010-02-21 19:29:33 +00:00
Jonathan Gordon
f85103e8f2 remote multifont fixes. it shoud be working again (blame AlexP! he made me break it last week!) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24812 a1c6a512-1295-4272-9138-f99709370657
 2010-02-21 19:10:09 +00:00
Teruaki Kawashima
dafcd1470a remove unused fields from struct gui_synclist. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24807 a1c6a512-1295-4272-9138-f99709370657
 2010-02-21 13:32:52 +00:00
Jonathan Gordon
eca85ac327 make sure font fd's get closed when a new skin is loaded 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24803 a1c6a512-1295-4272-9138-f99709370657
 2010-02-21 02:53:50 +00:00
Thomas Martitz
c19e53654b Playlist Viewer Changes to bring consistency: 
- combine its two context menus to one and
- make the ACTION_STD_MENU go to the main menu as it does in all other screens
- call playlist_viewer() via root_menu to reduce call depth and to be consistent with other screens (and for the above changes to be more flexible w.r.t to the following screen)

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24791 a1c6a512-1295-4272-9138-f99709370657
 2010-02-20 19:06:39 +00:00
Tomer Shalev
516d1264f8 WPS: Use helper local variable instead of its value (no functional change) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24789 a1c6a512-1295-4272-9138-f99709370657
 2010-02-20 13:26:50 +00:00
Jonathan Gordon
ccd50dd2d7 and actually fix multifont on remote lcd targets also 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24780 a1c6a512-1295-4272-9138-f99709370657
 2010-02-19 23:54:36 +00:00
Jonathan Gordon
90d9e66920 fix possible out-of-bounds error on remote lcd targets if they try loading a font to id==2 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24779 a1c6a512-1295-4272-9138-f99709370657
 2010-02-19 23:49:17 +00:00
Jonathan Gordon
45a181d8fc allow integer sound settings (bass, volume, etc) to be used with conditional %St. "%?St|name|<min|min+1|...|max-1|max>" 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24745 a1c6a512-1295-4272-9138-f99709370657
 2010-02-18 07:04:16 +00:00
Jonathan Gordon
7dfd594cca fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24741 a1c6a512-1295-4272-9138-f99709370657
 2010-02-18 02:37:58 +00:00
Jonathan Gordon
3cb735ef39 basic alignment support (%a|l|c|r|L|R) in the playlist viewer. no sublines so the whole line will either be left, right or centered. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24740 a1c6a512-1295-4272-9138-f99709370657
 2010-02-18 01:52:13 +00:00
Jonathan Gordon
f7ba156b27 change the %St tag so it only shows the filename of file settings, not the full path (i.e cabbiev2 instead of /.rockbox/wps/cabbiev2.wps) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24717 a1c6a512-1295-4272-9138-f99709370657
 2010-02-17 07:17:06 +00:00
Teruaki Kawashima
13035a48af scrollbar.c: Simplify code a bit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24694 a1c6a512-1295-4272-9138-f99709370657
 2010-02-16 13:38:30 +00:00
Teruaki Kawashima
d50c78c238 * surround member only used by charcells with #ifdef HAVE_LCD_CHARCELLS in struct scrollinfo in scroll_engine.h. 
* remove function prototypes which are not actualy defined.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24693 a1c6a512-1295-4272-9138-f99709370657
 2010-02-16 11:59:37 +00:00
Jonathan Gordon
877d378710 Reuse the backdrop buffers if 2 skins use the same backdrop (on the same screen of course) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24690 a1c6a512-1295-4272-9138-f99709370657
 2010-02-16 05:24:27 +00:00
Maurus Cuelenaere
5ea32cf05a WPS volume touchregion: fix reverse Y coordinate in portrait mode 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24649 a1c6a512-1295-4272-9138-f99709370657
 2010-02-14 15:31:19 +00:00
Jonathan Gordon
1c2aa35371 FS#10984 - multifont! 2 major additions: 
1) seperate UI font for the remote and main displays
2) allow individual skins to load additional fonts for use in the skin (Uo to 7 extra in this first version) see CustomWPS for info on how to load a font in the skins.

Code should always use FONT_UI+screen_number to get the correct user font


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24644 a1c6a512-1295-4272-9138-f99709370657
 2010-02-14 06:26:16 +00:00
Maurus Cuelenaere
9ec0c1669c Touchscreen: fix scrollbar handling when it's on the right 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24635 a1c6a512-1295-4272-9138-f99709370657
 2010-02-13 15:53:10 +00:00
Teruaki Kawashima
1549b19d9e color_picker: a bit of rework for color_picker. 
* don't call display->getcharheight() so often, store the value to char_height and use it instead.
* replay title_height by char_height, they should be the same.
* fix spaces.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24595 a1c6a512-1295-4272-9138-f99709370657
 2010-02-11 14:18:31 +00:00
Teruaki Kawashima
93f9e7cbfb fix text scrolling handling in do_menu, set_time_screen and time_screen. 
Don't scroll text in time_screen(). the lines will be redrawn before scrolling statrs, so they don't scroll anyway.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24591 a1c6a512-1295-4272-9138-f99709370657
 2010-02-11 10:41:06 +00:00
Jonathan Gordon
f8aa88ba50 OK, this is hopefully the last sbs related fix. This one will fix the backdrop going garbage, and add a missing else which kugel spotted 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24579 a1c6a512-1295-4272-9138-f99709370657
 2010-02-10 04:53:04 +00:00
Jonathan Gordon
fd2fdc2d75 Fix FS#10983 - r24568 was just moronic. Sorry 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24578 a1c6a512-1295-4272-9138-f99709370657
 2010-02-10 04:19:50 +00:00
Alex Parker
3e4e67b408 Fix WPS backdrop drawing, as instructed by JdGordon. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24571 a1c6a512-1295-4272-9138-f99709370657
 2010-02-08 22:34:04 +00:00
Jonathan Gordon
9955e9a7df unconditioannly show the main/base skins backdrop when enabling the theme so plugins show the correct backdrop in menus 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24568 a1c6a512-1295-4272-9138-f99709370657
 2010-02-08 17:19:15 +00:00
Jonathan Gordon
54ca765769 fix red. these long #if's need to be changed to a single #define 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24566 a1c6a512-1295-4272-9138-f99709370657
 2010-02-08 09:47:08 +00:00
Jonathan Gordon
7e6f124d4e revert r24478 and make the backdrop behaviour the same as it used to be (so when in the wps the sbs' backdrop will be fully disabled). Also changes the API back to having to manually set the current backdrop. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24565 a1c6a512-1295-4272-9138-f99709370657
 2010-02-08 09:38:03 +00:00
Jonathan Gordon
dc3f746af2 fix FS#10957 - the wps backdrop is always shown in the "create bookmark?" ask screen (Actual fix is to always enable the theme in the yesno screen) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24560 a1c6a512-1295-4272-9138-f99709370657
 2010-02-08 05:11:32 +00:00
Jonathan Gordon
5513c30e34 make all the RTC tokens in the skins be useable in conditionals (I dare anyone to use %cY though :D ) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24526 a1c6a512-1295-4272-9138-f99709370657
 2010-02-05 23:58:53 +00:00
Jonathan Gordon
0a16a99a69 fix a bug where the backdrop from the sbs is displayed on scrolling lines in the wps when the %wd tag is not used. 
I'm not crazy about this commit and maybe a better solution would be to outright disable the sbs backdrop when in any skinned screen. This then means backdrops go back to needing special handling (i.e they arnt "free")



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24478 a1c6a512-1295-4272-9138-f99709370657
 2010-02-03 07:03:48 +00:00
Jonathan Gordon
bb86299b81 make sure skins always draw with their backdrop, otherwise the backdrop only changes on a full redraw which usually ends up being in the wrong order 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24435 a1c6a512-1295-4272-9138-f99709370657
 2010-02-01 04:47:19 +00:00
Jonathan Gordon
c0e2d9fe1b Fix RTL list handing when not loading a custom base skin. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24401 a1c6a512-1295-4272-9138-f99709370657
 2010-01-31 03:08:44 +00:00
Jonathan Gordon
4c514b9d94 really the last of the red this time 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24370 a1c6a512-1295-4272-9138-f99709370657
 2010-01-29 08:39:08 +00:00
Jonathan Gordon
03ab592c9c bugger, too tired, didnt mean to commit this. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24369 a1c6a512-1295-4272-9138-f99709370657
 2010-01-29 08:26:14 +00:00
Jonathan Gordon
ae91e8b693 fix the last of the red... note to self, fix backdrop.h! 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24368 a1c6a512-1295-4272-9138-f99709370657
 2010-01-29 08:25:24 +00:00
Jonathan Gordon
349bf08ed1 fix reds 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24367 a1c6a512-1295-4272-9138-f99709370657
 2010-01-29 08:13:40 +00:00
Jonathan Gordon
eee5423fe1 skin rework (FS#10922) notable changes: 
- simplify the setting/skin relationship. settings are used as the fallback if it's not specified in the skin
- backdrop buffers are now in the skin buffer (which has also increased slightly to accomodate 1 backdrop for each skin and 2 full colour screens for bmps (up for 1.5))
- if no %X is specified in a skin then the backdrop setting will be used. use %Xd to explicitly disable a skin from displaying a backdrop
- the base skin can now specify a backdrop.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24366 a1c6a512-1295-4272-9138-f99709370657
 2010-01-29 07:52:13 +00:00
Jonathan Gordon
6f0f98da1d Fix remote backdrop crashes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24357 a1c6a512-1295-4272-9138-f99709370657
 2010-01-28 06:54:37 +00:00
Thomas Martitz
e18e806930 Fix yellows 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24352 a1c6a512-1295-4272-9138-f99709370657
 2010-01-27 20:45:42 +00:00
Thomas Martitz
feb3a261c7 Fix multiscreen handling of the viewportmanager. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24351 a1c6a512-1295-4272-9138-f99709370657
 2010-01-27 20:34:51 +00:00
Jonathan Gordon
2565389402 futile attempt to keep the ondioSP rombox working. This will almost certainly be the last release with it. (The backdrop API is chaning very soon after release so this is no big deal) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24340 a1c6a512-1295-4272-9138-f99709370657
 2010-01-27 06:47:56 +00:00
Thomas Martitz
e8ae70a382 Fix wps showing parts of the main backdrop in some circumstances. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24336 a1c6a512-1295-4272-9138-f99709370657
 2010-01-26 21:29:08 +00:00
Thomas Martitz
5629d551d7 Accept the last patch FS#10797 with a few changes by me (fixing side effects and adding the new backdrop_hide() to the multi screen api). It changes the hide_bars parameter to mean hide_theme. 
This makes plugins show the menu backdrop in their backdrop so that they don't look like crap if you have an sbs and look more integrated. I've test about all plugins and all work fine.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24335 a1c6a512-1295-4272-9138-f99709370657
 2010-01-26 20:14:42 +00:00
Bertrik Sikken
552835ebe2 Add a missing #include, make a function static, make touchpad_set_buttonlight implementation and declaration consistent 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24281 a1c6a512-1295-4272-9138-f99709370657
 2010-01-18 21:20:36 +00:00
Jonathan Gordon
12173598e4 fix red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24234 a1c6a512-1295-4272-9138-f99709370657
 2010-01-15 07:30:30 +00:00
Jonathan Gordon
fea4689e91 Get rid of those horrible macros to protect against NULL reference when looking up the id3 info for tokens. 
Change the way the wps playlist viewer gets the token values. All %i tokens are now supported (and a few others, experiment :) )


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24233 a1c6a512-1295-4272-9138-f99709370657
 2010-01-15 07:20:56 +00:00
Jonathan Gordon
51630cbac1 outright reject any tags which need a special parser in the wps playlist viewer. There is no intention of even trying to support them and without this possible upcoming changes will cause crashes if any of those tags are used. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24229 a1c6a512-1295-4272-9138-f99709370657
 2010-01-15 01:26:57 +00:00
Jonathan Gordon
a1b97086c5 fix typo 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24223 a1c6a512-1295-4272-9138-f99709370657
 2010-01-13 07:47:53 +00:00
Jonathan Gordon
d668900848 Fix red and yellow. HWCODEC cant see the metadata for more than the next track so only show the filename there 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24221 a1c6a512-1295-4272-9138-f99709370657
 2010-01-13 06:24:21 +00:00
Jonathan Gordon
dc0ba917fa FS#10898 - Add a playlist viewer to the WPS. http://www.rockbox.org/wiki/CustomWPS#Playlist_viewer for an exaplanation how to use it. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24220 a1c6a512-1295-4272-9138-f99709370657
 2010-01-13 06:02:38 +00:00
Teruaki Kawashima
67470c890a list: improvement to move and show selection in multi-line lists. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24195 a1c6a512-1295-4272-9138-f99709370657
 2010-01-07 12:51:57 +00:00
Jonathan Gordon
669afd093d fix checkwps 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24194 a1c6a512-1295-4272-9138-f99709370657
 2010-01-07 07:47:19 +00:00
Jonathan Gordon
91e6b06be9 RTL language enhancements by Tomers Shalev and I. 
3 new tokens:
%ax - the next token should follow the language direction (what that means is defined by the individual tokens)
%aL - align left on LTR language (same as %al), right on RTL languages
%aR - align right on LTR language (same as %ar), left on RTL languages

This commit adds %ax support to the %V and %Cl tokens. 


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24193 a1c6a512-1295-4272-9138-f99709370657
 2010-01-07 07:34:15 +00:00
Michael Chicoine
8e8e2627b2 FS#10856 - Skip to previous track inconsistent when using cuesheet 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24191 a1c6a512-1295-4272-9138-f99709370657
 2010-01-06 14:48:42 +00:00
Bertrik Sikken
44fa025d8f Use plain int (instead of char) for field selection_size in struct simplelist_info 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24188 a1c6a512-1295-4272-9138-f99709370657
 2010-01-05 21:15:20 +00:00
Bertrik Sikken
6fef14bd16 Set svn:keywords property on .c and .h files that didn't already have it. Correct svn:executable property on some files. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24165 a1c6a512-1295-4272-9138-f99709370657
 2010-01-03 14:28:09 +00:00
Bertrik Sikken
92d2874959 apps/gui/bitmap/list.c: use bool instead of int to hold boolean value 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24161 a1c6a512-1295-4272-9138-f99709370657
 2010-01-03 13:14:50 +00:00
Andree Buschmann
05778b501d Fix further tabs 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24156 a1c6a512-1295-4272-9138-f99709370657
 2010-01-03 10:50:34 +00:00
Bertrik Sikken
1d46959012 Make debug builds compile again 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24150 a1c6a512-1295-4272-9138-f99709370657
 2010-01-02 23:56:11 +00:00
Bertrik Sikken
5c4ef78cc9 Simplify some expressions using the ? operator 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24136 a1c6a512-1295-4272-9138-f99709370657
 2010-01-01 22:47:25 +00:00
Tomer Shalev
e15a0c9118 WPS: Use helper function to parse int value on album-art directive 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24121 a1c6a512-1295-4272-9138-f99709370657
 2009-12-29 18:14:31 +00:00
Jonathan Gordon
ae08a21b42 Fix FS#10215 - peakmeter updates breaks scrolling lines in conditionally enalbed viewports... fix is to not disable conditional viewports during these updates which are *only* touching the pm token anyway 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24090 a1c6a512-1295-4272-9138-f99709370657
 2009-12-21 06:35:31 +00:00
Jonathan Gordon
65f18a7044 fix yello 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24088 a1c6a512-1295-4272-9138-f99709370657
 2009-12-21 05:32:23 +00:00
Jonathan Gordon
9d1832cfba fix FS#10870 - slightly change the viewportmanager theme undo-er to be able to force an update even if the theme isnt being toggled from off to on which caused WPS artifacts when leaving the WPS if the theme was enabled 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24087 a1c6a512-1295-4272-9138-f99709370657
 2009-12-21 05:19:12 +00:00
Jonathan Gordon
88ae46cc88 fix another bug from FS#10771 - list touchscreen handling needs to ignore presses outside the list viewport. 
It probably makes sense to pass off any button presses outside of the list viewport to the sbs, I'll leave that for someone else though


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24086 a1c6a512-1295-4272-9138-f99709370657
 2009-12-21 04:42:20 +00:00
Bertrik Sikken
0201a19d2d Make read-only struct const 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24085 a1c6a512-1295-4272-9138-f99709370657
 2009-12-20 18:04:07 +00:00
Bertrik Sikken
5698674ece Code police: add missing header file, make some local functions static 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24083 a1c6a512-1295-4272-9138-f99709370657
 2009-12-20 16:28:15 +00:00
Jonathan Gordon
0900b563f2 FS#10855 3 minor sbs bugs, spotted and fixed by Teruaki Kawashima 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24065 a1c6a512-1295-4272-9138-f99709370657
 2009-12-18 06:51:36 +00:00
Jonathan Gordon
e425371e10 Fix FS#10289 - screens showing a list need to check the show_icons setting before setting the callback. the List will now always draw icons if a callback is set (like its always done for voice) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24022 a1c6a512-1295-4272-9138-f99709370657
 2009-12-16 08:36:46 +00:00
Jeffrey Goode
033ed87321 Fix yellow: add braces 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23918 a1c6a512-1295-4272-9138-f99709370657
 2009-12-10 16:21:29 +00:00
Frank Gevaerts
4862e28b67 Fix FS#10841. Thanks to Thomas Martitz for spotting what was wrong. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23914 a1c6a512-1295-4272-9138-f99709370657
 2009-12-09 20:34:06 +00:00
Jonathan Gordon
dd9fbbf7c8 fix red checkwps 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23905 a1c6a512-1295-4272-9138-f99709370657
 2009-12-09 07:44:08 +00:00
Jonathan Gordon
b2eb44ce0e FS#10824 - viewport/statusbar API rework. 
Hopefully the only user visible changes are:
- fm and recording screens go by the statusbar setting (sbs or inbuilt)
- plugins go back to using the theme as they should for menus and lists
- splash screens might get cut a bit... entirely theme and splash dependant.. if there is a problematic one we can look at it later.
- hopefully nothing more than very minor screen flickerings... let me know exactly where they are so they can be fixed

New GUI screen rules:
* Screens assume that the theme (sbs+ui viewport+ maybe background image) are always enabled. They may be disabled on a per display basis, but MUST be re-enabled on exit
* Screens must not be coded in a way that requires a statusbar of any type.. the inbuilt bar will be removed shortly.
ALWAYS RESPECT THE USERS SETTINGS unless the screen requires the full display to fit.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23904 a1c6a512-1295-4272-9138-f99709370657
 2009-12-09 07:25:46 +00:00
Tomer Shalev
8db32ddfee Skin parser: Use parse_list() when possible 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23846 a1c6a512-1295-4272-9138-f99709370657
 2009-12-04 13:10:06 +00:00
Jonathan Gordon
58ca43dc9d fix FS#10674 - make skin debugger count the lines correctly so the line number in the output is actually useful! 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23825 a1c6a512-1295-4272-9138-f99709370657
 2009-12-03 05:36:23 +00:00
Jonathan Gordon
85bcd1eaf7 fix segfault on %Rb token 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23798 a1c6a512-1295-4272-9138-f99709370657
 2009-11-30 02:16:36 +00:00
Jonathan Gordon
4966666062 fix mono recording token, 
Add %bu - usb powered token


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23713 a1c6a512-1295-4272-9138-f99709370657
 2009-11-22 19:09:54 +00:00
Jonathan Gordon
6c3c8a866c hopefully fix the sameplrate token 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23690 a1c6a512-1295-4272-9138-f99709370657
 2009-11-22 02:10:41 +00:00
Michael Chicoine
591ef80c9c FS#10781 - Scrolling doesn't stop when entering USB screen from WPS 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23687 a1c6a512-1295-4272-9138-f99709370657
 2009-11-21 21:44:24 +00:00
Thomas Martitz
19ec4ffe64 Remove a left-over check for metadata info being ready that delayed the initial draw of the wps quite a bit (most notably on slowish hwcodec). The skin engine is safe against that, so draw it instantly and make another redraw once the metadata info is ready. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23646 a1c6a512-1295-4272-9138-f99709370657
 2009-11-16 01:38:36 +00:00
Thomas Martitz
cc697a8f7a Avoid two subsequent full update. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23645 a1c6a512-1295-4272-9138-f99709370657
 2009-11-16 01:38:33 +00:00
Thomas Martitz
bdf2961ba3 Fix some drawing problems when displaying the WPS initially with sbs enabled. Move initial display of the wps to wps.c too. Should fix bug 3 of FS#10771. 
Also change GUI_EVENT_REFRESH event handling so that the passed drawing function is always called, not only when sbs or custom ui vp are used.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23644 a1c6a512-1295-4272-9138-f99709370657
 2009-11-16 01:38:30 +00:00
Tomer Shalev
ec0f4b4044 FS#10783 - WPS translation 
- Use the %Sx skin tag in WPS to translate 'Next Track', 'Next', and 'of' (X of Y tracks)
- New conditional skin token 'Sr' which checks whether the currently loaded language is an RTL language (Hebrew/Arabic). It uses lang_is_rtl().
- Added Hebrew translation


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23638 a1c6a512-1295-4272-9138-f99709370657
 2009-11-15 21:39:39 +00:00
Thomas Martitz
ca39b27dd4 Partly revert r23625 (the TIMEOUT_NOBLOCK change), and add a comment explaining why (or trying to, at least). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23637 a1c6a512-1295-4272-9138-f99709370657
 2009-11-15 20:45:50 +00:00
Thomas Martitz
3e60fb410d Consolidate some #ifdef code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23636 a1c6a512-1295-4272-9138-f99709370657
 2009-11-15 18:05:18 +00:00
Thomas Martitz
f80a6ddeae Fix crash when selecting statusbar: custom in the menus without having a valid sbs loaded. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23635 a1c6a512-1295-4272-9138-f99709370657
 2009-11-15 17:44:13 +00:00
Thomas Martitz
2e82199fed Fix peakmeter from delaying the initial display of the wps. Also change HZ/100 to TIMEOUT_NOBLOCK which is more appropriater in the get_action() call below. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23625 a1c6a512-1295-4272-9138-f99709370657
 2009-11-14 20:07:31 +00:00
Jeffrey Goode
0212de4c8d Add crossfade feature tag, update manual, fix crossfade WPS tag behavior 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23610 a1c6a512-1295-4272-9138-f99709370657
 2009-11-11 17:38:00 +00:00
Jonathan Gordon
db4cab0e66 fix build, ? buttonbar.... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23607 a1c6a512-1295-4272-9138-f99709370657
 2009-11-11 06:48:56 +00:00
Jonathan Gordon
7c440bff32 remove 3 bad viewport functions: 
* viewport_set_current_vp() because if a screen wants to not use the user setting it shouldn't be dealing with the viewport manager at all (other than to disable the bars)
* viewport_ui_vp_get_state() is unused (and not needed)
* viewport_get_current_vp() because you should be using set_defaults() instead.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23606 a1c6a512-1295-4272-9138-f99709370657
 2009-11-11 06:39:23 +00:00
Thomas Martitz
6db8f952dc Fall back to info vp from sbs when intersection fails (again, r23575 changed it despite it was agreed on info vp beforehand). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23604 a1c6a512-1295-4272-9138-f99709370657
 2009-11-10 23:01:01 +00:00
Thomas Martitz
c5b4482ee2 Revert r23599 and r23600 and fix the early usb problem at the root. The the viewportmanager and custom statusbar was initialized too late. 
Now, call it earlier and remove parts of it that caused the need to call it later. Removing that is OK since it's done again on settings loading.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23603 a1c6a512-1295-4272-9138-f99709370657
 2009-11-10 20:13:24 +00:00
Teruaki Kawashima
0771686339 usb screen: show logo at center of ui viewport and try to fit logo and title to the viewoprt to avoid possible redraw issue with sbs. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23601 a1c6a512-1295-4272-9138-f99709370657
 2009-11-10 13:40:50 +00:00
Jonathan Gordon
c4df53571c really fix early usb this time 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23600 a1c6a512-1295-4272-9138-f99709370657
 2009-11-10 07:47:57 +00:00
Jonathan Gordon
29e28a3945 hopefully fix "early usb" 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23599 a1c6a512-1295-4272-9138-f99709370657
 2009-11-10 04:46:52 +00:00
Jeffrey Goode
dd93ef41bb HAVE_CROSSFADE defs: fix yellow and red 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23598 a1c6a512-1295-4272-9138-f99709370657
 2009-11-10 04:21:40 +00:00
Frank Gevaerts
8c15799e70 Implement %Ss for playback speed 
This is similar to %Sp for pitch.  The conditional form %?Ss<...> is also
supported in the same way as FS#10680; you can use

    %?Ss<%xdAa|%xdAb|>

to show an icon of a tortoise (subpicture 1 of image A) or a hare
(subpicture 2 of image A) when not playing at the normal speed.

Flyspray: FS#10681
Author: Junio C Hamano



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23591 a1c6a512-1295-4272-9138-f99709370657
 2009-11-09 17:57:17 +00:00
Frank Gevaerts
7de32efe1c Don't define pitch_speed_enum() on MAS3507D. Fixes yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23590 a1c6a512-1295-4272-9138-f99709370657
 2009-11-09 17:51:36 +00:00
Frank Gevaerts
a20d77dba0 Allow %?Sp<...> to be used as a conditional 
When there are two choices (i.e. boolean), choose the first one if the
pitch is different from the normal value, and choose the second one if the
pitch is the same as the normal value.

When there are more than two choices (i.e. enum), the left half of the
choices are used to show 0..normal range, and the right half of the
choices are used to show values over that range.  The last entry is used
when it is set to the normal setting, following the rockbox convention to
use the last entry for special values.

  2 items: %?Sp<0..99 or 101..infinity|100>
  3 items: %?Sp<0..99|101..infinity|100>
  4 items: %?Sp<0..49|50..99|101..infinity|100>
  5 items: %?Sp<0..49|50..99|101..149|150..infinity|100>
  6 items: %?Sp<0..33|34..66|67..99|101..133|134..infinity|100>
  7 items: %?Sp<0..33|34..66|67..99|101..133|134..167|167..infinity|100>

This will allow two expected use cases:

 (1) %?Sp<%Sp> to show the pitch only when playing at a modified pitch.

 (2) %?Sp<%xdAa|%xdAb|> to show an icon of Darth Vader (subpicture 1
     of image A) when playing at a lower pitch than the original, and to
     show an icon of a chipmunk (subpicture 2 of image A) when playing at
     a higher pitch than the original.  When playing at a normal pitch,
     nothing is shown.

Flyspray: FS#10680
Author: Junio C Hamano



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23589 a1c6a512-1295-4272-9138-f99709370657
 2009-11-09 17:43:46 +00:00
Jonathan Gordon
6008c29e5e try that previous commit again... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23581 a1c6a512-1295-4272-9138-f99709370657
 2009-11-09 06:27:04 +00:00
Jonathan Gordon
10fcb6b183 fix segfault on remote targets where no sbs is loaded for the remote 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23580 a1c6a512-1295-4272-9138-f99709370657
 2009-11-09 06:17:56 +00:00
Jonathan Gordon
4cd805cfaf Fix the error condition to actually set the fullscreen viewport. Also remove a comment which doesnt really add anything.. the comments 15lines above it explain whats happening 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23575 a1c6a512-1295-4272-9138-f99709370657
 2009-11-09 05:15:48 +00:00
Jonathan Gordon
892332ce87 fix red.. markers need to be outside #ifdefs 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23574 a1c6a512-1295-4272-9138-f99709370657
 2009-11-09 05:03:33 +00:00
Jonathan Gordon
0621afad49 Add a bunch of markers into the tokens enum to make figuring out which token isnt in the bugout output easier. ("FIXME code(80)" is alot worse than "FIXME: TOKEN_MARKER_SOUND+5") 
Also, slightly reorder the enum to group misc items together


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23573 a1c6a512-1295-4272-9138-f99709370657
 2009-11-09 04:46:19 +00:00
Thomas Martitz
cc65afac0a Get font and colors from UI viewport before intersecting, instead of leaving them empty. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23526 a1c6a512-1295-4272-9138-f99709370657
 2009-11-04 22:55:02 +00:00
Thomas Martitz
e9c900d09d Fix a possiblity where viewport_set_default left the viewport unchanged. Improve comments a bit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23521 a1c6a512-1295-4272-9138-f99709370657
 2009-11-04 21:08:21 +00:00
Teruaki Kawashima
139694c7e2 Fix volume change in wps. %mv tag keeped showing volume is changed if volume is changed in wps. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23515 a1c6a512-1295-4272-9138-f99709370657
 2009-11-04 12:46:31 +00:00
Thomas Martitz
b2e64581d3 Fix player yellows and reds. I'm not sure why viewport.c was never compiled for charcell. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23513 a1c6a512-1295-4272-9138-f99709370657
 2009-11-04 07:20:41 +00:00
Thomas Martitz
c0635ba6c9 Remove wps_data.remote_wps. It's redundant with the new global curr_screen. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23512 a1c6a512-1295-4272-9138-f99709370657
 2009-11-04 07:14:02 +00:00
Thomas Martitz
6750d65f79 Reorder a bit in viewport.c so that we don't need stubs for checkwps. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23511 a1c6a512-1295-4272-9138-f99709370657
 2009-11-04 06:56:04 +00:00
Jonathan Gordon
dd1063d67c fix charcell yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23509 a1c6a512-1295-4272-9138-f99709370657
 2009-11-04 05:27:37 +00:00
Jonathan Gordon
c812614a1d Fix the WPS to work properly with the statusbar for the previous change.. Side effect is it fixes FS#10721 where %pb didnt work 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23508 a1c6a512-1295-4272-9138-f99709370657
 2009-11-04 05:24:30 +00:00
Jonathan Gordon
a7d784b1d5 Fix viewport "UI area" to work based on what was agreed on last week in the mailing lists and IRC: 
* viewport_set_defaults() will always set the viewport to the intersection of the user setting and any sbs set user viewport
* viewport_set_fullscreen() will always set the viewport to the full display, take care to disable the statusbars if you use this!

This patch is from FS#10709 and contains code which will be removed once the current inbuilt statusbar is finally removed. This *may* break themes which dont use the %we or %wd token.. follow up commit to fix this coming...


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23507 a1c6a512-1295-4272-9138-f99709370657
 2009-11-04 05:10:53 +00:00
Jonathan Gordon
f76b2f2046 Initial recording screen skin support (usable in .sbs skins only for now) 
new skin tokens:
%Rp - does the target have recording?
%Rf - samplerate
%Re - encoder
%Rb - bitrate
%Rm - mono/stereo

Please put all bugs from these (which very probably dont work 100%) into FS#10755. And someone who knows how the recoding capabilities work please look this over... ideally the same value should be returned for the middle three tags no matter what the capabilities of the target are.
CustomWPS on the wiki for more details


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23491 a1c6a512-1295-4272-9138-f99709370657
 2009-11-03 07:58:10 +00:00
Rob Purchase
24c1c75364 Add touchscreen WPS actions for volume up/down (using a button rather than the slider). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23488 a1c6a512-1295-4272-9138-f99709370657
 2009-11-02 21:56:48 +00:00
Thomas Martitz
e28bfd1349 Rework how feature skin tags work (%cc currently) when used conditionally (i.e. to detect a feature). 
If the feature is known to be unavailable at compile time or runtime detected, then let parsing skip over the true case. That enables parsing skins that properly put tags not available on a target within these tags. In the past the true case was parsed even if never could be true, which led to unexpected parsing failures.
Parsing %cc<%St|time format|[..]|> is now possible on target where that setting doesn't exist (the %St parser wold fail).
More of these tags are to be added, for example to indicate fm radio or recording capabilities.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23479 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 23:35:14 +00:00
Rafaël Carré
6cdb80d7df Revert r23474 "new skin token: %cx - 24 hour time format enabled in the setting.. e.g %?cx<24 hour|12 hour>" 
Committed accidentally with a svn/git desynch

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23475 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 22:51:26 +00:00
Rafaël Carré
9cd15dad9d new skin token: %cx - 24 hour time format enabled in the setting.. e.g %?cx<24 hour|12 hour> 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23474 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 22:48:46 +00:00
Jonathan Gordon
e702e5dbf8 revert that last checkin... something better is coming 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23473 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 21:45:01 +00:00
Jonathan Gordon
cb8527d073 new skin token: %cx - 24 hour time format enabled in the setting.. e.g %?cx<24 hour|12 hour> 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23472 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 21:35:35 +00:00
Thomas Martitz
3216d32a05 Move find_viewport() and find_image() to skin_parser.c where the reset of the linked-list handling sits. That enables removing duplicated code from checkwps. Also remove a few stubs in favor having the restart playback mechanism on albumart change #ifdef __PCTOOL__ 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23465 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 15:48:31 +00:00
Thomas Martitz
4f0e3ecda9 Fix red - statusbar_position() is a macro. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23462 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 13:36:57 +00:00
Thomas Martitz
6db726c147 Remove a wps function call from skin engine, hopefully the last one. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23461 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 13:36:52 +00:00
Thomas Martitz
dd33bdfe0d Cleanup includes a bit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23459 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 13:08:57 +00:00
Jonathan Gordon
132256d1be YELLOW ZOMBIES! 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23457 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 02:56:37 +00:00
Jonathan Gordon
ea094b163d haloween night is when red monsters are vanquished right? or is that green monsters? 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23456 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 02:47:38 +00:00
Jonathan Gordon
235d1ae795 Fix FS#10745 - %mv not working in sbs... 
This fix is as good as we can do, but not perfect. Because the sbs is only updated when a button is pressed it will stay in the "volume changing" state probalby longer than expected.. which isnt terrible, but useful to remember.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23455 a1c6a512-1295-4272-9138-f99709370657
 2009-11-01 02:36:51 +00:00
Thomas Martitz
28aef1f96a Consolidate code duplication in WPS volume changing handling. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23436 a1c6a512-1295-4272-9138-f99709370657
 2009-10-31 14:55:13 +00:00
Nils Wallménius
67f616478a Const correctness 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23402 a1c6a512-1295-4272-9138-f99709370657
 2009-10-29 15:09:09 +00:00
Jonathan Gordon
0aa035d73e * code police on a macro which has no reason for being 
* add the TOKEN_RTC_PRESENT value to the skin debugger listing
* Allow the width and height of a viewport to be negative values (so width -50 means extend to 50pixels inside from the right edge)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23393 a1c6a512-1295-4272-9138-f99709370657
 2009-10-29 03:27:13 +00:00
Nils Wallménius
ff197a4706 Use array for quickscreen item settings to simplify some logic 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23380 a1c6a512-1295-4272-9138-f99709370657
 2009-10-28 20:41:34 +00:00
Jonathan Gordon
bee5900032 Allow the x and y pixel values of viewports to be a negative number.. 
%V|-50|0|-|..... will position that viewport 50 pixels from the right of the display at the top.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23378 a1c6a512-1295-4272-9138-f99709370657
 2009-10-28 06:44:37 +00:00
Teruaki Kawashima
478afc3d62 FS#10722: some improvements for gui/list.c 
* Add function list_get_nb_lines and replace duplicated codes to calculate number of lines by it.
* Refine calculation of start_item in function gui_list_put_selection_on_screen.
- displays as many items as possible. hopefully fix FS#10054.
* Fix checking bounds in function gui_synclist_item_is_onscreen.
* Remove trailing spaces and fix indents.

Flyspray: FS#10722
Author: myself


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23367 a1c6a512-1295-4272-9138-f99709370657
 2009-10-27 13:18:54 +00:00
Tomer Shalev
83d24f89df FS#10704 - Make a configuration option to disable USB HID 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23322 a1c6a512-1295-4272-9138-f99709370657
 2009-10-23 13:29:19 +00:00
Thomas Martitz
3ddbe63ff5 Remove all update event callbacks if the custom statusbar is unused. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23306 a1c6a512-1295-4272-9138-f99709370657
 2009-10-20 23:29:13 +00:00
Thomas Martitz
8f11075f85 No need to have this variable global anymore. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23305 a1c6a512-1295-4272-9138-f99709370657
 2009-10-20 23:15:17 +00:00
Thomas Martitz
804e3aadae Fix a few potential redraw problems with the custom statusbar and wps fighting for the same full redraw variable. 
Instead, introduce a new skin struct holding data which is meant for all screens for a single skin (struct wps_state is currently used by both at the same time). Also clean up (classic) statusbar handling for skins using this new struct.
Also, implement deactivating updating of the custom statusbar when the LCD is deactivated, saving a bit battery life on some targets.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23304 a1c6a512-1295-4272-9138-f99709370657
 2009-10-20 23:12:20 +00:00
Thomas Martitz
d85c3ec410 Convert lcd_activation callbacks to use the event system to allow for multiple parallel callbacks (for custom statusbar). 
Increase maximum event count as we need more (I actually had a report about it during custom statusbar testing).
Removed corresponding functions from the core and plugin api. Bump min version and sort.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23302 a1c6a512-1295-4272-9138-f99709370657
 2009-10-20 21:54:59 +00:00
Frank Gevaerts
1c2172d453 usb_keypad_mode shouldn't depend on SIMULATOR 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23294 a1c6a512-1295-4272-9138-f99709370657
 2009-10-20 17:30:42 +00:00
Thomas Martitz
72f93e5f10 Cleanup quickscreen text drawing by using text alignment flags for viewports. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23283 a1c6a512-1295-4272-9138-f99709370657
 2009-10-19 22:49:47 +00:00
Tomer Shalev
0abc34b342 Fix yellow: wrong file used 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23281 a1c6a512-1295-4272-9138-f99709370657
 2009-10-19 21:59:19 +00:00
Tomer Shalev
55a7b2dd16 Fix yellow: Missing statusbar.h include (hopefully the last one missing) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23280 a1c6a512-1295-4272-9138-f99709370657
 2009-10-19 21:53:56 +00:00
Tomer Shalev
e684a3a8f9 Fix yellow: Missing ata_mmc.h include 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23278 a1c6a512-1295-4272-9138-f99709370657
 2009-10-19 21:44:38 +00:00
Tomer Shalev
5d585f4b9b Extract usb_screen logic out of screens.c into apps/gui/usb_screen.c 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23273 a1c6a512-1295-4272-9138-f99709370657
 2009-10-19 21:19:30 +00:00
Thomas Martitz
1016ee4e80 Initial custom statusbar commit. 
The custom statusbar can be used as a WPS for the main UI, using .(r)sbs files. It's using the skin engine and knows all tags the WPS also knows.
The default folder for .sbs is the wps folder to reuse images used in the WPS.
As it can be shown in the WPS also, it's useful to move shared parts to the custom statusbar in order to save skin buffer space.
There are a few restrictions/TODOs:
*) Peak meter doesn't redraw nicely(not frequent enough), as very frequent updates would slow the UI down as hell (some targets fight with it in the WPS already: FS#10686)
*) No touchregion support as the statusbar doesn't have any action handling (it won't fail to parse though).
*) Drawing stuff into the default VP is forbidden (loading images in it is not). You *need* to use viewports for the displaying stuff (parsing fails if no viewport is used).
*) Themes that don't use a custom ui viewport can be fixed up using the new %Vi tag to avoid nasty redraw effectts (you must not draw into it as well, it's used to fix up the ui viewport). %Vi describes the viewport that the lists can use without getting in the way of the statusbar.

Otherwise, it behaves like the classic statusbar, it can be configured in the theme settings, and can be turned off in the wps using %wd.

Note to translaters: When translating LANG_STATUSBAR_CUSTOM, please consider using the same translation as for LANG_CHANNEL_CUSTOM if it's compatible. They could be combined later then.

Flyspray: FS#10566
Author: myself

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23258 a1c6a512-1295-4272-9138-f99709370657
 2009-10-19 15:28:15 +00:00
Thomas Martitz
6225f388b8 Reorder members for more efficient alignment. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23254 a1c6a512-1295-4272-9138-f99709370657
 2009-10-19 00:26:46 +00:00
Thomas Martitz
c26949c54b r23208 broke conditional use of metadata and filename tags. Return NULL instead of "n/a" to make it work again. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23253 a1c6a512-1295-4272-9138-f99709370657
 2009-10-18 23:58:42 +00:00
Bertrik Sikken
d24d885aa4 Use wrap-safe TIME_BEFORE/TIME_AFTER macros to compare times with current_time, instead of comparing them directly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23246 a1c6a512-1295-4272-9138-f99709370657
 2009-10-18 15:50:30 +00:00
Thomas Martitz
a7c888c48e Add a option to skip length which lets you skip 5s before the end of a song, which can be useful on gapless albums. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23229 a1c6a512-1295-4272-9138-f99709370657
 2009-10-17 16:05:23 +00:00