Michael Sevakis
5e73f9ff20
Fix FS#8660-Recording hardlocks with keyclick enabled and FS#9388-keyclicks too late. Introduce audio_buffer_state to check whether PCM buffer is useable or disabled (trashed).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19411 a1c6a512-1295-4272-9138-f99709370657
2008-12-13 01:32:39 +00:00
Michael Sevakis
bdf3004f96
CLOCKING register should be set on hardware init.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19410 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 23:03:30 +00:00
Jens Arnold
6ed3ca7405
Make some more constants involved in right shifts unsigned to get rid of __ashrsi3 in the Player's core as well, saving some binsize.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19409 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 22:19:42 +00:00
Jonas Häggqvist
7c18a3d91a
Bugfixes for Pictureflow (FS#9627 by Thomas Martitz):
...
- Get complete metadata for albums (closes FS#9606).
- Explicitly remove existing cache before creating new one (closes FS#9135).
- Resetting the selection variable upon re-entering tracklist mode (better fix for FS#8347).
- Use the system-wide HAVE_SCROLLWHEEL define rather than the local SCROLLWHEEL.
- Change a buffer to be of size MAX_PATH+1 rather than MAX_PATH. It's unclear whether this is needed or not.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19408 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 21:28:54 +00:00
Bertrik Sikken
7d354c5d34
FS#9625, keep HPCM codec setting (headphone common mode) enabled for E200V2 too.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19407 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 21:18:47 +00:00
Frank Gevaerts
f6ac3ec7ed
Fix array sizes
...
Fix some error handling
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19406 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 20:13:50 +00:00
Dominik Wenger
90bcf9be5e
m200v4: rename Keys, so they match better other targets with similar key-layout. Enable plugins, add keymaps for plugins. More keymap improvements needed.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19405 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 19:50:49 +00:00
Jonas Häggqvist
790f5ae1e0
Pictureflow:
...
- Always initialise artist and albumartist to NULL to avoid segfaults and other nastiness (closes FS#9266). Ideally they should be set to their actual values (would fix FS#9606), but this fix at least avoids some problems.
- Be a bit more precise in the error given when no albumart is found.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19404 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 19:38:08 +00:00
Michael Sevakis
4f81ee65fa
Argh. Being stupid. Missed one. Nap time.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19403 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 13:08:35 +00:00
Michael Sevakis
b6e78acc5e
Get rid of some pcm_apply_settings cruft at the low level I somehow missed. Move the ones in pcm.c around to better spots. Remove a variable from pcm-pnx0101.c that should no longer be there.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19402 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 12:46:57 +00:00
Michael Sevakis
4bbaef6fd5
Fix-m the ruddiness.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19401 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 11:20:58 +00:00
Michael Sevakis
e69d567d9e
Bring consistency to pcm implementation and samplerate handling. Less low-level duplication. A small test_sampr fix so it works on coldfire again.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19400 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 11:01:07 +00:00
Jens Arnold
0ad97d13fc
Reclaim a bit of binsize on hdd based archoses by making the bit test unsigned. On SH1, gcc optimizes this by using a right shift, and a signed '1' made it use an arithmetic right-shift-by-n, which is a libgcc function on SH1. This was the only place in the core using it. No effect on other architectures.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19399 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 07:48:01 +00:00
Tom Ross
c99ad8f2b4
Don't let the user play the hand if it has already completed. Fixes FS #9399 .
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19398 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 05:52:11 +00:00
Jonathan Gordon
5b0f683b6f
fix FS#9615 - the set time/date screen was not setting the viewport before using the lcd funcitons
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19397 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 05:12:33 +00:00
Mark Arigo
f2dc7139b9
Fix the sound level on the Philips HDD1630
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19396 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 04:59:06 +00:00
Mark Arigo
08585e417b
FS#9591 by Anton Veretenenko for the Philips GoGear HDD1620/1630 (with a few changes by me). Fixes boot problem, pixel format, sound, and a few other things.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19395 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 04:56:25 +00:00
Andrew Mahone
ea5d0bd7ec
fix yellow
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19394 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 03:16:06 +00:00
Andrew Mahone
66b0d8198e
fix broken greyscale upscaling
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19393 a1c6a512-1295-4272-9138-f99709370657
2008-12-12 02:44:13 +00:00
Jonas Häggqvist
ea5457ca90
Exit the configure script with non-zero status on errors.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19392 a1c6a512-1295-4272-9138-f99709370657
2008-12-11 17:24:04 +00:00
Rafaël Carré
eb6db0a647
Sansa e200v2 and Fuze : disable not implemented recording
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19391 a1c6a512-1295-4272-9138-f99709370657
2008-12-11 14:16:05 +00:00
Rafaël Carré
76ea5f0fae
Sansa e200v2 and Fuze : disable tuner until i2c communication is tested (or written)
...
Correct a comment (si4702 is compatible with si4700.c)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19390 a1c6a512-1295-4272-9138-f99709370657
2008-12-11 14:05:52 +00:00
Andrew Mahone
5a7454e878
add yields in superdom, patch from FS#7528
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19389 a1c6a512-1295-4272-9138-f99709370657
2008-12-11 01:53:48 +00:00
Michael Sevakis
2e8266df12
Fix a PortalPlayer PCM bug that made keyclick malfunction. Should fix FS#8836. Move FIQ banked register init out of crt0-pp.S and into pcm-pp.c to keep setups local to PCM driver.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19388 a1c6a512-1295-4272-9138-f99709370657
2008-12-11 01:48:31 +00:00
Dominik Riebeling
bbc58d5a20
Use caps macro instead of textsc to prevent the heavy HTML issue.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19387 a1c6a512-1295-4272-9138-f99709370657
2008-12-10 21:40:55 +00:00
Michael Sevakis
441fca176a
Fix a wrong comment in thread.c and mention an alternative approach to inits. Fix a couple headers' Id fields while at it.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19386 a1c6a512-1295-4272-9138-f99709370657
2008-12-10 21:10:34 +00:00
Andrew Mahone
72f150139e
fix get_totalsize to return the correct size in some cases where it failed
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19385 a1c6a512-1295-4272-9138-f99709370657
2008-12-10 20:41:53 +00:00
Dominik Riebeling
2ea61be605
Fix a typo in the manual (FS#9619 by Alexander Levin).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19384 a1c6a512-1295-4272-9138-f99709370657
2008-12-10 18:31:45 +00:00
Nils Wallménius
7987e9a801
Fix minor copy & paste error in comment. No functional change.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19383 a1c6a512-1295-4272-9138-f99709370657
2008-12-10 13:42:20 +00:00
Rafaël Carré
88bb7acc0a
Sansa Clip: enable tagcache, quickscreen and pitchscreen
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19382 a1c6a512-1295-4272-9138-f99709370657
2008-12-10 13:00:01 +00:00
Andrew Mahone
995c89cb6f
code cleanup, more descriptive variable names, and algorithm docs for color scalers
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19381 a1c6a512-1295-4272-9138-f99709370657
2008-12-10 12:09:03 +00:00
Andrew Mahone
eb04315b19
small binsize improvement for color scalers
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19380 a1c6a512-1295-4272-9138-f99709370657
2008-12-10 09:45:49 +00:00
Jonathan Gordon
9356b13a23
add some missing ifdef HAVE_TAGCACHE checks spooted by funman
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19379 a1c6a512-1295-4272-9138-f99709370657
2008-12-10 09:17:49 +00:00
Michael Sevakis
f2f394793c
Fix red and a couple other things I somehow missed.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19378 a1c6a512-1295-4272-9138-f99709370657
2008-12-10 09:11:43 +00:00
Michael Sevakis
8cfbd3604f
Use cookies for thread identification instead of pointers directly which gives a buffer against wrongly identifying a thread when the slot is recycled (which has been nagging me for awhile). A slot gets 255 uses before it repeats. Everything gets incompatible so a full update is required.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19377 a1c6a512-1295-4272-9138-f99709370657
2008-12-10 08:57:10 +00:00
Andrew Mahone
40ff47c7ee
fix yellow - bogus unitialized use warnings
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19376 a1c6a512-1295-4272-9138-f99709370657
2008-12-09 23:48:34 +00:00
Jens Arnold
a29b659758
Assembler optimised mono predictor for ARM. Speedup for -c1000 mono is ~5% on PP, ~8% on Gigabeat S (less for higher compression levels). Also fix some overlooked comments in the stereo predictor.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19375 a1c6a512-1295-4272-9138-f99709370657
2008-12-09 23:20:59 +00:00
Andrew Mahone
781421afa2
resize-on-load for bitmap files on 2bpp and color targets
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19374 a1c6a512-1295-4272-9138-f99709370657
2008-12-09 23:07:59 +00:00
Andrew Mahone
a2c71fde1b
add Andrew Mahone / unhelpful to COMMITTERS
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19373 a1c6a512-1295-4272-9138-f99709370657
2008-12-09 21:48:09 +00:00
Nils Wallménius
65f61d6cce
FS#9609 FM radio support for the Gigabeat S, seeking/scanning is not yet
...
implemented but manual tuning works nicely. Thanks to Rafaël Carré,
Bertrik Sikken and Robert Menes for suggestions and debugging help.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19372 a1c6a512-1295-4272-9138-f99709370657
2008-12-09 20:48:04 +00:00
Jonas Häggqvist
a13c162719
Compile the WPS debug functions for the sim, to make --debugwps work.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19371 a1c6a512-1295-4272-9138-f99709370657
2008-12-09 18:15:19 +00:00
Dominik Wenger
02184a242e
make fmradio-i2c code from clip more generic, so it works for m200v4 and hopefully all other as3525 targets.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19370 a1c6a512-1295-4272-9138-f99709370657
2008-12-09 17:21:16 +00:00
Michael Sevakis
4ae9de5490
Color LCDs shouldn't have to have contrast set to 0 before shutdown. If contrast is implemented, then it can cause it to flash a bit before poweroff.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19369 a1c6a512-1295-4272-9138-f99709370657
2008-12-09 01:33:01 +00:00
Michael Sevakis
cb06108024
Meg-FX: Enable a real tick in the bootloader. Do cleanups before switching to firmware and cache handling. Put proper main return address in lr.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19368 a1c6a512-1295-4272-9138-f99709370657
2008-12-08 23:31:05 +00:00
Michael Sevakis
ea929a3e45
Have drivers merged for WM8711/21/31 since they are so similar but respect all register differences between codecs. Change minis to #define the actual codec type. If anything breaks check if OSCPD and CLKOUTPD need to be clear for the target- H10 is fine. A nice naming convention suggestion for WM codec multidrivers would be welcome rather than naming for a specific chip.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19367 a1c6a512-1295-4272-9138-f99709370657
2008-12-08 21:09:56 +00:00
Bertrik Sikken
ed96b2a4dd
Sansa Clip: implement the fmradio_i2c interface using generic_i2c
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19366 a1c6a512-1295-4272-9138-f99709370657
2008-12-08 19:32:05 +00:00
Bertrik Sikken
bbb1f89043
* combine i2c_ack and i2c_outb
...
* do not switch sda back and forth between input and output when reading a byte
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19365 a1c6a512-1295-4272-9138-f99709370657
2008-12-08 19:01:00 +00:00
Rafaël Carré
9856a37de3
Sansa Clip: revert 19353
...
If we don't set pin B6 to 1, display can go off at random times
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19364 a1c6a512-1295-4272-9138-f99709370657
2008-12-08 16:39:55 +00:00
Maurus Cuelenaere
6471b3c81a
Commit FS#9607 by Adam Hogan: fix plugin keymaps for Creative Zen Vision:M
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19363 a1c6a512-1295-4272-9138-f99709370657
2008-12-08 09:51:42 +00:00
Björn Stenberg
66459fee3d
Fix red player build
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19362 a1c6a512-1295-4272-9138-f99709370657
2008-12-08 08:32:30 +00:00