Commit graph

163 commits

Author SHA1 Message Date
Hardeep Sidhu
685356cb89 Store playlist index for prepended/appended tracks in control file. Fixes resume problem with these tracks and insert shuffled.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10115 a1c6a512-1295-4272-9138-f99709370657
2006-06-12 23:06:51 +00:00
Hardeep Sidhu
1386034044 Always set first_index to value stored in settings when resuming. Fixes incorrect index problem when resuming an insert_shuffle'd playlist.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10024 a1c6a512-1295-4272-9138-f99709370657
2006-05-30 23:52:58 +00:00
Hardeep Sidhu
bda2d5e798 Boost cpu when performing large insertions or saving playlist to disk
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9942 a1c6a512-1295-4272-9138-f99709370657
2006-05-15 19:15:04 +00:00
Hardeep Sidhu
cab3a16417 Return immediately if we have no control commands to flush. Fixes erroneous playlist control update error when inserting tracks
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9912 a1c6a512-1295-4272-9138-f99709370657
2006-05-11 19:14:18 +00:00
Hardeep Sidhu
83d1a5eabe Only flush and reload tracks after the playlist has started. Fixes B#5312.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9895 a1c6a512-1295-4272-9138-f99709370657
2006-05-09 14:43:49 +00:00
Hardeep Sidhu
ed41ba0ca7 Fixed bug with playlist_skip_entry when track to be skipped was less then current index
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9879 a1c6a512-1295-4272-9138-f99709370657
2006-05-05 08:32:07 +00:00
Hardeep Sidhu
b236dc63ff Fixed problem with incorrect first index after resume
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9835 a1c6a512-1295-4272-9138-f99709370657
2006-04-30 05:29:04 +00:00
Hardeep Sidhu
fede7ff6f2 Fixed playlist control corruption on dircache systems
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9834 a1c6a512-1295-4272-9138-f99709370657
2006-04-30 04:40:56 +00:00
Hardeep Sidhu
3f7292e13a Don't call playlist_start() when changing directories on swcodec devices. Fixes problem with previous dir not working.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9774 a1c6a512-1295-4272-9138-f99709370657
2006-04-23 17:15:45 +00:00
Hardeep Sidhu
24f0a374c6 Fixed problem with forced reload of dircached filenames when playlist is sorted
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9738 a1c6a512-1295-4272-9138-f99709370657
2006-04-20 05:56:34 +00:00
Hardeep Sidhu
195a9f2766 No need to force a sync of control file until playlist has started. This should improve tagcache playlist creation performance on Archos devices (esp. Ondio). Also fixed a small bug in playlist_set_current.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9735 a1c6a512-1295-4272-9138-f99709370657
2006-04-20 01:43:16 +00:00
Hardeep Sidhu
b79c9a6145 Allow insert shuffled option for directories when playlist is empty. Based on patch #3011 by Jonathan Gordon.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9728 a1c6a512-1295-4272-9138-f99709370657
2006-04-19 02:22:23 +00:00
Brandon Low
2b18727a8a Fix dir skipping with new playback arch. Enable dir skipping on ipod with a couple of difficult combos (select|right/left) or short-long left / short-long right. The latter causes stuck in pause sometimes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9720 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 18:33:09 +00:00
Hardeep Sidhu
095ad1a39c Minor fix for insert_shuffle when playlist is empty
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9716 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 16:44:51 +00:00
Hardeep Sidhu
d0de1aafac Fixed problem with auto change directory not working when browsing plugins
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9715 a1c6a512-1295-4272-9138-f99709370657
2006-04-18 16:24:12 +00:00
Hardeep Sidhu
6dd728cdea Fixed problems with playlist buffer full handling
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9454 a1c6a512-1295-4272-9138-f99709370657
2006-04-03 14:25:47 +00:00
Hardeep Sidhu
30db2b4ac3 Fix for repeat shuffle on SW codec devices
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9453 a1c6a512-1295-4272-9138-f99709370657
2006-04-03 13:48:38 +00:00
Jens Arnold
67de1d3d9b Thorough .lang rework: Removed all deprecated strings, combined string which were only split because long ago we had no splash(), sorted strings into logical groups to ease the transition to langv2. Bunped binary .lng version.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9398 a1c6a512-1295-4272-9138-f99709370657
2006-04-01 13:36:33 +00:00
Jens Arnold
e523041468 Fix 64bit warnings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9375 a1c6a512-1295-4272-9138-f99709370657
2006-03-30 21:43:24 +00:00
Miika Pekkarinen
3881ce94bd Dircache support for simulator also.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9365 a1c6a512-1295-4272-9138-f99709370657
2006-03-30 18:53:44 +00:00
Hardeep Sidhu
0cca6caa8a Currently playing playlist can now be overwritten. Save playlist screen defaults to this.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8641 a1c6a512-1295-4272-9138-f99709370657
2006-02-09 09:09:32 +00:00
Hardeep Sidhu
75a60fbf69 Added a cache for playlist control commands. On non-dircache systems, behaviour should be the same as before (all commands except shuffle flushed immediately). On dircache systems, commands are only flushed when disk is accessed or during shutdown. This especially reduces disk accesses when playing queued files and should fix the problem with gapless playback.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8584 a1c6a512-1295-4272-9138-f99709370657
2006-02-05 18:17:41 +00:00
Brandon Low
8d5a6609a3 AB-repeat mode for software codecs. Accessible through menu as a repeat mode, with buttom mappings much like those on other rockbox targets for now.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8409 a1c6a512-1295-4272-9138-f99709370657
2006-01-21 23:43:57 +00:00
Miika Pekkarinen
178a85f31c iriver: Better fix for the previous problem, stop playback if next
song is not immediately available, don't flush buffer when changing to
next directory,


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8393 a1c6a512-1295-4272-9138-f99709370657
2006-01-19 20:35:06 +00:00
Daniel Stenberg
f981ea93fb kill gcc4 warnings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8162 a1c6a512-1295-4272-9138-f99709370657
2005-12-05 22:44:42 +00:00
Miika Pekkarinen
6a4bfb5dcf iRiver: Fixed several problems with playback on track skipping & loading:
* Correctly detecting codec type from metadata.
* Skipping incorrect tracks correctly if there are more than one unloadable track.
* Fixed internal ram skipping when codec switching is required.
* Fixed hang if no files in playlist is playable.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8116 a1c6a512-1295-4272-9138-f99709370657
2005-12-01 18:44:11 +00:00
Miika Pekkarinen
caee4b3e37 One more fix to revert a part of an incorrect change from the previous commit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8023 a1c6a512-1295-4272-9138-f99709370657
2005-11-21 13:23:06 +00:00
Miika Pekkarinen
4394cc787e The previous commit didn't fully fix the problem. Now it should have
been fixed.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8022 a1c6a512-1295-4272-9138-f99709370657
2005-11-21 11:31:15 +00:00
Miika Pekkarinen
d1704f6894 Fixed playlist skipping of incorrect files and playback engine not to
hang if codec loading fails. Also displaying a "Loading..." message on
resume and not calling queue_post too often.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8021 a1c6a512-1295-4272-9138-f99709370657
2005-11-21 11:14:51 +00:00
Miika Pekkarinen
bae4fed19d Fix to the previous commit: Pointers were not always correctly erased.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7932 a1c6a512-1295-4272-9138-f99709370657
2005-11-17 19:41:16 +00:00
Miika Pekkarinen
735f453730 Added dircache support to playlist. Now playlist filename pointers are
automatically accuired from dircache. WPS UI response with dircache
enabled should be instant.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7931 a1c6a512-1295-4272-9138-f99709370657
2005-11-17 19:31:29 +00:00
Anton Oleynikov
ffc3963d57 fixed a bug in folder skipping preventing a feature to work in some cases
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7815 a1c6a512-1295-4272-9138-f99709370657
2005-11-11 19:58:08 +00:00
Anton Oleynikov
00928af4dd iRiver: more robust folder skip routines + folder navigation on main unit via
either PLAY+LEFT/RIGHT or short then long LEFT/RIGHT


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7810 a1c6a512-1295-4272-9138-f99709370657
2005-11-10 22:31:47 +00:00
Kevin Ferrare
3aa842c9a3 some multi-screen work in playlist.c, properly formated splash.h
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7766 a1c6a512-1295-4272-9138-f99709370657
2005-11-06 17:30:53 +00:00
Anton Oleynikov
d102e1f345 patch 1328447: folder skip routines in playlist API plus next/prev folder navigation for iRiver's remote
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7735 a1c6a512-1295-4272-9138-f99709370657
2005-11-02 22:32:04 +00:00
Miika Pekkarinen
56bb45cfaf We reserved two bits instead of one bit for the new skipped attribute.
Fixed.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7648 a1c6a512-1295-4272-9138-f99709370657
2005-10-21 07:25:19 +00:00
Miika Pekkarinen
c52f7f1b5e iRiver: Fixed broken items skipping on playlist: Now skipping and
marking them as bad instead of deleting the entries from playlist.
Faster buffered track skipping and preventing glitches from previous
tracks (still something might occur though, please report them).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7647 a1c6a512-1295-4272-9138-f99709370657
2005-10-21 06:40:45 +00:00
Jens Arnold
d6c054575b Renamed CONFIG_HWCODEC and MASNONE to the more appropriate CONFIG_CODEC and SWCODEC, respectively.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7416 a1c6a512-1295-4272-9138-f99709370657
2005-08-29 21:15:27 +00:00
Linus Nielsen Feltzing
0ad617cbf0 Patch #1105616 by Ray Lambert - A-B Repeat for Archos studio/recorder, still not 100% complete, but I wanted to commit it before the 2.5 feature freeze
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7380 a1c6a512-1295-4272-9138-f99709370657
2005-08-21 23:01:12 +00:00
Miika Pekkarinen
159c52dd36 Initial voice ui support for software codec platforms. Added also a
beep when changing tracks.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7360 a1c6a512-1295-4272-9138-f99709370657
2005-08-20 11:13:19 +00:00
Ryan Jackson
1476fecf72 All repeat modes now work correctly if there is only one track in the playlist. Fixed a track-changing bug in 'Move to Next Folder' mode that could cause Rockbox to crash.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7268 a1c6a512-1295-4272-9138-f99709370657
2005-07-30 19:36:06 +00:00
Magnus Holmgren
97c6fd0892 'Move to Next Folder' didn't work if it involved going up to the root of the drive.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7265 a1c6a512-1295-4272-9138-f99709370657
2005-07-30 18:12:25 +00:00
Hardeep Sidhu
348d8f6bab A couple of bug fixes: 1. Take mutex before all playlist control file operations including fsync. 2. Don't flush and reload tracks if nothing is playing.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7060 a1c6a512-1295-4272-9138-f99709370657
2005-07-08 00:52:54 +00:00
Hardeep Sidhu
839dbcaed7 Moved resume info updating to the mpeg/playback threads so that it's saved even when not in the WPS
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7018 a1c6a512-1295-4272-9138-f99709370657
2005-07-04 22:50:57 +00:00
Hardeep Sidhu
71d2281d8b Added new feature to move to next folder once the current one completes when playing directories
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6963 a1c6a512-1295-4272-9138-f99709370657
2005-07-01 11:25:16 +00:00
Hardeep Sidhu
965c86a845 Forgot a const
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6862 a1c6a512-1295-4272-9138-f99709370657
2005-06-25 06:28:55 +00:00
Hardeep Sidhu
74d082c038 Added new shuffle repeat mode that reshuffles playlist before repeating. Also added new shuffled insert mode that randomly inserts selected track(s) somewhere between current track and end of playlist.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6861 a1c6a512-1295-4272-9138-f99709370657
2005-06-25 04:46:25 +00:00
Linus Nielsen Feltzing
d34865a530 mp3buf renamed to audiobuf
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6252 a1c6a512-1295-4272-9138-f99709370657
2005-04-05 11:33:58 +00:00
Linus Nielsen Feltzing
8a237a829e More audio code restructuring, mostly renaming functions so far
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6246 a1c6a512-1295-4272-9138-f99709370657
2005-04-04 12:06:29 +00:00
Daniel Stenberg
22b7701fe7 Build cleanup and general fixes. fprintf() is now fdprintf(), the separation
between uisimulator files and firmware/apps files are better done.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6031 a1c6a512-1295-4272-9138-f99709370657
2005-02-22 12:19:12 +00:00