Commit graph

6681 commits

Author SHA1 Message Date
Nicolas Pennequin
fd19b8dba4 * Improve conditional evaluation to allow using enums with only two cases (problem reported by roolku). This happens to simplify the code.
* Rename get_tag() to get_token_value() and make it get a token pointer instead of the index of a token. This also simplifies the code a bit.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13073 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 14:00:00 +00:00
Jens Arnold
349345db39 Enabled pacbox for M5.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13071 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 13:34:48 +00:00
Dan Everton
1322ae02f9 FS #6759: Support tan function in calculator plugin. Patch by Luke Blaney.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13070 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 11:22:12 +00:00
Jonathan Gordon
9e95e306cd fix yellow
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13069 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 06:15:34 +00:00
Jonathan Gordon
21b415df56 Give all menus using the old API a nice title and icons (except plugins)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13068 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 05:52:47 +00:00
Jonathan Gordon
1e0ae1be63 Remove dead code
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13067 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 05:30:03 +00:00
Nicolas Pennequin
ef5cfb4e58 Oops, this shouldn't have been removed (fix red).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13066 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 04:12:55 +00:00
Nicolas Pennequin
07696c10b1 FS#6991. Patch by Alexander Levin, modified by me:
* Reorganisation of the WPS data structure with line and subline structs. This allows us to use sublines more sparingly, so it should save some memory. Also it removes the need for the "End Of Line" token. Overall, the data structure and the code are simplified and gain in clarity.
* Some code improvements and added comments.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13065 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 04:01:06 +00:00
Jonathan Gordon
fad3ad6894 fix FS#6883 — Follow playlist override where the WPS leaves you when a playlist ends
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13064 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 02:11:33 +00:00
Jonathan Gordon
981f6c9aee action_signalscreenchange(); was missing
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13063 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 02:08:54 +00:00
Jonathan Gordon
a053e58894 minor actions cleanup:
- CONTEXT_MAINMENU is not actually needed, use CONTEXT_TREE which does the same actions
- (gigabeat) use vol+/- in the lists to control volume (every list!) (FS#6982 in a better way)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13062 a1c6a512-1295-4272-9138-f99709370657
2007-04-08 01:33:01 +00:00
Miika Pekkarinen
7b1e827f0c Dircache fixes: Stop scanning properly if shutdown is initiated. Require user to re-enable dircache if initialization fails. Don't create statefile unless eeprom settings have been initialized.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13060 a1c6a512-1295-4272-9138-f99709370657
2007-04-07 17:48:51 +00:00
Jens Arnold
8e6e25c353 Fix NULL pointer access (crashes the sim on windows) in directories with no displayed entries.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13059 a1c6a512-1295-4272-9138-f99709370657
2007-04-07 15:31:22 +00:00
Nicolas Pennequin
3dc42ba8c7 Add the sleep timer tag that got forgotten in the initial code.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13056 a1c6a512-1295-4272-9138-f99709370657
2007-04-07 11:57:59 +00:00
Miika Pekkarinen
0b5998c7ea Updated user rating to the tagnavi.config (FS#6890)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13055 a1c6a512-1295-4272-9138-f99709370657
2007-04-07 11:23:08 +00:00
Nicolas Pennequin
f3a149acf6 Make conditionals trigger a line update. Fixes FS#6987.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13054 a1c6a512-1295-4272-9138-f99709370657
2007-04-07 00:18:28 +00:00
Jens Arnold
f9b90e9103 Now charcell displays require lcd_update() for updating the main lcd content like bitmap displays.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13050 a1c6a512-1295-4272-9138-f99709370657
2007-04-06 22:55:00 +00:00
Adam Boot
a5d7309d96 Support resume for Musepack
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13049 a1c6a512-1295-4272-9138-f99709370657
2007-04-06 21:48:17 +00:00
Nicolas Pennequin
8527ce82b6 Use the default subline timeout value in case the value isn't explicitly set. Hopefully this will be the last commit in that area :)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13048 a1c6a512-1295-4272-9138-f99709370657
2007-04-06 19:07:57 +00:00
Nicolas Pennequin
87e77ba466 This time I hope I got it right! Basically, remove what the previous commit about subline timeouts added and make the values be computed by a special function at display time. This should bring complete compatibility with the previous code.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13047 a1c6a512-1295-4272-9138-f99709370657
2007-04-06 16:43:07 +00:00
Nicolas Pennequin
3954a51311 Better handling of subline timeout values : All values are set to the default before another value is found by the parser. No more
resetting to the default value at displaying time (this caused problems especially noticeable on the DancePuffDuo WPS). Changing 
the values with conditionals is still possible but only strictly positive tiemout values are accepted now. 


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13045 a1c6a512-1295-4272-9138-f99709370657
2007-04-06 14:18:07 +00:00
Nicolas Pennequin
31d8068b33 End the default remote-WPS with a newline. Fixes FS #6979.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13041 a1c6a512-1295-4272-9138-f99709370657
2007-04-06 02:01:34 +00:00
Peter D'Hoye
0db06ce7db Oops again, use correct variable types for storing file date and time
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13039 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 21:38:27 +00:00
Peter D'Hoye
33975fbbda Use date and time rather than size and starting cluster to detect installation of a new version
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13038 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 21:24:21 +00:00
Peter D'Hoye
bf92f9c1f6 Fix automatic rolo on new version for archos. Introduces new define in config files for bootfile location.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13036 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 20:24:07 +00:00
Dave Chapman
1396826a30 Add apps/plugins/mpegplayer/*.S to the source tarballs.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13035 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 16:49:09 +00:00
Nicolas Pennequin
9cf8960c85 * Fix the bug where subline separators were read as part of a string.
* Some cosmetic code changes, no other functional change (add a comment and rename some variables).


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13034 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 14:09:59 +00:00
Dan Everton
86c0e3a4ca Rearrange struct wps_tag to avoid padding. Hopefully save some bytes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13033 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 10:21:49 +00:00
Marcoen Hirschberg
80d882105e optimized motion compensation for ARM from the mplayer-w100 project. Elefants Dream plays back 2.3fps faster on the Gigabeat
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13032 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 09:56:28 +00:00
Jonathan Gordon
78585318b5 count was set wrong for the parititons screen. imo this is a bug in the list code, but quick fix untill a proper one
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13031 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 05:18:47 +00:00
Jonathan Gordon
d88db1fc12 Fix sim warning
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13030 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 05:01:38 +00:00
Jonathan Gordon
cd41bfa52e Make the partitions debug screen use the list also.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13029 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 04:52:53 +00:00
Jonathan Gordon
6cbf30d5c7 Give the playlist viewer a title (FS#6898)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13028 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 04:13:02 +00:00
Jonathan Gordon
ec7ca33a0c Fix the root menu for any targets without a radio (we are using #if not #ifdef for CONFIG_TUNER). Fixes the bookmark issue in FS#6965)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13027 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 02:50:43 +00:00
Nicolas Pennequin
29e18caacf Allow subline timeout values to be changed dynamically in the WPS (e.g. by using conditionals).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13026 a1c6a512-1295-4272-9138-f99709370657
2007-04-05 02:44:01 +00:00
Jens Arnold
7b8767c093 Player full-line progress bar: No more separate character cell(s) for the colon(s) in the time display. Looks better, and takes less software-definable characters, allowing for up to 99:59:59 with the last progress bar character still working properly.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13023 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 23:18:35 +00:00
Marcoen Hirschberg
4d9c0012d4 just pass the struct to vo_setup instead of multiple arguments
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13022 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 22:51:57 +00:00
Jens Arnold
c6fce6cad3 Player progress drawing rewrite (both emptying cup and full-line bar): * Fixes FS #6820, related to the glitch that progress moved in the opposite direction when seeking. * Smaller, more efficient code. * Full-line bar only displays as many software defined characters as needed, freeing the remaining ones for other text. * Don't cut last digit from times >=1 hour (at the cost of inexact last progress bar character).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13021 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 22:05:04 +00:00
Nicolas Pennequin
830a3a4720 * Make some private variables 'static'.
* Fix the pitch tag and allow it to be used on all targets except the Archos Player.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13020 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 15:47:51 +00:00
Nicolas Pennequin
ab90d58801 Introducing the WPS tokenizer !
When a WPS file is loaded, it is parsed to an array of tokens, which allows more efficient displaying. More info on the tracker entry : FS #6862.
The parsing code is completely independant and is all in wps_parser.c. The displaying part stays in gwps-common.c.
Debugging code is provided (with the right ifdefs) and is disabled by default.
Overall, the code should be easier to read and maintain. Adding new WPS tags is made quite trivial.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13019 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 14:41:40 +00:00
Marcoen Hirschberg
ab9d654c86 add support for non 16x16 frame sizes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13016 a1c6a512-1295-4272-9138-f99709370657
2007-04-04 08:14:03 +00:00
Tom Ross
771133eb12 Fix yellow.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13012 a1c6a512-1295-4272-9138-f99709370657
2007-04-03 20:56:14 +00:00
Tom Ross
70101c6027 Adjust Chopper and fix my warning from Wormlet.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13011 a1c6a512-1295-4272-9138-f99709370657
2007-04-03 20:22:04 +00:00
Tom Ross
f4c6560ea7 Adjust Wormlet to use the new macros.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13010 a1c6a512-1295-4272-9138-f99709370657
2007-04-03 20:10:40 +00:00
Nicolas Pennequin
af2ca4706e Better check when using the plugin buffer to store a temp cuesheet.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13007 a1c6a512-1295-4272-9138-f99709370657
2007-04-03 18:18:35 +00:00
Jens Arnold
323d75d25f It's not necessary (anymore?) to map lcd_icon() to sim_lcd_icon() for the simulator. * Removed a stray lcd_icon() call from usb handling.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13006 a1c6a512-1295-4272-9138-f99709370657
2007-04-03 18:06:13 +00:00
Nicolas Pennequin
bbe1eaf89e Improve ID3 "spoofing" to allow detection of missing information by the WPS.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13005 a1c6a512-1295-4272-9138-f99709370657
2007-04-02 19:40:53 +00:00
Jens Arnold
2a72a2fb59 This is called database for quite a while now...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13004 a1c6a512-1295-4272-9138-f99709370657
2007-04-02 19:35:11 +00:00
Steve Bavin
a81f97adc9 Simulator logf builds don't need two ways to access logf
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13002 a1c6a512-1295-4272-9138-f99709370657
2007-04-02 16:46:08 +00:00
Steve Bavin
2e7cb462b2 Fix occasional display of old tag data (normally from 32 tracks previous)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13001 a1c6a512-1295-4272-9138-f99709370657
2007-04-02 15:04:14 +00:00
Marcoen Hirschberg
1805203cc2 update by Wenbin Leo
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13000 a1c6a512-1295-4272-9138-f99709370657
2007-04-02 11:00:10 +00:00
Jens Arnold
fef40e465a These remote LCD bitmap functions cannot be added without warning this way; revert for now.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12997 a1c6a512-1295-4272-9138-f99709370657
2007-04-02 00:32:26 +00:00
Jens Arnold
c55ec18f98 Multi-screen API: * lcd_update() is now available for all LCDs. * Added missing functions for non-monochrome remote LCDs.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12996 a1c6a512-1295-4272-9138-f99709370657
2007-04-02 00:26:31 +00:00
Jens Arnold
239cda6fc4 Multi-screen API: * lcd_update() is now available for all LCDs. * Added missing functions for non-monochrome remote LCDs.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12995 a1c6a512-1295-4272-9138-f99709370657
2007-04-02 00:13:54 +00:00
Jens Arnold
2684e36724 Repair player progressbars (single char and full line) broken in the full unicode support move, and enable text alignment for charcell.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12993 a1c6a512-1295-4272-9138-f99709370657
2007-04-01 17:32:12 +00:00
Jens Arnold
738c37cdcf Player: Reduced the selectable codepages to those which can actually work, and made them work.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12990 a1c6a512-1295-4272-9138-f99709370657
2007-04-01 13:09:22 +00:00
Michael Sevakis
9f2b5cce84 JPEG Viewer on color LCDs: Finish up another old project. Add grayscale display option. Add ordered and diffusion dither modes to output. These options are under 'Display Options' in the viewer menu and are persisted in jpeg.cfg. Default setting is color display without dithering as before.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12987 a1c6a512-1295-4272-9138-f99709370657
2007-04-01 00:41:17 +00:00
Jonathan Gordon
c26a6bb57a stop the first press after exiting some plugins being eaten.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12986 a1c6a512-1295-4272-9138-f99709370657
2007-04-01 00:17:06 +00:00
Robert Kukla
1f33735097 FS#6948 - Fix the broken 'follow playlist' feature
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12985 a1c6a512-1295-4272-9138-f99709370657
2007-03-31 21:59:57 +00:00
Miika Pekkarinen
cf5671d75f FS#6890 Reworking of the default tagnavi.config file.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12984 a1c6a512-1295-4272-9138-f99709370657
2007-03-31 17:03:48 +00:00
Robert Kukla
8f1bc1f00b pre-set date fields in time/date screen to build date ( FS#6831 & FS#6939 )
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12982 a1c6a512-1295-4272-9138-f99709370657
2007-03-31 13:04:22 +00:00
Jens Arnold
81625742c9 Player: Fix setting integer values to their min/max values.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12980 a1c6a512-1295-4272-9138-f99709370657
2007-03-31 12:37:03 +00:00
Jens Arnold
54ea2e435e Charcell lcd driver: Preparations for switching to non-immediate LCD updates, using lcd_update() like on bitmap targets. * Added proper clipping. * Simplified simulator code.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12979 a1c6a512-1295-4272-9138-f99709370657
2007-03-31 09:58:49 +00:00
Dave Chapman
6186b556bd Change file reads from 128KB to 32KB chunks - this prevents audio dropouts on targets with slow disk access (Sansa). Also change FPS display line to include the current a/v delay.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12978 a1c6a512-1295-4272-9138-f99709370657
2007-03-31 08:51:32 +00:00
Miika Pekkarinen
ce35f76a53 Don't update runtime info when stopping playback, except when playlist ends. Fixes wrong playcounts and autoscores being generated.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12976 a1c6a512-1295-4272-9138-f99709370657
2007-03-31 06:49:49 +00:00
Dave Chapman
1088f695a2 Another AV sync bugfix - the initial avdelay was being incorrectly calculated in some cases
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12975 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 23:58:12 +00:00
Peter D'Hoye
dc33e1e8a7 Don't check for bootfile changes on devices that use OF for USB (and thus reboot)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12974 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 23:36:10 +00:00
Peter D'Hoye
c6ea09d6ef Minor update to Dutch lang file
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12973 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 22:54:39 +00:00
Peter D'Hoye
d2b305571e Check if a new version got installed after usb disconnect and ask if user wants to reboot. Causes disk spinup before showing the usb logo. Also fixes do_menu() not returning to root_menu after usb disconnect.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12972 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 21:54:48 +00:00
Dave Chapman
16fa5a9f01 Be less aggressive when dropping frames - mpegplayer was dropping any frame which was decoded more than 1/20th of a second late, change that to 3/20th second (150ms), giving noticably smoother video. Also process PTS values when dealing with MPEG-1 program streams
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12967 a1c6a512-1295-4272-9138-f99709370657
2007-03-30 00:03:07 +00:00
Peter D'Hoye
4d28b2f043 set correct eol-style and keywords properties
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12966 a1c6a512-1295-4272-9138-f99709370657
2007-03-29 22:51:03 +00:00
Nicolas Pennequin
d77274aeb9 Cuesheet tweaks:
* Max length for the info strings is now 80, according to the cue spec.
* Don't display the album artist if it's the same as the track artist.
* If the cue has composer info but not the tracks, the cue composer info is displayed for all the tracks.
* Slightly change the display in the cue viewer.
* A few cosmetic changes in the code.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12964 a1c6a512-1295-4272-9138-f99709370657
2007-03-29 18:39:04 +00:00
Jens Arnold
f267e04a69 Fix icons for built-in types on charcell.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12961 a1c6a512-1295-4272-9138-f99709370657
2007-03-29 17:35:25 +00:00
Jonathan Gordon
678705c732 Hopefully fix FS#6863 for good. (possible to get into infinite loop in the menu with screens returning GO_TO_PREVIOUS)
Also clean up root_menu.c a bit


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12960 a1c6a512-1295-4272-9138-f99709370657
2007-03-29 14:19:28 +00:00
Jonathan Gordon
21165a3f3d Recode filetypes.c to remove its need for a static string buffer.
Functional changes:
- filetypes.c handles the open with menu now instead of onplay.c
- automatic plugin registration no longer works (did anyone know about you could do this?)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12959 a1c6a512-1295-4272-9138-f99709370657
2007-03-29 06:16:00 +00:00
Michael Sevakis
62e0a516a0 Accept FS#6918 - Remove Nested Functions by Tim Ross. Adjust some names. Hunt down and remove the remaining ones in the recording system as well.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12955 a1c6a512-1295-4272-9138-f99709370657
2007-03-29 01:55:47 +00:00
Tom Ross
79df16adc1 Use the left and right buttons for changing volume in mpegplayer on the gigabeatsince the screen is rotated.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12953 a1c6a512-1295-4272-9138-f99709370657
2007-03-28 23:09:59 +00:00
Nicolas Pennequin
8f3a37ceaa Fix the warning.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12950 a1c6a512-1295-4272-9138-f99709370657
2007-03-28 19:55:41 +00:00
Nicolas Pennequin
10e9dc617a Improved cuesheet parser. Among other improvements, the use of quotation marks around strings in cuesheet files is now optional.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12949 a1c6a512-1295-4272-9138-f99709370657
2007-03-28 19:43:03 +00:00
Nicolas Pennequin
538126cb34 Use isspace() instead of a naive comparison.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12948 a1c6a512-1295-4272-9138-f99709370657
2007-03-28 14:17:10 +00:00
Miika Pekkarinen
b4a2d6a06a Killing of threads enabled also for logf debug builds.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12947 a1c6a512-1295-4272-9138-f99709370657
2007-03-28 07:33:40 +00:00
Tom Ross
c7f5cccd3e Adjust plugins to use the new menu API. Int settings still use the old API. Remove a nasty global in Star and add some error checking. Add a work-around for the gigabeat so that Star doesn't crash on target. The transition works fine on the sim and I see nothing obviously wrong with the code but it manages to crash on target everytime.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12946 a1c6a512-1295-4272-9138-f99709370657
2007-03-28 07:33:18 +00:00
Miika Pekkarinen
a289324e30 Ability to kill threads in debug screen by pressing select.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12945 a1c6a512-1295-4272-9138-f99709370657
2007-03-28 06:36:34 +00:00
Jens Arnold
290a812e71 Make the charset more maintainable by using an enum for font indexing, fix wrong U circumflex, and add 2 missing characters to the vkeyboard.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12940 a1c6a512-1295-4272-9138-f99709370657
2007-03-27 18:32:58 +00:00
Jonathan Gordon
91e726a1c1 Move all valid menu return codes to a single file (root_menu.h) so we don't need to rely on GO_TO_ROOT == MENU_ATTACHED_USB.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12937 a1c6a512-1295-4272-9138-f99709370657
2007-03-27 06:38:11 +00:00
Robert Kukla
40595bd57a #ifdef HAVE_TAGCACHE the set_rating code and remove some old, unused code
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12936 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 23:10:40 +00:00
Nicolas Pennequin
025d8d6133 Add support for the SONGWRITER cuesheet command, displayed as composer in the WPS. Also, use the album artist tag to store the disc artist defined in the cuesheet. Finally, only look for INDEX 01 commands instead of simply INDEX: we only care about INDEX 01.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12932 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 20:26:41 +00:00
Dave Chapman
f2df5b5b53 Those pesky 64-bit simulator builds..
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12931 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 19:54:07 +00:00
Dave Chapman
704b793787 Improved (I hope) A/V sync. mpegplayer now takes account of the difference in the initial audio and video PTS values, and constantly adjusts the av delay to compensate for drift between the audio PTS and the actual duration of the played audio.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12930 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 19:37:48 +00:00
Michael Sevakis
138baaa669 SWCODEC: Need to call resampler_new_delta when resetting DSP.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12929 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 18:39:03 +00:00
Miika Pekkarinen
66258a30a4 Make scheduler functions thread safe core wise. A big step towards playback running on COP (not yet possible because more protection on file system level is necessary).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12926 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 16:55:17 +00:00
Miika Pekkarinen
5f67db67b0 Killed a logf warning.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12924 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 16:34:58 +00:00
Michael Sevakis
32f418fb1c Argh. Get the tabs out the asm again.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12923 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 15:20:44 +00:00
Robert Kukla
226cb7b0b8 Rating support for database and WPS (based on FS# 6301). A value between 0 and 10 can be assigned to the currently playing track using the WPS context menu. This value is displayed in the WPS using the %rr tag (replacing autoscore) and can be used as "rating" in tagnavi.config (examples provided).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12922 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 15:08:59 +00:00
Jonathan Gordon
cd1ccad9d6 Make the OS stacks usage debug screen nicer, and unfiy the code for charcell/bmp lcds
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12921 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 12:09:08 +00:00
Jonathan Gordon
21c930310c woops, used the wrong define
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12920 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 10:14:32 +00:00
Jonathan Gordon
73c46ffd6e Convert the playback control menu to the new API. Makes a good example
for plugin devs :)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12919 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 09:14:16 +00:00
Jens Arnold
1764583f99 Rockblox: Repair initial display on targets with no highscore list.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12918 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 08:52:36 +00:00
Jens Arnold
51f4d3f212 Ooops.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12917 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 08:04:30 +00:00
Jens Arnold
ad4e3d6657 First step of charcell LCD code rework: * Make it fully unicode aware so that adding non-ISO8859-1 scripts becomes possible (limited by the LCD capabilities of course). * Make the API more similar to the bitmap LCD code's API. * Moved hardware dependent parts to target tree. * Simplified code. * Jumpscroll temporarily non-functional.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12916 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 07:52:13 +00:00
Dave Chapman
5e2984ad80 Fix warning
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12914 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 01:43:10 +00:00
Dave Chapman
a56757137c mpegplayer for grayscale targets. Note that performance is slow...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12913 a1c6a512-1295-4272-9138-f99709370657
2007-03-26 01:32:31 +00:00
Dave Chapman
465820da22 Initial attempt at rebuffering
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12911 a1c6a512-1295-4272-9138-f99709370657
2007-03-25 18:05:14 +00:00
Tom Ross
8a6e69263e Fix a few bugs in Xobox. Now menu isn't pure black on non-color targets and an issue where the board was drawn even when the user quit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12910 a1c6a512-1295-4272-9138-f99709370657
2007-03-25 17:52:56 +00:00
Robert Kukla
77983681ca fix bug where runtime data was not gathered for last track (end of playlist or stop button).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12909 a1c6a512-1295-4272-9138-f99709370657
2007-03-25 17:12:27 +00:00
Jonathan Gordon
8b7a27d189 fix red
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12908 a1c6a512-1295-4272-9138-f99709370657
2007-03-25 14:42:14 +00:00
Jonathan Gordon
1f5ee2a366 convert the xobox menu to the new API so it can be used as an example for plugin devs
Includes some fixes in the api to handle this.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12907 a1c6a512-1295-4272-9138-f99709370657
2007-03-25 14:31:56 +00:00
Jens Arnold
14fea30548 Allow clearing the backdrop on greyscale targets.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12906 a1c6a512-1295-4272-9138-f99709370657
2007-03-25 12:24:58 +00:00
Michael Sevakis
369c2a37b7 SWCODEC & Coldfire: Do some more DSP straigntening out. Do as much Coldfire optimizing as seems reasonably possible by jumping through some hoops to avoid stalls. Further boost reduction will just be fractional points if taken to extremes-- not worth it. Wrap up the ASM for awhile.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12905 a1c6a512-1295-4272-9138-f99709370657
2007-03-25 04:03:44 +00:00
Tomasz Malesinski
7d9ff93b79 FS #6848 - optimizations of Huffman decoding in Tremor.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12903 a1c6a512-1295-4272-9138-f99709370657
2007-03-24 14:06:56 +00:00
Tomasz Malesinski
25046aac17 FS #6848 - fast vector operations for ARM in Tremor.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12902 a1c6a512-1295-4272-9138-f99709370657
2007-03-24 13:45:54 +00:00
Dominik Riebeling
c3bef27cbd Temporary workaround hard lockup with "nothing to resume" splash at end of the playlist if the last active screen was the main menu. A proper fix should come soon.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12896 a1c6a512-1295-4272-9138-f99709370657
2007-03-23 08:09:28 +00:00
Dave Chapman
8b40769554 Clamp output when converting from libmad's s3.28 format to 16-bit integers.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12894 a1c6a512-1295-4272-9138-f99709370657
2007-03-22 22:47:04 +00:00
Nicolas Pennequin
e5b77b1a47 Add the necessary action_signalscreenchange call to avoid going back one level in the tree after leaving the cuesheet viewer screen.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12891 a1c6a512-1295-4272-9138-f99709370657
2007-03-22 13:52:56 +00:00
Jonathan Gordon
17a7f7ad35 Use power for ACTION_STD_CANCEL when left is being used for something else
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12890 a1c6a512-1295-4272-9138-f99709370657
2007-03-22 13:16:26 +00:00
Jonathan Gordon
62ec36c113 Woops.. no longer needed
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12887 a1c6a512-1295-4272-9138-f99709370657
2007-03-22 11:35:54 +00:00
Jonathan Gordon
da0ee110d9 fix FS#6877 — Using the quickmenu in the database view causes problems
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12886 a1c6a512-1295-4272-9138-f99709370657
2007-03-22 11:31:34 +00:00
Dave Chapman
46cf8805b6 Oops, only swcodec targets have pcm_get_bytes_waiting()
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12885 a1c6a512-1295-4272-9138-f99709370657
2007-03-22 09:40:26 +00:00
Dave Chapman
8310848421 Some small mpegplayer improvements/bug-fixes, and improved A/V sync. Audio is used as the master clock and video is synced to the number of samples played. This doesn't take account of any PTS difference at the start of the stream. Also enable Limit FPS and Skip Frames by default - these options need to be enabled for A/V sync to work. Adds pcm_get_bytes_waiting() to the plugin API
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12884 a1c6a512-1295-4272-9138-f99709370657
2007-03-22 09:18:46 +00:00
Nicolas Pennequin
81cad7db46 Further error checking that I shouldn't have forgotten earlier.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12883 a1c6a512-1295-4272-9138-f99709370657
2007-03-21 23:35:26 +00:00
Nicolas Pennequin
a83a94ea9c Add a bit more error checking to prevent possible crashes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12880 a1c6a512-1295-4272-9138-f99709370657
2007-03-21 21:38:55 +00:00
Barry Wardell
bbe55362da Fix FS#6875 - can't change shuffle setting in quickscreen on Sansa.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12876 a1c6a512-1295-4272-9138-f99709370657
2007-03-21 09:53:14 +00:00
Jonathan Gordon
e4689fd18e revert the last commit... setting wasnt worth the space
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12874 a1c6a512-1295-4272-9138-f99709370657
2007-03-21 07:26:07 +00:00
Jonathan Gordon
a5c5bd3831 Add a setting to force the backlight to stay on (or act normally) when
in plugins.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12873 a1c6a512-1295-4272-9138-f99709370657
2007-03-21 07:05:05 +00:00
Jonathan Gordon
59649b888a Fix FS#6863 - infinite looping with "Nothing to resume"
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12872 a1c6a512-1295-4272-9138-f99709370657
2007-03-21 05:45:34 +00:00
Michael Sevakis
571d3245f7 FS#6864 - iriver H340 doesn't connect via USB - should be fixed. Registered the voice queue but didn't create the thread.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12859 a1c6a512-1295-4272-9138-f99709370657
2007-03-20 14:09:50 +00:00
Michael Sevakis
3354531614 More logf fixes. speex.c wants to format 64bit args so I didn't change that one nor add any formatting for that.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12858 a1c6a512-1295-4272-9138-f99709370657
2007-03-20 13:53:23 +00:00
Michael Sevakis
e1dd10ddfb SWCODEC: Get rid of extra swap buffer and get back 512K of RAM or 100K if the players RAM is <= 1MB. Make any needed changes to things to stabilize and facilitate this including removing flattening out initialization. Comment some things heavily. Fix a few logfs I didn't want to see the compiler complaining about.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12843 a1c6a512-1295-4272-9138-f99709370657
2007-03-19 22:04:17 +00:00
Jens Arnold
96a0b2dac8 Further simplification of constraints in libspeex arm asm.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12841 a1c6a512-1295-4272-9138-f99709370657
2007-03-19 18:44:41 +00:00
Nils Wallménius
b41e93ae63 Draw peakmeter scale marks in foreground color instead of inversed background color, fixes FS #6855
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12840 a1c6a512-1295-4272-9138-f99709370657
2007-03-19 16:49:55 +00:00
Dave Chapman
f1bf798b8a Volume control for mpegplayer - based on FS #6814 by Jacob Gardner and Pascal Briehl, modified by me (blame me for any problems). Mapped to the same buttons that are used to control volume in the WPS.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12834 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 17:04:44 +00:00
Jens Arnold
2cf98689cf Player: Improve usaibiliy of wps volume adjustment in wps, and allow ON as 'ok' in standard context (fixes charging screen).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12833 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 14:19:18 +00:00
Jonathan Gordon
f34495deca Dont boost so often, fixes FS#6845
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12832 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 13:25:18 +00:00
Jonathan Gordon
5b61ebe84e Remove buffer overflow in solatiare menu
Make the old api -> new api wrapper in the menu safer.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12831 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 11:01:23 +00:00
Magnus Holmgren
01a010fd19 Fix several printf-style warnings in logf builds.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12830 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 09:50:53 +00:00
Jonathan Gordon
dd40a2e2fc Exit the preset context menu correctly after editing/deleting preset
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12829 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 07:57:36 +00:00
Jonathan Gordon
458648bd23 fix red
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12828 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 07:25:01 +00:00
Jonathan Gordon
e54d8e1388 Remove the exit_value variable.. set the MENU_FUNC_CHECK_RETVAL fla and
return 1 if you want your funciton to quit the menus.
save settings after clearing the background so it persists


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12827 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 07:03:43 +00:00
Jonathan Gordon
b5e587c081 Fix improper shift and mask order causing FS#6842
Set start_selected if exiting do_menu() early from more places


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12826 a1c6a512-1295-4272-9138-f99709370657
2007-03-18 06:31:33 +00:00
Jonathan Gordon
3d39c4de28 Fix it dropping back to the file browser.
Fix yellow


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12823 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 14:16:11 +00:00
Jonathan Gordon
208136d1ea Reload the menu if do_menu() is called while another menu is running
(fixes crashing coming out of rec settings from fm menu)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12822 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 14:10:51 +00:00
Jonathan Gordon
daf66940b1 Unify the way functions are called from menus.
Optionally, the functions return value can be checked for a value to 
tell the menu to quit.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12821 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 12:33:34 +00:00
Nils Wallménius
86ecc9588b Remove unused header
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12820 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 11:57:53 +00:00
Jens Arnold
bd5c0ad7bb Cast some more to keep both 32 bit and 64 bit simulator platforms happy.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12819 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 10:50:58 +00:00
Jens Arnold
f68362ad6f Fix simulator builds, and some debugf() format strings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12817 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 09:54:28 +00:00
Jens Arnold
79c8a8cbbe Let GCC check arguments of some more printf-style functions, also for plugins and codecs.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12815 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 09:02:53 +00:00
Magnus Holmgren
1329d7d3fd Fix occasional missing cursor when moving up in a list with a title when paged scrolling is on.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12814 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 07:30:33 +00:00
Nils Wallménius
685f6bb5e6 #ifdef code that only makes sense for multivolume targets, make private functions 'static'
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12813 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 00:55:23 +00:00
Marianne Arnold
661cb91e00 Give the greyscale minesweeper tiles a bit more shadow
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12812 a1c6a512-1295-4272-9138-f99709370657
2007-03-17 00:10:19 +00:00
Jens Arnold
2c7b127dd7 Set CONFIG_RTC to 0 for non-RTC targets, and check with #if to profit from -Wundef. No code change.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12811 a1c6a512-1295-4272-9138-f99709370657
2007-03-16 23:47:03 +00:00