Michael Hohmuth
593d520a00
mpegplayer: Adapt to new pause_rewind setting and apply it for all
...
kinds of pause, not just pause on headphone unplug.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29878 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 22:51:10 +00:00
Michael Hohmuth
4b5f68633f
Manual changes for rewind on pause. (Fixed a few typos while we are
...
at it.)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29877 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 22:28:55 +00:00
Michael Hohmuth
5aec3c2400
FS#11931 part 2: Allow a short rewind when playback is paused. Patch
...
by John Morris.
This patch adds an option to rewind the current track by a few seconds
when it is paused, irrespective of what has caused the pause. This is
useful for audiobooks and podcasts to allow the listener to recall
where the track was left off.
The patch subsumes the existing rewind-on-headphone-unplug feature and
extends it to all invocations of pause: play/pause button (or touch
area), headphone removal, and power-supply unplug in car-adapter
mode. It also subsumes FS#9448 (rewind on fade).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29876 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 22:28:47 +00:00
Andree Buschmann
0a070c5420
Fix last known 'set but not used' warning by GCC 4.6.1.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29875 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 19:40:17 +00:00
Andree Buschmann
d9098707f8
Fix another 'set but not used' warning.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29874 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 19:34:11 +00:00
Andree Buschmann
2aa0759077
Fix even more 'set but not used' warnings and a regression.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29873 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 19:23:27 +00:00
Andree Buschmann
4f4edd89e4
Fix further 'set but not used' warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29872 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 19:06:04 +00:00
Andree Buschmann
f7808c1fe5
Fix several 'variable set but not used' warnings reported by GCC 6.4.1.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29871 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 18:47:42 +00:00
Michael Giacomelli
6484b45d71
Make the AMS bootloader prompt slightly more specific.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29870 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 18:35:19 +00:00
Amaury Pouly
a43509cc99
fuze+: implement a full-blown debug screen for touchpad with graphical feedback
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29869 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 16:40:22 +00:00
Amaury Pouly
bdb8f4c15c
sbtools: fix a few memcpy with overlapping src/dst, fix a parsing bug (would access one byte paste the end of the buffer)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29868 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 12:20:49 +00:00
Amaury Pouly
a29ef617f3
sbtools: be more verbose on debug and fix a bug (uninitialized structure)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29867 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 12:13:02 +00:00
Thomas Martitz
6034978c84
Skin engine: Swap meaning of & and * for touch regions.
...
r29653 broke compatibility in a unnecessary way, including shipped themes (cabbieve2). Swapping restores compatibility.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29866 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 11:38:04 +00:00
Thomas Martitz
94dacca559
Rework MediaButtonReceiver a bit:
...
* Get rid of reflection since the lack of methods can be detected via exceptions
* Use requestAudioFocus/abandonAudioFocus APIs on 2.2+ to play nice with other music apps.
* Don't unregister the receiver on exit so we can receive media button presses (and startup the service) after idle poweroff (hopefully it's ok if mMediaButtonReceiver is garbage collected)
This should fix that Android calls the standard music app sometimes when those buttons are pressed.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29865 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 11:26:18 +00:00
Andree Buschmann
fffc6c4a80
Trapped into ifdef-hell. Configure libfaad's IRAM/DRAM usage like it is meant to be.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29864 a1c6a512-1295-4272-9138-f99709370657
2011-05-12 22:24:09 +00:00
Andree Buschmann
281666a066
The last submit had one define too much. Nevertheless fix the IRAM configuration for static allocation method.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29863 a1c6a512-1295-4272-9138-f99709370657
2011-05-12 18:06:03 +00:00
Andree Buschmann
2263cf35ab
libfaad: AAC including HE-profile needs ~470 KB for playback (measured on ARM). Therefor it does not make sense to enable HE on devices with CODEC_SIZE < 512 KB. This will allow to load and play larger AAC-LC files on such devices.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29862 a1c6a512-1295-4272-9138-f99709370657
2011-05-12 17:41:45 +00:00
Andree Buschmann
72fba7a9d7
Make libfaad compilable again without PS_DEC.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29861 a1c6a512-1295-4272-9138-f99709370657
2011-05-12 17:35:06 +00:00
Michael Hohmuth
9f32eb6f0d
FS#12102 - Manual, "Quick Start" section for AMSv2 players: Clarifies
...
how USB charging is handled. Thanks to Justin Hannigan!
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29860 a1c6a512-1295-4272-9138-f99709370657
2011-05-12 06:43:57 +00:00
Amaury Pouly
86e8c28330
fuze+: implement Synaptics RMI driver on top of i2c, add touchpad debug screen, bootloader enters debug screen by default
...
Since the bootloader currently always fails at storage point (unimplemented), always enter touchpad debug screen and power off which pressing power button.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29859 a1c6a512-1295-4272-9138-f99709370657
2011-05-11 22:38:09 +00:00
Michael Hohmuth
bc315ad731
FS#12076 - DB stats resurrection: If the filename was changed, require
...
all three of album, artist, and title tags to match for resurrection
to take place.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29858 a1c6a512-1295-4272-9138-f99709370657
2011-05-11 22:37:46 +00:00
Andree Buschmann
0e7c04e57d
libfaad: Move PS related variables to sbr_info struct. This allows dynamic allocation including error handling.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29857 a1c6a512-1295-4272-9138-f99709370657
2011-05-11 18:52:05 +00:00
Andree Buschmann
df7deee00f
Correct notation of a few supported audio formats in the manual.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29856 a1c6a512-1295-4272-9138-f99709370657
2011-05-10 21:38:00 +00:00
Alexander Levin
90f21b3fcc
Manual: typeset the commas using the normal font, not as 'fname'
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29855 a1c6a512-1295-4272-9138-f99709370657
2011-05-10 20:19:34 +00:00
Andree Buschmann
03e23d1113
Implement error handling for libfaad's memory allocation. Do not allocate PS related types dynamically anymore to minimize code changes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29854 a1c6a512-1295-4272-9138-f99709370657
2011-05-10 19:04:24 +00:00
Andree Buschmann
78b0f94c76
Proper initialization of static variables in codeclib.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29853 a1c6a512-1295-4272-9138-f99709370657
2011-05-10 18:20:56 +00:00
Amaury Pouly
2481427b03
fuze+: add init/enable/disable lcd sequences for the second lcd kind (only based on disassembly, untested)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29852 a1c6a512-1295-4272-9138-f99709370657
2011-05-10 17:22:01 +00:00
Michael Hohmuth
6a24a7a903
tagnavi.config: Add a logical-OR operator ("|") for tagnavi conditionals.
...
Logical-AND ("&") always takes precedence over logical-OR.
(Parentheses are not supported.)
Fight binsize increase by storing some common expressions in local
variables. This avoids repeated reevaluations involving memory
accesses.
check_clauses: Fail clause (return false) in case of errors (tag too
long, DB entry deleted).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29851 a1c6a512-1295-4272-9138-f99709370657
2011-05-10 10:25:41 +00:00
Jeffrey Goode
8cb4b36ee3
Fix whitespace and some comment typos
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29850 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 21:52:06 +00:00
Michael Sevakis
5a8f5b8330
Provide a reasonable fix for FS#12093 - Playback hanging after codec/playback rework. Also, get rid of an impossible buffering case (BUF_USED is always less than buffer_len) and remove a buffering API that is not used anywhere and shouldn't be needed (plugin API has to be incompatible).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29849 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 21:19:11 +00:00
Andree Buschmann
12e8e43236
Use signed variable to check available buffer size.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29848 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 20:43:35 +00:00
Alexander Levin
526346b6a7
Manual: add metadata section (FS#12090 by Andree Buschmann with slight modifications by me)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29847 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 20:34:14 +00:00
Andree Buschmann
1ee4e89627
Renaming for the sake of consistency.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29846 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 19:34:45 +00:00
Michael Hohmuth
0b59079dd2
Fix a warning
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29845 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 13:07:04 +00:00
Michael Hohmuth
84301c1e2d
FS#11931 part 1: Make fade in/out behavior more consistent across the
...
various causes of pause and unpause.
Patch by John Morris.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29844 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 12:59:46 +00:00
Michael Hohmuth
9b7027232f
unplug_change: Precede call to audio_ff_rewind with
...
audio_pre_ff_rewind (for SWCODEC).
This became necessary with the recent playback-code renovation.
Thanks to jethead for the hint!
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29843 a1c6a512-1295-4272-9138-f99709370657
2011-05-09 12:51:19 +00:00
Andree Buschmann
9befc2e747
Remove tabs.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29842 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 21:21:02 +00:00
Andree Buschmann
67f215032d
Fix a bunch of 'variable set but not used' warnings reported from GCC 4.6.0.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29841 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 21:06:38 +00:00
Bertrik Sikken
ab99e941db
More tab fixes
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29840 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 20:35:29 +00:00
Andree Buschmann
d68d02ec11
Move implementation of codec_get_buffer() to codec.c, make related variables static.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29839 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 20:18:35 +00:00
Andree Buschmann
b452fa061d
Use CACHEALIGN_SIZE in codec_malloc for optimal alignment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29838 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 19:50:39 +00:00
Andree Buschmann
f79769c541
Minor loop optimization in libfaad's is/ms decoding.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29837 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 19:36:08 +00:00
Dominik Riebeling
7d4616ea40
Fix BUILDID getting appended even if not set.
...
Rename some stuff to make it clearer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29836 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 19:34:03 +00:00
Dominik Riebeling
bdfd95e27d
Rockbox Utility: bump version to 1.2.10.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29834 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 18:49:54 +00:00
Andree Buschmann
e720724b95
Use MEM_ALIGN_ATTR and CACHEALIGN_SIZE in oggmalloc to ensure optimal alignment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29833 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 16:41:23 +00:00
Bertrik Sikken
9c33dca647
Fix tabs in .c and .h files in firmware/
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29832 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 11:37:18 +00:00
Andree Buschmann
897fd92827
codeclib: Declare several variables static and remove unused variables.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29831 a1c6a512-1295-4272-9138-f99709370657
2011-05-08 10:34:05 +00:00
Dominik Riebeling
75e3fb7edb
SAPI voice creating: add slovak to languages.
...
Extend sapi_voice.vbs with slovak (FS#10904). Additionally add it to the list
of supported languages in Rockbox Utility and fix the country code used for
slovenscina (by myself).
Author: Peter Lecky
Flyspray: FS#10904
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29830 a1c6a512-1295-4272-9138-f99709370657
2011-05-07 15:55:42 +00:00
Dominik Riebeling
0925bfbb1c
Rockbox Utility: Add some more cases to version check test.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29829 a1c6a512-1295-4272-9138-f99709370657
2011-05-07 15:39:09 +00:00
Nils Wallménius
04b4722a5c
Fix FS#12098 by ignoring battery update events in the yesno screen.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29828 a1c6a512-1295-4272-9138-f99709370657
2011-05-07 08:08:49 +00:00