Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
25566 commits 17 branches 142 tags 291 MiB
Commit graph

172 commits

Author SHA1 Message Date
Jonathan Gordon
10df05438e more textarea to viewport conversion... yes/no screen... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17454 a1c6a512-1295-4272-9138-f99709370657
 2008-05-11 13:39:22 +00:00
Jonathan Gordon
daa8341a13 a bit of code cleanup.. use a single function to get the statusbar height (or lack of if its enabled), and remove some gui_textarea stuff which could be done using the splash. (gui_textarea is on the way out) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17350 a1c6a512-1295-4272-9138-f99709370657
 2008-05-04 10:58:05 +00:00
Bertrik Sikken
e15f8a21a9 Made source files #include the header file that they implement to make sure they are in sync. Made some local functions static. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17312 a1c6a512-1295-4272-9138-f99709370657
 2008-05-03 08:35:14 +00:00
Jonathan Gordon
fa64dbb525 So, I was skimming the irc logs from my 3 day absense and I was pinged about a bug in the simplelist code and this function in particular. Neither time was the actual bug explained so I dont know what this commit fixes... I'm fairly certain it does fix it though because the old code was rediculously wrong. MY guess is it has something to do with the radio debug screen seen as its the only call to this with the param != 0. 
Please use the damn tracker for bug reports.. pinging someone when they arnt even online (as opposed to idling in the channel) really is a waste of time.)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17204 a1c6a512-1295-4272-9138-f99709370657
 2008-04-21 13:32:10 +00:00
Nils Wallménius
6848961aa5 Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
 2008-04-09 15:25:17 +00:00
Jonathan Gordon
be185a1eaf fix the buttonbar in the browser and menus. 
fix a problem where the menus wouldnt redraw when they should have when settings change


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16816 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 09:05:42 +00:00
Jonathan Gordon
5ca1539969 the menu and list now accepts a parent viewport to draw in (and the menu can be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
 2008-03-26 03:35:24 +00:00
Jonathan Gordon
885283c424 more fixes for button bar... this will all disappear when viewports are handled by a manager of some sort 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16589 a1c6a512-1295-4272-9138-f99709370657
 2008-03-09 09:37:39 +00:00
Jonathan Gordon
3f686d7034 fix recorder, buttonbar caused list problems 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16584 a1c6a512-1295-4272-9138-f99709370657
 2008-03-09 02:00:31 +00:00
Jonathan Gordon
f444f1ecbe fix the touchpad list code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16528 a1c6a512-1295-4272-9138-f99709370657
 2008-03-05 10:38:10 +00:00
Jonathan Gordon
0e5cec2d18 FS#8457 - convert the list drawing code to use viewports. This does not include any of the customizability which was in the patch, so unless any bugs show up users should not notice any difference. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16527 a1c6a512-1295-4272-9138-f99709370657
 2008-03-05 09:58:30 +00:00
Jens Arnold
bf9ae1f303 Fix the simplelist redraw behaviour. It caused e.g. the 'Open with...' menu items to not scroll as they should, making it partially unusable with small displays and/or large fonts. Thanks to JdGordon for pointing me into the right direction. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16415 a1c6a512-1295-4272-9138-f99709370657
 2008-02-25 07:41:30 +00:00
Peter D'Hoye
c4c678ff1a Accept FS #8490 by Vuong Minh Hiep: fix wrong selection in multi-line lists 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16135 a1c6a512-1295-4272-9138-f99709370657
 2008-01-21 22:28:25 +00:00
Jonathan Gordon
b684b82fd0 Accept and Fix FS#8427 - problem with empty screens in lists with pages scrolling enabled 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16023 a1c6a512-1295-4272-9138-f99709370657
 2008-01-08 08:12:32 +00:00
Jonathan Gordon
213d9a2ca1 fix touchpad list code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15948 a1c6a512-1295-4272-9138-f99709370657
 2007-12-17 04:23:34 +00:00
Jonathan Gordon
f5ec3e49e0 remove the duplicated gui_list struct and only duplicate the members which are actually different on each screen. should translate to a smaller bin and easier code (users shouldnt notice any difference) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15947 a1c6a512-1295-4272-9138-f99709370657
 2007-12-17 02:37:21 +00:00
Nicolas Pennequin
485bbbdb30 Make the "current line" value in the gradient style code zero-based, and an attempt at more understandable names and better comments. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15886 a1c6a512-1295-4272-9138-f99709370657
 2007-12-06 17:09:24 +00:00
Nicolas Pennequin
b766f11701 Oops, wrong define. Fixes the warnings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15699 a1c6a512-1295-4272-9138-f99709370657
 2007-11-19 18:25:13 +00:00
Nicolas Pennequin
1d86dbffe3 Accept FS#7901 by Akio Idehara: Fix gradient for scrolling lines when more than one line is selected 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15698 a1c6a512-1295-4272-9138-f99709370657
 2007-11-19 18:14:51 +00:00
Linus Nielsen Feltzing
e75327b332 FS#7738 - Scroll wheel acceleration for iPod 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15681 a1c6a512-1295-4272-9138-f99709370657
 2007-11-19 11:05:54 +00:00
Jonathan Gordon
04d0e3bc41 fix talking simplelists which I broke yesterday. dont talk if the list is being redrawn because get_action() timed out. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15459 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 12:52:32 +00:00
Jonathan Gordon
eb20149804 minor touchpad tweaking... 
lists - dont do ACTION_STD_OK if pressing an area under the last item
colour chooser - change the seelcted colour straight away without having to swicth sliders first


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15455 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 10:51:11 +00:00
Jonathan Gordon
e247230e0d redraw the siplelist more often 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15446 a1c6a512-1295-4272-9138-f99709370657
 2007-11-04 01:04:10 +00:00
Karl Kurbjun
38548c7118 Build some more plugins for M:Robe most work, doom builds and runs if you use a hack - need to fix the user timer so that it works properly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15403 a1c6a512-1295-4272-9138-f99709370657
 2007-11-02 05:21:34 +00:00
Michael Sevakis
d6af287397 Implement as genuine a set_irq_level function for the sim as possible. The yield added earlier is still nescessary since other threads won't run anyway while viewing the database screen on either sim or target. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15321 a1c6a512-1295-4272-9138-f99709370657
 2007-10-26 23:11:18 +00:00
Steve Bavin
ab784649cd Don't lock up simulators when lists are used with TIMEOUT_NOBLOCK. Fixes FS#8030. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15318 a1c6a512-1295-4272-9138-f99709370657
 2007-10-26 18:04:42 +00:00
Steve Bavin
072a3c5017 Complete info screen voicing; now consistent with displayed screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15284 a1c6a512-1295-4272-9138-f99709370657
 2007-10-24 12:32:12 +00:00
Jonathan Gordon
eed41ff985 mrobe changes: 
stop it thinking the battery is always flat and shutting down
add keymap for time/date screen
pressing a list item will highlight it before accepting it (looks better than it just entering the item without the selection changing first)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15280 a1c6a512-1295-4272-9138-f99709370657
 2007-10-23 14:33:16 +00:00
Stéphane Doyon
a82a860c7e Small voice-related tweaks and fixes to simplelists. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15276 a1c6a512-1295-4272-9138-f99709370657
 2007-10-23 05:19:03 +00:00
Jonathan Gordon
fa13cbee80 First go at getting the touchpad working in the ui. lists only for now. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15264 a1c6a512-1295-4272-9138-f99709370657
 2007-10-22 12:26:53 +00:00
Jonathan Gordon
0465101f92 allow simplelists to set the timeout and the start selection. 
set a slightly saner default timeout
talk the selected item when the list is first displayed


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15247 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 13:47:43 +00:00
Miika Pekkarinen
caff835d78 Fixed debug menu crashing. Show last file processed by tagcache engine in debug menu. Enabled autoupdating of deleted files for flash storage devices. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15244 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 11:06:30 +00:00
Jonathan Gordon
616971c71e remove the seelection_size param from the info init call to hopefully decrease the bin size a bit 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15237 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 06:42:52 +00:00
Jonathan Gordon
5eac0108f9 simplify the simpelist api slightly so not every struct member needs to be init manually. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15236 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 01:27:17 +00:00
Stéphane Doyon
8486c0413e Accept FS#7774: Voice callback for gui_synclist. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15231 a1c6a512-1295-4272-9138-f99709370657
 2007-10-21 00:20:10 +00:00
Jonathan Gordon
5f893be2a3 add a list API for simple lists which dont need lots of code to run. 
Example uses in debug_menu.c
This API works best if most of the text is static, or not many actions 
need to acted on. (of course, any list could use this)



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15221 a1c6a512-1295-4272-9138-f99709370657
 2007-10-20 12:32:55 +00:00
Antoine Cellerier
d66b3c0f61 Remove the "invert scroll" code since it's not used anywhere anymore (and it was broken on color targets with gradients anyway). Closes FS #7875. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15125 a1c6a512-1295-4272-9138-f99709370657
 2007-10-15 20:42:51 +00:00
Nicolas Pennequin
7eedcb49d9 Fix buggy gradient display when a coloured file is selected in the browser. Thanks to smably for the report. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14891 a1c6a512-1295-4272-9138-f99709370657
 2007-09-28 19:47:28 +00:00
Nicolas Pennequin
49a9e1ef35 Make the gradient look better when more than one line is selected (running time, ID3 info, cuesheet viewer...). I haven't found a solution for scrolling yet, so that won't look too good. 
The recording screen code needs a bit of adapting too, but I don't have a target to test on, so leave it for now.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14884 a1c6a512-1295-4272-9138-f99709370657
 2007-09-28 13:49:43 +00:00
Nicolas Pennequin
f3b015f73b FS#7808 by Tom Ross, Ken Fazzone and me, with help from Antoine Cellerier. 
Add two new line selector types: solid colour and gradient. Solid colour only uses the primary colour setting.
The secondary colour setting is used for the gradient. Text colour for the selected item is also changeable.
These new settings are a bit controversial so they may be removed later.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14868 a1c6a512-1295-4272-9138-f99709370657
 2007-09-27 15:42:55 +00:00
Jonathan Gordon
cf1cef5f57 minor update to gui_synclist_do_button() which will hopefully simplify things later. 
Now returns true if the action was handled in that function instead of returning the handled action.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
 2007-09-17 10:08:50 +00:00
Jonathan Gordon
ffeccda8cd Fix the bug where holding left no longer stopped at the browser root. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13983 a1c6a512-1295-4272-9138-f99709370657
 2007-07-25 12:37:09 +00:00
Michael Sevakis
873e0fd1ef Wheel acceleration for e200. A general acceleration interface intended for use on any scroll target and by any code. A general interface to obtain data associated with most recently dequeued button presses and actions. Use #define HAVE_SCROLLWHEEL and set appropriate constants, values in the scroller driver that feel right. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13959 a1c6a512-1295-4272-9138-f99709370657
 2007-07-22 21:02:24 +00:00
Jonathan Gordon
2d4ee368e3 Fix problems with the list when you change font size 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13680 a1c6a512-1295-4272-9138-f99709370657
 2007-06-21 13:21:33 +00:00
Brandon Low
488de5e09c Fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13657 a1c6a512-1295-4272-9138-f99709370657
 2007-06-17 21:29:24 +00:00
Brandon Low
74cbb0a1b2 Give color targets the ability to display each LCD line a different color and use this newfangled ability to provide themable colored file types. See the comments on read_color_theme_file and the sample.colors file provided for how to use this. .colors files go in themes directory for now. This separate line color function should be trivial to add to menus and wpss. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13656 a1c6a512-1295-4272-9138-f99709370657
 2007-06-17 21:16:34 +00:00
Jonathan Gordon
57440d5292 Fix a minor annoyance with the last commit where selecting an item could result in having empty space under the list. 
Also very very minor code reduction.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13607 a1c6a512-1295-4272-9138-f99709370657
 2007-06-10 08:18:19 +00:00
Jonathan Gordon
f4d0f053e6 Really fix FS#7274 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13606 a1c6a512-1295-4272-9138-f99709370657
 2007-06-10 07:12:39 +00:00
Jonathan Gordon
f3145ba07c simple fix for FS#7274 - selected item might not be shown when a list is drawn in paged scroll mode 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13602 a1c6a512-1295-4272-9138-f99709370657
 2007-06-09 09:41:13 +00:00
Jonathan Gordon
3823486a58 Add a mode the lists which doesnt show the selection marker. 
Useful for the debug menus where users shouldn't think pressing select would do anything.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13588 a1c6a512-1295-4272-9138-f99709370657
 2007-06-07 12:14:31 +00:00
Jonathan Gordon
fea88888f0 Fix most (all) known list wierdness bugs, hopefully simplifies the code a bit, plenty of room for optimizing, but wanted to get it working first. (fixes FS#7255 and possibly others) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13556 a1c6a512-1295-4272-9138-f99709370657
 2007-06-05 02:57:43 +00:00
Jonathan Gordon
20a8a9a3c8 Move the old api out of the core and into the plugin lib. 
ew plugins shuold use the new api and not this one.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13537 a1c6a512-1295-4272-9138-f99709370657
 2007-06-03 04:06:58 +00:00
Nils Wallménius
fbdbd2112c Fix warning 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13525 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 18:08:29 +00:00
Nils Wallménius
f46657ec5a Move the setvol wrapper function to misc.c and use it in more places instead of doing the same checks everywhere 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13524 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 17:57:32 +00:00
Jonathan Gordon
dfb071d92e Last list commit for a while. fix the multi-item lists at the very end of the list 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13523 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 09:25:59 +00:00
Jonathan Gordon
0178568325 fix non-paged scrolling aroun the ends of lists 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13522 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 09:11:59 +00:00
Jonathan Gordon
5983e7fa42 few more list anomolys fixed.. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13521 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 08:29:44 +00:00
Jonathan Gordon
155e3d33d6 Fix the last (?) of the selction wierdness, this time when moving at the begining of the list 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13520 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 02:08:35 +00:00
Jonathan Gordon
6fd3d96309 fix selection wierdness when scrolling down at the end of lists 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13514 a1c6a512-1295-4272-9138-f99709370657
 2007-05-29 13:06:41 +00:00
Jonathan Gordon
20202017f4 Really fix FS#7230 this time. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13513 a1c6a512-1295-4272-9138-f99709370657
 2007-05-29 12:28:02 +00:00
Jonathan Gordon
195ac12296 Fix FS#7230 - the second line in a multi-line item could be the selected item 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13512 a1c6a512-1295-4272-9138-f99709370657
 2007-05-29 12:16:31 +00:00
Jonathan Gordon
42698e4e47 Accept FS#6798 - scan acceleration for the lists. 
Settings are in display > scrolling


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13499 a1c6a512-1295-4272-9138-f99709370657
 2007-05-27 15:08:56 +00:00
Jonathan Gordon
c9ed673c81 only show the cursor for the first line of the selected item (if selection is more than one line). doesnt effect inverted cursor mode 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13375 a1c6a512-1295-4272-9138-f99709370657
 2007-05-12 14:13:23 +00:00
Jonathan Gordon
39a6b5d643 Stop using the old menu API in the debug menu (using the new api causes massive bin increase, so fake the old api with existing code instead) (onplay.c and plugins are the only parts using th eold api now) 
Fix a bug where the menu title was sometimes shown in the system font


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13286 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 15:31:43 +00:00
Jonathan Gordon
7f3c66f1cb Fix the playlist viewer so only 1 line flashes when you move a track 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13231 a1c6a512-1295-4272-9138-f99709370657
 2007-04-21 11:14:57 +00:00
Jonathan Gordon
6a5cc0bd25 Customizable icons for all bitmap targets. (FS#7013) 
http://www.rockbox.org/twiki/bin/view/Main/CustomIcons for info on format and how to load them


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13177 a1c6a512-1295-4272-9138-f99709370657
 2007-04-16 09:14:36 +00:00
Jens Arnold
0b7bb31453 Simplification, queue pointers don't wrap (except at INT_MAX, but the calculation is still correct in this case). Implemented queue_count() for the simulator. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13154 a1c6a512-1295-4272-9138-f99709370657
 2007-04-14 09:47:47 +00:00
Jonathan Gordon
08e633c25c Hide the list title if only one line would fit under it 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13107 a1c6a512-1295-4272-9138-f99709370657
 2007-04-11 10:34:44 +00:00
Jonathan Gordon
a053e58894 minor actions cleanup: 
- CONTEXT_MAINMENU is not actually needed, use CONTEXT_TREE which does the same actions
- (gigabeat) use vol+/- in the lists to control volume (every list!) (FS#6982 in a better way)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13062 a1c6a512-1295-4272-9138-f99709370657
 2007-04-08 01:33:01 +00:00
Magnus Holmgren
1329d7d3fd Fix occasional missing cursor when moving up in a list with a title when paged scrolling is on. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12814 a1c6a512-1295-4272-9138-f99709370657
 2007-03-17 07:30:33 +00:00
Miika Pekkarinen
2eefb5acb8 Optimized the gui list code performance, including automatic frame dropping and cpu boosting when button events are getting queued. Improved scrollwheel acceleration code is needed to notice a real change. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12721 a1c6a512-1295-4272-9138-f99709370657
 2007-03-11 10:52:36 +00:00
Jonathan Gordon
f83d6eb145 revert FS#6747 — y-margin reset in gui_list_draw, it introduced a nasty 
scroll bug which isnt so simple to fix.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12719 a1c6a512-1295-4272-9138-f99709370657
 2007-03-11 08:05:05 +00:00
Jonathan Gordon
4949818c24 only call display->setmargins() once 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12706 a1c6a512-1295-4272-9138-f99709370657
 2007-03-10 13:05:47 +00:00
Jonathan Gordon
a990ff2920 Accept FS#6747 by Timo Horstschäfer 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12704 a1c6a512-1295-4272-9138-f99709370657
 2007-03-10 12:43:21 +00:00
Linus Nielsen Feltzing
298c2bbd83 Allow dynamic menu items to be spoken, especially the resume/now playing item 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12614 a1c6a512-1295-4272-9138-f99709370657
 2007-03-05 00:32:33 +00:00
Jonathan Gordon
5ea43ce8a9 thats what happens when you commit between dinner courses :p 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12582 a1c6a512-1295-4272-9138-f99709370657
 2007-03-04 08:35:20 +00:00
Jonathan Gordon
e6ba70548d Fix red builds. 
(Previous commit was for FS#6713 btw)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12581 a1c6a512-1295-4272-9138-f99709370657
 2007-03-04 08:05:33 +00:00
Jonathan Gordon
ca701bf62e Add a function to get the actual button that was pressed (and some 
status codes) instead of the action. Use this to figure out which screen 
to do prev/next page on in the lists


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12580 a1c6a512-1295-4272-9138-f99709370657
 2007-03-04 07:45:12 +00:00
Jonathan Gordon
7ae5f12449 The list should reset the x margin when it finishes drawing. Not leave 
it up to the next screen


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12570 a1c6a512-1295-4272-9138-f99709370657
 2007-03-03 13:42:12 +00:00
Steve Bavin
361a60c964 Centralise icon enabling to hopefully save a few bytes 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12540 a1c6a512-1295-4272-9138-f99709370657
 2007-03-01 18:25:13 +00:00
Nils Wallménius
7fdee10a70 Make private functions static. Remove some functions from the plugin api as they weren't used in any plugins and could then be declared static. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12462 a1c6a512-1295-4272-9138-f99709370657
 2007-02-23 21:52:45 +00:00
Jonathan Gordon
eff0dc3e13 Allow the list to display a title icon even if no other icons will be 
displayed


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12375 a1c6a512-1295-4272-9138-f99709370657
 2007-02-18 00:52:34 +00:00
Daniel Stenberg
20a5926d2e build with -Wundef to make sure we have spelled the defines right in #if lines 
and have the proper includes included etc


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12360 a1c6a512-1295-4272-9138-f99709370657
 2007-02-17 21:54:17 +00:00
Jens Arnold
2597a13497 Next round of static'ing and related fixes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11836 a1c6a512-1295-4272-9138-f99709370657
 2006-12-25 14:01:47 +00:00
Peter D'Hoye
3e1f837d11 Turned function back into define as that uses less bytes because gcc inlined the function. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11699 a1c6a512-1295-4272-9138-f99709370657
 2006-12-09 12:27:04 +00:00
Peter D'Hoye
552ac5a724 Fix crash in browser when using very big fonts and show path option together. Solves FS#6397. Patch created by Mark Arigo and modified by me. Minor code ploicing while in there. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11696 a1c6a512-1295-4272-9138-f99709370657
 2006-12-09 10:02:09 +00:00
Jonathan Gordon
6a1161b634 dont allow the volume setting to wrap 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11445 a1c6a512-1295-4272-9138-f99709370657
 2006-11-06 10:11:51 +00:00
Jonathan Gordon
717f63e8e2 fixes fs# 5938 - scrollbar with title enabled shows one less than it should 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11412 a1c6a512-1295-4272-9138-f99709370657
 2006-11-01 12:03:27 +00:00
Martin Scarratt
4a1d8d272a fix warning 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11043 a1c6a512-1295-4272-9138-f99709370657
 2006-09-25 11:06:54 +00:00
Martin Scarratt
1ab1f02dfe fix the bug where when scrolling text left in the filebrowser you could suddenly find yourself in the root directory. A long press on the left scrolling button will still take you to the root quickly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11042 a1c6a512-1295-4272-9138-f99709370657
 2006-09-25 10:56:38 +00:00
Jonathan Gordon
4553069f9d holding left in the tree will quickly get back to root, as long as the text is in the left-most position (like before) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10965 a1c6a512-1295-4272-9138-f99709370657
 2006-09-17 08:30:17 +00:00
Mark Arigo
34301bb37b Add optional icon to list title, current path display shows a dir icon, and list titles now left-justified. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10726 a1c6a512-1295-4272-9138-f99709370657
 2006-08-23 20:02:06 +00:00
Jonathan Gordon
66c4bd6e63 Stop lists wrapping when using page up/down 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10712 a1c6a512-1295-4272-9138-f99709370657
 2006-08-23 08:35:31 +00:00
Dan Everton
98c9f959e5 Clear file view title if the user turns it off. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10596 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 22:14:35 +00:00
Jonathan Gordon
599fa9a627 fix "off-by-one" bug in paginated scrolling with the title 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10589 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 14:06:29 +00:00
Linus Nielsen Feltzing
224c0a13eb Finally, the new button action system is here, thanks to Jonathan Gordon. Some button mappings have changed and other things may break. Comments should go to the forum, http://forums.rockbox.org/index.php?topic=5829.0 or the mailing list. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10582 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 12:27:07 +00:00
Dan Everton
c0f8b18770 A few changes and fixes for the title in the file view: disable title string in tagcache view, strip leading / from current directory title, center title properly, scroll title if it's too long. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10581 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 12:23:55 +00:00
Dave Chapman
079ad11896 Patch #5795 from Jonathan Gordon - change the settings display for enumerations and integers to use the list widget. Patch also adds an optional title to the list widget which is used in the settings. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10576 a1c6a512-1295-4272-9138-f99709370657
 2006-08-15 08:14:46 +00:00
Shachar Liberman
f53779d2f4 Committing FS#5182 - One button hold for Horizontal screen scrolling. 
=>hold RIGHT or LEFT button on a GUI based list to scroll horizontally.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10545 a1c6a512-1295-4272-9138-f99709370657
 2006-08-12 13:40:49 +00:00
Kevin Ferrare
f64280ff00 OOPS Forgot remote keys bindings for the ID3 info screen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10176 a1c6a512-1295-4272-9138-f99709370657
 2006-07-02 16:18:59 +00:00