Michael Sevakis
092d355c34
Kill the errors for now. Would like to know why resetting in_recording_screen from outside the function should ever be needed. If you're not in the recording screen any more, the function should have exited and reset in_recording_screen to false. If it hasn't actually been reset in that case, the function hasn't return for some reason.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12226 a1c6a512-1295-4272-9138-f99709370657
2007-02-07 17:03:23 +00:00
Jonathan Gordon
3e16c9eb25
if you reset your settings, you wont be in the rec screen anymore!
...
(hopefully fix the statusbar problem for good)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12225 a1c6a512-1295-4272-9138-f99709370657
2007-02-07 14:17:13 +00:00
Jonathan Gordon
48289a51ad
Do Mike's previous patch a bit nicer.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12224 a1c6a512-1295-4272-9138-f99709370657
2007-02-07 06:14:35 +00:00
Michael Sevakis
946e4f871b
Fix warnings. Initialized struct needs at least one member actually initialized. Add a dummy until at least one is guaranteed in all builds. Please remove it at that point.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12223 a1c6a512-1295-4272-9138-f99709370657
2007-02-07 04:54:04 +00:00
Michael Sevakis
eed62f1657
Change the radio screen and recording screen to use the global_status structure for state. I guess global_status had been added already and I missed it. :D
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12222 a1c6a512-1295-4272-9138-f99709370657
2007-02-07 04:24:21 +00:00
Michael Sevakis
ff3bb3aa18
Don't save the in-out state of the recording screen as a setting. Fixes the statusbar icons if settings were saved while recording screen was on. Humbly may I suggest a global_state structure to do all this state checking more efficiently\? Ignore me if that's being worked on by someone.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12221 a1c6a512-1295-4272-9138-f99709370657
2007-02-07 02:48:19 +00:00
Tom Ross
70ebc8feb1
Correct a deceptive comment. Clarify that this config file is only for the 4g grayscale iPod.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12220 a1c6a512-1295-4272-9138-f99709370657
2007-02-07 02:18:14 +00:00
Michael Sevakis
ce89a2745c
Woops. Upon examining the diffs again I find I shouldn't have deleted that one yield() from the a52 codec.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12219 a1c6a512-1295-4272-9138-f99709370657
2007-02-07 01:30:05 +00:00
Michael Sevakis
aba6ca0881
Fix resampling clicking as much as possible at the moment. 1) Upsampling clicked because of size inaccuracies returned by DSP. Fix by simplifying audio system to use per-channel sample count from codec to pcm buffer. 2) Downsampling affected by 1) and was often starting passed the end of the data when not enough was available to generate an output sample. Fix by clamping input range to last sample in buffer and using the last sample value in the buffer. A perfect fix will require a double buffering scheme on the resampler to sufficient data during small data transients on both ends at all times of the down ratio on input and the up ratio on output.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12218 a1c6a512-1295-4272-9138-f99709370657
2007-02-07 00:51:50 +00:00
Dave Chapman
dd50c863e6
Oops, we should close the devices during the scan
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12217 a1c6a512-1295-4272-9138-f99709370657
2007-02-06 22:48:30 +00:00
Tom Ross
2882b26a99
Major Rockboy update.
...
1) Adapt Rockboy to smaller screens (H10, X5, and iPod Nano).
2) Add the ability to use a preset palette on color targets. Choose 'Set Palette' from the main menu.
3) Clean up the code to remove any unused code and variables.
4) Changed tabs to spaces.
5) Disable reading and writing sound when sound is disabled.
6) Disbable writing to the RTC since it is not implemented yet.
7) Minor optimizations from WAC gnuboy CE and iBoy.
8) Massive clean up of code to make it appear consistent.
9) Change all C++ style comments to C style.
10) Completely reorganize dynarec. Add fixmes to all unimplemented opcodes. Add debug writes for all opcodes. Attempt to implement a few opcodes myself.
11) Silence some warnings when built using dynarec.
12) Minor reshuffling of IRAM, may or not offer a speed increase.
13) Include fixes found in the short-lived gnuboy CVS.
All in all, there's about a 10% improvement on my test roms when sound is disabled and slight improvement with sound. Especially noticable when there are few sprites on screen and less action is occurring. See FS #6567 .
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12216 a1c6a512-1295-4272-9138-f99709370657
2007-02-06 21:41:08 +00:00
Dave Chapman
1026c0f5b2
Make the [device] parameter optional. If none is specified, then ipodpatcher scans for an ipod, and if exactly one ipod is found, it uses that device.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12215 a1c6a512-1295-4272-9138-f99709370657
2007-02-06 21:00:56 +00:00
Nils Wallménius
28a8894656
Ifdef some remote lcd code in the recording screen that is not used for non lcd remote targets
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12214 a1c6a512-1295-4272-9138-f99709370657
2007-02-06 20:30:58 +00:00
Jonathan Gordon
2f4521ea9e
More HAVE_TAGCACHE by Austin Appel
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12213 a1c6a512-1295-4272-9138-f99709370657
2007-02-06 13:25:57 +00:00
Dave Chapman
9d15361758
Bump version to 0.7 for release
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12212 a1c6a512-1295-4272-9138-f99709370657
2007-02-06 09:15:00 +00:00
Jonathan Gordon
d18a68d93b
Fix FS #6624 - remove useless menu items from the context menu in an empty directory
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12211 a1c6a512-1295-4272-9138-f99709370657
2007-02-06 09:01:32 +00:00
Paul Louden
d71b44cbd2
Made ipodpatcher use slightly more clear for linux users.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12210 a1c6a512-1295-4272-9138-f99709370657
2007-02-05 21:16:16 +00:00
Dave Chapman
6e641e81ed
Support for modifying the firmware partition on Macpods (useful for IPL users), along with the addition of a big warning when ipodpatcher detects a Macpod to say that Rockbox won't work on it.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12209 a1c6a512-1295-4272-9138-f99709370657
2007-02-05 18:29:39 +00:00
Nils Wallménius
d442cbeab8
add a note about installing the bootloader on US h300s
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12208 a1c6a512-1295-4272-9138-f99709370657
2007-02-05 18:14:43 +00:00
Jonathan Gordon
3d43828f53
fix FS#6621 - viewer bookmarks only working for one file
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12207 a1c6a512-1295-4272-9138-f99709370657
2007-02-05 13:29:50 +00:00
Steve Bavin
608e53d10f
Remove H300 GPOODx debugging; it was using the wrong port addresses anyway
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12206 a1c6a512-1295-4272-9138-f99709370657
2007-02-05 13:08:08 +00:00
Dave Chapman
e332f4c2ea
Update (C) date to 2007
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12205 a1c6a512-1295-4272-9138-f99709370657
2007-02-05 01:20:20 +00:00
Thom Johansen
5ba289bc27
Kill a warning.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12204 a1c6a512-1295-4272-9138-f99709370657
2007-02-05 01:18:29 +00:00
Thom Johansen
5f48e1590f
Optimise EQ coef calculation routines for both speed and size. Move now unneeded fsqrt function to plugin fixed point library in case it'll be needed. Move all fixed point helper macros to dsp.h. Added FRACMUL_SHL macro to facilitate high-precision shifting of 64 bit multiplies and remove rounding from macsr in main thread to make this work as intended.
...
Tested quite thorougly, but as always, be careful with your ears.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12203 a1c6a512-1295-4272-9138-f99709370657
2007-02-05 01:01:15 +00:00
Jens Arnold
7170a00daa
Enable building ipodpatcher (pure win32 binary) on cygwin with a simple 'make'
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12202 a1c6a512-1295-4272-9138-f99709370657
2007-02-05 00:50:49 +00:00
Linus Nielsen Feltzing
1eff300f18
New PLL calculations to make sure that PLLDIV != 0. This seems to solve the problem with the troublesome H140 batch from OutletMP3.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12201 a1c6a512-1295-4272-9138-f99709370657
2007-02-05 00:01:29 +00:00
Dave Chapman
eee9798d8d
Bump version to 0.6 ready for new release
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12200 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 23:57:06 +00:00
Dave Chapman
c500b968b8
Fix compile error on BSD and Mac OS and remove a warning
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12199 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 23:41:47 +00:00
Dave Chapman
4da04b77e2
Fix USB detection on ipods and other portalplayer targets - Rockbox now correctly distinguishes between a USB connection to a computer and a connection to a USB AC charger. Based on the experimental USB code in FS #6494 by Barry Wardell. Closes FS #4724 .
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12198 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 21:46:01 +00:00
Barry Wardell
6ce28d849d
Fix Scroll Up/Down being backwards in some screens on the Sansa.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12197 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 20:53:18 +00:00
Barry Wardell
7174e88b19
Fix setting time on Sansa used to set the day to one day later than it
...
should.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12196 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 20:43:25 +00:00
Daniel Ankers
88b3f39d73
Enable FAT16 support for Sansa E200
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12195 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 15:42:55 +00:00
Marcoen Hirschberg
f3fb97c32b
removed since there's no UniCatcher for H10 5GB
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12194 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 13:16:27 +00:00
Dave Chapman
33e1515662
Bugfix. ipodpatcher wasn't correctly deciding when to rearrange the contents of the firmware partition to make space for the bootloader. This bug was only hit when the amount of space required was less than 0x4400 bytes (17KB) - e.g. when upgrading an existing bootloader.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12193 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 13:04:23 +00:00
Jens Arnold
7ebb2911b8
Fixed 64 bit warning.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12192 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 12:35:44 +00:00
Marcoen Hirschberg
e14594edf4
WPS updates by Ioannis Koutoulakis
...
iCatcher/UniCatcher:
- Better drawn bitmaps for iPod5G/Gigabeat
- Better drawn shuffle icon for other colour targets, as well
- Wavpack codec icon now shows "WV" instead of "WVPC"
iCatcher:
- iPod5G/Gigabeat versions now use nimbus-19 font. It's better now and more consistent to other versions that use nimbus font as well
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12191 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 12:31:03 +00:00
Dave Chapman
31aa4524da
Mainly internal changes to create a struct ipod_t instead of passing lots of parameters to all the functions. Also adds (untested) 3G support, plus a --write-firmware-bin option (requested by IPL people to write a kernel directly to the firmware partition).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12190 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 11:42:11 +00:00
Magnus Holmgren
7c9f4e3a3a
Try to fix the simulator build warnings.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12189 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 10:24:37 +00:00
Magnus Holmgren
39bd2375fa
Fix playback of mono FLAC files, so they don't play in the left channel only.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12188 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 10:04:42 +00:00
Daniel Ankers
67ec6177a7
Work around a bug in the Sansa flash driver
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12187 a1c6a512-1295-4272-9138-f99709370657
2007-02-04 03:20:36 +00:00
Barry Wardell
a7af649766
Backlight support for Sansa, including brightness. Thanks to Rene
...
Peinthor and FS#6608.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12186 a1c6a512-1295-4272-9138-f99709370657
2007-02-03 13:39:20 +00:00
Barry Wardell
1a2dddc346
RTC support for Sansa.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12185 a1c6a512-1295-4272-9138-f99709370657
2007-02-03 13:10:17 +00:00
Marianne Arnold
28aa1316d4
Allow longer filenames for settings files. (fixes FS #6615 )
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12184 a1c6a512-1295-4272-9138-f99709370657
2007-02-03 10:52:57 +00:00
Jens Arnold
6b0fdae0f6
Removed unused 'mode' parameter from mkdir() for consistency with creat().
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12183 a1c6a512-1295-4272-9138-f99709370657
2007-02-03 10:28:55 +00:00
Dave Chapman
ae6abfb094
Bugfix: Remove use of IDATA_ATTR - plugins can not use IRAM without stopping audio playback. This fixes crashes when invadrox is started with audio playing.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12182 a1c6a512-1295-4272-9138-f99709370657
2007-02-03 09:35:19 +00:00
Linus Nielsen Feltzing
bc76a42eca
Corrected the comments regarding USB charging
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12181 a1c6a512-1295-4272-9138-f99709370657
2007-02-02 15:47:28 +00:00
Jonathan Gordon
927ffda593
fmr is not a theme setting
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12180 a1c6a512-1295-4272-9138-f99709370657
2007-02-02 06:37:08 +00:00
Jens Arnold
67eb154146
Removed 'mode' parameter from creat(). It wasn't pure posix anyway, it was ignored on target and mixed into 'oflags' in the simulator. * Simplified io.c a bit by defining a dummy O_BINARY for OSes which don't have that.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12179 a1c6a512-1295-4272-9138-f99709370657
2007-02-01 23:08:15 +00:00
Nils Wallménius
98dc093317
Comment out an unused function
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12178 a1c6a512-1295-4272-9138-f99709370657
2007-02-01 20:52:36 +00:00
Daniel Ankers
fa7dd74cf5
Increase disk thread stack on the Sansa in line with the changes in r12093. Fixes the recent Sansa crashes. Thanks to Rene Peinthor
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12177 a1c6a512-1295-4272-9138-f99709370657
2007-02-01 20:22:19 +00:00