Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
15776 commits 17 branches 142 tags 291 MiB
Commit graph

484 commits

Author SHA1 Message Date
Jonathan Gordon
887ff33f2e Fix int settings being backwards on the player 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15116 a1c6a512-1295-4272-9138-f99709370657
 2007-10-15 07:57:11 +00:00
Jonathan Gordon
58777c350a Fix FS#7952 - flip list settings didnt work properly 
Accept FS#7956 - flip some sound settings on wheel targets so clockwise increases


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15113 a1c6a512-1295-4272-9138-f99709370657
 2007-10-15 05:35:20 +00:00
Nicolas Pennequin
7eedcb49d9 Fix buggy gradient display when a coloured file is selected in the browser. Thanks to smably for the report. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14891 a1c6a512-1295-4272-9138-f99709370657
 2007-09-28 19:47:28 +00:00
Nicolas Pennequin
49a9e1ef35 Make the gradient look better when more than one line is selected (running time, ID3 info, cuesheet viewer...). I haven't found a solution for scrolling yet, so that won't look too good. 
The recording screen code needs a bit of adapting too, but I don't have a target to test on, so leave it for now.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14884 a1c6a512-1295-4272-9138-f99709370657
 2007-09-28 13:49:43 +00:00
Nicolas Pennequin
f3b015f73b FS#7808 by Tom Ross, Ken Fazzone and me, with help from Antoine Cellerier. 
Add two new line selector types: solid colour and gradient. Solid colour only uses the primary colour setting.
The secondary colour setting is used for the gradient. Text colour for the selected item is also changeable.
These new settings are a bit controversial so they may be removed later.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14868 a1c6a512-1295-4272-9138-f99709370657
 2007-09-27 15:42:55 +00:00
Nils Wallménius
7b71787bd8 Get rid of macros and do these calculations only once instead 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14770 a1c6a512-1295-4272-9138-f99709370657
 2007-09-20 10:06:33 +00:00
Steve Bavin
39ff1878bc Fix FS#7766 - crash at track transition if A-B repeat is enabled but no B marker is set 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14769 a1c6a512-1295-4272-9138-f99709370657
 2007-09-20 09:15:35 +00:00
Jonathan Gordon
cf1cef5f57 minor update to gui_synclist_do_button() which will hopefully simplify things later. 
Now returns true if the action was handled in that function instead of returning the handled action.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14733 a1c6a512-1295-4272-9138-f99709370657
 2007-09-17 10:08:50 +00:00
Nils Wallménius
12a957b0e8 Disable wrapping of the bass and treble settings and do the same for volume in a cleaner way, closes FS#7783 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14712 a1c6a512-1295-4272-9138-f99709370657
 2007-09-15 17:29:15 +00:00
Nils Wallménius
22df2fd0bf Slight code simplification 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14683 a1c6a512-1295-4272-9138-f99709370657
 2007-09-13 20:53:23 +00:00
Jonathan Gordon
24006ffeac stop non-live settings from beign accepted even if cancel was chosen 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14616 a1c6a512-1295-4272-9138-f99709370657
 2007-09-05 03:06:49 +00:00
Jonathan Gordon
51edc1102c Change the way set_option() works so these settings are voiced again (recording settings mostly..) Fixes FS#7552 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14487 a1c6a512-1295-4272-9138-f99709370657
 2007-08-28 11:00:54 +00:00
Magnus Holmgren
a50c2b1494 Apply fix from FS#6341, with some changes by me. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14430 a1c6a512-1295-4272-9138-f99709370657
 2007-08-22 16:33:34 +00:00
Nils Wallménius
9b59183953 Use size_t type for the buffer_size parameter to formatter functions, static two private functions 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14392 a1c6a512-1295-4272-9138-f99709370657
 2007-08-19 10:22:46 +00:00
Peter D'Hoye
ebcf06d237 Make peakmeter release setting work in units per tick (was units per read), add the unit and make it voiced. Make old leftover in lang file deprecated 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14390 a1c6a512-1295-4272-9138-f99709370657
 2007-08-18 23:03:03 +00:00
Jens Arnold
1d1d9a8491 Switch to using millivolt for battery voltage and other internal voltages. * Fix debug voltage history display. * Some code cleanup. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14364 a1c6a512-1295-4272-9138-f99709370657
 2007-08-15 23:57:27 +00:00
Jonathan Gordon
022173195f Try to translate items when using the STRINGCHOICE_SETTING() macro (fixes FS#7603) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14353 a1c6a512-1295-4272-9138-f99709370657
 2007-08-15 13:16:16 +00:00
Peter D'Hoye
05221a9d87 Convert IDs to strings before using them, fixes FS #7564 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14304 a1c6a512-1295-4272-9138-f99709370657
 2007-08-12 21:59:42 +00:00
Nils Wallménius
b597165dcd 16 bits are enough here, save bytes :-) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14270 a1c6a512-1295-4272-9138-f99709370657
 2007-08-10 16:40:48 +00:00
Dan Everton
eecfe9f1cb Add support for grouping tags. From FS#7362. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14242 a1c6a512-1295-4272-9138-f99709370657
 2007-08-08 10:19:56 +00:00
Nils Wallménius
1ff0c351f7 Fix red archos sims and make some minor cleanup 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14216 a1c6a512-1295-4272-9138-f99709370657
 2007-08-06 15:01:45 +00:00
Nils Wallménius
5b76936a44 Accept FS#6159 'Add voice to roughly 100 splash screens and yes-no menus' by Stephane Doyon with some minor tweaks by me. Rerun 'configure' and do a 'make clean' before rebuilding your voice files. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14213 a1c6a512-1295-4272-9138-f99709370657
 2007-08-06 13:08:36 +00:00
Nils Wallménius
b311367481 *** Lang v2 cleanup (FS#6574) *** 
1) Introduces apps/features.txt that controls which strings are included 
for each target based on defines.
2) .lng and .voice files are now target specific and the format versions 
of both these file types have been bumped, which means that new voice 
files are needed. 
3) Use the 'features' mechanism to exclude strings for targets that 
didn't use them.
4) Delete unused and deprecated and duplicated strings, sort strings in 
english.lang

Some string IDs were changed so translations will be slightly worse than 
before.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14198 a1c6a512-1295-4272-9138-f99709370657
 2007-08-05 19:19:39 +00:00
Jonathan Gordon
8d4d5f67ea Address FS#6310 - shows an "infinite" slider when deleting/copying/moving files. 
maybe add this to other parts of the code so it doesnt look like the ui has stalled


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14189 a1c6a512-1295-4272-9138-f99709370657
 2007-08-05 10:25:00 +00:00
Dan Everton
f4a61f0c4a Add support for parsing the disc number tag from metadata and use of it in the database. Patch originally from FS#4961 with some minor tweaks by me. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14154 a1c6a512-1295-4272-9138-f99709370657
 2007-08-03 10:00:42 +00:00
Jonathan Gordon
73336e9729 Finally use the rec button to get to the rec screen on sansa and iriver hxxx. hold rec to get there... short press still is unused 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14141 a1c6a512-1295-4272-9138-f99709370657
 2007-08-02 12:13:20 +00:00
Nicolas Pennequin
5e8dad8dfa Fix FS#7490 (%px tag causes divide by zero errors). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14018 a1c6a512-1295-4272-9138-f99709370657
 2007-07-27 02:04:40 +00:00
Jonathan Gordon
bb555d00fc Fix a bug where targets which have a software keylock couldnt seek in the wps easily. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14001 a1c6a512-1295-4272-9138-f99709370657
 2007-07-26 13:57:01 +00:00
Nicolas Pennequin
aa643db434 Oops, forgot to trim down the lines before my previous commit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13988 a1c6a512-1295-4272-9138-f99709370657
 2007-07-25 14:24:49 +00:00
Nicolas Pennequin
29407cbe80 Implement feature request FS#7476: Add a "song progress percentage" WPS tag (%px) that can be used in a conditional to create custom progress meters. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13987 a1c6a512-1295-4272-9138-f99709370657
 2007-07-25 14:14:47 +00:00
Jonathan Gordon
ffeccda8cd Fix the bug where holding left no longer stopped at the browser root. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13983 a1c6a512-1295-4272-9138-f99709370657
 2007-07-25 12:37:09 +00:00
Nicolas Pennequin
34a6c4748c Fix FS#7441: Volume wasn't mapped correctly to the enum cases when using the %?pv WPS tag. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13967 a1c6a512-1295-4272-9138-f99709370657
 2007-07-23 17:11:13 +00:00
Jonathan Gordon
fe2b376060 Fix the text for settings which have a different title than what is shown in the menu (i.e scroll options) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13962 a1c6a512-1295-4272-9138-f99709370657
 2007-07-23 05:40:45 +00:00
Michael Sevakis
873e0fd1ef Wheel acceleration for e200. A general acceleration interface intended for use on any scroll target and by any code. A general interface to obtain data associated with most recently dequeued button presses and actions. Use #define HAVE_SCROLLWHEEL and set appropriate constants, values in the scroller driver that feel right. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13959 a1c6a512-1295-4272-9138-f99709370657
 2007-07-22 21:02:24 +00:00
Nicolas Pennequin
3213d4a0f5 Add a verbosity level command line option to the chackwps tool. This should make life easier for the themes.rockbox.org people. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13958 a1c6a512-1295-4272-9138-f99709370657
 2007-07-22 17:17:53 +00:00
Jonathan Gordon
f7675a244b remove the need for action_signalscreenchange(). 
Fixes problems with targets where the ACTION_STD_CANCEL event is a combo


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13956 a1c6a512-1295-4272-9138-f99709370657
 2007-07-22 06:05:53 +00:00
Jonathan Gordon
ca0cc784bc Fix the problem where settings stopped saving automatically 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13929 a1c6a512-1295-4272-9138-f99709370657
 2007-07-19 09:17:25 +00:00
Jonathan Gordon
a5278fa3db Rearrange and cleanup settings code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13851 a1c6a512-1295-4272-9138-f99709370657
 2007-07-11 05:41:23 +00:00
Steve Bavin
276ff3bceb Copy current track path as a string, not a slightly-oversized block. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13808 a1c6a512-1295-4272-9138-f99709370657
 2007-07-06 22:34:18 +00:00
Peter D'Hoye
16b67e5812 Make sure statusbar is updated when time changes. Fixes FS #7388. Moved time variable around and added init of info struct. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13802 a1c6a512-1295-4272-9138-f99709370657
 2007-07-05 23:20:58 +00:00
Nicolas Pennequin
3f95ea53b0 Make the time in the statusbar always display --:-- when the RTC isn't set 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13729 a1c6a512-1295-4272-9138-f99709370657
 2007-06-28 13:51:44 +00:00
Marianne Arnold
74aabc8381 Make the '%mh' wps tag (to indicate keylock status) available on the Archos targets as well. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13716 a1c6a512-1295-4272-9138-f99709370657
 2007-06-25 20:54:11 +00:00
Jonathan Gordon
2d4ee368e3 Fix problems with the list when you change font size 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13680 a1c6a512-1295-4272-9138-f99709370657
 2007-06-21 13:21:33 +00:00
Brandon Low
488de5e09c Fix yellow 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13657 a1c6a512-1295-4272-9138-f99709370657
 2007-06-17 21:29:24 +00:00
Brandon Low
74cbb0a1b2 Give color targets the ability to display each LCD line a different color and use this newfangled ability to provide themable colored file types. See the comments on read_color_theme_file and the sample.colors file provided for how to use this. .colors files go in themes directory for now. This separate line color function should be trivial to add to menus and wpss. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13656 a1c6a512-1295-4272-9138-f99709370657
 2007-06-17 21:16:34 +00:00
Brandon Low
9a550524af Make RTC tags display hyphens instead of nothing on non-rtc targets. This makes WPSs that use RTC tags look decent again with the new separated RTC tag style 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13639 a1c6a512-1295-4272-9138-f99709370657
 2007-06-16 20:33:30 +00:00
Peter D'Hoye
93af4feae9 Ignore SYS_CHARGER_DISCONNECTED event in yesno screen (other events may need to be filtered as well) as it made the auto-ROLO question close immediatly. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13635 a1c6a512-1295-4272-9138-f99709370657
 2007-06-16 11:50:42 +00:00
Jonathan Gordon
cfe0f4826a Make the screen draw correctly with the user iconset 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13619 a1c6a512-1295-4272-9138-f99709370657
 2007-06-11 13:32:29 +00:00
Jonathan Gordon
57440d5292 Fix a minor annoyance with the last commit where selecting an item could result in having empty space under the list. 
Also very very minor code reduction.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13607 a1c6a512-1295-4272-9138-f99709370657
 2007-06-10 08:18:19 +00:00
Jonathan Gordon
f4d0f053e6 Really fix FS#7274 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13606 a1c6a512-1295-4272-9138-f99709370657
 2007-06-10 07:12:39 +00:00
Jonathan Gordon
f3145ba07c simple fix for FS#7274 - selected item might not be shown when a list is drawn in paged scroll mode 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13602 a1c6a512-1295-4272-9138-f99709370657
 2007-06-09 09:41:13 +00:00
Jonathan Gordon
3823486a58 Add a mode the lists which doesnt show the selection marker. 
Useful for the debug menus where users shouldn't think pressing select would do anything.



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13588 a1c6a512-1295-4272-9138-f99709370657
 2007-06-07 12:14:31 +00:00
Nicolas Pennequin
887b31c01a Add some more explicit defines for my previous commit. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13561 a1c6a512-1295-4272-9138-f99709370657
 2007-06-05 14:57:07 +00:00
Nicolas Pennequin
b5f4d90b4b Make the bitmap loading code handle the progressbar and backdrop bitmaps in a slightly more generic way. This hopefully simplifies the code a bit and should make adding special bitmaps less painful. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13560 a1c6a512-1295-4272-9138-f99709370657
 2007-06-05 10:42:41 +00:00
Jonathan Gordon
fea88888f0 Fix most (all) known list wierdness bugs, hopefully simplifies the code a bit, plenty of room for optimizing, but wanted to get it working first. (fixes FS#7255 and possibly others) 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13556 a1c6a512-1295-4272-9138-f99709370657
 2007-06-05 02:57:43 +00:00
Jonathan Gordon
20a8a9a3c8 Move the old api out of the core and into the plugin lib. 
ew plugins shuold use the new api and not this one.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13537 a1c6a512-1295-4272-9138-f99709370657
 2007-06-03 04:06:58 +00:00
Nils Wallménius
fbdbd2112c Fix warning 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13525 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 18:08:29 +00:00
Nils Wallménius
f46657ec5a Move the setvol wrapper function to misc.c and use it in more places instead of doing the same checks everywhere 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13524 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 17:57:32 +00:00
Jonathan Gordon
dfb071d92e Last list commit for a while. fix the multi-item lists at the very end of the list 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13523 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 09:25:59 +00:00
Jonathan Gordon
0178568325 fix non-paged scrolling aroun the ends of lists 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13522 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 09:11:59 +00:00
Jonathan Gordon
5983e7fa42 few more list anomolys fixed.. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13521 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 08:29:44 +00:00
Jonathan Gordon
155e3d33d6 Fix the last (?) of the selction wierdness, this time when moving at the begining of the list 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13520 a1c6a512-1295-4272-9138-f99709370657
 2007-05-30 02:08:35 +00:00
Dave Chapman
f0d4fc6c6b Commit my patch from FS#7179 - a standalone command-line checkwps tool. To build, just type "make checkwps" in tools and run it with "checkwps wpsname.wps". 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13517 a1c6a512-1295-4272-9138-f99709370657
 2007-05-29 19:00:36 +00:00
Jonathan Gordon
6fd3d96309 fix selection wierdness when scrolling down at the end of lists 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13514 a1c6a512-1295-4272-9138-f99709370657
 2007-05-29 13:06:41 +00:00
Jonathan Gordon
20202017f4 Really fix FS#7230 this time. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13513 a1c6a512-1295-4272-9138-f99709370657
 2007-05-29 12:28:02 +00:00
Jonathan Gordon
195ac12296 Fix FS#7230 - the second line in a multi-line item could be the selected item 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13512 a1c6a512-1295-4272-9138-f99709370657
 2007-05-29 12:16:31 +00:00
Nicolas Pennequin
6579818b43 Add the possibility to store cuesheets in /.rockbox/cue. The code will look for a cuesheet there in case there wasn't one in the same folder as the audio file. This is to reduce the clutter created by one cuesheet per audio file in some places. 
Also some duplicate code was replaced by a function call.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13508 a1c6a512-1295-4272-9138-f99709370657
 2007-05-28 23:18:31 +00:00
Jonathan Gordon
42698e4e47 Accept FS#6798 - scan acceleration for the lists. 
Settings are in display > scrolling


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13499 a1c6a512-1295-4272-9138-f99709370657
 2007-05-27 15:08:56 +00:00
Nils Wallménius
e1374b0536 Oops, remove accidentally left in, commented out code 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13492 a1c6a512-1295-4272-9138-f99709370657
 2007-05-24 22:43:54 +00:00
Nils Wallménius
c2a77563c2 Remove dead code. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13488 a1c6a512-1295-4272-9138-f99709370657
 2007-05-24 19:03:26 +00:00
Nicolas Pennequin
392d07902f Oops, next file info should be dynamic. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13456 a1c6a512-1295-4272-9138-f99709370657
 2007-05-21 14:04:38 +00:00
Nicolas Pennequin
5cc98efddc Add %fk and %Fk WPS tags : (next) file audio frequency in KHz (rewrite of FS#6393 to adapt it to the tokenizer). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13455 a1c6a512-1295-4272-9138-f99709370657
 2007-05-21 13:41:43 +00:00
Nicolas Pennequin
9d5e376fc3 Allow the day of month (%cm) and day of week (%cu and %cw) RTC tags to be used in enums. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13454 a1c6a512-1295-4272-9138-f99709370657
 2007-05-21 12:54:07 +00:00
Michael Sevakis
8f659ae8d3 Use bitmasks to define which inputs are available. Makes it easier to remove old assumptions of which are available. Inspired by e200 being unique in having FM Radio and Mic but no Line. Doesn't remove the assumption that Mic is available or that one of Mic and/or Line is available just to avoid excessive #ifdef'ing until needed. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13448 a1c6a512-1295-4272-9138-f99709370657
 2007-05-20 20:26:36 +00:00
Nils Wallménius
f31e123133 Remove unused function and unused header 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13424 a1c6a512-1295-4272-9138-f99709370657
 2007-05-19 19:54:11 +00:00
Nicolas Pennequin
4a6ab0d031 Commit FS#7164 (request is FS#6780) : Improve WPS volume enumeration. It is now the following : %?pv<Mute|...|...|0 dB|Above 0 dB>. It almost doesn't changes anything for most WPSs but adds some new possibilities. Keep in mind that some targets don't go above 0 dB so the last case might be unused. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13387 a1c6a512-1295-4272-9138-f99709370657
 2007-05-14 14:33:43 +00:00
Jonathan Gordon
c9ed673c81 only show the cursor for the first line of the selected item (if selection is more than one line). doesnt effect inverted cursor mode 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13375 a1c6a512-1295-4272-9138-f99709370657
 2007-05-12 14:13:23 +00:00
Michael Sevakis
1c59b101df SWCODEC Playback: Seriously mess with it and get rid of (at least some ;) race conditions. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13361 a1c6a512-1295-4272-9138-f99709370657
 2007-05-08 22:56:12 +00:00
Nicolas Pennequin
aa220d5acd Trim a bunch of long lines and fix an infinite loop and buffer overrun in the impossible case that a WPS line ends with a litteral string but without a newline char (wps_parser.c:774). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13306 a1c6a512-1295-4272-9138-f99709370657
 2007-05-02 17:51:01 +00:00
Magnus Holmgren
05a158ecf3 Treat empty strings as 'no value' in conditionals, as it used to. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13304 a1c6a512-1295-4272-9138-f99709370657
 2007-05-02 16:28:24 +00:00
Nicolas Pennequin
378a140ae2 Add a check for unclosed conditionals at the end of the WPS parsing in case we didn't reach the end of the file. Also a few minor other changes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13303 a1c6a512-1295-4272-9138-f99709370657
 2007-05-02 11:39:46 +00:00
Peter D'Hoye
3494b2118b FS #7093 by Dave Hooper: prevent crash when loading too many/long static strings in the wps 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13302 a1c6a512-1295-4272-9138-f99709370657
 2007-05-01 23:36:15 +00:00
Nicolas Pennequin
7e6af1532b Better handling of strings in the WPS parser by detecting duplicates to avoid having two copies of the same string in the string buffer. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13295 a1c6a512-1295-4272-9138-f99709370657
 2007-04-30 14:08:58 +00:00
Jonathan Gordon
39a6b5d643 Stop using the old menu API in the debug menu (using the new api causes massive bin increase, so fake the old api with existing code instead) (onplay.c and plugins are the only parts using th eold api now) 
Fix a bug where the menu title was sometimes shown in the system font


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13286 a1c6a512-1295-4272-9138-f99709370657
 2007-04-29 15:31:43 +00:00
Nicolas Pennequin
1cf2ec38b1 Change some ifdefs for the recent backdrop changes (fixes the yellow builds) and move the backdrop files. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13265 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 22:08:00 +00:00
Nicolas Pennequin
7fdfa56454 Add backdrop support for LCD remotes with depth > 1-bit. Only WPS backdrops, but the groundwork is laid for main backdrops too (all that's really needed are menus to set/clear them). 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13263 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 21:44:56 +00:00
Nicolas Pennequin
2a2b8d8a82 Make bitmaps use the right format in a RWPS and prevent a backdrop tag in a RWPS from clearing the main display's backdrop. This also allows future backdrop support for LCD remotes by making the parsing code aware of whether the display for a WPS is a remote or not. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13261 a1c6a512-1295-4272-9138-f99709370657
 2007-04-25 13:09:56 +00:00
Nicolas Pennequin
6ac306a515 Add a new commandline switch to the simulator: "--debugwps". It enables printing of advanced (and very verbose) WPS debugging information. Also make the debugging code a bit cleaner. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13257 a1c6a512-1295-4272-9138-f99709370657
 2007-04-24 23:58:57 +00:00
Nicolas Pennequin
d7fd989319 WPS Parser: On parse failure, print a (hopefully) useful error message with line number (sim only). 
Also the debug code is still  disabled but now in a nicer way.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13251 a1c6a512-1295-4272-9138-f99709370657
 2007-04-24 00:57:04 +00:00
Jens Arnold
6bf86b799e Ooooops, fix warning. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13243 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 12:48:05 +00:00
Jens Arnold
5070f41bfc Consolidated several potential places of return from WPS into one. Fixes the 'Return from WPS at end of playlist always brings up the root menu.' bug on hwcodec. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13241 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 12:38:11 +00:00
Jonathan Gordon
9d3694ced6 Fix FS#7056 - dont display garbage if the viewer icon set and the main iconset have different icon heights 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13237 a1c6a512-1295-4272-9138-f99709370657
 2007-04-22 08:50:24 +00:00
Nicolas Pennequin
814d402d4c More strict WPS parsing and displaying code. If there are errors, WPS loading will fail and the default WPS will be displayed. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13236 a1c6a512-1295-4272-9138-f99709370657
 2007-04-21 19:31:46 +00:00
Michael Sevakis
26d242ae65 General housekeeping: Make plugin buffer functions take size_t * instead of int * to match the parameter type of the buffer functions called in the core. Get rid of unsafe int * <==> size_t * casting. Use ssize_t where int was used and size_t where unsigned int was used in the buffer calls to not alter signedness in the plugins. No API version change since it should only be an issue for 64-bit sim builds. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13233 a1c6a512-1295-4272-9138-f99709370657
 2007-04-21 18:38:25 +00:00
Jonathan Gordon
7f3c66f1cb Fix the playlist viewer so only 1 line flashes when you move a track 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13231 a1c6a512-1295-4272-9138-f99709370657
 2007-04-21 11:14:57 +00:00
Magnus Holmgren
392a4ef49b Fix logf builds on devices that support remotes. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13202 a1c6a512-1295-4272-9138-f99709370657
 2007-04-18 17:49:32 +00:00
Jonathan Gordon
36a2e30872 Move the inbuilt filetype info into filetypes.c and rename the defines. 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13201 a1c6a512-1295-4272-9138-f99709370657
 2007-04-18 13:03:01 +00:00
Jonathan Gordon
e9610dca80 Remove unneeded #include, comment the filename define 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13193 a1c6a512-1295-4272-9138-f99709370657
 2007-04-17 08:37:01 +00:00
Jonathan Gordon
754d9195f7 explicitly set *loaded_ok = false; when given "" for a filename. 
remove icon_init from the startup sequence, its not dependant on filetypes_init anymore,settings_apply calls the icons_init (causes the bmp's to only be read once on boot instead of twice)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13191 a1c6a512-1295-4272-9138-f99709370657
 2007-04-17 06:37:22 +00:00
Jens Arnold
79a8b41513 Fix loadable remote icons. fb_data != fb_remote_data ... 
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13190 a1c6a512-1295-4272-9138-f99709370657
 2007-04-17 01:03:25 +00:00