Nicolas Pennequin
b36d3c0be2
Some bugfixes after r17109:
...
* Fix FS#8893 by plugging a file descriptor leak in audio_load_track.
* Fix a possible null pointer dereference by not allowing audio_current_track to return NULL.
* Make audio_current_track return prevtrack_id3 only during an automatic track skip. Fixes the wrong metadata being displayed for a short time after a backwards skip.
-Cette ligne, et les suivantes ci-dessous, seront ignorées--
M apps/playback.c
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17126 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 19:20:57 +00:00
Dominik Riebeling
7acc5538bd
Fix some button macros to make several manuals build again.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17125 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 19:19:56 +00:00
Dominik Riebeling
1e9ea256cc
Document line selector color config file settings (FS#8880 by Justin Hannigan).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17124 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 18:53:06 +00:00
Bertrik Sikken
7697609455
Fixed FS#7849
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17123 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 18:34:20 +00:00
Nils Wallménius
fd1e1b7706
Slight clean up and binsize save
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17122 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 18:10:22 +00:00
Steve Bavin
ba58dd8d35
Fix some red.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17121 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 15:41:13 +00:00
Michael Sevakis
040b6cc654
Kill warnings that annoy me when building for Gigabeat S.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17120 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 14:44:32 +00:00
Michael Sevakis
c4a49c4e5f
Make the gigabeat S bootloader compile again. Don't know if it still works.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17119 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 13:35:41 +00:00
Michael Sevakis
595d0659d4
Make the transparent bitmaps work on Gigabeat S.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17118 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 13:06:29 +00:00
Steve Bavin
e50202c5c4
Remove a global variable which is (hopefully) not needed. Also fixes a very minor bug where restarting playback after a playlist ends would play the final 3 seconds again.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17117 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 12:38:17 +00:00
Jonathan Gordon
970cfee394
woops... fix red and some svn keywords.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17115 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 11:00:38 +00:00
Jonathan Gordon
5b5a626bb6
Setup the touchpads to have two modes - stylus and button - and set them in button mode by default.
...
in button mode the touchpad is split into a 3x3 grid for 9 seperate buttons which can be used by the action system like real buttons.
Unify the keymap file for the touchpads in button mode. the target keymap file only needs to worry about real buttons.
(As these ports mature each screen will need to be fixed seperatly to be able to use stylus mode (the lists can already but don't change mode just yet.)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17114 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 10:35:11 +00:00
Steve Bavin
50851794a6
Fix a (possibly gcc 3 only) warning.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17112 a1c6a512-1295-4272-9138-f99709370657
2008-04-15 07:39:21 +00:00
Andree Buschmann
df243a124b
Undo r17095. A bug report clearly showed this power supply is also needed for accessories on 5G/5.5G. A more sophisticated solution is needed.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17111 a1c6a512-1295-4272-9138-f99709370657
2008-04-14 17:06:32 +00:00
Mustapha Senhaji
67ef381ae2
Update the french translation.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17110 a1c6a512-1295-4272-9138-f99709370657
2008-04-14 16:51:09 +00:00
Nicolas Pennequin
4e2de44b44
A rather big change to how tracks are loaded: there are now two parts to the process and metadata loading is done by the buffering thread (except for the first unbuffered track). The audio thread now calls audio_load_track, and once the metadata is loaded, the buffering thread sends an event which will make the audio thread call audio_finish_load_track. This one then takes care of the rest of the loading.
...
This method makes skipping noticeably faster for unbuffered tracks, and especially backwards.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17109 a1c6a512-1295-4272-9138-f99709370657
2008-04-14 16:17:47 +00:00
Nicolas Pennequin
a5ad74ffca
Revert what was left of r17018 until I find a better way. It had quirks in some cases, and doesn't play well with what I'm about to commit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17108 a1c6a512-1295-4272-9138-f99709370657
2008-04-14 15:51:40 +00:00
Nicolas Pennequin
3c9625969b
FS#8882: Fix the bug where skipping backwards with Ogg files could result in a skip forward (FS#8508). The problem was introduced by a one-line change in r16025, so we revert it. At the time I thought that line had become useless but obviously I was wrong. Thanks to Greg Erwin for finding the fix.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17107 a1c6a512-1295-4272-9138-f99709370657
2008-04-14 10:52:16 +00:00
Jonathan Gordon
dada3242d5
Dont show the playlist catalog item in the file context menu unless the file is audio or a m3u(8).
...
Mentinoed in FS#8752
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17106 a1c6a512-1295-4272-9138-f99709370657
2008-04-14 10:03:46 +00:00
Michael Sevakis
0257547d58
Gigabeat S: Make ADC battery voltage reading correct. Tiny tweak to ADC driver traffic limiting.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17105 a1c6a512-1295-4272-9138-f99709370657
2008-04-14 06:52:38 +00:00
Michael Sevakis
25ebc85842
Oops...simple math proves elusive at times. Get the array calcs right.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17104 a1c6a512-1295-4272-9138-f99709370657
2008-04-14 04:22:47 +00:00
Michael Giacomelli
861525852c
Increase the size of one of the look up tables. Fixes 'burst of static' in some files. I still have no idea how big it really needs to be...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17103 a1c6a512-1295-4272-9138-f99709370657
2008-04-14 01:12:51 +00:00
Stéphane Doyon
be4f41f0b7
My own name was in CREDITS twice, one of them a misspelling.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17102 a1c6a512-1295-4272-9138-f99709370657
2008-04-14 00:25:43 +00:00
Bertrik Sikken
c826933984
Fixed "#else if", changed to "#elif"
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17101 a1c6a512-1295-4272-9138-f99709370657
2008-04-13 22:10:31 +00:00
Michael Sevakis
b12c69bac7
ADC driver for Gigabeat S - a bit on the general side for now. Needs to have scales set properly (what physical value a reading represents isn't clear from the docs or I'm just lazy atm). Throw-in a _bunch_ more reg defines for the PMIC. Show all 16 raw channels values in debug menu.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17100 a1c6a512-1295-4272-9138-f99709370657
2008-04-13 20:03:08 +00:00
Dominik Riebeling
73d1eb4ac0
Make httpget class work with URI paths containing characters that need to be percent-encoded. Fixes FS#8872. Add a few comments.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17099 a1c6a512-1295-4272-9138-f99709370657
2008-04-13 18:43:51 +00:00
Frank Gevaerts
be77cf5279
only reconnect mass storage if there is actually an active usb connection, with mass storage enabled
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17098 a1c6a512-1295-4272-9138-f99709370657
2008-04-13 17:16:50 +00:00
Andree Buschmann
b90a766d01
ASM optimization for fiq_playback(). Saves about 0.4MHz of CPU while playback on PP502x/PP5002.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17097 a1c6a512-1295-4272-9138-f99709370657
2008-04-13 17:03:24 +00:00
Jens Arnold
2bf4178018
Make mpegplayer sleep the disk after buffering to save battery. * Add a simulator stub for ata_sleep(), and un-ifdef most calls to it.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17096 a1c6a512-1295-4272-9138-f99709370657
2008-04-13 12:24:47 +00:00
Andree Buschmann
4c5a735a02
Further power saving for iPod Video (FS#8603). Do not enable D2REGC1 voltage for 5G/5.5G -- no changes for other iPods. Savings on a 5G/5.5G are about 1.5mA.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17095 a1c6a512-1295-4272-9138-f99709370657
2008-04-13 12:24:41 +00:00
Jens Arnold
c773eed3e1
The greylib now takes care of the necessary aligment and uncached addressing itself, so simplify the code a bit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17094 a1c6a512-1295-4272-9138-f99709370657
2008-04-13 11:57:11 +00:00
Nils Wallménius
8c5d552ebd
Charger detection for Gigabeat S
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17093 a1c6a512-1295-4272-9138-f99709370657
2008-04-13 10:04:21 +00:00
Magnus Holmgren
d715f79ed6
Remove redundant init call.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17092 a1c6a512-1295-4272-9138-f99709370657
2008-04-13 10:00:42 +00:00
Jens Arnold
d055ffe715
Refine information and macros for clock skipping. Not functional changes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17091 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 23:55:30 +00:00
Michael Giacomelli
9a946f6022
Commit FS#8822 by Magnus Holmgren. Fixes resuming previously playing WMA files after a reboot.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17090 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 19:52:31 +00:00
Rob Purchase
8f464068af
Fix cut'n'pasterelated yellows.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17089 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 18:34:35 +00:00
Rob Purchase
b14c2de523
D2: Charging detection, plus basic PCF50606 interrupt handler.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17088 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 18:17:15 +00:00
Nils Wallménius
660dbac5c9
Make a couple of private functions static
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17087 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 17:08:35 +00:00
Michael Sevakis
a7af9e4a7f
Add GPIO manager. Get the PMIC interrupt handling working (along with power button and HP detect). Add some reg field defined instead of using raw numbers. Add PMIC info to debug ports screen. Refine PMIC driver ops a little bit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17086 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 16:56:45 +00:00
Rob Purchase
ddfd787c54
D2: Implement battery voltage readout from PCF50606 (levels not yet calibrated). Adjust I2C delay to ensure this also works when boosted.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17085 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 16:18:28 +00:00
Nils Wallménius
84dc8d2c7e
Move a function to gwps-common.c because it belongs there
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17084 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 13:25:16 +00:00
Jens Arnold
fef82552e1
Optimise some more line drawing calls.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17083 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 09:51:16 +00:00
Jens Arnold
b6213bbf98
Optimise line drawing calls.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17082 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 08:57:28 +00:00
Jens Arnold
00ac809cc7
LCD drivers: * Automatically optimise horizontal and vertical lines drawn via _drawline(), with debug message to show possible optimisations in the caller. * Get rid of the extra ICODE function declarations by putting the attribute into the definition.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17081 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 07:53:33 +00:00
Nils Wallménius
02eb1d83a7
FS#8871 by Tomasz Wasilczyk, avoid negative runtime estimation (that would later be cast to an unsigned giving huge values
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17080 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 07:14:13 +00:00
Michael Sevakis
ef97db1011
Big oops. Fix enum spi_module_number to set right enum values. :p.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17079 a1c6a512-1295-4272-9138-f99709370657
2008-04-12 05:11:50 +00:00
Rob Purchase
b70239e15b
D2: Remove USB detection as it's not actually on GPIOC26 (that's a charging indicator). Remove those warnings as I'm well aware USB isn't implemented.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17078 a1c6a512-1295-4272-9138-f99709370657
2008-04-11 21:23:51 +00:00
Daniel Stenberg
7387a0470e
sync with key list with mi4code and add the single mi4 key it had but this
...
still didn't
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17077 a1c6a512-1295-4272-9138-f99709370657
2008-04-11 21:11:55 +00:00
Marianne Arnold
2841b8dc41
A tiny bit of cleanup afterwards... save a few bytes by storing the 'Rockboxed' greyscale bitmaps as 4-bit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17076 a1c6a512-1295-4272-9138-f99709370657
2008-04-11 21:08:56 +00:00
Marianne Arnold
606d7af4a5
Finish bitmap strips work - convert the rest of the 'Rockboxed' WPS (bigger colour displays). Similar changes as in the previous Rockboxed commits: integrate statically loaded bitmaps into the background and delete the now unused bitmaps, remove the unnecessary coordinates in the backdrop tag, add missing codec names, volume and battery icons now with one graphic (part of a strip) per status which simplifies the code, rename sl-* to shuffle-* and hd-* to lock*- bmps. Correct mime-type for all image files. * Don't forget to clean up the 'Rockboxed' directory...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17075 a1c6a512-1295-4272-9138-f99709370657
2008-04-11 20:24:48 +00:00