Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

settings: Remove redundant lang_id check for F_PADTITLE settings

Browse source 
All the F_PADTITLE settings use a lang string so it's safe to
assume the title (which is usually from the setting's lang_id)
is ok. Not like it's very useful or safe to show the cfg_vals,
anyway...

Change-Id: I0bf710e1b2a5a7bcdfe9e4370f48a2f25e8dddf0
This commit is contained in:
Aidan MacDonald 2022-11-30 01:27:00 +00:00
parent fb0757b913
commit 528dd0b03d
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
apps/menu.c
View file

@ -333,10 +333,7 @@ void do_setting_screen(const struct settings_list *setting, const char * title,
if (setting->flags&F_PADTITLE) if (setting->flags&F_PADTITLE)
{ {
int i = 0, len; int i = 0, len;
if (setting->lang_id == -1) title = P2STR((unsigned char*)title);
title = (char*)setting->cfg_vals;
else
title = P2STR((unsigned char*)title);
len = strlen(title); len = strlen(title);
while (i < MAX_PATH-1) while (i < MAX_PATH-1)
{ {