From 528dd0b03d27fa82b97e3fe785969b90f32cdeff Mon Sep 17 00:00:00 2001
From: Aidan MacDonald <amachronic@protonmail.com>
Date: Wed, 30 Nov 2022 01:27:00 +0000
Subject: [PATCH] settings: Remove redundant lang_id check for F_PADTITLE
 settings

All the F_PADTITLE settings use a lang string so it's safe to
assume the title (which is usually from the setting's lang_id)
is ok. Not like it's very useful or safe to show the cfg_vals,
anyway...

Change-Id: I0bf710e1b2a5a7bcdfe9e4370f48a2f25e8dddf0
---
 apps/menu.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/apps/menu.c b/apps/menu.c
index 1b2c21cef7..eb3adcc037 100644
--- a/apps/menu.c
+++ b/apps/menu.c
@@ -333,10 +333,7 @@ void do_setting_screen(const struct settings_list *setting, const char * title,
     if (setting->flags&F_PADTITLE)
     {
         int i = 0, len;
-        if (setting->lang_id == -1)
-            title = (char*)setting->cfg_vals;
-        else
-            title = P2STR((unsigned char*)title);
+        title = P2STR((unsigned char*)title);
         len = strlen(title);
         while (i < MAX_PATH-1)
         {