rockbox/apps/plugins/imageviewer
Christian Soffke e71a441762 ImageViewer: Fix buffer overflow
np_file is a buffer of size MAX_PATH. After
removing only the file name component and
leaving the rest of the path, the
available space may not be sufficient
for appending another file name (possibly of
size MAX_PATH itself) to it.

This can occur after a file of acceptable
length is opened in ImageViewer, and you
then advance to another file whose path
(including the file name) is longer than
MAX_PATH.

Change-Id: Ideadd9451359bd5735bce92fca5d983e61f300e9
2022-04-18 10:58:40 -04:00
..
bmp imageviewer: gif viewer based on giflib-5.0.2 2012-11-13 18:13:10 +01:00
gif ImageViewer: Fix FS#13329 (GIF File handle/memory leaks) 2022-01-09 14:36:14 +00:00
jpeg Remove unhelpful unsigned casting trick 2021-08-07 15:52:18 +00:00
png Limit more variables to file scope 2015-01-11 21:40:51 +01:00
ppm lcd-24bit: Introduce a 24-bit mid-level LCD driver 2014-06-21 00:15:53 +02:00
image_decoder.c imageviewer: gif viewer based on giflib-5.0.2 2012-11-13 18:13:10 +01:00
image_decoder.h imageviewer: gif viewer based on giflib-5.0.2 2012-11-13 18:13:10 +01:00
imageviewer.c ImageViewer: Fix buffer overflow 2022-04-18 10:58:40 -04:00
imageviewer.h imageviewer: gif viewer based on giflib-5.0.2 2012-11-13 18:13:10 +01:00
imageviewer.make Refactor and unify objcopy calls in the build system. Also now properly handles DEBUG builds on hosted targets to keep debug symbols if necessary. 2012-04-04 21:48:19 +02:00
imageviewer_button.h ImageViewer: M3K keymap allow scrolling up/down 2022-04-01 11:01:52 -04:00
readme.txt image viewer: add quick guide describing how to add image decoder. also improve comments. 2011-01-16 12:45:11 +00:00
SOURCES FS#6321: Universal Image Viewer 2010-11-21 13:47:56 +00:00
SUBDIRS imageviewer: gif viewer based on giflib-5.0.2 2012-11-13 18:13:10 +01:00

this document describes how to add new image decoder.

1. create a directory which name is your image decoder's name and put source files
 under the directory.
'const struct image_decoder image_decoder' and 'IMGDEC_HEADER' must be declared in
 one of your source files.
see imageviewer.h for the detail of struct image_decoder.

2. add the directory name to apps/plugins/imageviewer/SUBDIR so that the decoder
 is built.
if the decoder is supported by particular targets, surround it with #if directive.
e.g. if the decoder supports color LCD targets only,
#ifdef HAVE_LCD_COLOR
bmp
#endif

3. append appropriate entry to enum image_type in image_decoder.h, decoder_names
 and ext_list in image_decoder.c so that the imageviewer plugin can recognize
 the decoder.
if the decoder is supported by particular targets, surround them with same #if
 directive in SUBDIR.

4. add entry to apps/plugins/viewers.config
 (in format: file_extension,viewer/imageviewer) so that the file with specified 
 file extension will be opened by image viewer plugin.
if the decoder is supported by particular targets, surround it with same #if
 directive in SUBDIR.

5. add entry to apps/plugins/CATEGORIES (in format: decoder_name,viewer) so
 that the build file is copied to viewers directory.
DON'T surround this with #if directive.


notes:
if you need to use greylib functions to draw image, add the functions to
 struct imgdec_api just like gray_bitmap_part because GREY_INFO_STRUCT is
 declared in imageviewer and is not available from the decoder.