Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
rockbox/apps
History
Christian Soffke 6bc443f474 Hotkeys: Add placeholder for function return value 
Seems a bit clearer to me than redefining the meaning
of ONPLAY_OK in this context, which was easy to miss.

Fixes the return value for the bookmark_create_menu
hotkey, too. It was previously mapped to ONPLAY_OK
in case the function failed, and to ONPLAY_RELOAD_DIR
if it succeeded. This had no ill effect - or any effect –
since either of the values were disregarded by the WPS
when executing a hotkey.

Return values of playlist_insert_shuffled also had no
effect (by design, apparently, see commit 482b45b).
Use ONPLAY_FUNC_RETURN in hotkey_assignment.

Behavior hasn't changed, it's only been made more
explicit.

Change-Id: Iefc60c9f42c1063af78d368dc382916848064d38
2022-11-23 01:22:14 -05:00
..
bitmaps Rename symbols of FiiO M3K Linux-based port 2021-02-27 23:53:28 +00:00
gui remove some sprintf putsxy calls in favor of putsxyf 2022-11-21 00:25:12 -05:00
hosted/android replace strlcpy with strmemccpy 2022-11-14 23:56:16 -05:00
iap fix yellow iap-core.c 2022-11-17 04:43:38 -05:00
keymaps Enable access to Shortcuts Menu from QuickScreen 2022-10-25 03:26:51 +02:00
lang translations: Update US English "translation" 2022-11-15 09:56:07 -05:00
menus remove some sprintf putsxy calls in favor of putsxyf 2022-11-21 00:25:12 -05:00
plugins Properties: Refactoring & Minor fix 2022-11-20 00:41:10 -05:00
radio skin engine: Reduce scope of internal wps_data struct 2022-11-15 14:20:31 +00:00
recorder convert a few more strlcpy to strmemccpy calls Fix Red and Yellow 2022-11-15 01:24:26 -05:00
abrepeat.c
abrepeat.h
action.c move buflib_free invalid handle check to the function 2022-10-15 09:26:58 -04:00
action.h key remap: simplify and use movable allocations 2022-09-25 11:05:59 +01:00
alarm_menu.c alarm_menu share setter with settime 2022-03-30 09:05:28 -04:00
alarm_menu.h
appevents.h
applimits.h
apps.make
audio_path.c
audio_thread.c
audio_thread.h
beep.c
bookmark.c Fix return to root after selecting items from playlist viewer 2022-11-19 10:01:23 +01:00
bookmark.h Fix return to root after selecting items from playlist viewer 2022-11-19 10:01:23 +01:00
buffering.c replace strlcpy with strmemccpy 2022-11-14 23:56:16 -05:00
buffering.h buffering: remove bufgettail/bufcuttail 2022-04-20 16:51:49 -04:00
codec_thread.c codec_thread.c don't overrun audio_formats[] array 2021-08-11 10:56:14 -04:00
codec_thread.h
codecs.c
core_asmdefs.c
core_keymap.c key remap: simplify and use movable allocations 2022-09-25 11:05:59 +01:00
core_keymap.h key remap: simplify and use movable allocations 2022-09-25 11:05:59 +01:00
cuesheet.c cuesheet.c guard against invalid digits causing underflow on field ASAN 2022-11-21 23:24:30 -05:00
cuesheet.h
debug_menu.c create function open_pathfmt() to allow printf formatting on open() 2022-11-19 23:13:42 -05:00
debug_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
enc_config.c enc_config.c don't overrun mp3_enc_bitr[] array 2021-08-11 11:00:03 -04:00
enc_config.h
features.txt Reset settings on button hold 2022-06-21 22:43:39 -04:00
filetree.c filetree.c add back SORT_ALPHA_REVERSED 2022-11-23 00:51:54 -05:00
filetree.h Don't autoload bookmarks after saving dynamic playlist 2022-10-18 07:23:25 -04:00
filetypes.c filetypes.c clean-up 2022-11-22 15:19:45 -05:00
filetypes.h filetypes.c clean-up 2022-11-22 15:19:45 -05:00
fracmul.h
keyboard.h
language.c language.c fix possible buffer overrun 2021-08-03 00:57:35 +00:00
language.h
logfdisp.c create function open_pathfmt() to allow printf formatting on open() 2022-11-19 23:13:42 -05:00
logfdisp.h
main.c add splash_progress 2022-10-09 08:46:51 -04:00
menu.c Fix menus in Settings 2022-11-15 22:43:41 +01:00
menu.h
misc.c misc.c open_pathfmt fix yellow 2022-11-20 00:00:40 -05:00
misc.h create function open_pathfmt() to allow printf formatting on open() 2022-11-19 23:13:42 -05:00
onplay.c Hotkeys: Add placeholder for function return value 2022-11-23 01:22:14 -05:00
onplay.h Hotkeys: Add placeholder for function return value 2022-11-23 01:22:14 -05:00
open_plugin.c open_plugins add name when plugin can't open & check LANG_LAST_INDEX_IN_ARRAY 2022-11-17 01:43:16 -05:00
open_plugin.h open_plugins add name when plugin can't open & check LANG_LAST_INDEX_IN_ARRAY 2022-11-17 01:43:16 -05:00
pcmbuf.c Additional Single Mode options 2021-12-11 11:43:39 -05:00
pcmbuf.h
playback.c fix strptokspn, add strcspn, fix splash.c 2022-11-13 01:14:49 -05:00
playback.h Option to switch off album art or to prefer file over embedded 2022-01-22 08:29:40 -05:00
playlist.c playlist: reduce memory usage for loading playlists 2022-11-16 06:47:38 -05:00
playlist.h
playlist_catalog.c Playlist Viewer & Catalogue: Go to WPS when ACTION_TREE_WPS is pressed 2022-11-19 13:39:58 +01:00
playlist_catalog.h Fix return to root after selecting items from playlist viewer 2022-11-19 10:01:23 +01:00
playlist_menu.h
playlist_viewer.c Database & Playlist Viewer: Fix return to WPS from plugin 2022-11-19 17:08:39 +01:00
playlist_viewer.h
plugin.c PictureFlow: Minor fixes & changed defaults 2022-10-22 09:33:50 +02:00
plugin.h PictureFlow: Minor fixes & changed defaults 2022-10-22 09:33:50 +02:00
rbcodec_helpers.c move buflib_free invalid handle check to the function 2022-10-15 09:26:58 -04:00
rbcodecconfig.h
rbcodecplatform.h
README
root_menu.c Fix return to root after selecting items from playlist viewer 2022-11-19 10:01:23 +01:00
root_menu.h
screen_access.c make splash split on control characters 2022-11-12 06:22:16 -05:00
screen_access.h make splash split on control characters 2022-11-12 06:22:16 -05:00
screens.c replace strlcpy with strmemccpy 2022-11-14 23:56:16 -05:00
screens.h Remove dead code 2022-04-16 10:18:28 -04:00
settings.c make int_setting step & unit int16_t 2022-11-20 13:57:09 -05:00
settings.h Implement Rewind across tracks functionality 2022-11-12 09:13:19 -05:00
settings_list.c BUG FIX settings_list.c 2022-11-22 02:19:06 -05:00
settings_list.h make int_setting step & unit int16_t 2022-11-20 13:57:09 -05:00
shortcuts.c replace strlcpy with strmemccpy 2022-11-14 23:56:16 -05:00
shortcuts.h
sound_menu.h
SOURCES LastFm remove scrobbler from core make a TSR plugin WIP 2022-03-26 02:50:11 -04:00
status.c
status.h
tagcache.c create function open_pathfmt() to allow printf formatting on open() 2022-11-19 23:13:42 -05:00
tagcache.h PictureFlow: Minor fixes & changed defaults 2022-10-22 09:33:50 +02:00
tagnavi.config tagtree: Support user override config file 2021-12-24 10:41:27 -05:00
tagtree.c tagtree.c move sort_inverse out of compare function 2022-11-22 19:14:26 -05:00
tagtree.h Database: Restore selection in lower menu levels 2022-11-14 05:47:10 +01:00
talk.c create function open_pathfmt() to allow printf formatting on open() 2022-11-19 23:13:42 -05:00
talk.h talk.c clean up 2022-11-19 02:12:09 -05:00
tree.c filetypes.c clean-up 2022-11-22 15:19:45 -05:00
tree.h Database: Remove firstpos/pos_history 2022-11-02 07:19:36 -04:00
usb_keymaps.c Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
usb_keymaps.h
voice_thread.c voice_thread.c ensure cpu gets re-boosted after Q_VOICE_STOP event 2021-09-29 01:18:00 -04:00
voice_thread.h voice: Allow voice prompt volume to be configurable 2021-03-07 12:51:36 +00:00

README 

For general information see: docs/README
For API information see: docs/API