rockbox/firmware/target/arm/s3c2440
Thomas Jarosch 575ec8902e mini2440: Fix bogus buffer access in LCD backlight driver
The backlight driver always writes a bogus value
from memory into the LCD brightness register.

Fix it up by adding bounds checks and
use a more sane default value.

While looking at the code, I noticed
that BACKLIGHT_CONTROL_SET probably ignores
the desired brightness level, too.

Note: Please test on real hardware, I don't own it.

cppcheck reported:
[rockbox/firmware/target/arm/s3c2440/mini2440/backlight-mini2440.c:53]: (error) Array 'log_brightness[13]' accessed at index 255, which is out of bounds.

Change-Id: Iaafa929a8adaa97b93ebcb66e1f6bd3bf0dad84e
2014-12-20 14:47:09 +01:00
..
gigabeat-fx
mini2440 mini2440: Fix bogus buffer access in LCD backlight driver 2014-12-20 14:47:09 +01:00
adc-s3c2440.c
app.lds
boot.lds
crt0.S
debug-s3c2440.c
dma-s3c2440.c
dma-target.h
i2c-s3c2440.c
i2c-s3c2440.h
kernel-s3c2440.c
lcd-s3c2440.c
sd-s3c2440.c Rewrite filesystem code (WIP) 2014-08-30 03:48:23 +02:00
system-s3c2440.c
system-target.h Remove atomic register bit manipulation functions from i.MX and s3c target code and introduce generic functions for ARM (bitmod32, bitset32, and bitclr32). Multiprocessor support is possible but just not implemented at the moment, only interrupt lockout. 2010-06-30 02:02:46 +00:00
uart-s3c2440.c
uart-s3c2440.h