Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
rockbox/apps
History
William Wilgus 3f110daf30 Fix tree.c->tree_get_entry_at() buffer overflow 
I observed a crash on buflib>move_block
after dumping ram I noticed that the buffer for filetypes was being corrupted

tree_get_entry_at returns a entry from the buflib 'tree entry' buffer
filetree.c->ft_load writes data to this buffer before checking if it has
reached the last entry resulting in buffer overflow that overwrites the
next entry in the buffer ['filetypes']

Patch checks that the index passed to tree_get_entry_at() is in range
otherwise it returns NULL

Added checks + panic in other functions using tree_get_entry_at()
Fixed tree_lock_cache() calls in playlist and filetree

Change-Id: Ibf9e65652b4e00445e8e509629aebbcddffcfd4d
2018-12-14 01:28:17 -06:00
..
bitmaps Agptek Rocker: Initial commit 2018-06-12 10:31:14 +02:00
gui Volume adjustment in WPS ignored AUDIOHW_SETTING values 2018-06-20 12:19:33 +02:00
hosted/android
iap iAP: fix USB storage mount after using an iAP accessory 2016-08-26 00:16:16 +02:00
keymaps More keymap refinements 2018-12-06 15:15:26 +01:00
lang Fix possible truncation misc.c->output_dyn_value + use Kibytes 2018-12-09 22:54:55 -06:00
menus Fix possible truncation misc.c->output_dyn_value + use Kibytes 2018-12-09 22:54:55 -06:00
player
plugins Pdbox hide cast-function-type fix overlapping memcpy 2018-12-08 06:23:19 -06:00
radio nwz: improve keymap 2017-11-14 16:49:36 +01:00
recorder Fix possible truncation misc.c->output_dyn_value + use Kibytes 2018-12-09 22:54:55 -06:00
abrepeat.c
abrepeat.h
action.c Fix error with action subsystem and custom context mapping 2017-12-18 22:23:18 +01:00
action.h Action.c FIX / Rework / Clean-up Action System 2017-11-18 16:08:07 +01:00
alarm_menu.c Fix menu warnings 2018-10-18 00:06:31 +02:00
alarm_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
appevents.h Get voice event out of playback.c 2017-12-12 20:28:56 -05:00
applimits.h
apps.make
audio_path.c nwzlinux: add support for radio 2017-11-06 21:37:06 +01:00
audio_thread.c Get voice event out of playback.c 2017-12-12 20:28:56 -05:00
audio_thread.h
beep.c
bookmark.c
bookmark.h
buffering.c Buffering: Missed converting one case assuming const handle size. 2017-12-19 14:19:39 -05:00
buffering.h Get rid of useless playlist probing and fix up some data types. 2017-12-17 16:33:50 -05:00
codec_thread.c fix builds broken by the selective stack bump for opus seeking. 2018-10-09 15:00:48 -04:00
codec_thread.h
codecs.c
core_asmdefs.c
cuesheet.c Fix Truncation warning in cuesheet.c->browse_cuesheet 2018-12-08 04:47:27 -06:00
cuesheet.h
debug_menu.c Fix possible truncation misc.c->output_dyn_value + use Kibytes 2018-12-09 22:54:55 -06:00
debug_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
enc_config.c Fix menu warnings 2018-10-18 00:06:31 +02:00
enc_config.h Fix menu warnings 2018-10-18 00:06:31 +02:00
features.txt Revert "As3525 v1/v2 Add power savings menu" 2018-07-28 17:35:07 +02:00
filetree.c Fix tree.c->tree_get_entry_at() buffer overflow 2018-12-14 01:28:17 -06:00
filetree.h
filetypes.c
filetypes.h
fracmul.h
keyboard.h
language.c
language.h
logfdisp.c Don't add new message to logf when we dump it to file 2016-04-04 11:07:44 +02:00
logfdisp.h
main.c Agptek Rocker: Implement USB mass storage driver 2018-06-12 10:31:15 +02:00
menu.c
menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
misc.c Fix possible truncation misc.c->output_dyn_value + use Kibytes 2018-12-09 22:54:55 -06:00
misc.h Fix possible truncation misc.c->output_dyn_value + use Kibytes 2018-12-09 22:54:55 -06:00
mpeg.c
mpeg.h
onplay.c Add file view menu to file browser 2018-06-05 16:35:17 +02:00
onplay.h
pcmbuf.c Fix a problem with audio not starting on a list of short files 2017-04-06 19:32:35 -04:00
pcmbuf.h Fix a problem with audio not starting on a list of short files 2017-04-06 19:32:35 -04:00
playback.c Fix playback.c audio_track_count() warning 2018-10-18 09:57:20 -04:00
playback.h Fix playback.c audio_track_count() warning 2018-10-18 09:57:20 -04:00
playlist.c Fix tree.c->tree_get_entry_at() buffer overflow 2018-12-14 01:28:17 -06:00
playlist.h Reenable database ramcache and playlist dircache 2017-01-17 15:27:47 -05:00
playlist_catalog.c
playlist_catalog.h
playlist_menu.h
playlist_viewer.c Don't shorten the playlist on shuffle. Fixes FS#13040 2015-04-19 12:31:45 +02:00
playlist_viewer.h
plugin.c Remove buffering functions from plugin API. 2017-12-17 18:43:23 -05:00
plugin.h Remove buffering functions from plugin API. 2017-12-17 18:43:23 -05:00
rbcodec_helpers.c
rbcodecconfig.h
rbcodecplatform.h
README
root_menu.c iBasso DX50/DX90: Major code cleanup and reorganization. 2015-02-02 21:57:55 +01:00
root_menu.h
screen_access.c
screen_access.h
screens.c Fix possible truncation misc.c->output_dyn_value + use Kibytes 2018-12-09 22:54:55 -06:00
screens.h Fix menu warnings 2018-10-18 00:06:31 +02:00
scrobbler.c iBasso DX50/DX90: Major code cleanup and reorganization. 2015-02-02 21:57:55 +01:00
scrobbler.h
settings.c Fix menu warnings 2018-10-18 00:06:31 +02:00
settings.h Revert "As3525 v1/v2 Add power savings menu" 2018-07-28 17:35:07 +02:00
settings_list.c Revert "As3525 v1/v2 Add power savings menu" 2018-07-28 17:35:07 +02:00
settings_list.h Selective Backlight/Advanced Softlock - Selective actions based on context 2017-01-17 23:06:17 +01:00
shortcuts.c Shortcuts, Fix FS#13151 Deleting shortcut removes name, icon, talkclip 2018-12-10 12:04:55 -06:00
shortcuts.h
sound_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
SOURCES Add cleaned-up xDuoo X3 support 2018-07-28 10:56:31 -04:00
status.c
status.h
tagcache.c Database: Fix destabilization if ramcache fails to load + misc. 2017-04-01 13:01:20 -04:00
tagcache.h
tagnavi.config
tagtree.c Fix menu warnings 2018-10-18 00:06:31 +02:00
tagtree.h Fix menu warnings 2018-10-18 00:06:31 +02:00
talk.c Fix possible truncation misc.c->output_dyn_value + use Kibytes 2018-12-09 22:54:55 -06:00
talk.h
tree.c Fix tree.c->tree_get_entry_at() buffer overflow 2018-12-14 01:28:17 -06:00
tree.h Fix tree.c->tree_get_entry_at() buffer overflow 2018-12-14 01:28:17 -06:00
usb_keymaps.c
usb_keymaps.h
voice_thread.c Get voice event out of playback.c 2017-12-12 20:28:56 -05:00
voice_thread.h

README 

For general information see: docs/README
For API information see: docs/API