Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
rockbox/firmware/target/arm/s3c2440/mini2440
History
Thomas Jarosch 575ec8902e mini2440: Fix bogus buffer access in LCD backlight driver 
The backlight driver always writes a bogus value
from memory into the LCD brightness register.

Fix it up by adding bounds checks and
use a more sane default value.

While looking at the code, I noticed
that BACKLIGHT_CONTROL_SET probably ignores
the desired brightness level, too.

Note: Please test on real hardware, I don't own it.

cppcheck reported:
[rockbox/firmware/target/arm/s3c2440/mini2440/backlight-mini2440.c:53]: (error) Array 'log_brightness[13]' accessed at index 255, which is out of bounds.

Change-Id: Iaafa929a8adaa97b93ebcb66e1f6bd3bf0dad84e
2014-12-20 14:47:09 +01:00
..
adc-target.h Initial touchscreen support for mini2440. Based on D2 touchscreen driver 2009-10-27 20:25:40 +00:00
backlight-mini2440.c mini2440: Fix bogus buffer access in LCD backlight driver 2014-12-20 14:47:09 +01:00
backlight-target.h Initial mini2440 port. 2009-10-19 18:14:27 +00:00
button-mini2440.c Various minor cleanups for mini2440 2010-08-01 08:56:15 +00:00
button-target.h button-target.h : move prototypes to button.h 2012-01-08 00:07:19 +00:00
lcd-target.h Collect some of the memory frame LCD C code. 2011-12-15 23:07:11 +00:00
led-mini2440.c Various minor cleanups for mini2440 2010-08-01 08:56:15 +00:00
led-mini2440.h Initial mini2440 port. 2009-10-19 18:14:27 +00:00
pcm-mini2440.c Revise the PCM callback system after adding multichannel audio. 2012-03-03 07:23:38 +01:00
power-mini2440.c Initial mini2440 port. 2009-10-19 18:14:27 +00:00
powermgmt-mini2440.c Rework powermgmt to enable code re-use on appliation and sims. 2012-01-03 23:44:38 +00:00
touchscreen-mini2440.c Initial touchscreen support for mini2440. Based on D2 touchscreen driver 2009-10-27 20:25:40 +00:00
touchscreen-target.h Initial touchscreen support for mini2440. Based on D2 touchscreen driver 2009-10-27 20:25:40 +00:00