Nyaaori/rockbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
rockbox/apps
History
Christian Soffke 0761532d09 Don't autoload bookmarks after saving dynamic playlist 
4f83e66 (FS#13287) introduced a useful option to
immediately re-load the saved dynamic playlist, so that
bookmark creation becomes possible.
(Current Playlist->Reload After Saving)

It seems unnecessary and won't produce the intended
effect to autoload bookmarks after the playlist is saved,
since playback position will be restored to where
it was previously.

Additionally, with "Load last Bookmark" set to "Ask",
the dialog  for choosing a stored bookmark will appear
after the playlist has been saved. The dialog is
unwanted, since:

- Selecting a bookmark doesn't have expected effect
- Selecting "Don't resume" will actually resume
- Cancelling out of the screen will prevent the
saved playlist from being loaded, without this being
obvious to the user
- It causes a crash if the dynamic playlist is saved
from within the Playlist Viewer (both the Playlist Viewer
and the bookmark selection screen use the plugin
buffer)

Change-Id: I7d696e56c89394b3cd10ef6acfed4ddc7e814118
2022-10-18 07:23:25 -04:00
..
bitmaps Rename symbols of FiiO M3K Linux-based port 2021-02-27 23:53:28 +00:00
gui Fix red for !HAVE_ALBUMART targets (c6ee9dc883) 2022-10-17 15:20:19 +01:00
hosted/android Fix red for Android builds (c6ee9dc883) 2022-10-17 15:20:28 +01:00
iap apps: Add ability to do a clean reboot 2022-04-16 14:36:39 +01:00
keymaps fiiom3k Yes/No screen: Only accept Play button for YES 2022-04-18 22:28:13 -04:00
lang Revert "RFC: Get rid of mpegplayer plugin" 2022-10-13 11:08:11 -04:00
menus gui: Remove gui_synclist_item_is_onscreen() 2022-10-05 11:23:11 -04:00
plugins Revert "RFC: Get rid of mpegplayer plugin" 2022-10-13 11:08:11 -04:00
radio Limit exposure of skin engine internals 2022-10-17 14:29:12 +01:00
recorder Limit exposure of skin engine internals 2022-10-17 14:29:12 +01:00
abrepeat.c [3/4] Completely remove HWCODEC support 2020-07-24 21:20:13 +00:00
abrepeat.h [3/4] Completely remove HWCODEC support 2020-07-24 21:20:13 +00:00
action.c move buflib_free invalid handle check to the function 2022-10-15 09:26:58 -04:00
action.h key remap: simplify and use movable allocations 2022-09-25 11:05:59 +01:00
alarm_menu.c alarm_menu share setter with settime 2022-03-30 09:05:28 -04:00
alarm_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
appevents.h Get voice event out of playback.c 2017-12-12 20:28:56 -05:00
applimits.h
apps.make
audio_path.c nwza860: fix simulator build 2020-10-19 03:39:33 +00:00
audio_thread.c Get voice event out of playback.c 2017-12-12 20:28:56 -05:00
audio_thread.h
beep.c
bookmark.c gui: Remove "enum list_wrap" from list action functions 2022-10-05 11:22:55 -04:00
bookmark.h
buffering.c buffering: remove bufgettail/bufcuttail 2022-04-20 16:51:49 -04:00
buffering.h buffering: remove bufgettail/bufcuttail 2022-04-20 16:51:49 -04:00
codec_thread.c codec_thread.c don't overrun audio_formats[] array 2021-08-11 10:56:14 -04:00
codec_thread.h
codecs.c [3/4] Completely remove HWCODEC support 2020-07-24 21:20:13 +00:00
core_asmdefs.c
core_keymap.c key remap: simplify and use movable allocations 2022-09-25 11:05:59 +01:00
core_keymap.h key remap: simplify and use movable allocations 2022-09-25 11:05:59 +01:00
cuesheet.c gui: Remove "enum list_wrap" from list action functions 2022-10-05 11:22:55 -04:00
cuesheet.h [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
debug_menu.c Limit exposure of skin engine internals 2022-10-17 14:29:12 +01:00
debug_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
enc_config.c enc_config.c don't overrun mp3_enc_bitr[] array 2021-08-11 11:00:03 -04:00
enc_config.h Fix menu warnings 2018-10-18 00:06:31 +02:00
features.txt Reset settings on button hold 2022-06-21 22:43:39 -04:00
filetree.c Don't autoload bookmarks after saving dynamic playlist 2022-10-18 07:23:25 -04:00
filetree.h Don't autoload bookmarks after saving dynamic playlist 2022-10-18 07:23:25 -04:00
filetypes.c misc: Add 'mpga' as a valid file extension 2022-02-01 13:23:39 -05:00
filetypes.h filetree.c move static and stack allocated buffers around 2021-10-20 16:05:21 -04:00
fracmul.h
keyboard.h [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
language.c language.c fix possible buffer overrun 2021-08-03 00:57:35 +00:00
language.h
logfdisp.c [4/4] Remove HAVE_LCD_BITMAP, as it's now the only choice. 2020-07-24 21:20:13 +00:00
logfdisp.h
main.c add splash_progress 2022-10-09 08:46:51 -04:00
menu.c gui: Remove "enum list_wrap" from list action functions 2022-10-05 11:22:55 -04:00
menu.h do_menu pass internal synclist reference to callback 2020-07-19 22:10:26 +00:00
misc.c add const to const * strings 2022-05-03 23:00:58 -04:00
misc.h add function string_option to misc.c use in skin_parser.c 2022-03-13 03:45:00 -04:00
onplay.c add splash_progress 2022-10-09 08:46:51 -04:00
onplay.h add hotkeys for properties and pictureflow 2022-08-05 11:39:35 -04:00
open_plugin.c apps: fix use of negative fd in open_plugin.c 2022-05-02 16:42:32 +01:00
open_plugin.h Open Plugins Ignore hash for lang Ids 2021-10-23 02:45:54 -04:00
pcmbuf.c Additional Single Mode options 2021-12-11 11:43:39 -05:00
pcmbuf.h Fix a problem with audio not starting on a list of short files 2017-04-06 19:32:35 -04:00
playback.c move buflib_free invalid handle check to the function 2022-10-15 09:26:58 -04:00
playback.h Option to switch off album art or to prefer file over embedded 2022-01-22 08:29:40 -05:00
playlist.c splash_progress add delay function 2022-10-13 00:10:25 -04:00
playlist.h [3/4] Completely remove HWCODEC support 2020-07-24 21:20:13 +00:00
playlist_catalog.c Partial fix for FS#12702: playlist catalogue silently fails to save files 2022-08-21 09:36:04 -04:00
playlist_catalog.h
playlist_menu.h
playlist_viewer.c gui: Remove "enum list_wrap" from list action functions 2022-10-05 11:22:55 -04:00
playlist_viewer.h
plugin.c move buflib_free invalid handle check to the function 2022-10-15 09:26:58 -04:00
plugin.h Revert "Remove YUV blitting functions and LCD modes" 2022-10-13 11:08:06 -04:00
rbcodec_helpers.c move buflib_free invalid handle check to the function 2022-10-15 09:26:58 -04:00
rbcodecconfig.h
rbcodecplatform.h
README
root_menu.c add splash_progress 2022-10-09 08:46:51 -04:00
root_menu.h Add open_plugin to core 2020-08-17 10:15:14 -04:00
screen_access.c Whitespace cleanup on fb_viewport Rewrite 2020-10-26 12:38:22 -04:00
screen_access.h Whitespace cleanup on fb_viewport Rewrite 2020-10-26 12:38:22 -04:00
screens.c gui: Remove "enum list_wrap" from list action functions 2022-10-05 11:22:55 -04:00
screens.h Remove dead code 2022-04-16 10:18:28 -04:00
settings.c gui: Remove redundant copies of list scrolling settings 2022-10-05 10:22:55 -04:00
settings.h Reset settings on button hold 2022-06-21 22:43:39 -04:00
settings_list.c gui: Remove redundant copies of list scrolling settings 2022-10-05 10:22:55 -04:00
settings_list.h Add open_plugin to core 2020-08-17 10:15:14 -04:00
shortcuts.c add const to const * strings 2022-05-03 23:00:58 -04:00
shortcuts.h
sound_menu.h Fix menu warnings 2018-10-18 00:06:31 +02:00
SOURCES LastFm remove scrobbler from core make a TSR plugin WIP 2022-03-26 02:50:11 -04:00
status.c [2/4] get rid of HAVE_LCD_CHARCELLS 2020-07-24 21:20:13 +00:00
status.h [2/4] get rid of HAVE_LCD_CHARCELLS 2020-07-24 21:20:13 +00:00
tagcache.c Convert a number of allocations to use buflib pinning 2022-10-16 14:50:39 +01:00
tagcache.h tagtree/tagcache add new clause operators begins/ends _oneof 2022-03-19 02:24:14 -04:00
tagnavi.config tagtree: Support user override config file 2021-12-24 10:41:27 -05:00
tagtree.c Convert a number of allocations to use buflib pinning 2022-10-16 14:50:39 +01:00
tagtree.h Fix menu warnings 2018-10-18 00:06:31 +02:00
talk.c move buflib_free invalid handle check to the function 2022-10-15 09:26:58 -04:00
talk.h talk: Explicitly cast -1 as unsigned before a left shift. 2021-07-20 00:09:33 +00:00
tree.c Convert a number of allocations to use buflib pinning 2022-10-16 14:50:39 +01:00
tree.h Convert a number of allocations to use buflib pinning 2022-10-16 14:50:39 +01:00
usb_keymaps.c Document intentional fallthroughs + fix harmless unintended ones 2021-08-04 18:59:46 +00:00
usb_keymaps.h
voice_thread.c voice_thread.c ensure cpu gets re-boosted after Q_VOICE_STOP event 2021-09-29 01:18:00 -04:00
voice_thread.h voice: Allow voice prompt volume to be configurable 2021-03-07 12:51:36 +00:00

README 

For general information see: docs/README
For API information see: docs/API