Commit graph

55 commits

Author SHA1 Message Date
Solomon Peachy
cddd8d66e2 Silence warnings that happen on newer GCCs
(code is presumably correct)

Change-Id: I3ee11b6a10dc87eb6f6178d6182397f0c7f686d5
2020-10-13 20:09:14 -04:00
William Wilgus
78b2d13567 Pdbox hide cast-function-type fix overlapping memcpy
dsoundfile.c used memcpy for overlapping memory regions switched to memmove
Suppress the 160+ warnings for cast-function-type
This plugin would require major work to fix these warnings

Change-Id: I309d914839c1e70126a05b387863fd21613497a9
2018-12-08 06:23:19 -06:00
Frank Gevaerts
2a2800b528 pdbox: fix bug shown by new gcc warning
Change-Id: Ife308a3090f9bc62f2e98d2d979fdf393c22054d
2016-10-12 16:52:49 +02:00
Thomas Jarosch
fdd4aef340 Make thirty functions static to reduce binary size
If any of those functions should be (unused) API functions,
they can easily be turned back once really needed.

Detected using a new cppcheck check that
uses the internal symbol database to catch
functions that are only used in the current file.

Change-Id: Ic2b1e5b8020b76397f11cefc4e205f3b7ac1f184
2015-01-05 18:44:36 +01:00
Marcin Bukat
71778bd21e pdbox: Always use fixedpoint version of math functions
Change-Id: Ie5671d8f425804c9cf3265bad86eadadaf73ea1c
2012-10-07 15:04:24 +02:00
Michael Sevakis
286a4c5caa Revise the PCM callback system after adding multichannel audio.
Additional status callback is added to pcm_play/rec_data instead of
using a special function to set it. Status includes DMA error
reporting to the status callback. Playback and recording callback
become more alike except playback uses "const void **addr" (because
the data should not be altered) and recording  uses "void **addr".
"const" is put in place throughout where appropriate.

Most changes are fairly trivial. One that should be checked in
particular because it isn't so much is telechips, if anyone cares to
bother. PP5002 is not so trivial either but that tested as working.

Change-Id: I4928d69b3b3be7fb93e259f81635232df9bd1df2
Reviewed-on: http://gerrit.rockbox.org/166
Reviewed-by: Michael Sevakis <jethead71@rockbox.org>
Tested-by: Michael Sevakis <jethead71@rockbox.org>
2012-03-03 07:23:38 +01:00
Frank Gevaerts
7efbd632c2 Fix wrong pointer arithmetic in the PDbox aiff header writing code
The SSND bit is intended to be right after the t_aiff-sized header.
Someone got cast vs + precedence rules wrong here.

Change-Id: Iccec75043ed5e35724331f9833b24f7e3b90c447
2012-01-22 21:41:38 +01:00
Wincent Balin
d01954cad2 Committing fix for FS#12249. Patch by Buschel. Further fixes for AIFF loader in PDBox in the future.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30944 a1c6a512-1295-4272-9138-f99709370657
2011-11-08 23:48:24 +00:00
Andree Buschmann
0a070c5420 Fix last known 'set but not used' warning by GCC 4.6.1.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29875 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 19:40:17 +00:00
Andree Buschmann
2aa0759077 Fix even more 'set but not used' warnings and a regression.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29873 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 19:23:27 +00:00
Andree Buschmann
4f4edd89e4 Fix further 'set but not used' warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29872 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 19:06:04 +00:00
Andree Buschmann
f7808c1fe5 Fix several 'variable set but not used' warnings reported by GCC 6.4.1.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29871 a1c6a512-1295-4272-9138-f99709370657
2011-05-13 18:47:42 +00:00
Teruaki Kawashima
930a8a5050 set mode argument for open() where O_CREAT flag is/can be set.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28527 a1c6a512-1295-4272-9138-f99709370657
2010-11-07 11:45:20 +00:00
Rafaël Carré
aa3c676945 pdbox: avoid making own DEBUG clash with rockbox define
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27388 a1c6a512-1295-4272-9138-f99709370657
2010-07-11 16:46:49 +00:00
Wincent Balin
38fe596cd5 pdbox: Optimizations in the audio output code.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27288 a1c6a512-1295-4272-9138-f99709370657
2010-07-05 01:35:04 +00:00
Frank Gevaerts
9e5846e7fc Fix include file
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27017 a1c6a512-1295-4272-9138-f99709370657
2010-06-21 16:39:55 +00:00
Frank Gevaerts
3c78cb35e8 Remove plugin-specific defines from the pdbox makefile, and add them to m_pd.h, which is the global pdbox header. This makes sure that the defines are set during depency generation so dependencies are correct.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@27016 a1c6a512-1295-4272-9138-f99709370657
2010-06-21 16:34:13 +00:00
Wincent Balin
0133a4f052 pdbox: Reverted premature commit of Coldfire optimization.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26560 a1c6a512-1295-4272-9138-f99709370657
2010-06-04 21:32:14 +00:00
Wincent Balin
58d875e441 pdbox: Fixing yellows.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26552 a1c6a512-1295-4272-9138-f99709370657
2010-06-04 18:54:07 +00:00
Wincent Balin
66cc643402 pdbox: Corrected inclusion of m_fixed.h .
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26551 a1c6a512-1295-4272-9138-f99709370657
2010-06-04 18:37:55 +00:00
Wincent Balin
d166d61b09 pdbox: Added Coldfire multiplication optimization by Buschel.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26550 a1c6a512-1295-4272-9138-f99709370657
2010-06-04 18:21:47 +00:00
Andree Buschmann
dbfb90672b Ensure CPU is defined.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26546 a1c6a512-1295-4272-9138-f99709370657
2010-06-04 16:22:10 +00:00
Wincent Balin
2e5b1b1a9c pdbox: Applied several changes by Buschel. Reintroduced compilation for iPods.
Changes by Buschel:

* Reduced footprint by making cosine table of size 1^13 instead of 1^15
* Corrected interpolation in the cos~ object
* Optimized multiplication on ARM platforms



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26534 a1c6a512-1295-4272-9138-f99709370657
2010-06-03 22:03:37 +00:00
Rafaël Carré
da2dd97705 pdbox: fix build on ARM with eabi
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26514 a1c6a512-1295-4272-9138-f99709370657
2010-06-03 15:27:59 +00:00
Wincent Balin
c1ae4414d4 pdbox: Source cleanup. Removed unneeded files.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26497 a1c6a512-1295-4272-9138-f99709370657
2010-06-03 00:39:13 +00:00
Wincent Balin
5edd8cf736 pdbox: Syntax cleanup for the cosine table.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26496 a1c6a512-1295-4272-9138-f99709370657
2010-06-02 23:26:12 +00:00
Wincent Balin
36f3a8d67e Added myself and Pure Data team to credits.
Updated copyright years where needed.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26457 a1c6a512-1295-4272-9138-f99709370657
2010-06-01 21:44:55 +00:00
Wincent Balin
f52c9aae3a pdbox: Code cleanup, optimizations.
* Reverted minimal working memory to 4 MB
* Reverted size of a single audio buffer
* Optimized sound output loop


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26454 a1c6a512-1295-4272-9138-f99709370657
2010-06-01 20:37:16 +00:00
Wincent Balin
a266ff185a pdbox: Solved issue with WAV file import on big-endian targets (signed 16-bit files only); small I/O-related workaround in g_array.c
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26439 a1c6a512-1295-4272-9138-f99709370657
2010-06-01 00:23:59 +00:00
Wincent Balin
112ad0ac42 pdbox: Code cleanup
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26274 a1c6a512-1295-4272-9138-f99709370657
2010-05-24 23:38:04 +00:00
Wincent Balin
cb185d2860 pdbox: Successfully resolved issue with loading of audio files
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26272 a1c6a512-1295-4272-9138-f99709370657
2010-05-24 23:13:37 +00:00
Wincent Balin
c208486fcc pdbox: Rewrote recently added bugfixes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26184 a1c6a512-1295-4272-9138-f99709370657
2010-05-20 04:23:40 +00:00
Wincent Balin
ae2659e633 pdbox: Got rid of signedness-related warnings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26183 a1c6a512-1295-4272-9138-f99709370657
2010-05-20 03:38:53 +00:00
Wincent Balin
6274944942 pdbox: Made size value signed
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26182 a1c6a512-1295-4272-9138-f99709370657
2010-05-20 03:33:18 +00:00
Wincent Balin
5ea0dc83ec pdbox: Adjusted return values for functions read() and write()
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26181 a1c6a512-1295-4272-9138-f99709370657
2010-05-20 03:27:12 +00:00
Thomas Martitz
0a1d7c28b7 Make open() posix compliant api-wise. A few calls (those with O_CREAT) need the additional optional mode parameter so add it. Impact for the core is almost zero, as open() is a wrapper macro for the real open function which doesn't take the variable parameter.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25844 a1c6a512-1295-4272-9138-f99709370657
2010-05-06 17:35:13 +00:00
Wincent Balin
a607a6c3c2 pdbox: Fixed loading of sound files, pdpod_drums.pd works now.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25769 a1c6a512-1295-4272-9138-f99709370657
2010-05-02 00:32:50 +00:00
Frank Gevaerts
ca755f767c Fix pdbox makefile to actually take part in dependency generation
Change pdbox include paths to handle this



git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24916 a1c6a512-1295-4272-9138-f99709370657
2010-02-25 23:35:16 +00:00
Wincent Balin
7964b69635 PDBox: Correcting two more warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22174 a1c6a512-1295-4272-9138-f99709370657
2009-08-05 15:36:08 +00:00
Wincent Balin
764b12fc1d PDBox: Got rid of warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22173 a1c6a512-1295-4272-9138-f99709370657
2009-08-05 15:09:26 +00:00
Wincent Balin
eac0a5b840 PDBox: Removed unneeded include file to, hopefully, diminish the amount of warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22170 a1c6a512-1295-4272-9138-f99709370657
2009-08-05 14:18:52 +00:00
Wincent Balin
349db581b5 PDBox: Changed type of t_int to remove 64-bit related warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22167 a1c6a512-1295-4272-9138-f99709370657
2009-08-05 13:19:17 +00:00
Wincent Balin
7996e77334 PDBox: Use correct values of maximal string size for snprintf.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22154 a1c6a512-1295-4272-9138-f99709370657
2009-08-04 13:52:43 +00:00
Wincent Balin
11ac0b3f2a PDBox: Minor addition and bugfixes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22148 a1c6a512-1295-4272-9138-f99709370657
2009-08-04 02:04:24 +00:00
Peter D'Hoye
c8195d80bf By Wincent Balin: Cleaned up unneeded prototypes in s_path.c (ongoing FS #10416)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21992 a1c6a512-1295-4272-9138-f99709370657
2009-07-21 11:59:04 +00:00
Maurus Cuelenaere
06bb5ea004 Fix PDbox compilation
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21952 a1c6a512-1295-4272-9138-f99709370657
2009-07-18 12:38:17 +00:00
Peter D'Hoye
c133c6a964 Another patch by Wincent Balin (from the FS #10416 series): get rid of some warnings. PDBox now builds without any error or warning.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21819 a1c6a512-1295-4272-9138-f99709370657
2009-07-12 19:18:59 +00:00
Peter D'Hoye
4bcd8475cb PDBox: One file with stuff is enough....
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21818 a1c6a512-1295-4272-9138-f99709370657
2009-07-12 18:52:35 +00:00
Peter D'Hoye
66a0492ab7 More work on PDBox by Wincent Balin. The PDBox plug-in is now working with the pdpod_test.pd file from the PureData.zip archive
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21816 a1c6a512-1295-4272-9138-f99709370657
2009-07-12 18:44:26 +00:00
Peter D'Hoye
0d4560cb03 Accept FS #10244 by Wincent Balin: more pdbox work done for GSoC; also some keyword and line-ending fixes by me
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21626 a1c6a512-1295-4272-9138-f99709370657
2009-07-03 22:16:11 +00:00