rockbox

Nyaaori/rockbox

Fork 0

Commit graph

Author	SHA1	Message	Date
William Wilgus	70aeac4666	Fix red dynamic menus missed one. Change-Id: Ifa986b0a3397fed8ef28931ecbcdd2910d203ea3	2019-09-20 03:57:38 -05:00
William Wilgus	10e5e56f3c	Bug fix dynamic menus Dynamic menus had a buffer_len variable in the parent function but it was discarded before passing to the callbacks Why!!?? No clue but everything that used it was assuming MAXPATH Wouldn't be surprised to see some bugs pop out from this one.. init_menu_lists() was assuming MENU_HAS_DESC and setting the menu title + icon based on such even though it could be invalid didn't see anywhere in the code that was currently using MENU_DYNAMIC_DESC in relation to a top level menu but considering it caused all kinds of corruption to the menu when I tried its probably been tried and abandoned before... Change-Id: I8d961d748918bfa8ea6adb5ad60491af4d739d6e	2019-09-20 03:07:29 -05:00
Michael Sevakis	80d0d15ca9	Gigabeat S: Fully enable access to hardware tone controls and 3-D effect feature. Under the hood, it's designated a hardware equalizer since it is one. Implement code framework for hardware EQ in general. Menu aspect is well abstracted and so the UI and strings can be changed around if taste doesn't quite suit. So far the emphasis is distinction of the UI labelling from the software EQ so that it's clear the settings are for a different thing. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26051 a1c6a512-1295-4272-9138-f99709370657	2010-05-15 13:09:45 +00:00

Author

SHA1

Message

Date

William Wilgus

70aeac4666

Fix red dynamic menus

missed one.

Change-Id: Ifa986b0a3397fed8ef28931ecbcdd2910d203ea3

2019-09-20 03:57:38 -05:00

William Wilgus

10e5e56f3c

Bug fix dynamic menus

Dynamic menus had a buffer_len variable in the parent function but it
was discarded before passing to the callbacks

Why!!?? No clue but everything that used it was assuming MAXPATH
Wouldn't be surprised to see some bugs pop out from this one..

init_menu_lists() was assuming MENU_HAS_DESC and setting the
menu title + icon based on such even though it could be invalid
didn't see anywhere in the code that was currently using MENU_DYNAMIC_DESC
in relation to a top level menu but considering it caused all kinds
of corruption to the menu when I tried its probably been tried
and abandoned before...

Change-Id: I8d961d748918bfa8ea6adb5ad60491af4d739d6e

2019-09-20 03:07:29 -05:00

Michael Sevakis

80d0d15ca9

Gigabeat S: Fully enable access to hardware tone controls and 3-D effect feature. Under the hood, it's designated a hardware equalizer since it is one. Implement code framework for hardware EQ in general. Menu aspect is well abstracted and so the UI and strings can be changed around if taste doesn't quite suit. So far the emphasis is distinction of the UI labelling from the software EQ so that it's clear the settings are for a different thing.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26051 a1c6a512-1295-4272-9138-f99709370657

2010-05-15 13:09:45 +00:00

3 commits