Jonathan Gordon
3823486a58
Add a mode the lists which doesnt show the selection marker.
...
Useful for the debug menus where users shouldn't think pressing select would do anything.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13588 a1c6a512-1295-4272-9138-f99709370657
2007-06-07 12:14:31 +00:00
Nicolas Pennequin
887b31c01a
Add some more explicit defines for my previous commit.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13561 a1c6a512-1295-4272-9138-f99709370657
2007-06-05 14:57:07 +00:00
Nicolas Pennequin
b5f4d90b4b
Make the bitmap loading code handle the progressbar and backdrop bitmaps in a slightly more generic way. This hopefully simplifies the code a bit and should make adding special bitmaps less painful.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13560 a1c6a512-1295-4272-9138-f99709370657
2007-06-05 10:42:41 +00:00
Jonathan Gordon
fea88888f0
Fix most (all) known list wierdness bugs, hopefully simplifies the code a bit, plenty of room for optimizing, but wanted to get it working first. (fixes FS#7255 and possibly others)
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13556 a1c6a512-1295-4272-9138-f99709370657
2007-06-05 02:57:43 +00:00
Jonathan Gordon
20a8a9a3c8
Move the old api out of the core and into the plugin lib.
...
ew plugins shuold use the new api and not this one.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13537 a1c6a512-1295-4272-9138-f99709370657
2007-06-03 04:06:58 +00:00
Nils Wallménius
fbdbd2112c
Fix warning
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13525 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 18:08:29 +00:00
Nils Wallménius
f46657ec5a
Move the setvol wrapper function to misc.c and use it in more places instead of doing the same checks everywhere
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13524 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 17:57:32 +00:00
Jonathan Gordon
dfb071d92e
Last list commit for a while. fix the multi-item lists at the very end of the list
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13523 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 09:25:59 +00:00
Jonathan Gordon
0178568325
fix non-paged scrolling aroun the ends of lists
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13522 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 09:11:59 +00:00
Jonathan Gordon
5983e7fa42
few more list anomolys fixed..
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13521 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 08:29:44 +00:00
Jonathan Gordon
155e3d33d6
Fix the last (?) of the selction wierdness, this time when moving at the begining of the list
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13520 a1c6a512-1295-4272-9138-f99709370657
2007-05-30 02:08:35 +00:00
Dave Chapman
f0d4fc6c6b
Commit my patch from FS#7179 - a standalone command-line checkwps tool. To build, just type "make checkwps" in tools and run it with "checkwps wpsname.wps".
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13517 a1c6a512-1295-4272-9138-f99709370657
2007-05-29 19:00:36 +00:00
Jonathan Gordon
6fd3d96309
fix selection wierdness when scrolling down at the end of lists
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13514 a1c6a512-1295-4272-9138-f99709370657
2007-05-29 13:06:41 +00:00
Jonathan Gordon
20202017f4
Really fix FS#7230 this time.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13513 a1c6a512-1295-4272-9138-f99709370657
2007-05-29 12:28:02 +00:00
Jonathan Gordon
195ac12296
Fix FS#7230 - the second line in a multi-line item could be the selected item
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13512 a1c6a512-1295-4272-9138-f99709370657
2007-05-29 12:16:31 +00:00
Nicolas Pennequin
6579818b43
Add the possibility to store cuesheets in /.rockbox/cue. The code will look for a cuesheet there in case there wasn't one in the same folder as the audio file. This is to reduce the clutter created by one cuesheet per audio file in some places.
...
Also some duplicate code was replaced by a function call.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13508 a1c6a512-1295-4272-9138-f99709370657
2007-05-28 23:18:31 +00:00
Jonathan Gordon
42698e4e47
Accept FS#6798 - scan acceleration for the lists.
...
Settings are in display > scrolling
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13499 a1c6a512-1295-4272-9138-f99709370657
2007-05-27 15:08:56 +00:00
Nils Wallménius
e1374b0536
Oops, remove accidentally left in, commented out code
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13492 a1c6a512-1295-4272-9138-f99709370657
2007-05-24 22:43:54 +00:00
Nils Wallménius
c2a77563c2
Remove dead code.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13488 a1c6a512-1295-4272-9138-f99709370657
2007-05-24 19:03:26 +00:00
Nicolas Pennequin
392d07902f
Oops, next file info should be dynamic.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13456 a1c6a512-1295-4272-9138-f99709370657
2007-05-21 14:04:38 +00:00
Nicolas Pennequin
5cc98efddc
Add %fk and %Fk WPS tags : (next) file audio frequency in KHz (rewrite of FS#6393 to adapt it to the tokenizer).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13455 a1c6a512-1295-4272-9138-f99709370657
2007-05-21 13:41:43 +00:00
Nicolas Pennequin
9d5e376fc3
Allow the day of month (%cm) and day of week (%cu and %cw) RTC tags to be used in enums.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13454 a1c6a512-1295-4272-9138-f99709370657
2007-05-21 12:54:07 +00:00
Michael Sevakis
8f659ae8d3
Use bitmasks to define which inputs are available. Makes it easier to remove old assumptions of which are available. Inspired by e200 being unique in having FM Radio and Mic but no Line. Doesn't remove the assumption that Mic is available or that one of Mic and/or Line is available just to avoid excessive #ifdef'ing until needed.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13448 a1c6a512-1295-4272-9138-f99709370657
2007-05-20 20:26:36 +00:00
Nils Wallménius
f31e123133
Remove unused function and unused header
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13424 a1c6a512-1295-4272-9138-f99709370657
2007-05-19 19:54:11 +00:00
Nicolas Pennequin
4a6ab0d031
Commit FS#7164 (request is FS#6780) : Improve WPS volume enumeration. It is now the following : %?pv<Mute|...|...|0 dB|Above 0 dB>. It almost doesn't changes anything for most WPSs but adds some new possibilities. Keep in mind that some targets don't go above 0 dB so the last case might be unused.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13387 a1c6a512-1295-4272-9138-f99709370657
2007-05-14 14:33:43 +00:00
Jonathan Gordon
c9ed673c81
only show the cursor for the first line of the selected item (if selection is more than one line). doesnt effect inverted cursor mode
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13375 a1c6a512-1295-4272-9138-f99709370657
2007-05-12 14:13:23 +00:00
Michael Sevakis
1c59b101df
SWCODEC Playback: Seriously mess with it and get rid of (at least some ;) race conditions.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13361 a1c6a512-1295-4272-9138-f99709370657
2007-05-08 22:56:12 +00:00
Nicolas Pennequin
aa220d5acd
Trim a bunch of long lines and fix an infinite loop and buffer overrun in the impossible case that a WPS line ends with a litteral string but without a newline char (wps_parser.c:774).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13306 a1c6a512-1295-4272-9138-f99709370657
2007-05-02 17:51:01 +00:00
Magnus Holmgren
05a158ecf3
Treat empty strings as 'no value' in conditionals, as it used to.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13304 a1c6a512-1295-4272-9138-f99709370657
2007-05-02 16:28:24 +00:00
Nicolas Pennequin
378a140ae2
Add a check for unclosed conditionals at the end of the WPS parsing in case we didn't reach the end of the file. Also a few minor other changes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13303 a1c6a512-1295-4272-9138-f99709370657
2007-05-02 11:39:46 +00:00
Peter D'Hoye
3494b2118b
FS #7093 by Dave Hooper: prevent crash when loading too many/long static strings in the wps
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13302 a1c6a512-1295-4272-9138-f99709370657
2007-05-01 23:36:15 +00:00
Nicolas Pennequin
7e6af1532b
Better handling of strings in the WPS parser by detecting duplicates to avoid having two copies of the same string in the string buffer.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13295 a1c6a512-1295-4272-9138-f99709370657
2007-04-30 14:08:58 +00:00
Jonathan Gordon
39a6b5d643
Stop using the old menu API in the debug menu (using the new api causes massive bin increase, so fake the old api with existing code instead) (onplay.c and plugins are the only parts using th eold api now)
...
Fix a bug where the menu title was sometimes shown in the system font
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13286 a1c6a512-1295-4272-9138-f99709370657
2007-04-29 15:31:43 +00:00
Nicolas Pennequin
1cf2ec38b1
Change some ifdefs for the recent backdrop changes (fixes the yellow builds) and move the backdrop files.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13265 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 22:08:00 +00:00
Nicolas Pennequin
7fdfa56454
Add backdrop support for LCD remotes with depth > 1-bit. Only WPS backdrops, but the groundwork is laid for main backdrops too (all that's really needed are menus to set/clear them).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13263 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 21:44:56 +00:00
Nicolas Pennequin
2a2b8d8a82
Make bitmaps use the right format in a RWPS and prevent a backdrop tag in a RWPS from clearing the main display's backdrop. This also allows future backdrop support for LCD remotes by making the parsing code aware of whether the display for a WPS is a remote or not.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13261 a1c6a512-1295-4272-9138-f99709370657
2007-04-25 13:09:56 +00:00
Nicolas Pennequin
6ac306a515
Add a new commandline switch to the simulator: "--debugwps". It enables printing of advanced (and very verbose) WPS debugging information. Also make the debugging code a bit cleaner.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13257 a1c6a512-1295-4272-9138-f99709370657
2007-04-24 23:58:57 +00:00
Nicolas Pennequin
d7fd989319
WPS Parser: On parse failure, print a (hopefully) useful error message with line number (sim only).
...
Also the debug code is still disabled but now in a nicer way.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13251 a1c6a512-1295-4272-9138-f99709370657
2007-04-24 00:57:04 +00:00
Jens Arnold
6bf86b799e
Ooooops, fix warning.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13243 a1c6a512-1295-4272-9138-f99709370657
2007-04-22 12:48:05 +00:00
Jens Arnold
5070f41bfc
Consolidated several potential places of return from WPS into one. Fixes the 'Return from WPS at end of playlist always brings up the root menu.' bug on hwcodec.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13241 a1c6a512-1295-4272-9138-f99709370657
2007-04-22 12:38:11 +00:00
Jonathan Gordon
9d3694ced6
Fix FS#7056 - dont display garbage if the viewer icon set and the main iconset have different icon heights
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13237 a1c6a512-1295-4272-9138-f99709370657
2007-04-22 08:50:24 +00:00
Nicolas Pennequin
814d402d4c
More strict WPS parsing and displaying code. If there are errors, WPS loading will fail and the default WPS will be displayed.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13236 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 19:31:46 +00:00
Michael Sevakis
26d242ae65
General housekeeping: Make plugin buffer functions take size_t * instead of int * to match the parameter type of the buffer functions called in the core. Get rid of unsafe int * <==> size_t * casting. Use ssize_t where int was used and size_t where unsigned int was used in the buffer calls to not alter signedness in the plugins. No API version change since it should only be an issue for 64-bit sim builds.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13233 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 18:38:25 +00:00
Jonathan Gordon
7f3c66f1cb
Fix the playlist viewer so only 1 line flashes when you move a track
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13231 a1c6a512-1295-4272-9138-f99709370657
2007-04-21 11:14:57 +00:00
Magnus Holmgren
392a4ef49b
Fix logf builds on devices that support remotes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13202 a1c6a512-1295-4272-9138-f99709370657
2007-04-18 17:49:32 +00:00
Jonathan Gordon
36a2e30872
Move the inbuilt filetype info into filetypes.c and rename the defines.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13201 a1c6a512-1295-4272-9138-f99709370657
2007-04-18 13:03:01 +00:00
Jonathan Gordon
e9610dca80
Remove unneeded #include, comment the filename define
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13193 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 08:37:01 +00:00
Jonathan Gordon
754d9195f7
explicitly set *loaded_ok = false; when given "" for a filename.
...
remove icon_init from the startup sequence, its not dependant on filetypes_init anymore,settings_apply calls the icons_init (causes the bmp's to only be read once on boot instead of twice)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13191 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 06:37:22 +00:00
Jens Arnold
79a8b41513
Fix loadable remote icons. fb_data != fb_remote_data ...
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13190 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 01:03:25 +00:00
Jens Arnold
f87eaf3c4e
Fix non-working default viewer icons. Remote viewer icons work now, but still not properly.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13189 a1c6a512-1295-4272-9138-f99709370657
2007-04-17 00:29:04 +00:00