Commit graph

60 commits

Author SHA1 Message Date
Jonathan Gordon
ff469ab573 Updated recording trigger screen (seems to be a feature almost noone uses?)
problems/complaints in http://forums.rockbox.org/index.php?topic=16837.0
there is a known issue that on this screen the stop icon wont update, I dont know why and noone else wants to look at it, so hopefully this will force another set of eyes on it.. this is only a graphical issue... recordings still work fine


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17643 a1c6a512-1295-4272-9138-f99709370657
2008-05-28 10:55:39 +00:00
Bertrik Sikken
db2d61f4ea Killed unnecessary global variables by making them static.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17184 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 10:24:15 +00:00
Dave Chapman
d02c79c03f Commit viewports-in-WPS patch (FS#8385). This adds the %V tag - see the CustomWPS page for details (shortly...). There is still some work to do - decide how to handle font references, decide how to handle conditionals. Plus checkwps is broken - I'll fix that in a separate commit.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16733 a1c6a512-1295-4272-9138-f99709370657
2008-03-21 19:38:00 +00:00
Peter D'Hoye
9c3f6c4079 Simplify that clip indicator reset code a bit
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16559 a1c6a512-1295-4272-9138-f99709370657
2008-03-08 20:32:37 +00:00
Peter D'Hoye
0ecdb37e99 Fix FS #8514 (remote peakmeter issue) by separating the peak release times for the screens. Thanks to amiconn for pointing in the right direction.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16234 a1c6a512-1295-4272-9138-f99709370657
2008-02-06 21:53:07 +00:00
Jens Arnold
8b44601a7c Disable highperf mode in the peakmeter for swcodec targets, as it makes no sense. Improves responsiveness a lot with a peakmeter-enabled wps on targets with slow lcd updates (e.g. G5). Added a comment why highperf mode is needed for MAS targets.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15140 a1c6a512-1295-4272-9138-f99709370657
2007-10-16 08:34:51 +00:00
Michael Sevakis
6077e5b7c8 Unify PCM interface just above the hardware driver level for all targets including the sims. Perform lockout of audio callback when changing states. Weird new playback or recording trouble? Check before and after this revision first though things seem quite sound.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15006 a1c6a512-1295-4272-9138-f99709370657
2007-10-06 22:27:27 +00:00
Nils Wallménius
c70d9462be Make a few private functins static and use fewer bytes for constants
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14783 a1c6a512-1295-4272-9138-f99709370657
2007-09-20 16:44:28 +00:00
Jens Arnold
945462edef Make peakmeters work for real in swcodec simulators instead of just showing random movement.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14650 a1c6a512-1295-4272-9138-f99709370657
2007-09-09 09:07:22 +00:00
Peter D'Hoye
6109d39469 only build the clipcounter for targets with recording
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14467 a1c6a512-1295-4272-9138-f99709370657
2007-08-26 21:34:36 +00:00
Peter D'Hoye
583f186ce4 Implement FS #2976: Clip Counter for recording screen. If enabled in peak meter settings, it shows the number of times clipping occurred (clip indicator going on). Count is reset on recording start and only counts during actual recording. Stays on screen when stopping or pauzing. Also fix a drawing bug when peakmeters start at a non-zero x offset.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14455 a1c6a512-1295-4272-9138-f99709370657
2007-08-25 15:53:54 +00:00
Jens Arnold
99ff02d2cb Make peak release work per tick as intended. But that's too fast, so it's not the final solution.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14397 a1c6a512-1295-4272-9138-f99709370657
2007-08-20 06:36:24 +00:00
Peter D'Hoye
ebcf06d237 Make peakmeter release setting work in units per tick (was units per read), add the unit and make it voiced. Make old leftover in lang file deprecated
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14390 a1c6a512-1295-4272-9138-f99709370657
2007-08-18 23:03:03 +00:00
Jens Arnold
47bf6c5a5a Moved archos backlight code to target tree. Changed old mutlivalue CONFIG_BACKLIGHT to a simple HAVE_BACKLIGHT.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13136 a1c6a512-1295-4272-9138-f99709370657
2007-04-12 22:12:13 +00:00
Nils Wallménius
b41e93ae63 Draw peakmeter scale marks in foreground color instead of inversed background color, fixes FS #6855
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12840 a1c6a512-1295-4272-9138-f99709370657
2007-03-19 16:49:55 +00:00
Jens Arnold
3a37f46fc9 Fix CONFIG_BACKLIGHT warnings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12393 a1c6a512-1295-4272-9138-f99709370657
2007-02-18 10:07:27 +00:00
Jens Arnold
2597a13497 Next round of static'ing and related fixes.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11836 a1c6a512-1295-4272-9138-f99709370657
2006-12-25 14:01:47 +00:00
Martin Scarratt
d8103f3ba6 Recording trigger for software codec targets
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11479 a1c6a512-1295-4272-9138-f99709370657
2006-11-09 12:27:56 +00:00
Michael Sevakis
0f5cb94aa4 Big Patch adds primarily: Samplerate and format selection to recording for SWCODEC. Supprort for samplerates changing in playback (just goes with the recording part inseparably). Samplerates to all encoders. Encoders can be configured individually on a menu specific to the encoder in the recording menu. File creation is delayed until flush time to reduce spinups when splitting. Misc: statusbar icons for numbers are individual digits to display any number. Audio buffer was rearranged to maximize memory available to recording and properly reinitialized when trashed. ColdFire PCM stuff moved to target tree to avoid a complicated mess when adding samplerate switching. Some needed API changes and to neaten up growing gap between hardware and software codecs.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@11452 a1c6a512-1295-4272-9138-f99709370657
2006-11-06 18:07:30 +00:00
Martin Scarratt
c8bd9129bf Button action code for recording screen. Shouldnt make any noticable difference in recording screen button operation except for H300 I-River remote, which should now work as expected, -10 button = LCD off
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10666 a1c6a512-1295-4272-9138-f99709370657
2006-08-20 21:33:40 +00:00
Magnus Holmgren
0b35bcfc71 Guard against division by zero in the peak meter (the settings menu allows the user the set range min and max to the same value; maybe that should be changed too).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10631 a1c6a512-1295-4272-9138-f99709370657
2006-08-17 09:35:27 +00:00
Peter D'Hoye
5fc66e58dd Automatic Gain Control during recording. At this point only compiled for iriver h1x0 and h3x0. Patch FS#4748 by Jvo Studer, Martin Scarratt and myself.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10625 a1c6a512-1295-4272-9138-f99709370657
2006-08-16 23:26:55 +00:00
Martin Scarratt
1ae0cdbc46 I-River targets: A workaround for the recording interference hardware issue when recording with a remote. Disable remote LCD while recording by pressing vol- on the remote. All remote buttons and cliplight are still operational while lcd is disabled.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10376 a1c6a512-1295-4272-9138-f99709370657
2006-07-31 12:55:27 +00:00
Martin Scarratt
76b729c47b On-the-fly filesplitting when recording for I-Rivers. Record button starts new file, Play/Pause button pauses/resumes recording. Also, Filename information for all screens > 80 pixels high.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10270 a1c6a512-1295-4272-9138-f99709370657
2006-07-20 22:44:10 +00:00
Martin Scarratt
13e49f5f91 Completed implementation of display GUI code for recording and peakmeter
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10249 a1c6a512-1295-4272-9138-f99709370657
2006-07-19 15:30:40 +00:00
Peter D'Hoye
96d269e059 Increased peakmeter accuracy in the (for recording important) -12 to 0 dB range. Patch 5022 by Jvo Studer.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10177 a1c6a512-1295-4272-9138-f99709370657
2006-07-02 22:36:46 +00:00
Linus Nielsen Feltzing
defbc69b2b Patch #4999 by Matthias Mohr - Peakmeter scaling dots does not respect x-offset in peak_meter_draw
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9450 a1c6a512-1295-4272-9138-f99709370657
2006-04-03 08:20:20 +00:00
Dan Everton
b66477adcc Support the recording screen on the LCD remote. Also adds support for the peakmeter in the rremote WPS. Patch from Martin Scarratt (task 4818).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9246 a1c6a512-1295-4272-9138-f99709370657
2006-03-25 13:35:31 +00:00
Peter D'Hoye
311f73264b Make clipping detection more sensitive for swcodec platforms by triggering on the first peak value
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8962 a1c6a512-1295-4272-9138-f99709370657
2006-03-08 20:38:16 +00:00
Peter D'Hoye
64f0682f6e also enable recording cliplight when monitoring before recording
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8834 a1c6a512-1295-4272-9138-f99709370657
2006-02-24 19:17:47 +00:00
Dan Everton
e376545211 Make peak meter work in simulator for SWCODEC targets.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8815 a1c6a512-1295-4272-9138-f99709370657
2006-02-23 21:13:03 +00:00
Peter D'Hoye
3467ba60b1 Patch #1423609 by Martin Scarratt and myself: enables using the backlight as record clipping indicator.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8722 a1c6a512-1295-4272-9138-f99709370657
2006-02-17 22:47:56 +00:00
Daniel Stenberg
727eab12b3 fix yellow build by removing a static unused variable from the simulator build
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8125 a1c6a512-1295-4272-9138-f99709370657
2005-12-02 08:44:09 +00:00
Andy
1e4d1f8de7 iRiver recording changes:
- Added Peakmeter in recording screen
- Fix for stop bug
- Fix for playback peakmeter not working after recording


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8120 a1c6a512-1295-4272-9138-f99709370657
2005-12-02 01:04:03 +00:00
Christi Scarborough
4c0b83f5e9 Remote WPS support (and some WPS bugfixes) by Stephan Wezel
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7934 a1c6a512-1295-4272-9138-f99709370657
2005-11-17 20:14:59 +00:00
Jens Arnold
d6c054575b Renamed CONFIG_HWCODEC and MASNONE to the more appropriate CONFIG_CODEC and SWCODEC, respectively.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7416 a1c6a512-1295-4272-9138-f99709370657
2005-08-29 21:15:27 +00:00
Jens Arnold
99a0598c28 Major peakmeter rework: * Changed set/get functions for dbfs mode to bool type. * Removed performance setting, leaving (slightly adapted) high performance mode only. * Refresh rate is always 20 Hz now. * Readout doesn't do an extra (hidden) peek, should allow for slightly better clip detection. * Brought back high performance peakmeter for recording. Peakmeter stops hogging the CPU when the disk is spinning; this is enough to avoid the performance problem when saving data. * Optimisations, code cleanup and code policeing. * (iriver) Reduced CPU load of peakmeter by not calculating excessive overlaps. ** Bumped config block version, so save your settings before upgrading.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7415 a1c6a512-1295-4272-9138-f99709370657
2005-08-29 20:07:17 +00:00
Miika Pekkarinen
e9919342c5 Initial attempt to support peak meter on iriver. It still has some
strange behaviour and readings might not be correct.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7182 a1c6a512-1295-4272-9138-f99709370657
2005-07-17 19:29:02 +00:00
Jens Arnold
f894a4c269 4-shades greyscale graphics core for iriver H1x0. 4-grey rockbox logo and light grey background in splash() boxes. Simplified the splash() box creation as the new graphics core does clipping. Adapted screendump feature and added flexible preprocessing to construct the bmp header. Rockboy now uses 4-grey mode as well. 4-grey support for win32 simulator. Fixed win32 player sim to not use double bitmap conversion via a recorder-like framebuffer, and correctly display double-height text. X11 simulator temporarily adapted. The display won't be distorted, but it still shows b&w only.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7046 a1c6a512-1295-4272-9138-f99709370657
2005-07-06 22:58:02 +00:00
Jens Arnold
7e11acbce9 Second part of graphics api rework. Bitmap drawing and text output converted; some code cleanup and more optimisations.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6906 a1c6a512-1295-4272-9138-f99709370657
2005-06-28 23:15:47 +00:00
Jens Arnold
934941294b Core functions taking advantage of the new, optimised lcd_hline() and lcd_vline() functions. Some cleanup.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6859 a1c6a512-1295-4272-9138-f99709370657
2005-06-25 00:28:09 +00:00
Jens Arnold
04daef17a1 First part of graphics api rework. Special functions, parameter handling, pixel functions, lines and filled primitives done for black & white core, main display.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6856 a1c6a512-1295-4272-9138-f99709370657
2005-06-24 22:33:21 +00:00
Linus Nielsen Feltzing
4dd5134a1f Killed some warnings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6587 a1c6a512-1295-4272-9138-f99709370657
2005-06-06 01:08:18 +00:00
Jens Arnold
9d14b73989 Bugfix: The peakmeter drew too much cpu power when recording, occasionally causing the recording buffer to wrap before the first save finished (when fsinfo didn't contain a next-free-cluster hint so that an exhaustive search was necessary).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6558 a1c6a512-1295-4272-9138-f99709370657
2005-06-04 09:48:03 +00:00
Thom Johansen
7de0b0ecae Removed 'static' keyword from non-static variables.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6356 a1c6a512-1295-4272-9138-f99709370657
2005-04-26 00:10:15 +00:00
Jens Arnold
cf986e8d44 Triggered recording fixes: (1) Made it compile for Ondio FM recorder (no led, button assigment). (2) Disabled trigger settings and peakmeter trigger handling for devices without recording. Saves > 2 KB of code on Ondio SP. (3) Const policed, saves some more code size. (4) Some code cleanup.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6248 a1c6a512-1295-4272-9138-f99709370657
2005-04-04 20:16:01 +00:00
Linus Nielsen Feltzing
68482bbed2 Patch #868645 by Philipp Pertermann, volume triggered recording for the Archos recording devices
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6243 a1c6a512-1295-4272-9138-f99709370657
2005-04-04 09:12:12 +00:00
Jean-Philippe Bernardy
4ff0c8e4c8 long policy
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5971 a1c6a512-1295-4272-9138-f99709370657
2005-02-16 11:04:35 +00:00
Daniel Stenberg
db32fb131e make this build on systems with no HW codec (iriver/gmini)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5745 a1c6a512-1295-4272-9138-f99709370657
2005-02-02 21:49:19 +00:00
Jens Arnold
2f20b3e784 Const policed pointer arguments to functions, part 4
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5001 a1c6a512-1295-4272-9138-f99709370657
2004-08-18 19:59:06 +00:00