It should not exit() anymore on error except on malloc failure.
Resource leaks on errors (especially I/O) are quite likely though.
Change-Id: I6fcf72fb08fc683468b390d0b8745d31ca982b48
With the transition to git the assumption of the version starting with "r"
isn't true anymore for non-release builds. This caused the wrong strings to be
used when constructing various download URLs.
Remove the test binary which was never intended to be added and fix some
warnings in the test implementation.
Change-Id: I879fdff201cb85f3c89cca73ab6a0514edb5a2df
A warning triggered by attribute warn_unused_result cannot be suppressed by
casting the result to void. Properly check the return value and pass it to the
caller.
Fix the check for the number of bytes written. The return value of fread is the
number of items written, not the number of bytes.
Change-Id: I8c60e23ac549e22fd3f7dd5c51c5a8e6fc517cb1
This allows testing the class by using temporary files without the need of
constructing a special path.
Change-Id: Id5ccd37f05219f246b9bf9f8a26ec81342654f89
Since we don't have revision numbers anymore remove the "r" prefix when showing
the version information to the user.
Change-Id: I1e36b11a23301dda9fe67bb284489510c65567d8
/firmware is in the #include path with makes #include "asm/beep.c" sufficient.
Add a comment to generic beep code and make another express intent better.
Change-Id: I587cd704478b894785927bdfe2e647e28614df62
1) this patch replace all keymaps with PLA ones. It also clean some optionnal
compiling that are not needed anymore througt PLA.
2) the patch also made required change to the manual in order to match code's
change.
3) it also add an alternative exit button (PLA_EXIT or PLA_CANCEL).
Change-Id: If6e78711eaab1dd2c907b418ba72c8789ceaa72b
Reviewed-on: http://gerrit.rockbox.org/105
Reviewed-by: Thomas Martitz <kugel@rockbox.org>
Tested-by: Thomas Martitz <kugel@rockbox.org>
For now due to current lack of an apps/asm, place the ASM/generic code in the
firmware/asm directory.
Additionally, make generic beep code more generic.
Change-Id: I4a69b6ffcbb97d9e6dfde2209c5a118de19e5638
adds wrappers for the functions playlist_sync, playlist_remove_all_tracks, and playlist_insert_track, playlist_insert_directory
playlist_{sync,remove_all_tracks} take no arguments
playlist_insert_{track,directory} only have one required argument (either the filename or directory name)
They take as optional arguments position, queue, and either sync or recurse
They all just pass NULL to work with the current playlist
also adds constants for:
PLAYLIST_PREPEND,
PLAYLIST_INSERT,
PLAYLIST_INSERT_LAST,
PLAYLIST_INSERT_FIRST,
PLAYLIST_INSERT_SHUFFLED,
PLAYLIST_REPLACE, and
PLAYLIST_INSERT_LAST_SHUFFLED
Change-Id: Ib7464cba50e7a250edf092e50668f11010f2b737
Reviewed-on: http://gerrit.rockbox.org/109
Reviewed-by: Thomas Martitz <kugel@rockbox.org>
Only output logf() to the serial port if LOGF_SERIAL is defined
(in addition to HAVE_SERIAL). Add an option to advanced configure
to set this (defaults to off).
Change-Id: I13d0f5df391e5371f7797f46a3faaf7a6974b9e4
Reviewed-on: http://gerrit.rockbox.org/92
Reviewed-by: Björn Stenberg <bjorn@haxx.se>
Create a new widget which holds the contents of the manual tab and its logic.
Unify its display / download code. Fixes FS#12587, which was caused by
duplicated code.
Change-Id: I5721d2a95ebeaf80481c1fd149eda22cf1328501
Instead of passing a parameter to decide if a dialog box should be shown pass a
pointer to the parent widget and make it static. This allows calling it from
outside while keeping the possibility to not show a warning.
Change-Id: I72fa53a7e8a83d527c22b698dfa434c24100ac29
1) On all non PLA plugin, power button is used for exit. For consistency,
we set PLA_EXIT to power button.
2) Manual updated accordingly
Change-Id: Ia4b8fce13bad2f8dc0710cdb29ccf6c74b3fd9c4
Reviewed-on: http://gerrit.rockbox.org/91
Reviewed-by: Thomas Martitz <kugel@rockbox.org>
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
Since smoothing was enabled for battery_status_update() in 109084d, the simulated charge/ discharge cycle was so fast that the battery level never really dropped much below 90%.
Change-Id: Ide5c7ceef97bc9ed62d45e3a0afd99ff6f0550ea
On Windows /dev/random does not exist, so trying to open it will fail. Replace
it with rand() which is available on all supported platforms and sufficient.
Fixes mkimxboot not working, as well as Rockbox Utility "crashing" (which is in
fact its error handler calling exit(), thus terminating Rockbox Utility) on
Windows.
Change-Id: Ia164f937f329877e8f80f473f27be8c5df2a0a68
1) this patch replace all keymaps with PLA ones. It also clean some optionnal
compiling that are not needed anymore througt PLA
2) the patch also made required change to the manual in order to match code's
change.
Change-Id: I54ec953f79a419a6bb2f78877ca8b82f572fb510
Reviewed-on: http://gerrit.rockbox.org/86
Reviewed-by: Thomas Martitz <kugel@rockbox.org>
Tested-by: Thomas Martitz <kugel@rockbox.org>
This is the case if either the player has lots of lifes or a high score
Change-Id: Ic4c7011e9fa582d2ae552b28474ba260f2b4cab0
Reviewed-on: http://gerrit.rockbox.org/88
Reviewed-by: Jonathan Gordon <rockbox@jdgordon.info>
It wasn't only a52 but also a52_rm that didn't reset the elapsed counter on
each new track. The problems seemed obvious enough so fixes are being added
blind. Will leave task open for feedback from bug reporter.
Change-Id: Ic6d8eb98690ff4be47547d13b6bbafeadf4da745
Use these tags to stop having multiple conditionals.. e.g:
OLD: %?C<%?Ia<something>>
NEW: %?and(%C, %Ia)<something>
Change-Id: Ia3bbe4611cf808e87dcd1b1147181461fa08294a
Fixes a crash when leaving the encoder settings dialog with the Ok button but
the dynamically loaded library missing, in which case no settings will be
available.
Change-Id: I889a0bbcde6bed2df658b5df57341edf6802daad
