Commit graph

96 commits

Author SHA1 Message Date
Nils Wallménius
3200d04d75 Make the formatter functions used by the settings return a pointer to avoid usless copying of lang strings, this brought with it a long chain of const correctness and a few random cleanups
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22440 a1c6a512-1295-4272-9138-f99709370657
2009-08-20 16:47:44 +00:00
Jonathan Gordon
061b7ebcc8 show the skin buffer size as well as the used amount in the rockbox info screen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22419 a1c6a512-1295-4272-9138-f99709370657
2009-08-19 04:41:30 +00:00
Jonathan Gordon
c0897a8002 remove the rockbox info line saying the AA size and replace it with skin RAM usage
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22364 a1c6a512-1295-4272-9138-f99709370657
2009-08-16 22:00:38 +00:00
Bertrik Sikken
0307cd16a0 Remove some unused #includes
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22183 a1c6a512-1295-4272-9138-f99709370657
2009-08-06 08:20:06 +00:00
Thomas Martitz
3b75c86d74 A bit mroe wps/skin engine cleanup so that the structs the wps uses can be static:
-add wrappers wps_data_load() and wps_data_init() so that other code doesn't need the structs for that
-change (and rename) gui_sync_wps_uses_albumart() to take points to be filled as parameter to get the AA size of a wps

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22139 a1c6a512-1295-4272-9138-f99709370657
2009-08-03 15:06:30 +00:00
Jonathan Gordon
3e7444ff87 part two of the grand overall wps/skinning engine cleanup work:
* rename wps_engine to skin_engine as that was agreed on
* rename music_screen back to wps
* clean up the skin display/update functions a bit
* make skin_data_load setup the hardcoded default if a skin cant be loaded for whatever reason instead of doing it when it is first displayed

ignore any gui_wps or wps_ or gwps_ nameing in skin_engine/ ... these will be renamed as this work gets finished


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22135 a1c6a512-1295-4272-9138-f99709370657
2009-08-03 04:43:34 +00:00
Jonathan Gordon
5e5fc64cb2 Start of some apps/ and wps cleanup work... Move everything related to the actual drawing of the wps into apps/gui/wps_engine, things related to the actual screen are in apps/gui/music_screen.c (names are temporary unless noone comes up with anything better)
No real code changes.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22062 a1c6a512-1295-4272-9138-f99709370657
2009-07-27 07:21:05 +00:00
Nils Wallménius
3d4701a6e4 FS#10080
* Move strncpy() from core to the pluginlib
* Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins
* Drop strncpy() from the codec api as no codec used it
* Bump codec and plugin api versions


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21863 a1c6a512-1295-4272-9138-f99709370657
2009-07-14 13:57:45 +00:00
Michael Sevakis
077ce00fdd Forget Info screen auto refresh for now since it messes with text scrolling.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19873 a1c6a512-1295-4272-9138-f99709370657
2009-01-28 21:59:24 +00:00
Michael Sevakis
4118de4cc8 Make sure 'Battery: Charging' is displayed in the info screen when charging no matter the algorithm (Archos Recorder still specially handled). Have screen refresh itself at 1HZ if CONFIG_CHARGING.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19872 a1c6a512-1295-4272-9138-f99709370657
2009-01-28 20:53:50 +00:00
Alessio Lenzi
a1a287905b Changed lang message for credits item in Rockbox Mainmenu/System and updated italian translation.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19699 a1c6a512-1295-4272-9138-f99709370657
2009-01-06 16:53:44 +00:00
Jonathan Gordon
e385ee18ce Decouple the statusbar drawing from the rest of the screen drawing. it is not drawn roughly 4x per second automatically.
viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.)
All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false).

This commit also includes some menu/list viewport cleanups from kugel in FS#9603


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
2008-12-31 05:59:26 +00:00
Michael Sevakis
3157e13956 Simplify powermgmt thread loops so it calls functions turn (no more power_thread_sleep). Do other target-friendly simplifications, generic battery switch handling and split sim-specific code. Whoever can, please verify charging on the Archos Recorder (due to change in the charger duty cycle code).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19579 a1c6a512-1295-4272-9138-f99709370657
2008-12-24 16:58:41 +00:00
Bertrik Sikken
e5bf5beaee Static police.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19291 a1c6a512-1295-4272-9138-f99709370657
2008-12-01 18:51:43 +00:00
Jonathan Gordon
c7fec13fd8 FS#9173 - move all time/clock related settings in the menus into system > "time & date" (this includes sleep timer, alarm settings)
The time/date dispaly has been moved out of the "rockbox info" screen and into this screen also (only displayed if there is at least 3 lines of text on the screen though)
The time/date is talked in this screen by pressing the usual context-menu button (usually long-select)

Targets without a RTC are not changed (i.e sleep timer isnt moved)


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19282 a1c6a512-1295-4272-9138-f99709370657
2008-12-01 09:28:14 +00:00
Nils Wallménius
5aa0665b5b Move 'Playback Settings' up from 'General Settings' to 'Settings' (FS#9472 by William Poetra Yoga Hadisoeseno but without the menu rearrangement) also closes FS#9154. Update manual to reflect the menu change, Playback Settings is now its own chapter. As a bonus that makes it a bit easier to find stuff in the toc.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18799 a1c6a512-1295-4272-9138-f99709370657
2008-10-13 15:11:11 +00:00
Nils Wallménius
93a87685c3 Clean up use of snprintf where strncpy if suited, avoid useless copying of constant strings for wps token evaluator, minor const police too.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18625 a1c6a512-1295-4272-9138-f99709370657
2008-09-24 20:03:53 +00:00
Jonathan Gordon
d34ab4af8a Display the expected album art size in the info screen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18576 a1c6a512-1295-4272-9138-f99709370657
2008-09-23 11:20:08 +00:00
Bertrik Sikken
56e2764116 Make local function static and add missing #includes for Archos player
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18505 a1c6a512-1295-4272-9138-f99709370657
2008-09-12 21:11:06 +00:00
Stéphane Doyon
209245605b Rockbox info: restore the 5seconds update delay to allow scrolling,
which I broke in r18309.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18312 a1c6a512-1295-4272-9138-f99709370657
2008-08-19 03:51:33 +00:00
Stéphane Doyon
50512d696d Fix for issues in speaking the time in Rockbox Info screen (B#9167).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18309 a1c6a512-1295-4272-9138-f99709370657
2008-08-18 00:58:47 +00:00
Nils Wallménius
01729e7a18 FS#9281 Rename of splash functions.
* Remove gui_splash()
* Rename gui_syncsplash() to splashf() and remove its voice 
capabilities.
* Rename the internal splash() to splash_internal() and introduce an 
externally visible splash() that handles simple splashing  without 
printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ, 
"foo"); if a LANG_* id is passed it will be voiced.
* Adjust all places that called gui_syncsplash() to use the correct 
variant from above.
* Export both new functions to plugins and adjust places calling 
rb->splash() to use the correct variant so that we now have naming 
consistency between the core and plugins.
* Fix one latent bug that would cause my sim to crash with the above 
changes and correct P2STR and P2ID macros, thanks to pondlife.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
2008-08-15 08:27:39 +00:00
Bertrik Sikken
d86255b4a9 Fix FS#9237 (Mismatch in voiced and displayed buffer size).
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18190 a1c6a512-1295-4272-9138-f99709370657
2008-08-03 22:02:11 +00:00
Jonathan Gordon
39de8688f9 fix FS#9162 - the time needs to not talk so often, not the date line
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17985 a1c6a512-1295-4272-9138-f99709370657
2008-07-08 02:30:58 +00:00
Jonathan Gordon
311d048f6f fix FS#9144 hopefully for good... only update the screen if the time line is selected, or if talking menus are disabled, only update if the time line is actually on the screen. Also only update every 5s so scrolling lines still scroll. (turns out scroll_all was broken! fixed now)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17944 a1c6a512-1295-4272-9138-f99709370657
2008-07-05 12:31:04 +00:00
Daniel Stenberg
2acc0ac542 Updated our source code header to explicitly mention that we are GPL v2 or
later. We still need to hunt down snippets used that are not. 1324 modified
files...
http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-06-28 18:10:04 +00:00
Jonathan Gordon
8a393885ea fix red
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17791 a1c6a512-1295-4272-9138-f99709370657
2008-06-25 10:58:48 +00:00
Jonathan Gordon
46f38c5f4f ok, only update the screen if the time is selected... otherwise the scrolling lines arnt readable
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17790 a1c6a512-1295-4272-9138-f99709370657
2008-06-25 08:54:55 +00:00
Jonathan Gordon
b1dc552308 fix FS#8969 - rockbox info screen is now redrawn every half second
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17788 a1c6a512-1295-4272-9138-f99709370657
2008-06-25 07:46:18 +00:00
Jonathan Gordon
82c1aa8e8e scroll all lines in read-only info lists
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17366 a1c6a512-1295-4272-9138-f99709370657
2008-05-05 07:11:27 +00:00
Nils Wallménius
33c44461e1 Const police raid, making a lot of pointers to lang strings const and removing some ugly casting
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
2008-04-26 09:30:24 +00:00
Nils Wallménius
ac1b30ef73 Nicer handling of unset clock in the 'Rockbox Info' screen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17199 a1c6a512-1295-4272-9138-f99709370657
2008-04-20 21:01:39 +00:00
Nils Wallménius
8dca930a1a Some small binsize savings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17052 a1c6a512-1295-4272-9138-f99709370657
2008-04-09 16:01:40 +00:00
Nils Wallménius
6848961aa5 Pass the buffer length to the list_get_name callback functions instead of using hardcoded MAX_PATH
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
2008-04-09 15:25:17 +00:00
Linus Nielsen Feltzing
29cdd30dbc Fix for FS#8820 by Christopher Williams - Misformatted time in Rockbox Info
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16899 a1c6a512-1295-4272-9138-f99709370657
2008-03-31 07:37:19 +00:00
Jonathan Gordon
22fbafb6ba So, I've been sick these last few days, and I'm trying to not take drugs to get over the sickness... turns out that may not have been such a good descision. (AKA, I'm trying to get on the front page... (AKA, really revert this time... really) )
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16795 a1c6a512-1295-4272-9138-f99709370657
2008-03-25 13:13:46 +00:00
Jonathan Gordon
0158336ead well we suck! how could something seemingly simple be fubar'ed so much! KISS says revert this catastrofeeeee befroe anyone realises
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16794 a1c6a512-1295-4272-9138-f99709370657
2008-03-25 12:42:47 +00:00
Jonathan Gordon
58ee0fbd69 ok, redo that last commit.. always write /.rockbox/oldconfig.cfg when you load a new config or reset settings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16793 a1c6a512-1295-4272-9138-f99709370657
2008-03-25 10:38:55 +00:00
Jonathan Gordon
9ed5a67b69 write the current settings to .rockbox/config.cfg.bak before resetting settings
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16792 a1c6a512-1295-4272-9138-f99709370657
2008-03-25 10:28:37 +00:00
Jonathan Gordon
e1ba7f76ef there is no need to load the filename settings unless reading from a .cfg, so stop them being read every time settings_apply() is called
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16535 a1c6a512-1295-4272-9138-f99709370657
2008-03-06 07:03:14 +00:00
Jonathan Gordon
b8bc45ded0 FS#8353 - add a quick way to make a .cfg from the sound settings.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15971 a1c6a512-1295-4272-9138-f99709370657
2007-12-24 22:35:31 +00:00
Jonathan Gordon
f5ec3e49e0 remove the duplicated gui_list struct and only duplicate the members which are actually different on each screen. should translate to a smaller bin and easier code (users shouldnt notice any difference)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15947 a1c6a512-1295-4272-9138-f99709370657
2007-12-17 02:37:21 +00:00
Stéphane Doyon
fe2f1af0d3 Fix my mess in r15419: LANG_BATTERY_TOPOFF_CHARGE is only defined
when CONFIG_CHARGING == CHARGING_CONTROL.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15424 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 05:40:22 +00:00
Stéphane Doyon
69f88a5c35 Info screen: charging and battery.
For CHARGING_SIMPLE: if the charger is inserted, then indicate that the
battery is charging, and do not show the battery level (which should be
bogus anyway). This is the only place the charger status is reported for
blind users.

Allow reporting charge_state for CHARGING_MONITOR: the header file says
it could be CHARGING or TRICKLE. Hope this is right. Interestingly,
that's how the #ifdefs were for the voice part.

Have the voice match the displayed info.  In particular do not report
battery level when in a charging state.
Use the new talk time unit for the battery remaining duration.
If battery_level() is 0 and no info is available, then say "blank"
instead of nothing.
LANG_BATTERY_CHARGE: more verbose voice entry.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15419 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 04:13:25 +00:00
Stéphane Doyon
f6b404bd73 Info screen fixups:
* Shortened the voice entry for external disk names.
* Deprecated LANG_CURRENT_TIME which is not used anywhere.
* Before there were CRLFs, then there were blank lines, cleaned that up.
* Removed extra format specifier and args in the snprintf for MMC NOT_PRESENT.
* Made the voice info about disks match more closely what is displayed:
  basically, speak disk size for multi-volume case as well.
* Not too sure about the reordering, so I did NOT touch that.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15415 a1c6a512-1295-4272-9138-f99709370657
2007-11-03 03:38:54 +00:00
Alessio Lenzi
6c2a904f2b * For a better access to the information of the Rockbox Info menu by visually
impaired users, the order of the items has been modified.
* Now the software displays a message when the external memory card is not in
the device slot. (only for Sansa and Ondio models)
* The voice tag for the current_time message has been restored.


git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15381 a1c6a512-1295-4272-9138-f99709370657
2007-10-30 21:41:03 +00:00
Steve Bavin
fda41b892e Try and save some bytes, seeing as we already assumed LANG_ constants for month and weekday names are contiguous.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15289 a1c6a512-1295-4272-9138-f99709370657
2007-10-24 15:34:36 +00:00
Steve Bavin
b76b5b9fa2 Use some consts...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15287 a1c6a512-1295-4272-9138-f99709370657
2007-10-24 14:16:02 +00:00
Steve Bavin
7c95e5e6a6 Improved enum naming.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15286 a1c6a512-1295-4272-9138-f99709370657
2007-10-24 13:54:04 +00:00
Steve Bavin
072a3c5017 Complete info screen voicing; now consistent with displayed screen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15284 a1c6a512-1295-4272-9138-f99709370657
2007-10-24 12:32:12 +00:00