Andree Buschmann
dcf0f8de4a
Submit FS#12081. Check validity of channel configuration, comment unneeded code that is too inflexible to work with MAX_CHANNELS = 2. Fixes compiler warnings with GCC 4.6.0.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29784 a1c6a512-1295-4272-9138-f99709370657
2011-04-26 21:30:51 +00:00
Bertrik Sikken
05c3290608
iap: fix shutdown of logitech Pure-Fi Elite dock, by Ophir Lojkine
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29783 a1c6a512-1295-4272-9138-f99709370657
2011-04-25 11:06:59 +00:00
Michael Giacomelli
8166ce75c8
Commit FS#12056 by Noe Lojkinse. Fixes a bug in Xobox where old key presses were left on the buffer too long.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29781 a1c6a512-1295-4272-9138-f99709370657
2011-04-24 23:44:58 +00:00
Bertrik Sikken
4c1de9c015
iap: add more comments to iap command and responses
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29779 a1c6a512-1295-4272-9138-f99709370657
2011-04-24 20:22:38 +00:00
Andree Buschmann
a602f46d69
Rework of libfaad in several areas. Allow removal of malloc with a new define FAAD_STATIC_ALLOC (in common.h). For now malloc is not fully removed but used by a few arrays needed for AAC-HE SBR+PS only. Reason to keep malloc is to have this amount of memory available for AAC-LC files which might require large m4a tables. The changes make the allocation routines much smaller, better centralized and allow to move duplicated code from aac.c/raa.c to libfaad. The rework includes removal of (now and former) unused code as well.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29778 a1c6a512-1295-4272-9138-f99709370657
2011-04-24 20:19:05 +00:00
Andree Buschmann
69580a96eb
Fix yellow.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29777 a1c6a512-1295-4272-9138-f99709370657
2011-04-24 19:13:08 +00:00
Bertrik Sikken
abf503496b
iap: order lingo 0x00 commands by id and add comments
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29776 a1c6a512-1295-4272-9138-f99709370657
2011-04-24 19:05:23 +00:00
Andree Buschmann
2f215da9c3
Use dedicated function to internally reset aac decoder synthesis after seek.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29775 a1c6a512-1295-4272-9138-f99709370657
2011-04-24 18:56:23 +00:00
Andree Buschmann
2f04e6cca2
Ensure proper termination of m4a lookup table.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29774 a1c6a512-1295-4272-9138-f99709370657
2011-04-24 18:33:39 +00:00
Andree Buschmann
15e9053afb
Clean up array sizes in the SBR + PS part of libfaad. Add MAX_NTSRPS (=38), use MAX_NTSR and MAX_NTSRHFG at the right places. RAM (IRAM) usage is reduced by 2 KB.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29773 a1c6a512-1295-4272-9138-f99709370657
2011-04-24 13:54:02 +00:00
Jonathan Gordon
2271995517
invert the quickscreen setting direction on wheel targets for settings which are number lists so pressing up makes it bigger (i.e contrast). fixes http://forums.rockbox.org/index.php/topic,27778.0.html
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29772 a1c6a512-1295-4272-9138-f99709370657
2011-04-24 07:04:52 +00:00
Andree Buschmann
6bab4e8dc0
get_sample_info() has been removed.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29771 a1c6a512-1295-4272-9138-f99709370657
2011-04-23 22:28:47 +00:00
Andree Buschmann
7d1de584fe
Minor speed optimization to m4a lookup table build up.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29770 a1c6a512-1295-4272-9138-f99709370657
2011-04-23 20:43:47 +00:00
Bertrik Sikken
d038db9420
iap: introduce cmd_ok_mode0 and cmd_ok_mode4 functions to reduce code duplication
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29757 a1c6a512-1295-4272-9138-f99709370657
2011-04-21 22:36:10 +00:00
Bertrik Sikken
9ea20660ca
iap: split iap_handlepkt into a function per mode
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29755 a1c6a512-1295-4272-9138-f99709370657
2011-04-21 21:50:39 +00:00
Nils Wallménius
12a60efca9
FS#12072 Improved and updated translation of Romaneste by Sergiu Rotaru.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29751 a1c6a512-1295-4272-9138-f99709370657
2011-04-20 12:34:41 +00:00
Andree Buschmann
2358fabb70
Optimization to latest aac decoder changes. Significantly reduce loop count in m4a_check_sample_offset() during standard playback. Before this change the loop count increased with each decoded chunk and for each frame.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29750 a1c6a512-1295-4272-9138-f99709370657
2011-04-19 05:55:54 +00:00
Andree Buschmann
68199cc195
Major rework of the m4a parser for aac/alac playback, seek and resume support. As a result the memory consumption was drastically reduced. This allows to play several files with long duration -- especially on low memory targets. The change builds a lookup table from m4a's sample_to_chunk[] and chunk_offset[] and completely removes the allocation of the large tables chunk_offset[] and sample_byte_size[]. To be able to remove reading and allocating sample_byte_offset[] the aac and alac decoder now buffer a fixed amount of bytes for each frame. The generated lookup table is used for seek/resume and skipping bytes in empty chunks (aac decoder only). The precision for seek/resume is somewhat lower but still equals 0.5 sec for the worst case. Fixes FS#8923.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29745 a1c6a512-1295-4272-9138-f99709370657
2011-04-18 19:12:51 +00:00
Bertrik Sikken
204a2e920a
Move declaration of global function cfg_string_to_int to header file settings.h
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29737 a1c6a512-1295-4272-9138-f99709370657
2011-04-17 11:23:48 +00:00
Andree Buschmann
5775159462
Refactor aac decoder as preparation for upcoming m4a changes. The aac decoder does not need to use get_sample_info() to gather frame size or the number of consumed bytes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29727 a1c6a512-1295-4272-9138-f99709370657
2011-04-16 19:39:01 +00:00
Frank Gevaerts
a96a72b7b0
Since r29700 changed the way the backdrop setting works, the default needs to be updated too
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29726 a1c6a512-1295-4272-9138-f99709370657
2011-04-16 19:26:21 +00:00
Andree Buschmann
8055b48b46
Fix yellow.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29725 a1c6a512-1295-4272-9138-f99709370657
2011-04-16 19:26:07 +00:00
Andree Buschmann
19f9fd0f5f
Refactor alac decoder as preparation for upcoming m4a changes. The alac decoder does not need to use get_sample_info() to gather frame size or the number of consumed bytes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29724 a1c6a512-1295-4272-9138-f99709370657
2011-04-16 19:08:50 +00:00
Michael Hohmuth
cf223b98ad
Do not attempt to remove the temporary database twice during a database update.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29716 a1c6a512-1295-4272-9138-f99709370657
2011-04-15 21:45:45 +00:00
Nils Wallménius
bbeba640bf
Fix missing printfstyle formatting in simplified Chinese.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29711 a1c6a512-1295-4272-9138-f99709370657
2011-04-14 15:07:04 +00:00
Andree Buschmann
4359058c79
Fix the Xing header parser to have reliable gapless playback. Closes FS#12062.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29708 a1c6a512-1295-4272-9138-f99709370657
2011-04-13 05:51:03 +00:00
Bertrik Sikken
fa068bbaf7
Do not show IRMax/IWMax in the disk info debug screen for sd cards with CSD version > 1.0
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29703 a1c6a512-1295-4272-9138-f99709370657
2011-04-11 19:11:39 +00:00
Bertrik Sikken
98d6924d50
FS#12061 - April update of Czech language by Marek Salaba
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29702 a1c6a512-1295-4272-9138-f99709370657
2011-04-11 17:40:28 +00:00
Frank Gevaerts
966becfa9f
Deprecate strings that are unused since r29700
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29701 a1c6a512-1295-4272-9138-f99709370657
2011-04-10 13:54:06 +00:00
Frank Gevaerts
d09f97880a
Support loading backdrops from anywhere in the filesystem. Fixes FS#12041
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29700 a1c6a512-1295-4272-9138-f99709370657
2011-04-10 13:25:47 +00:00
Michael Sevakis
d5849e0d30
Playlists forget to set playlist.started when creating new playlist on SWCODEC and which leads to flush-and-rebuffer messages never being sent again until playback is restarted.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29697 a1c6a512-1295-4272-9138-f99709370657
2011-04-09 13:07:08 +00:00
Nils Wallménius
e7c6ba66aa
Whitespace and cosmetics consistency cleanup in playlist_viewer.c, no functional changes.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29694 a1c6a512-1295-4272-9138-f99709370657
2011-04-08 13:39:56 +00:00
Nils Wallménius
a0791178ae
Voice filenames in the playlist viewer, closes FS#11951
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29693 a1c6a512-1295-4272-9138-f99709370657
2011-04-08 13:10:32 +00:00
Andree Buschmann
29a855245c
Fix residual red. Keep index in mp3entry for HWCODEC.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29692 a1c6a512-1295-4272-9138-f99709370657
2011-04-07 22:11:12 +00:00
Andree Buschmann
39d9d8bab1
Fix red and yellow. Move resume_index from mp3entry to playlist_info struct. Bump codec api.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29691 a1c6a512-1295-4272-9138-f99709370657
2011-04-07 21:38:51 +00:00
Andree Buschmann
4df825be43
Fix regressions of r29682. Update playlist index resume position when playlist changes (e.g. shuffling, inserting, removing, ...).
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29690 a1c6a512-1295-4272-9138-f99709370657
2011-04-07 20:33:00 +00:00
Björn Stenberg
2d00f0c8b2
Removed some dead code identified by clang-analyzer.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29685 a1c6a512-1295-4272-9138-f99709370657
2011-04-06 21:08:31 +00:00
Andree Buschmann
3184cbe10a
Fix FS#12043. Next track was resumed when pausing and shutting down the player in the last seconds of a track.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29682 a1c6a512-1295-4272-9138-f99709370657
2011-04-06 19:11:40 +00:00
Andree Buschmann
d1766a1510
Rework parts of the replaygain code to be able to differentiate between 0.00 dB set intentionally and having no replaygain information at all. Bump codec api.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29679 a1c6a512-1295-4272-9138-f99709370657
2011-04-04 15:21:44 +00:00
Andree Buschmann
a7354e7925
Cosmetic change of a comment.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29666 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 22:06:52 +00:00
Andree Buschmann
29164ccbcc
Changing convert_gain() also implicitly changed get_replaygain_int() which could lead to div by zero. This patch finds another way to fix the replaygain fallback.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29665 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 21:46:09 +00:00
Andree Buschmann
4f7930b883
Fix for replaygain: Ensure fallback to track gain in case of missing album gain.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29664 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 12:44:29 +00:00
Björn Stenberg
ce755dd9c5
Only set volume on SYS_VOLUME_CHANGED the first time. Workaround for FS#12034.
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29663 a1c6a512-1295-4272-9138-f99709370657
2011-03-31 07:04:44 +00:00
Bertrik Sikken
81d67d0dda
Revert accidental commit of apps/plugins/SOURCES
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29661 a1c6a512-1295-4272-9138-f99709370657
2011-03-29 20:44:09 +00:00
Bertrik Sikken
8351a1aa9d
AMSv2 sd: do not try to switch sd cards into high-speed mode.
...
High-speed mode is only half implemented (sd controller still uses normal speed) and causes card detection problems.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29660 a1c6a512-1295-4272-9138-f99709370657
2011-03-29 20:37:40 +00:00
Rafaël Carré
8c3fc23ae6
remove set but unused variable
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29659 a1c6a512-1295-4272-9138-f99709370657
2011-03-28 21:44:36 +00:00
Rafaël Carré
cde3c9a08e
maze: fix warning spotted by gcc 4.6.0
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29658 a1c6a512-1295-4272-9138-f99709370657
2011-03-28 21:44:23 +00:00
Jonathan Gordon
87aa86cedd
Skin variables for touchscreen targets (origional implementation by Jens Theeß)
...
%vs(name, [set|inc|dec], value [,max]) - name is the id, set sets the value, inc increments by value, dec decrements by value
%vg(name) - get the current value
%vl(name [,timeout]) - 'has it changed in [timeout]'?
values start at 1 and are all reset to 1 on skin load
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29655 a1c6a512-1295-4272-9138-f99709370657
2011-03-27 08:01:58 +00:00
Jonathan Gordon
969381322d
Fix red
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29654 a1c6a512-1295-4272-9138-f99709370657
2011-03-27 07:30:23 +00:00
Jonathan Gordon
443b134983
Fix touchregions muting volume, and change &<action> to mean 'needs long press but only fire once'. Use *<action> for 'long press and allow repeats'
...
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29653 a1c6a512-1295-4272-9138-f99709370657
2011-03-27 07:23:38 +00:00